meson: reformat with meson formatter

Apply the `meson format` results.

Change-Id: Id7ac8548c847b897d5006011a809cb18354e0b05
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: I4113bd60a6817c8fdfad541c58e0910035a663ca
Signed-off-by: Patrick Williams <p

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: I4113bd60a6817c8fdfad541c58e0910035a663ca
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

build: use allowed over enabled or not-disabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`)

build: use allowed over enabled or not-disabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer return true for auto features. Instead, the
expectation is to use `allowed()` which is true for both enabled and
auto.

Switch all uses of `enabled` to `allowed`.
Switch all uses of `not disabled` to `allowed`.

Change-Id: Ic3591e9228286b3e98ef043638ca8e110e58f1d3
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

mmc: clang-tidy: Add override keyword

Marked virtual functions with the `override` keyword to ensure
they correctly override base class functions. This resolves
-Winconsistent-missing-override warni

mmc: clang-tidy: Add override keyword

Marked virtual functions with the `override` keyword to ensure
they correctly override base class functions. This resolves
-Winconsistent-missing-override warnings and improves code safety
and readability by explicitly indicating overridden functions.

```
Error while processing /var/jenkins-openbmc/workspace/ci-repository/openbmc/openpower-pnor-code-mgmt/mmc/item_updater_mmc.hpp.
/var/jenkins-openbmc/workspace/ci-repository/openbmc/openpower-pnor-code-mgmt/mmc/item_updater_mmc.hpp:94:10: error: 'validateImage' overrides a member function but is not marked 'override' [clang-diagnostic-inconsistent-missing-override]
94 | bool validateImage(const std::string& path);
| ^
../item_updater.hpp:199:18: note: overridden virtual function is here
199 | virtual bool validateImage(const std::string& path) = 0;
| ^
```

Tested: CI runs with no errors.

Change-Id: I24e5cae09e2cdeacf0155d5de70a6ecbae5e00e0
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

obmc-vpnor-util: Don't delete the HB_VOLATILE symlink

When symlinks to PNOR partitions were introduced in the emmc layout,
clearing of the HB_VOLATILE partition was done by deleting the symlink,
res

obmc-vpnor-util: Don't delete the HB_VOLATILE symlink

When symlinks to PNOR partitions were introduced in the emmc layout,
clearing of the HB_VOLATILE partition was done by deleting the symlink,
restoring the original lid file, and recreating the symlink. This leaves
a small time window when mboxd (hiomapd) can try to read this partition
and fail (since it expects that all partitions always exist because if
the partitions are regular files, there's always a read-only copy).

To mimic this behavior and avoid the mboxd error, don't delete and
recreate the symlink but instead just restore the original data.

Tested: The symlink modification time did not change as part of the
clear volatile operation.

Change-Id: Id7c4470130197d151eea89fdb529b87bc42511d5
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

clang-tidy: Initial commit

The clang-tidy configuration file has been initialized with all
recommended C++ category checks. These category checks are currently
disabled, except for one, which has be

clang-tidy: Initial commit

The clang-tidy configuration file has been initialized with all
recommended C++ category checks. These category checks are currently
disabled, except for one, which has been enabled for initial
validation. This strategy allows developers to progressively
enable the necessary checks over time.

Tested: verified build.

Change-Id: I0de58d81fe0fa4b1a119480b8298ca7652330a51
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-tidy: Remove unused lambda captures

The following errors were reported during clang-tidy enablement due
to unused lambda captures.

'''
functions.cpp:769:10: [0m[0;1;31merror: [0m[1mlambda cap

clang-tidy: Remove unused lambda captures

The following errors were reported during clang-tidy enablement due
to unused lambda captures.

'''
functions.cpp:769:10: [0m[0;1;31merror: [0m[1mlambda capture 'pldmPath' is not used [-Werror,-Wunused-lambda-capture]
'''

The fix involves removing these unused lambda captures.

Tested: Build and unit testing verified.

Change-Id: Ie2e28d4af2ad8eac2886c0202e98099ab3b82fc4
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-tidy: Add override keywords

Marked virtual functions with the `override` keyword to ensure
they correctly override base class functions. This resolves
-Winconsistent-missing-override warnings

clang-tidy: Add override keywords

Marked virtual functions with the `override` keyword to ensure
they correctly override base class functions. This resolves
-Winconsistent-missing-override warnings and improves code safety
and readability by explicitly indicating overridden functions.

'''
item_updater.hpp:120:18: [0m[0;1;31m
error: [0m[1m'deleteAll' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override
static/item_updater_static.hpp:75:10: [0m[0;1;31m
error: [0m[1m'validateImage' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override][0m
'''

Tested: Build verified

Change-Id: Iee2bb85498db72c8f2a9f265e0490fff9288f5f4
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-format: re-format for clang-19

clang-format-19 isn't compatible with the clang-format-18 output, so we
need to reformat the code with the latest version. A few parameters
in clang-tidy have b

clang-format: re-format for clang-19

clang-format-19 isn't compatible with the clang-format-18 output, so we
need to reformat the code with the latest version. A few parameters
in clang-tidy have been deprecated, so adjust the style file
accordingly.

See Ie2f6eb3b043f2d655c9df806815afd7971fd0947 for updated style.
See I88192b41ab7a95599a90915013579608af7bc56f for clang-19 enablement.

Change-Id: I876da9e8b709052b96cd1bc992058a0f6b466d07
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Add the new Software.Manager to service dependencies

Remove the Wants dependencies to the old code update service, these
services start by default. Add Before/After dependencies on the new
Software.

Add the new Software.Manager to service dependencies

Remove the Wants dependencies to the old code update service, these
services start by default. Add Before/After dependencies on the new
Software.Manager service to support both the old and the new flow.

Change-Id: Iec0ee77ec90d34422bad001ff789dcf215f0ac0f
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

functions: Delete symlink if the target doesn't match

If the symlink does not point to the expected target, delete it so that
it gets recreated to the correct target. This can happen when the BMC is

functions: Delete symlink if the target doesn't match

If the symlink does not point to the expected target, delete it so that
it gets recreated to the correct target. This can happen when the BMC is
put on a different system or the system is converted to a different one
without performing a firmware update.

Tested: Manually changed a symlink and verified that it got restored to
the expected target.

Change-Id: Ia9fd49554030bad8d727304e2ff2122107c90476
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: Id6c141dd4eba2423f476499b999aec9cb42f6192
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

test/README.md: Fix MD040 warnings

The following warnings are generated by using markdownlint analysis:
```
MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "

test/README.md: Fix MD040 warnings

The following warnings are generated by using markdownlint analysis:
```
MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
```
Refer to markdown-lint [1] to fix MD040
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/040-fenced-code-language.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I7f120915c474e9707e07061a078fd2b490b70e0c

show more ...

test/README.md: Fix MD004 warnings

The following warnings are generated by using markdownlint analysis:
```
MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
```
Refer to markdo

test/README.md: Fix MD004 warnings

The following warnings are generated by using markdownlint analysis:
```
MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
```
Refer to markdown-lint [1] to fix MD004
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/004-ul-style.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ie926528caaf9c82836fa9efffbb88c1382d88c77

show more ...

test/README.md: Fix MD041 warnings

The following warnings are generated by using markdownlint analysis:
```
MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading

test/README.md: Fix MD041 warnings

The following warnings are generated by using markdownlint analysis:
```
MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "Instructions on how to execute..."]
```
Refer to markdown-lint [1] to fix MD041
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/041-first-line-h1.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Iff7add9bc536168a651885fd8506889feb0d4d0d

show more ...

Add Blueridge and Fuji systems

Change-Id: I921838c9aa71568f877deb9be45d4c2113b36b70
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

generate-tar: Update private signing key

Updating from 1024 bits to 4096 bits for a more secure key

Change-Id: Ia73b7dcf280d729ed23e3e1113c257c68e979d25
Signed-off-by: Rashmica Gupta <rashmica@linu

generate-tar: Update private signing key

Updating from 1024 bits to 4096 bits for a more secure key

Change-Id: Ia73b7dcf280d729ed23e3e1113c257c68e979d25
Signed-off-by: Rashmica Gupta <rashmica@linux.ibm.com>

show more ...

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: I014e7670ca4ba57f7e1b80e96c001474cf7a6676
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

Recover host devtree file if corrupted

This commit addresses the issue where device tree file corruption could
lead to the failure of the BMC to boot up. Corruption of the file may
occur during a ke

Recover host devtree file if corrupted

This commit addresses the issue where device tree file corruption could
lead to the failure of the BMC to boot up. Corruption of the file may
occur during a kernel panic. In such instances, recovery of the previous
uncorrupted version of the file from the available read-only version is
now implemented.

A PEL is generated indicating the same and the BMC dump is generated.

Tested and working as expected.

```
peltool -i 0x50001C86
{
"Private Header": {
"Section Version": "1",
"Sub-section type": "0",
"Created by": "bmc code management",
"Created at": "04/22/2024 08:37:41",
"Committed at": "04/22/2024 08:37:41",
"Creator Subsystem": "BMC",
"CSSVER": "",
"Platform Log Id": "0x50001C86",
"Entry Id": "0x50001C86",
"BMC Event Log Id": "127"
},
"User Header": {
"Section Version": "1",
"Sub-section type": "0",
"Log Committed by": "bmc error logging",
"Subsystem": "BMC Firmware",
"Event Scope": "Entire Platform",
"Event Severity": "Unrecoverable Error",
"Event Type": "Not Applicable",
"Action Flags": [
"Service Action Required",
"Report Externally",
"HMC Call Home"
],
"Host Transmission": "Not Sent",
"HMC Transmission": "Acked"
},
"Primary SRC": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "bmc code management",
"SRC Version": "0x02",
"SRC Format": "0x55",
"Virtual Progress SRC": "False",
"I5/OS Service Event Bit": "False",
"Hypervisor Dump Initiated":"False",
"Backplane CCIN": "2E2D",
"Terminate FW Error": "False",
"Deconfigured": "False",
"Guarded": "False",
"Error Details": {
"Message": "Partition was not preserved
on reboot",
"CURRENT_FILE_SIZE": [
"0x100000",
"Size of the current running
partition"
],
"EXPECTED_FILE_SIZE": [
"0x65000",
"Size of the read only partition"
]
},
"Valid Word Count": "0x09",
"Reference Code": "BD8D360A",
"Hex Word 2": "00080055",
"Hex Word 3": "2E2D0010",
"Hex Word 4": "00000000",
"Hex Word 5": "00000000",
"Hex Word 6": "00100000",
"Hex Word 7": "00065000",
"Hex Word 8": "00000000",
"Hex Word 9": "00000000",
"Callout Section": {
"Callout Count": "1",
"Callouts": [{
"FRU Type": "Maintenance Procedure Required",
"Priority": "Mandatory, replace all with this
type as a unit",
"Procedure": "BMC0001"
}]
}
},
"Extended User Header": {
"Section Version": "1",
"Sub-section type": "0",
"Created by": "bmc error logging",
"Reporting Machine Type": "9105-22B",
"Reporting Serial Number": "139F210",
"FW Released Ver": "",
"FW SubSys Version": "fw1060.00-7",
"Common Ref Time": "00/00/0000 00:00:00",
"Symptom Id Len": "20",
"Symptom Id": "BD8D360A_2E2D0010"
},
"Failing MTMS": {
"Section Version": "1",
"Sub-section type": "0",
"Created by": "bmc error logging",
"Machine Type Model": "9105-22B",
"Serial Number": "139F210"
},
"User Data 0": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "bmc error logging",
"BMCLoad": "1.35 1.02 0.76",
"BMCState": "Ready",
"BMCUptime": "0y 2d 13h 38m 12s",
"BootState": "Unspecified",
"ChassisState": "Off",
"FW Version ID": "fw1060.00-7-2-g4d0fcde41f",
"HostState": "Off",
"System IM": "50001001"
},
"User Data 1": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "bmc error logging",
"CURRENT_FILE_SIZE": "1048576",
"EXPECTED_FILE_SIZE": "413696",
"FILE_NAME": "81e00672.lid"
}
}
```

Change-Id: I2ce9c7a471f6e1ba43ac5b061a62e27cfd61da23
Signed-off-by: deepakala-k <deepakala.karthikeyan@ibm.com>

show more ...

vpnor: updatesymlinks: Disable rate limiting

This service can be restarted multiple times in a row after a BMC reboot
due to its WantedBy dependencies, causing this service to fail with a
start-limi

vpnor: updatesymlinks: Disable rate limiting

This service can be restarted multiple times in a row after a BMC reboot
due to its WantedBy dependencies, causing this service to fail with a
start-limit-hit systemd error because it exceeds the default burst
limit.
Disable the rate limiting to avoid this error since this service is
designed to be started as many times as required.

Tested: Restarted pldmd and mboxd multiple times and the start-limit-hit
error is not seeing anymore.

Change-Id: I437cc70d3cf70cd8d59d17b7cb2f4b8995a278c8
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

OWNERS: Update Gunnar's email address

I have multiple email addresses in my Gerrit account but as
https://gerrit.openbmc.org/c/openbmc/bmcweb/+/69506 shows my Preferred
email has to match the OWNERS

OWNERS: Update Gunnar's email address

I have multiple email addresses in my Gerrit account but as
https://gerrit.openbmc.org/c/openbmc/bmcweb/+/69506 shows my Preferred
email has to match the OWNERS file, do that.

More discussion in Discord at
[1] https://discord.com/channels/775381525260664832/817151035197358081/1209585278025601094

Tested: With https://gerrit.openbmc.org/c/openbmc/bmcweb/+/69549 my +2
means something again.

Change-Id: I97d75054c68674ed5342df983e338ea524f60412
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

functions: Replace IBMCompatibleSystem with Compatible

The Compatible interface will be replacing the IBMCompatibleSystem
interface. Reference:
https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-int

functions: Replace IBMCompatibleSystem with Compatible

The Compatible interface will be replacing the IBMCompatibleSystem
interface. Reference:
https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/68125
https://gerrit.openbmc.org/c/openbmc/entity-manager/+/68128

Tested: Verified the symlinks for the PNOR files were created
successfully on a Rainier 4U system with the new Compatible interface
changes.

Change-Id: Idf2511d6616723bd21c945fe228499ae9eaf2fea
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

prefer std::format over fmt

Use std::format and remove the dependency on fmt.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I2d25b542c03c213727d872c5d36114fc59efc8fc

build: use allowed over enabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer retur

build: use allowed over enabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer return true for auto features. Instead, the
expectation is to use `allowed()` which is true for both enabled and auto.

Switch all uses of `enabled` to `allowed`.

Change-Id: Ia7640469aa92a6fac3a11dd55a2d3b9eea0e637a
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson: disable oe-sdk by default

The meson option oe-sdk is used in rare scenarios. Having it
non-defaulted turns it into an `auto` feature, which is not desired.
Explicitly disable it by default.

meson: disable oe-sdk by default

The meson option oe-sdk is used in rare scenarios. Having it
non-defaulted turns it into an `auto` feature, which is not desired.
Explicitly disable it by default.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I975964a1c316438e9ee358b84ff1b9a5c72de763

show more ...