Add re-try for redfish GET request for targets

Changes:
- This retries is added to improve the success rate
for the GET request in case returns JSON errors
for the following URI duri

Add re-try for redfish GET request for targets

Changes:
- This retries is added to improve the success rate
for the GET request in case returns JSON errors
for the following URI during operation
/redfish/v1/Systems/ and /redfish/v1/Managers/

- Added other places in code to handle exceptions.
- Fix IPMI import paths in test suite

Tested:
- Ran from sandbox.

Change-Id: Ie37dbdd9c7572e0003a56e65a7b5f0a4c3b26a1a
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Switch from Force Tags to Test Tags

Force Tags is deprecated in Robot 7.0 and will eventually
warn and then after that stop working. Test Tags performs
the same function per docs.

Change-Id: I7cf30

Switch from Force Tags to Test Tags

Force Tags is deprecated in Robot 7.0 and will eventually
warn and then after that stop working. Test Tags performs
the same function per docs.

Change-Id: I7cf305754b247b995a05d8da3b9de9ed613ecae2
Signed-off-by: Matt Fischer <matthew.fischer@hpe.com>

show more ...

Set system, chassis, and bmc as global variables

Changes:
- Add SYSTEM_ID as a global variable and set to default value system
- Replace redfish/v1/Systems/system to redfish/v1/Systems/SYSTEM_ID

Set system, chassis, and bmc as global variables

Changes:
- Add SYSTEM_ID as a global variable and set to default value system
- Replace redfish/v1/Systems/system to redfish/v1/Systems/SYSTEM_ID
- Replace redfish/v1/Chassis/chassis to redfish/v1/Chassis/CHASSIS_ID
- Replace redfish/v1/Managers/bmc to redfish/v1/Managers/MANAGER_ID

Tested:
- Tested on sandbox with the changes with sample test run with
sample test ID runs
1. without SYSTEM_ID provided
2. with -v SYSTEM_ID:system1
3. with export SYSTEM_ID=""
3. with export SYSTEM_ID="system2"

Change-Id: Ifc412b20038cef1eba632caaa6c300be328259bd
Signed-off-by: Wilson Suen <wilsons@supermicro.com>
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Add missing HTTPS_PORT reference

Without this reference all tests in this section fail
on non-standard ports.

Change-Id: I90db7c345d35f328d875fe4fad1791c563f73600
Signed-off-by: Matt Fischer <matth

Add missing HTTPS_PORT reference

Without this reference all tests in this section fail
on non-standard ports.

Change-Id: I90db7c345d35f328d875fe4fad1791c563f73600
Signed-off-by: Matt Fischer <matthew.fischer@hpe.com>

show more ...

Add new force tags for test suites

Comments:
- Added new tags for the test suites

Tested:
- NA

Change-Id: Ibd7eb9e821290c44bd1255d47a52e596e6135cbf
Signed-off-by: George Keishing <gkeishin@i

Add new force tags for test suites

Comments:
- Added new tags for the test suites

Tested:
- NA

Change-Id: Ibd7eb9e821290c44bd1255d47a52e596e6135cbf
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Managers ID : Introduced variable to declare Managers ID in resource.robot and updated all the scripts in openbmc-test-automation

Changes:
- Introduced ${MANAGER_ID} variable in resource.robot

Managers ID : Introduced variable to declare Managers ID in resource.robot and updated all the scripts in openbmc-test-automation

Changes:
- Introduced ${MANAGER_ID} variable in resource.robot
- Replaced all the Managers/bmc to Managers/${MANAGER_ID} across all the scripts
- Also in data/variables.py updated chassis id for the few redfish uri.

Tested:
- Ran All The Scripts Successfully

Change-Id: Iff3673aae27657e0799dec5cb94c1651a0cd5d18
Signed-off-by: ganesanb <ganesanb@ami.com>
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Clean up robot test suite imports

Changes:
- Remove resource file import to prevent cyclic reference

Tested:
- Ran test suites to check they are working.

Change-Id: I492b6eeda0023a515627

Clean up robot test suite imports

Changes:
- Remove resource file import to prevent cyclic reference

Tested:
- Ran test suites to check they are working.

Change-Id: I492b6eeda0023a5156274653d7db13e7f127822c
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Test documentation typo fixes using codespell tool

Changes:
- Fix typo in code documentation and test name

Tested: - Using codespell tool.

Change-Id: Ia1b65bddc01a4b1c103af9f2094d87da11c8895

Test documentation typo fixes using codespell tool

Changes:
- Fix typo in code documentation and test name

Tested: - Using codespell tool.

Change-Id: Ia1b65bddc01a4b1c103af9f2094d87da11c88953
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Robotframework request package upgrade changes

Current working package version
robotframework-requests 0.7.2

To Test:
pip3 install robotframework-requests -U
or

Robotframework request package upgrade changes

Current working package version
robotframework-requests 0.7.2

To Test:
pip3 install robotframework-requests -U
or
# Once this commit is merged.
pip3 install -r requirements.txt

Version latest:
robotframework-requests 0.9.3

Refer Documentation:
https://marketsquare.github.io/robotframework-requests/doc/RequestsLibrary.html

What is not changed:
- The test cases under directory tests/ is not modified and is
deprecated but you can continue using it with older package
and configuration using

git clone -b v3.0-stable https://github.com/openbmc/openbmc-test-automation

Tested:
Upstream HW_CI test list, firmware code update and few other
test suite like ipmi, certificate, dumps, ffdc and redfish
test suites.

Note: I have not tested end to end, so it is likely there could be
grey areas where it could fail but should be minor w.r.t
response data format.

Resolves: openbmc/openbmc-test-automation#2105

Change-Id: Ie03b25ff88948bcccb09e9d82f8da86e28c92697
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Fix test cases name tags under redfish directory

Change-Id: Icec85bd3b11f541c185a9242191096774d04290e
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Remove / base path for hypermedia URL

Refer: https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/46057

Change-Id: I52dfeb0f73bebcdd70d408e08926ae1b2cf7e7cc
Signed-off-by: George Keishing <gkeish

Remove / base path for hypermedia URL

Refer: https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/46057

Change-Id: I52dfeb0f73bebcdd70d408e08926ae1b2cf7e7cc
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Fixed cases with hard-coded 'chassis'

Reference to
https://www.dmtf.org/sites/default/files/standards/documents/DSP2046_2020.3.pdf

It should not hard-coded as 'chassis' in /redfish/v1/Chassis/chass

Fixed cases with hard-coded 'chassis'

Reference to
https://www.dmtf.org/sites/default/files/standards/documents/DSP2046_2020.3.pdf

It should not hard-coded as 'chassis' in /redfish/v1/Chassis/chassis.
It could be different name for /redfish/v1/Chassis/{ChassisId}.

Signed-off-by: Tony Lee <tony.lee@quantatw.com>
Change-Id: Ie6e8f37356b88692148bdda7348e715fcac6b4e3

show more ...

Ensure logout before testing logged out cases

When a case fails the test framework automatically collect the logs, and
it will login to BMC via REST/Redfish. In such case, test cases
depending on lo

Ensure logout before testing logged out cases

When a case fails the test framework automatically collect the logs, and
it will login to BMC via REST/Redfish. In such case, test cases
depending on logged out state will fail.

For example, in case "GET Redfish Hypermedia Without Login" fails, the
next case "GET Redfish SessionService Without Login" will fail as well.

Fix this by running Redfish.Logout before the "logged out" cases.

Tested: When "GET Redfish Hypermedia Without Login" fails, verify the
next case "GET Redfish SessionService Without Login" succeeds.

Signed-off-by: Lei YU <mine260309@gmail.com>
Change-Id: Iacb2d2b6379bd5d616cd5358498a8bd14fc014ae

show more ...

Robot coding guideline fixes

Changes:
- Fix line char 110 exceeding.

Change-Id: I45fcc995dfee29173cf038f63699ef634507e9a6
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Added test to verify unresponsive paths in redfish

Signed-off-by: Anusha Dathatri <adathatr@in.ibm.com>
Change-Id: I789c07398e04d162b0b9a92d3f74a19a50139a13

Remove GET request for motherboard

Condition where the host is not booted yet and test check for GET
on /redfish/v1/Chassis/motherboard and fails. This use case is
checked in other power on. Removin

Remove GET request for motherboard

Condition where the host is not booted yet and test check for GET
on /redfish/v1/Chassis/motherboard and fails. This use case is
checked in other power on. Removing from the GET listed test list.

Change-Id: I9f61f4f0366577aa5088cfa45503ebd48e433ad5
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Test to GET services available for HW_CI

Change-Id: If819cbd49a8cbc9837c96ad742d6e42d7bf28c5e
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Test to connect via redfish Session service

Change-Id: I243b64534fae57749743c0056e685e411dfa9705
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Test case to verify HTTP_NOT_FOUND error response code

Change-Id: I1b3bb99df30c8d832f4108a20ce58caed5bc78ad
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Remove use of deprecated rprint functions

For each of the rprint functions, there is a corresponding gen_print function
that can be used instead.

Change-Id: I89c6e0b63cac7aee92da7dc7945e41300128796

Remove use of deprecated rprint functions

For each of the rprint functions, there is a corresponding gen_print function
that can be used instead.

Change-Id: I89c6e0b63cac7aee92da7dc7945e413001287967
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Delete first session created.

Change-Id: Ica414d81576c68151f05fe1c05f107bf7528b645
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Enforce robotframework standards
- Using standards set in robot_standards file

Change-Id: I284e7958a7a34eca775b4c28b959f6fe2ec35a67
Signed-off-by: Joy Onyerikwu <onyekachukwu.joy.onyerikwu@ibm.com>

New BMC redfish library integration

Changes:
- Use redfish_plus.py when importing Redfish instances.
- Update bmc_redfish.py.
- Update bmc_redfish_utility.py.
- Update object name 'redfi

New BMC redfish library integration

Changes:
- Use redfish_plus.py when importing Redfish instances.
- Update bmc_redfish.py.
- Update bmc_redfish_utility.py.
- Update object name 'redfish' to 'Redfish'.
- Update test setup and teardown in suites.
- Update response error checking using valid_status_codes.
- Fix test cases required for migration.

Change-Id: Ida154aede649d9a2bbef66d16ccf725f5ea37ed0
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Redfish python utility

Changes:
- New redfish utility library code.
- Move generic utility functions to new library.
- Update test cases with new utility object acces.

Change-Id: Ia2bb1

Redfish python utility

Changes:
- New redfish utility library code.
- Move generic utility functions to new library.
- Update test cases with new utility object acces.

Change-Id: Ia2bb18cb46ca93503853bbfd1773d3e4447339c9
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Replace resource.txt with resource.robot

Change-Id: I4d2afd35645880e33a31644cd717bbeae55666f0
Signed-off-by: Sandhya Somashekar <sansomas@in.ibm.com>