Changed a Keyword and test case for date and time

Changes:
- Added a keyword for set date and time

Tested:
Ran and tested on BMC Environment

Change-Id: I3a3053cda80b4e1d456

Changed a Keyword and test case for date and time

Changes:
- Added a keyword for set date and time

Tested:
Ran and tested on BMC Environment

Change-Id: I3a3053cda80b4e1d456904de9d654115f78187a7
Signed-off-by: Saranya Devi Alluri <saranyad@in.ibm.com>

show more ...

Fix for Date and Time

Changes:
- Made status code changes for Redfish date and time.

Tested:
- Ran testcase from sandbox successfully.

Change-Id: Ic7824bccd431f75634df69ccf0a47db42058822e
Si

Fix for Date and Time

Changes:
- Made status code changes for Redfish date and time.

Tested:
- Ran testcase from sandbox successfully.

Change-Id: Ic7824bccd431f75634df69ccf0a47db42058822e
Signed-off-by: sarandev3 <saranyad@in.ibm.com>

show more ...

Separating network protocol and Manual date time Testcases

Changes:
- Separated test suites based on manual date, time, and NTP.

Tested:
- Ran and tested on BMC Environment.

Chang

Separating network protocol and Manual date time Testcases

Changes:
- Separated test suites based on manual date, time, and NTP.

Tested:
- Ran and tested on BMC Environment.

Change-Id: I5edca932207df0c5060f7e59a4be0adb179e7b1d
Signed-off-by: Anvesh-Kumar_Rayankula <anvesh.kumar.rayankula@ibm.com>

show more ...

Switch from Force Tags to Test Tags

Force Tags is deprecated in Robot 7.0 and will eventually
warn and then after that stop working. Test Tags performs
the same function per docs.

Change-Id: I7cf30

Switch from Force Tags to Test Tags

Force Tags is deprecated in Robot 7.0 and will eventually
warn and then after that stop working. Test Tags performs
the same function per docs.

Change-Id: I7cf305754b247b995a05d8da3b9de9ed613ecae2
Signed-off-by: Matt Fischer <matthew.fischer@hpe.com>

show more ...

Robot Framework 7.0 changes

Update robot code syntax overall in the repo

Changes:
- Update the requirement.txt package version for robot
- The '[Return]' setting is deprecated.
Use the

Robot Framework 7.0 changes

Update robot code syntax overall in the repo

Changes:
- Update the requirement.txt package version for robot
- The '[Return]' setting is deprecated.
Use the 'RETURN' statement instead.
- Singular section headers like '*** Test Case ***'
are deprecated. Use plural format like
'*** Test Cases ***' instead.
- Singular section headers like '*** Variable ***'
are deprecated

Tested:
- Ran from sandbox with the version
$ robot --version
Robot Framework 7.0 (Python 3.10.12 on linux)

and also tested on latest python version

Robot Framework 7.0 (Python 3.11.9 on linux)

Change-Id: I54e85f9d799556c63b9a39f79483f83e9b980768
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Add force tag for the date time suites

Changes:
- Added tag name as per standard

Tested:
- NA

Change-Id: Ia15e94253079ed9a487f5dbe5980caaa66ef323c
Signed-off-by: George Keishing <gkeishin@

Add force tag for the date time suites

Changes:
- Added tag name as per standard

Tested:
- NA

Change-Id: Ia15e94253079ed9a487f5dbe5980caaa66ef323c
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Fix Line has trailing whitespace (TrailingWhitespace)

Changes:
- Remove trailing white spaces in code

Tested:
- NA

Change-Id: I6eb73386d46e6f189f127d0a64a5156d3c4c2854
Signed-off-by: Geo

Fix Line has trailing whitespace (TrailingWhitespace)

Changes:
- Remove trailing white spaces in code

Tested:
- NA

Change-Id: I6eb73386d46e6f189f127d0a64a5156d3c4c2854
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Managers ID : Introduced variable to declare Managers ID in resource.robot and updated all the scripts in openbmc-test-automation

Changes:
- Introduced ${MANAGER_ID} variable in resource.robot

Managers ID : Introduced variable to declare Managers ID in resource.robot and updated all the scripts in openbmc-test-automation

Changes:
- Introduced ${MANAGER_ID} variable in resource.robot
- Replaced all the Managers/bmc to Managers/${MANAGER_ID} across all the scripts
- Also in data/variables.py updated chassis id for the few redfish uri.

Tested:
- Ran All The Scripts Successfully

Change-Id: Iff3673aae27657e0799dec5cb94c1651a0cd5d18
Signed-off-by: ganesanb <ganesanb@ami.com>
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Redfish NTP: Handled code to add ntp address and enable ntp if bmc time was 1970

Changes:
- In suite setup, add code to handle if bmc date was in 1970 ntp will be enabled
and ntp address w

Redfish NTP: Handled code to add ntp address and enable ntp if bmc time was 1970

Changes:
- In suite setup, add code to handle if bmc date was in 1970 ntp will be enabled
and ntp address will be added.
- If bmc date was not in 1970, it will continue for test execution.
- Added ${NTP_ADDRESSES} variable in lib/resource.robot to get ntp addresses as an list.

Tested:
- Ran All The Scripts Successfully

Change-Id: Ifcfdc9bf87c46150a628a537fee05de083200c6e
Signed-off-by: ganesanb <ganesanb@ami.com>

show more ...

Managers bmc & bmc time script fix

1. redfish/managers/test_managers_bmc.robot
Made the following changes
- In Verify boot count after reboot test case, store the
initial state of NTP/Pro

Managers bmc & bmc time script fix

1. redfish/managers/test_managers_bmc.robot
Made the following changes
- In Verify boot count after reboot test case, store the
initial state of NTP/ProtocolEnabled.
- Set NTP/ProtocolEnabled to TRUE.
- In Teardown restore the NTP to initial state.
This is been done since the test case fails when NTP is disabled.

2. redfish/managers/test_managers_bmc_time.robot
- In Verify Enable NTP test case, while checking the service sync
status for systemd-timesyncd, added a wait time of 1 min.
This is done since after Redfish NTP Patch to Enabled state,
the service status gets updated after some time which causes
test script failure.

Tested: Run robot redfish/managers/test_managers_bmc.robot
Run robot redfish/managers/test_managers_bmc_time.robot

Signed-off-by: Aravinth R <aravinthr@ami.com>
Change-Id: I1d7e1a0189e4d0030e58062b0bf93e8e5c9b47bb

show more ...

Added new test case to test_managers_bmc_time

- Verify_Set_DateTime_With_NTP_Enabled
Check set date time is restricted when NTP Protocol is Enabled.

- Added keyword to check NTP Protocol Enabled s

Added new test case to test_managers_bmc_time

- Verify_Set_DateTime_With_NTP_Enabled
Check set date time is restricted when NTP Protocol is Enabled.

- Added keyword to check NTP Protocol Enabled sync with systemd-timesyncd service status.

Tested: Run robot /redfish/managers/test_managers_bmc_time.robot

Signed-off-by: Aravinth R <aravinthr@ami.com>
Change-Id: Ic17696d9bd53478d3a8ae323869c937c2b2eaeda

show more ...

Update NTP test logic to better handle set and get NTP servers

Changes:
- Added new keyword to wait for GET request.
- Add test setup in the test to enabled NTP
- Update documentation an

Update NTP test logic to better handle set and get NTP servers

Changes:
- Added new keyword to wait for GET request.
- Add test setup in the test to enabled NTP
- Update documentation and variable string

Tested:

robot -v OPENBMC_HOST:xx.xx.xx.xx --include Verify_NTP_Server_Set
--include Verify_NTP_Server_Setting_Persist_After_BMC_Reboot
redfish/managers/test_managers_bmc_time.robot

Change-Id: I7976e4e8775b8f1e4b6b744bb54df386dc0d67fd
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Changed setting of manual mode to Redfish from Rest

Signed-off-by: Anusha Dathatri <adathatr@in.ibm.com>
Change-Id: I2ab3ddf43cbbbfa5dda7c7b481d280b0d081c01e

Fix typo in code documentation

Change-Id: I0036abe0f08262f78598da2fc12c673da9fba02b
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Added time delay to set datetime manually

This commit fixes the inconsistent failure see in
Verify_Immediate_Consumption_Of_BMC_Date test setup.

Change-Id: Ic55611f04268e6df868708f55afda793b9757b0f

Added time delay to set datetime manually

This commit fixes the inconsistent failure see in
Verify_Immediate_Consumption_Of_BMC_Date test setup.

Change-Id: Ic55611f04268e6df868708f55afda793b9757b0f
Signed-off-by: Anusha Dathatri <adathatr@in.ibm.com>

show more ...

Validate immediate datetime change

Validates
https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-time-manager/+/31284/
This suite does not contain any test which waits for deferred updates.
Hence

Validate immediate datetime change

Validates
https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-time-manager/+/31284/
This suite does not contain any test which waits for deferred updates.
Hence does not require any change wrt that.

Signed-off-by: Anusha Dathatri <adathatr@in.ibm.com>
Change-Id: I3b6fb750f153c3513714460a713d9e6a614871a4

show more ...

Set NTP service to inactive before set bmc time

Set NTP service to inactive before set bmc time.
and retore it at Suite Teardown. Otherwise, set bmc time will fail.

Signed-off-by: Tony Lee <tony.le

Set NTP service to inactive before set bmc time

Set NTP service to inactive before set bmc time.
and retore it at Suite Teardown. Otherwise, set bmc time will fail.

Signed-off-by: Tony Lee <tony.lee@quantatw.com>
Change-Id: I9960371f1380c7fe7873e8309ab6ad31b9e13c18

show more ...

Removed timeowner for Redfish tests

This change is wrt the code
https://gerrit.openbmc-project.xyz/#/c/openbmc/phosphor-time-manager/+/31278/

Signed-off-by: Anusha Dathatri <adathatr@in.ibm.com>
Ch

Removed timeowner for Redfish tests

This change is wrt the code
https://gerrit.openbmc-project.xyz/#/c/openbmc/phosphor-time-manager/+/31278/

Signed-off-by: Anusha Dathatri <adathatr@in.ibm.com>
Change-Id: I85846f32f87585cb1d0ec200004aed67bc167479

show more ...

Fix code documentation and robot lint warnings

Fixed all in the repository except for the following:

$ python -m rflint -A robot_standards -R robot_custom_rules.py .
+ ./redfish/service_root/test_s

Fix code documentation and robot lint warnings

Fixed all in the repository except for the following:

$ python -m rflint -A robot_standards -R robot_custom_rules.py .
+ ./redfish/service_root/test_service_root_security.robot
W: 19, 110: Line is too long (exceeds 110 characters) (LineTooLong)

Change-Id: I7011f6054a2b046f19a6b39b5f3cf38b5d4facb4
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Update time owner setting

By default the owner should be "Both".

Change-Id: I41647bc19e88f06d415b31f7704016716987910d
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Update NTP enabled body and response code check

Change-Id: Idd9a8079c7a37abc864bbde5cb923e0ace988aaf
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Fix NTP patch request body construct

Change-Id: Iac7f1d00cdbf189243d8788936d3c122f2077fa1
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Set time by applying manual mode before time ownership to BMC

Change-Id: I6c74155546fca23d91e39a84729bc4c6e70cb60c
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Change Rvalid to Valid

Change all references to keywords like "Rvalid Values" to "Valid Values".
"Rvalid Values" has been deprecated.

Change-Id: I1b418fa69e5753c8bfb9e6a06a8b566359e10cae
Signed-off

Change Rvalid to Valid

Change all references to keywords like "Rvalid Values" to "Valid Values".
"Rvalid Values" has been deprecated.

Change-Id: I1b418fa69e5753c8bfb9e6a06a8b566359e10cae
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Accommodate Valid Range lower/upper args

Valid Range previously accepted a valid_range string argument whose format
was "<lower>..<upper>". The valid_range argument has been deprecated and
replaced

Accommodate Valid Range lower/upper args

Valid Range previously accepted a valid_range string argument whose format
was "<lower>..<upper>". The valid_range argument has been deprecated and
replaced by 2 arguments: lower and upper.

Also, Rvalid Range has been renamed to Valid Range.

Instances of Rvalid Range have been altered to accommodate the changes.

Change-Id: If2e8495fb9d2099007b68d4451a8460924fbc999
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...