Switch from Force Tags to Test Tags

Force Tags is deprecated in Robot 7.0 and will eventually
warn and then after that stop working. Test Tags performs
the same function per docs.

Change-Id: I7cf30

Switch from Force Tags to Test Tags

Force Tags is deprecated in Robot 7.0 and will eventually
warn and then after that stop working. Test Tags performs
the same function per docs.

Change-Id: I7cf305754b247b995a05d8da3b9de9ed613ecae2
Signed-off-by: Matt Fischer <matthew.fischer@hpe.com>

show more ...

Robot Framework 7.0 changes

Update robot code syntax overall in the repo

Changes:
- Update the requirement.txt package version for robot
- The '[Return]' setting is deprecated.
Use the

Robot Framework 7.0 changes

Update robot code syntax overall in the repo

Changes:
- Update the requirement.txt package version for robot
- The '[Return]' setting is deprecated.
Use the 'RETURN' statement instead.
- Singular section headers like '*** Test Case ***'
are deprecated. Use plural format like
'*** Test Cases ***' instead.
- Singular section headers like '*** Variable ***'
are deprecated

Tested:
- Ran from sandbox with the version
$ robot --version
Robot Framework 7.0 (Python 3.10.12 on linux)

and also tested on latest python version

Robot Framework 7.0 (Python 3.11.9 on linux)

Change-Id: I54e85f9d799556c63b9a39f79483f83e9b980768
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Remove syslib and migrate to lib

Changes:
- Move files to lib and rename to align to lib naming
- Update test suites using it.

Tested:
- Test on sandbox with robot --dryrun to make sure

Remove syslib and migrate to lib

Changes:
- Move files to lib and rename to align to lib naming
- Update test suites using it.

Tested:
- Test on sandbox with robot --dryrun to make sure
the linkage is not broken.

Change-Id: I586c06dd3c4e544d87d130c3331886016af66437
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Add option to invalidate all the guard records

Changes:
- User driven option to invalidate all the guard records.
By default DELETE_OLD_GUARD_FILE is set to 0.

User should use ro

Add option to invalidate all the guard records

Changes:
- User driven option to invalidate all the guard records.
By default DELETE_OLD_GUARD_FILE is set to 0.

User should use robot option:
-v DELETE_OLD_GUARD_FILE:1
to call this option into force.

Tested:
- Ran from sandbox.

Change-Id: I0f3a066253d0d03d3e6d0b0733630079b85dbb5c
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Increase code update test timeout

Changes:
- Increase from 30 mins to 45 minutes. The test to update
both the running and primary side overall varies and
fails sometime due to tes

Increase code update test timeout

Changes:
- Increase from 30 mins to 45 minutes. The test to update
both the running and primary side overall varies and
fails sometime due to test timing out before it could
complete.

Tested:
- NA. This input is based on recent few code update runs
averaging from 26 minutes to 30+ minutes.

Change-Id: I222bb004f5de663bee97ffef82783879454b8475
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Redfish update test suite Force tags as per standard

Changes:
- Update Tags names for the test suite

Note: Refer CONTRIBUTING.md for under Tags section
documentation.

Tested:
- NA

Cha

Redfish update test suite Force tags as per standard

Changes:
- Update Tags names for the test suite

Note: Refer CONTRIBUTING.md for under Tags section
documentation.

Tested:
- NA

Change-Id: Ice5fa1a185876774d9e9bce4ff53f834b2a1f652
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

svc-restart: adapt do state service instance changes

phosphor-state-manager moved to a multi chassis and multi host design
point. This made their corresponding service files instance based.

Change-

svc-restart: adapt do state service instance changes

phosphor-state-manager moved to a multi chassis and multi host design
point. This made their corresponding service files instance based.

Change-Id: Ib28c5b0c5e6134e83ad056451029bcc132b73db0
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

Add systemd circular dependency check

It's usefull add circular dependency check for systemd units.

The error log if had circular dependency:
```
Mar 10 06:20:45 g220b systemd[1]: xyz.openbmc_proje

Add systemd circular dependency check

It's usefull add circular dependency check for systemd units.

The error log if had circular dependency:
```
Mar 10 06:20:45 g220b systemd[1]: xyz.openbmc_project.AssetManager.service: Found ordering cycle on xyz.openbmc_project.Software.BMC.Updater.service/start
Mar 10 06:20:45 g220b systemd[1]: xyz.openbmc_project.AssetManager.service: Found dependency on sel-ready.target/start
Mar 10 06:20:45 g220b systemd[1]: xyz.openbmc_project.AssetManager.service: Found dependency on xyz.openbmc_project.Logging.IPMI.service/start
Mar 10 06:20:45 g220b systemd[1]: xyz.openbmc_project.AssetManager.service: Found dependency on xyz.openbmc_project.Logging.service/start
Mar 10 06:20:45 g220b systemd[1]: xyz.openbmc_project.AssetManager.service: Found dependency on obmc-fru-fault-monitor.service/start
Mar 10 06:20:45 g220b systemd[1]: xyz.openbmc_project.AssetManager.service: Found dependency on xyz.openbmc_project.AssetManager.service/start
Mar 10 06:20:45 g220b systemd[1]: xyz.openbmc_project.AssetManager.service: Job xyz.openbmc_project.Software.BMC.Updater.service/start deleted to break ordering cycle start
Mar 10 06:20:45 g220b systemd[1]: Queued start job for default target Multi-User System.
```

I think this is good to check it in CI.

Tested:
```
~# python3 -m robot -v OPENBMC_HOST:xx.xx.xx.xx redfish/test_xit.robot

Mar 10 06:20:45 g220b systemd[1]: xyz.openbmc_project.AssetManager.service: Found ordering cycle on xyz.openbmc_project.Software.BMC.Updater.service/start
Verify No BMC Dump And Application Failures In BMC :: Verify no BM... | FAIL |
'Mar 10 06:20:45 g220b systemd[1]: xyz.openbmc_project.AssetManager.service: Found ordering cycle on xyz.openbmc_project.Software.BMC.Updater.service/start' should be empty.
------------------------------------------------------------------------------
Test Xit :: This suite is to run some test at the end of execution. | FAIL |
1 test, 0 passed, 1 failed
==============================================================================
```

Change-Id: I3288106b06399acf22fa44cba3b3d0fa69944cfc
Signed-off-by: Jian Zhang <zhangjian.3032@bytedance.com>

show more ...

Redfish new code update URI changes

Changes:
- Add the new FW update URI based on the probe if it
exists. This ensures the current and
new URI co-exist for older and newer drivers

Redfish new code update URI changes

Changes:
- Add the new FW update URI based on the probe if it
exists. This ensures the current and
new URI co-exist for older and newer drivers.
- Old : /redfish/v1/UpdateService and
New : /redfish/v1/UpdateService/update

Tested:
- Suite redfish_bmc_code_update.robot tested in sandbox
and there are other places which will need changes.
This commit will ONLY add for HW Jenkinsins to
ensure the upstream HW CI pipeline is not broken.

Change-Id: I9c3f780a03d73615a285fa6682728d607e734340
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Replaced REST usage with Redfish for core dump test case

Changes
- Replaced REST usage with Redfish for core dump test case
- Moved Core dump size test case to new redfish bucket

Tested:

Replaced REST usage with Redfish for core dump test case

Changes
- Replaced REST usage with Redfish for core dump test case
- Moved Core dump size test case to new redfish bucket

Tested:

- Ran the test successfully from sandbox.

Change-Id: Ib57ccaa19397908677296ff88b629895ba305465
Signed-off-by: manashsarma <manashsarma@in.ibm.com>

show more ...

Update test tag and typo fixes in test scripts

Changes:
- Fix tag mismatch with test cases
- Fix typo in code documentation

Tested:
Checked with codespell and tag checker tool.

C

Update test tag and typo fixes in test scripts

Changes:
- Fix tag mismatch with test cases
- Fix typo in code documentation

Tested:
Checked with codespell and tag checker tool.

Change-Id: I4de23c9225cdd46ffa8868e94e0d8d4a410853f4
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Added test to kill and restart service

Changes:
- Kill the list of services and expect killed services restart
- Test case added to test_service_restart_policy.robot suite
Tested:

Added test to kill and restart service

Changes:
- Kill the list of services and expect killed services restart
- Test case added to test_service_restart_policy.robot suite
Tested:
- Tested redfish/extended/test_service_restart_policy.robot

Signed-off-by: ganesanb <ganesanb@ami.com>
Change-Id: I01fd08aa17d5ea1e9280014be93241fc5c68e644

show more ...

Added Redfish.Login Keyword in Test Setup

Tested: Run redfish/extended/test_os_reboot.robot

Signed-off-by: ganesanb <ganesanb@ami.com>
Change-Id: I7d64d9ee7943e1772e31f49f28dfc36359f6e8a7

Replaced BMC reset with PDU reset keyword in restore policy testcase
and added PDU library files for few other PDU types

Tested: Run robot redfish/extended/test_power_restore.robot

Signed-off-by: A

Replaced BMC reset with PDU reset keyword in restore policy testcase
and added PDU library files for few other PDU types

Tested: Run robot redfish/extended/test_power_restore.robot

Signed-off-by: Aravinth R <aravinthr@ami.com>
Change-Id: I4554c1b071a496feaeef65b7b9735bb97a41c7cb

show more ...

Update code update firmware loop test

Changes:
- Logic to read the starting firmware and looping
- Update documentation
- Override test timeout for loop runs

Tested:
robot -v

Update code update firmware loop test

Changes:
- Logic to read the starting firmware and looping
- Update documentation
- Override test timeout for loop runs

Tested:
robot -v OPENBMC_HOST:xx.xx.xx.xx --include Redfish_Firmware_Update_Loop
-v LOOP_COUNT:4 redfish/extended/redfish_bmc_code_update.robot

Change-Id: I9dfba5e16e2bacffece9ca797aabfdf57bf67387
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Add support to code update same image on current and alternate side

Changes:
- Add new test case to perform code update.

Future commit will need few more checks on version.

Change-Id: Iada7030

Add support to code update same image on current and alternate side

Changes:
- Add new test case to perform code update.

Future commit will need few more checks on version.

Change-Id: Iada7030baf7dd48e396dbb89892f590d17768962
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Move test suite test_occ_power.robot to openpower

The OCC is the OpenPOWER On Chip Controller.

Resolves openbmc/openbmc-test-automation#2182

Change-Id: I8484dcef0e08d1fd53c397cb38bce973513e3f15
S

Move test suite test_occ_power.robot to openpower

The OCC is the OpenPOWER On Chip Controller.

Resolves openbmc/openbmc-test-automation#2182

Change-Id: I8484dcef0e08d1fd53c397cb38bce973513e3f15
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Move test suite test_bmc_devicetree.robot to openpower

This is BMC specific but cater to openpower systems like witherspoon.

Resolves openbmc/openbmc-test-automation#2181

Change-Id: Ic3cfc9cb06e

Move test suite test_bmc_devicetree.robot to openpower

This is BMC specific but cater to openpower systems like witherspoon.

Resolves openbmc/openbmc-test-automation#2181

Change-Id: Ic3cfc9cb06e26076ca2b33399078ef47d2e3e0d0
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Add skip error option for journald log checking

Usage:
Single string pattern option usage:
-v SKIP_ERROR:'core-dump'

Multiple string pattern "\|" separated option usage:
-v SKIP_ERR

Add skip error option for journald log checking

Usage:
Single string pattern option usage:
-v SKIP_ERROR:'core-dump'

Multiple string pattern "\|" separated option usage:
-v SKIP_ERROR:'core-dump/Failed to start OpenPOWER OCC'

Change-Id: If79827cd2ff84c50512b57e090d3a93a90a80b9e
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Fix code trailing whitespace and LineTooLong in suites

Changes:
- Line has trailing whitespace (TrailingWhitespace)
- Line is too long (exceeds 110 characters) (LineTooLong)

Testing:

Fix code trailing whitespace and LineTooLong in suites

Changes:
- Line has trailing whitespace (TrailingWhitespace)
- Line is too long (exceeds 110 characters) (LineTooLong)

Testing:
python3 -m rflint -rA robot_standards -R robot_custom_rules.py .

Change-Id: I6e5dcbbb94ddc87f9b49b309b86fbcce86684090
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Add DELETE_ERRLOGS check in code update

by default, all error logs on the system are deleted
skip if set to 0.

Usage:
-v DELETE_ERRLOGS: 0
Change-Id: I68344132ac6fdd99f39146e783b7515734dc6ceb

Sign

Add DELETE_ERRLOGS check in code update

by default, all error logs on the system are deleted
skip if set to 0.

Usage:
-v DELETE_ERRLOGS: 0
Change-Id: I68344132ac6fdd99f39146e783b7515734dc6ceb

Signed-off-by: George Keishing <gkeishin@in.ibm.com>
Change-Id: I987e914f380cf250ab067bd751b2d00ae2cb90e1

show more ...

redfish: extended: dump: fix read Size property failed from dump entry uri

Symptom:
After finish test item "Verify Core Dump Size" with PASS result then
run "Verify Dump After Host Watchdog Error In

redfish: extended: dump: fix read Size property failed from dump entry uri

Symptom:
After finish test item "Verify Core Dump Size" with PASS result then
run "Verify Dump After Host Watchdog Error Injection" will got failed.

From the log, we got "404 != 200" error message.
This error is relate to get size property fail from dump entry uri.
GET Request using : uri=/xyz/openbmc_project/dump/bmc/entry/1/attr/Size
got ${ret} = <Response [404]>. The expected result is 200.

Root cause:
"Trigger Core Dump" keyword will be executed in item "Verify Core Dump Size".
After that, the uri=/xyz/openbmc_project/dump/bmc/entry/1 be generated.
But, this uri will be deleted in "Redfish Delete All BMC Dumps" keword in item
"Verify Dump After Host Watchdog Error Injection".
Thus, cause read "Size" property got failed from the nonexistent uri.

Soluction:
Don't execute Redfish Delete All BMC Dumps this keyword. Remove it in test item.

Tested:
After finish test item "Verify Core Dump Size" with PASS result
then run "Verify Dump After Host Watchdog Error Injection" with PASS result.

Signed-off-by: Tim Lee <timlee660101@gmail.com>
Change-Id: Ica9b71111349c0667070e30b3c9a73297c19d5f2

show more ...

Fix for host code update when
no host image on BMC

Change-Id: Ic14372e8181087f070184807544e60920cb0dcd3
Signed-off-by: Sushil Singh <susilsi7@in.ibm.com>

New logic to look at inventory for firmware update

Changes:
- Refer the firmware inventory before and after upload
- Add new console logs for debugging
- Decouple upload with explicit ch

New logic to look at inventory for firmware update

Changes:
- Refer the firmware inventory before and after upload
- Add new console logs for debugging
- Decouple upload with explicit check for image ID via
SSH to BMC.

Change-Id: Idc17d726f453572ec4f4f5ad7450151bca1c790e
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Fix test cases name tags under redfish directory

Change-Id: Icec85bd3b11f541c185a9242191096774d04290e
Signed-off-by: George Keishing <gkeishin@in.ibm.com>