Fix depecrating robot syntax in test suites

Changes:
- Run KeyWord If is deprecated since Robot
Framework version 5.*, use IF instead
- Keyword name Redfish.login does not follow case

Fix depecrating robot syntax in test suites

Changes:
- Run KeyWord If is deprecated since Robot
Framework version 5.*, use IF instead
- Keyword name Redfish.login does not follow case convention
- TEMPLATE is in wrong place of Test Case.
Recommended order of elements in Test Cases:
DOCUMENTATION, TAGS, TIMEOUT, SETUP, TEMPLATE, KEYWORD, TEARDOWN

Tested:
- Ran dry-run test
Change-Id: I7b861ea1f90b86f57a483b97d40d3104dc789cdb
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Fix in test_user_account.robot

Changes:
- Updated the expected error message

Tested:
- Ran and tested on BMC Environment

Change-Id: I55dee4e1e2bf05a58523431ef1077b8706e7ec5e
Signed-off-by:

Fix in test_user_account.robot

Changes:
- Updated the expected error message

Tested:
- Ran and tested on BMC Environment

Change-Id: I55dee4e1e2bf05a58523431ef1077b8706e7ec5e
Signed-off-by: Vidya Kalasappanavar <Vidya.Kalasappanavar@ibm.com>

show more ...

Fix Account service patch HTTP response code

Changes:
- HTTP 200 and 204 are valid respond.
- CI failure fix F824 global ipmi_required_options
is unused: name is never assigned in scop

Fix Account service patch HTTP response code

Changes:
- HTTP 200 and 204 are valid respond.
- CI failure fix F824 global ipmi_required_options
is unused: name is never assigned in scope

Tested:
Ran from the sandbox with changes.

Change-Id: I11cca086914631b0dd7e39284668a9eb1541adfe
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Udpdate HTTPS valid response code for test

Changes:
- Added HTTP_NO_CONTENT as valid response code for
the test PATCH request

Tested:
- Tested on sandbox with changes

Change-Id: I

Udpdate HTTPS valid response code for test

Changes:
- Added HTTP_NO_CONTENT as valid response code for
the test PATCH request

Tested:
- Tested on sandbox with changes

Change-Id: I2d1c1566fd99336d06dbb59e4c08e1fc25d44b6e
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Robot Framework 7.0 changes

Update robot code syntax overall in the repo

Changes:
- Update the requirement.txt package version for robot
- The '[Return]' setting is deprecated.
Use the

Robot Framework 7.0 changes

Update robot code syntax overall in the repo

Changes:
- Update the requirement.txt package version for robot
- The '[Return]' setting is deprecated.
Use the 'RETURN' statement instead.
- Singular section headers like '*** Test Case ***'
are deprecated. Use plural format like
'*** Test Cases ***' instead.
- Singular section headers like '*** Variable ***'
are deprecated

Tested:
- Ran from sandbox with the version
$ robot --version
Robot Framework 7.0 (Python 3.10.12 on linux)

and also tested on latest python version

Robot Framework 7.0 (Python 3.11.9 on linux)

Change-Id: I54e85f9d799556c63b9a39f79483f83e9b980768
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Removed faillock file check to fix problem

Changes:
- faillock file check is leading to problem. As
it is not a must, removing this check.

Tested:
- Ran below test cases from sandbox

Removed faillock file check to fix problem

Changes:
- faillock file check is leading to problem. As
it is not a must, removing this check.

Tested:
- Ran below test cases from sandbox successfully
Redfish_Create_and_Verify_Admin_User

Change-Id: I489c3c4bf246cf8a127a74fa2ec3f6e3f6545a8e
Signed-off-by: Rahul Maheshwari <rahulmaheshwari@in.ibm.com>

show more ...

REDFISH: script fix redfish test_user_account.robot

Changes:
- Added script fix redfish test_user_account.robot
- remove pam_tally2
Tested:
- Ran and Executed script Successfully

Chang

REDFISH: script fix redfish test_user_account.robot

Changes:
- Added script fix redfish test_user_account.robot
- remove pam_tally2
Tested:
- Ran and Executed script Successfully

Change-Id: I5a0231c6ded3b3906b841c0a79fabd5c7a45ce42
Signed-off-by: ALAGIRI DHILIPAN K <alagiridhilipank@ami.com>

show more ...

Fix typo in test code and documentation

Changes:
- Fix spelling mistake in code.

Tested:
- Tested using codespell tool.

Change-Id: I9f74507049f936383bfc08cb335bb1ed9964c646
Signed-off-by:

Fix typo in test code and documentation

Changes:
- Fix spelling mistake in code.

Tested:
- Tested using codespell tool.

Change-Id: I9f74507049f936383bfc08cb335bb1ed9964c646
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Admin user ssh test case changes to expectation

Changes:
- Modify test case to handle use case where admin user
ssh is allowed and not allowed

Tested:
- Ran from sandbox and tested.

Admin user ssh test case changes to expectation

Changes:
- Modify test case to handle use case where admin user
ssh is allowed and not allowed

Tested:
- Ran from sandbox and tested.
By default SSH access test is allowed set to True
User can change the behaviour of this test case by
passing via CLI -v ssh_access:False

Change-Id: I2d42dbcc4ce3e5d59900b137ca19bcc2d5d642c0
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Fix the Account user incorrect use of operand AND

Changes:
- Fix incorrect use of AND

Tested:
- Ran test from sandbox successfully.

Change-Id: I4f8c77530a1c97b6465ab46cdfe47fe8a680b562
Sig

Fix the Account user incorrect use of operand AND

Changes:
- Fix incorrect use of AND

Tested:
- Ran test from sandbox successfully.

Change-Id: I4f8c77530a1c97b6465ab46cdfe47fe8a680b562
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Add test cases for user account manual unlock and authmethods

- Verify manually unlocking locked user account by setting
"Locked" property from true to false before "AccountLockout
Duration" is

Add test cases for user account manual unlock and authmethods

- Verify manually unlocking locked user account by setting
"Locked" property from true to false before "AccountLockout
Duration" is reached.
- Verify authmethod XToken enable and disable.
- On enable, session based auth should work.
- On disable, session based auth should fail.
- Verify authmethod BasicAuth enable and disable.
- On enable, basic auth should work.
- On disable, basic auth should fail.

Tested: redfish/account_service/test_user_account.robot

Signed-off-by: Aravinth R <aravinthr@ami.com>
Change-Id: Ifb0f53e42a1bcb050a9e503645b23e4c8edc1649

show more ...

Redfish: Fix for 'Verify Error Upon Creating Same Users With Different Privileges'

Changes:
- In /redfish/account_service/test_user_account.robot
- RoleId with 'Operator' no more exist, Henc

Redfish: Fix for 'Verify Error Upon Creating Same Users With Different Privileges'

Changes:
- In /redfish/account_service/test_user_account.robot
- RoleId with 'Operator' no more exist, Hence modifying RoleId value to 'ReadOnly'.

Tested: - Verify_Error_Upon_Creating_Same_Users_With_Different_Privileges

Change-Id: I787c5f880797290c97eab94f2ed33aff155f764f
Signed-off-by: Nandish-Matti <nandish.matti@ibm.com>

show more ...

Delete redfish test user

Changes:
- Added code to delete the admin user new_admin

Tested: - Ran test suite redfish/account_service/test_user_account.robot
Change-Id: Ie1b15416b8d04d911623bcc117

Delete redfish test user

Changes:
- Added code to delete the admin user new_admin

Tested: - Ran test suite redfish/account_service/test_user_account.robot
Change-Id: Ie1b15416b8d04d911623bcc117057eaccce7e11e
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Moved operator user related test out of Verify_Admin_User_Privilege test

Changes:
- Moved operator user related test out of Verify_Admin_User_Privilege
test case and added a new seperate

Moved operator user related test out of Verify_Admin_User_Privilege test

Changes:
- Moved operator user related test out of Verify_Admin_User_Privilege
test case and added a new seperate test case for it
- This is done to skip operator user-related test

Tested: - Ran both the old and new test cases and they passed
Signed-off-by: Rahul Maheshwari <rahulmaheshwari@in.ibm.com>
Change-Id: Ib0c5373af798308b4793a647c7be9d0ea71e1ce7

show more ...

Moved modify operator user attribute test out of a test

Changes:
- Moved modify operator user attribute test out of
Verify Modifying User Attributes test case and added a
new sepe

Moved modify operator user attribute test out of a test

Changes:
- Moved modify operator user attribute test out of
Verify Modifying User Attributes test case and added a
new seperate test case for it
- This is done to skip operator user-related test

Tested:
- Ran both the old and new test cases and they passed

Signed-off-by: Rahul Maheshwari <rahulmaheshwari@in.ibm.com>
Change-Id: I35047ff578511fe02778fa05585ad3f5e293be0d

show more ...

Split user persistence after reboot test into three

Changes:
- Split Verify Redfish User Persistence After Reboot test
in three test cases for admin, operator and read-only users
-

Split user persistence after reboot test into three

Changes:
- Split Verify Redfish User Persistence After Reboot test
in three test cases for admin, operator and read-only users
- This is done to skip operator user-related test

Tested:
- Ran all the three new tests from the sandbox and they passed

Signed-off-by: Rahul Maheshwari <rahulmaheshwari@in.ibm.com>
Change-Id: Icf25562f0e2bc7a5dcfc97f270d5efd1187b8185

show more ...

Fix tag mismatch in test suites

Fixes the following suites:

$ awk -f check_robot_tags.awk redfish/*/* openpower/*/*
--- redfish/account_service/test_user_account.robot:
Redfish Create and Verify

Fix tag mismatch in test suites

Fixes the following suites:

$ awk -f check_robot_tags.awk redfish/*/* openpower/*/*
--- redfish/account_service/test_user_account.robot:
Redfish Create and Verify Admin User
Redfish_Create_and_Verify_Users

--- openpower/test_timed_power_on.robot:
Set And Return Timer For Power ON
Set_Time_For_Power_ON

Change-Id: I6fa3d4f323233b81cccae0ad68de28523cdb48db
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Duplicate testcase name removal from test suite

+ redfish/account_service/test_user_account.robot
E: 103, 0: Duplicate testcase name 'Verify Redfish Operator User with Wrong Password' (DuplicateTest

Duplicate testcase name removal from test suite

+ redfish/account_service/test_user_account.robot
E: 103, 0: Duplicate testcase name 'Verify Redfish Operator User with Wrong Password' (DuplicateTestNames)

Change-Id: I81aefd2d6c40802a811b22d357ce2b58f5ed5b6a
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Seperated different users test into multiple test cases

Change-Id: I170187b47cc877c833ec998f1af4b8e20009fbd9
Signed-off-by: Rahul Maheshwari <rahulmaheshwari@in.ibm.com>

Fix for usr/sbin/faillock file not found failure.

Added check for faillock file, if present it execute faillock cmd
else execute pam_tally2 cmd to reset the accountlock.

Signed-off-by: Nagarjun B

Fix for usr/sbin/faillock file not found failure.

Added check for faillock file, if present it execute faillock cmd
else execute pam_tally2 cmd to reset the accountlock.

Signed-off-by: Nagarjun B <nagarjunb@ami.com>
Change-Id: I2df6dd9e729be149e9631b844e8197915f0fba69

show more ...

Fix test cases name tags under redfish directory

Change-Id: Icec85bd3b11f541c185a9242191096774d04290e
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Added testcase to verify admin user restriction

Added testcase:
- Verify SSH Login Access With Admin User

Change-Id: Ie6b8d84e2864e2cff2074621b0867d9c7a8009ab
Signed-off-by: manashsarma <manash

Added testcase to verify admin user restriction

Added testcase:
- Verify SSH Login Access With Admin User

Change-Id: Ie6b8d84e2864e2cff2074621b0867d9c7a8009ab
Signed-off-by: manashsarma <manashsarma@in.ibm.com>

show more ...

Added local user automation testcase

Verify Error While Deleting Root User

Change-Id: Ibcbc31568f0054f6dd28d88a76897b74cc433169
Signed-off-by: manashsarma <manashsarma@in.ibm.com>

Replacing deprecated pam_tally2 with faillock usage

pam_tally2 is removed from dev code using below commit:
- https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/41357

Change-Id: Ic43b89a83b7

Replacing deprecated pam_tally2 with faillock usage

pam_tally2 is removed from dev code using below commit:
- https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/41357

Change-Id: Ic43b89a83b7e1bad51af9f85957006eff87e9d6a
Signed-off-by: Rahul Maheshwari <rahulmaheshwari@in.ibm.com>

show more ...

Added case to verify Roles defined by Redfish

Verify standard roles described in Redfish Specification (DSP0266).

Change-Id: Ibaeab437fc550e415fe81f81dd4ce2c17517db6b
Signed-off-by: Tony Lee <tony.

Added case to verify Roles defined by Redfish

Verify standard roles described in Redfish Specification (DSP0266).

Change-Id: Ibaeab437fc550e415fe81f81dd4ce2c17517db6b
Signed-off-by: Tony Lee <tony.lee@quantatw.com>

show more ...