robotframework deprecated syntax changes

Prior to Robot Framework 6.0 the marker to use
when giving a custom name to a library was WITH NAME
instead of AS. The old syntax continues to work,
but it i

robotframework deprecated syntax changes

Prior to Robot Framework 6.0 the marker to use
when giving a custom name to a library was WITH NAME
instead of AS. The old syntax continues to work,
but it is considered deprecated and will eventually
be removed.

Changes:
- Deprecated 'WITH NAME' alias marker
used instead of 'AS'

Tested:
- Ran from local sandbox with the changes.

Change-Id: I2118dc04d27e37e56e1f4d49892e1f98ac629721
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Robot Framework 7.0 changes

Update robot code syntax overall in the repo

Changes:
- Update the requirement.txt package version for robot
- The '[Return]' setting is deprecated.
Use the

Robot Framework 7.0 changes

Update robot code syntax overall in the repo

Changes:
- Update the requirement.txt package version for robot
- The '[Return]' setting is deprecated.
Use the 'RETURN' statement instead.
- Singular section headers like '*** Test Case ***'
are deprecated. Use plural format like
'*** Test Cases ***' instead.
- Singular section headers like '*** Variable ***'
are deprecated

Tested:
- Ran from sandbox with the version
$ robot --version
Robot Framework 7.0 (Python 3.10.12 on linux)

and also tested on latest python version

Robot Framework 7.0 (Python 3.11.9 on linux)

Change-Id: I54e85f9d799556c63b9a39f79483f83e9b980768
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

IPMI/DCMI: Modified script based on user input

Changes:
    - Modified script based on user input
Tested:
    - Ran ipmi/ and ipmi/dcmi

Change-Id: Ic9d6e29ae199cffb6009e6718ae499293c319c96
Signed-o

IPMI/DCMI: Modified script based on user input

Changes:
    - Modified script based on user input
Tested:
    - Ran ipmi/ and ipmi/dcmi

Change-Id: Ic9d6e29ae199cffb6009e6718ae499293c319c96
Signed-off-by: Ishwarya Mathi M <ishwaryamm@ami.com>

show more ...

Robustness enhancements to test_ipmi_user

- Includes refactoring code from test_ipmi_user to ipmi_client,
which will allow greater reuse.

- Ipmi_client changes:
- Enhancements to keyword: Creat

Robustness enhancements to test_ipmi_user

- Includes refactoring code from test_ipmi_user to ipmi_client,
which will allow greater reuse.

- Ipmi_client changes:
- Enhancements to keyword: Create Random IPMI User
-- invokes Find Free User ID : to prevent clobbering pre-existing
IPMI userIDs;
-- invokes Wait And Confirm New User Entry : so that we have
confirmation before returning.
- In support of this:
- Add necessary Variables;
- Pull over keywords from test_ipmi_user :
-- Find Free User Id
-- Check Enabled User Count
-- Wait And Confirm New User Entry
-- Verify IPMI Username Visible.

- Test_ipmi_user changes:
- Remove unused variable (moved to ipmi_client);
- Verify IPMI User Summary : remove now redundant
Wait And Confirm New User Entry, since incorporated into
Create Random IPMI User;
- Test IPMI User Privilege : invoke the new and enhanced
Create Random IPMI User , to prevent clobbering pre-existing
IPMI userIDs and leverage the built-in confirmation;
- Remove the keywords that are being pulled over to ipmi_client.

Additional test_ipmi_user changes for robustness,
consistent with use already elsewhere in this suite:
- Verify Administrator And User Privilege For Different Channels :
Sleep 5s delay after Set Channel Access to allow privileges to set;
- Verify Operator And User Privilege For Different Channels :
Sleep 5s delay after Set Channel Access to allow privileges to set.

Tested: on x86 platforms.

Change-Id: I10548d5ad7f85542ab5b6b165dddb01089da0661
Signed-off-by: Ruud A. Haring <ruud@us.ibm.com>

show more ...

Added format specifier for date

Changes:
- Modified existing method so that caller can specify
a format for the date - Get Current Date from BMC

Tested:
- Dummy test

Change-Id: Iaa228e98c2015

Added format specifier for date

Changes:
- Modified existing method so that caller can specify
a format for the date - Get Current Date from BMC

Tested:
- Dummy test

Change-Id: Iaa228e98c201556359a4e442dc1038d9dced0939
Signed-off-by: Anusha Dathatri <adathatr@in.ibm.com>

show more ...

Update code documentation in test files

Changes:
- Remove or replace comments from code

Tested:
- NA

Change-Id: If4513dfe85682aa836c083cf47b0adc799c8c851
Signed-off-by: George Keishing <gk

Update code documentation in test files

Changes:
- Remove or replace comments from code

Tested:
- NA

Change-Id: If4513dfe85682aa836c083cf47b0adc799c8c851
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

IPMI: For test_ipmi_sel_time.robot added Sleep time in Create SEL keyword in ipmi_client.robot

Changes:
    - In ipmi_client.robot added Sleep 5s in Create SEL keyword. While executing sel elist com

IPMI: For test_ipmi_sel_time.robot added Sleep time in Create SEL keyword in ipmi_client.robot

Changes:
    - In ipmi_client.robot added Sleep 5s in Create SEL keyword. While executing sel elist command it takes 4 to 5 secs to display the event, hence added
sleep time in Create SEL keyword
Tested:
    - Ran ipmi/test_ipmi_sel_time.robot script Successfully

Change-Id: I1a97a2a88772e2872c1c175ac6cfe966d7a8469a
Signed-off-by: manimozhik <manimozhik@ami.com>

show more ...

Add SEL Entry: Modified add sel entry command

Changes:
- Generator ID in add sel entry command was given as 0x00 0x00.
- Introduced generator id variable in lib/resource.robot and the variab

Add SEL Entry: Modified add sel entry command

Changes:
- Generator ID in add sel entry command was given as 0x00 0x00.
- Introduced generator id variable in lib/resource.robot and the variable is called in
add sel entry command.
- Modified data/ipmi_raw_cmd_table.py file as per generator id.

Tested:
- Ran All The Scripts Successfully

Change-Id: I4503ca2667921c0681e1050c56fc32e173eacb03
Signed-off-by: ganesanb <ganesanb@ami.com>

show more ...

Modified Hardcoded channel Number as 1 to dynamic.

While Getting user info using "Get User Info" keyword by default
it will return channel numebr 1 user. we have to mention the channel
number to get

Modified Hardcoded channel Number as 1 to dynamic.

While Getting user info using "Get User Info" keyword by default
it will return channel numebr 1 user. we have to mention the channel
number to get the particular channel user info. So for Get User Info
keyword added ${CHANNEL_NUMBER} variable as argument.

And also while getting channel access we are hardcoding the channel
number as 1, there are removed 1 and added ${CHANNEL_NUMBER}.

Tested: Run robot ipmi/test_ipmi_user.robot
Run robot ipmi/test_ipmi_payload.robot
Run robot redfish/account_service/test_ipmi_redfish_user.robot

Change-Id: Id81b59e7880045b74e65195089e38d8653f66d7a
Signed-off-by: Nagarjun B <nagarjunb@ami.com>

show more ...

SEL Script Changes

ipmi/test_ipmi_sel_time.robot script changes
- In test_ipmi_sel_time.robot script created an time difference list and from time difference list
date and time will be either increm

SEL Script Changes

ipmi/test_ipmi_sel_time.robot script changes
- In test_ipmi_sel_time.robot script created an time difference list and from time difference list
date and time will be either incremented or decremented.

- Removed Identify SEL Time Future DateTime and Identify SEL Time DateTime Delay and added Identify SEL Time keyword
for incrementing or decrementing date and time.

- Modified Verify Last SEL Added keyword previously sel elist last 1 command was used to get last sel entry but sometimes
while adding sel time at the same time there may be an chance other sel also can be generated. so handled the code to get
complete sel elist via ipmi sel elist command and fetch the sel entry based on sensor name and event type. keyword also
renamed to Verify SEL Added.

ipmi/test_ipmi_sel.robot
- As Get Data And Byte From SDR sensor keyword was modified based on the modification
remodified the variable for this keyword.
- Like ipmi_sel_time.robot script verify sel entry command was modified.

lib/ipmi_client.robot
- Get Data And Byte From SDR Sensor keyword return variable ${field_data} was removed.

Tested:
- Tested ipmi/test_ipmi_sel_time.robot script.
- Tested ipmi/test_ipmi_sel.robot script.

Signed-off-by: ganesanb <ganesanb@ami.com>
Change-Id: If0342c07c16ecc83a0cc092e6f3476eea42d63f5

show more ...

Changes in ipmi_client.robot

"Fetch One Threshold Sensor From Sensor List" keyword was somehow modified to "Fetch Any Sensor From Sensor List"

All the variable names inside the keyword also changed

Changes in ipmi_client.robot

"Fetch One Threshold Sensor From Sensor List" keyword was somehow modified to "Fetch Any Sensor From Sensor List"

All the variable names inside the keyword also changed.

Modified the keyword name and variable name to its original name.

Signed-off-by: ganesanb <ganesanb@ami.com>
Change-Id: I493cb1dd6caf00ce7c738721d8b199fe99952d46

show more ...

Changes in ipmi/test_ipmi_fru_device.robot

Added Following Test Case

- Read Fru Device configuration
- Verify Get FRU Inventory Area Info
- Verify Get FRU Inventory Area Info For Invalid Device

Changes in ipmi/test_ipmi_fru_device.robot

Added Following Test Case

- Read Fru Device configuration
- Verify Get FRU Inventory Area Info
- Verify Get FRU Inventory Area Info For Invalid Device Data
- Verify Get FRU Inventory Area Info For Invalid Data Request
- Verify IPMI Write FRU Data
- Verify IPMI Write FRU Data With BMC Reboot

Functions required are defined under lib/bmc_dbus.robot, lib/ipmi_client.robot and lib/utils.py

Request data for fru data present in data/ipmi_raw_cmd_table.py.

Read Fru Device configuration - Validates each ipmi fru device data with corresponding dbus data.

Verify Get FRU Inventory Area Info - Validates fru inventory byte size with ipmi read fru count returned.

Verify Get FRU Inventory Area Info For Invalid Device Data - Validates the response of inventory fru area info command with invalid device id.

Verify Get FRU Inventory Area Info For Invalid Data Request - Validates the response of inventory fru area info command with invalid request data by giving extra bytes.

Verify IPMI Write FRU Data - Verify write fru data with the response returned with read fru data after data is written.

Verify IPMI Write FRU Data With BMC Reboot - Verify the response of read fru data after the bmc is rebooted once the data is written to the fru device.

Signed-off-by: ganesanb <ganesanb@ami.com>
Change-Id: I2ea51ad51512ecbcc4036e2d2593cafaa40a2d3c

show more ...

Remove Duplicate Keyword In ipmi_client.robot

Remove duplicate Verify Invalid IPMI Command from lines
481-492 in ipmi_client.robot

Signed-off-by: Lee Tarlton <leet@ami.com>
Change-Id: If2d65cbe95c2

Remove Duplicate Keyword In ipmi_client.robot

Remove duplicate Verify Invalid IPMI Command from lines
481-492 in ipmi_client.robot

Signed-off-by: Lee Tarlton <leet@ami.com>
Change-Id: If2d65cbe95c24d53aab495e745e17e7ef6e378ff

show more ...

Check For Existing IPMITool In Copy ipmitool Keyword

Check if BMC already has ipmitool installed in the
filesystem in Copy ipmitool keyword.

Set Suite Variable to existing and newly installed
locat

Check For Existing IPMITool In Copy ipmitool Keyword

Check if BMC already has ipmitool installed in the
filesystem in Copy ipmitool keyword.

Set Suite Variable to existing and newly installed
location in BMC for ipmitool.

Return to calling keyword if ipmitool already exists in
BMC filesystem.

Use Suite Variable for Run Dbus IPMI Standard Command
keyword.

Signed-off-by: Lee Tarlton <leet@ami.com>
Change-Id: I6a4f8d1e56e3a9d36336b9ab8bbdfac2831feeb3

show more ...

Added new cases for IPMI Set User access payload.

Testcases Added:

1) Verify Set User Access Payload For Standard Payload SOL
Disable standard payload 1(SOL) using set user access payload co

Added new cases for IPMI Set User access payload.

Testcases Added:

1) Verify Set User Access Payload For Standard Payload SOL
Disable standard payload 1(SOL) using set user access payload command
and verify it in get user access payload command and also check
sol activate is not working.

2) Verify Set User Access Payload For Operator Privileged User
Verify set user access payload command is not accessbile for Operator
privileged User.

Moved below keywords from ipmi/test_ipmi_user.robot to lib/ipmi_client.robot
for reuse purpose.
Enable IPMI User And Verify
Create Random IPMI User
Delete Created User

Added IPMI raw cmd for Set user access payload.

Tested: Run robot ipmi/test_ipmi_paylaod.robot.

Signed-off-by: Nagarjun B <nagarjunb@ami.com>
Change-Id: I8c7f3b0e46895fad0f6483043f76b714152a85be

show more ...

Added new testcases for Cipher suite IPMI cmd.

Testcases covered in this script:
1) Verify cipher suite IPMI raw cmd for all available channels
including channel 14(current channel).

2) Ver

Added new testcases for Cipher suite IPMI cmd.

Testcases covered in this script:
1) Verify cipher suite IPMI raw cmd for all available channels
including channel 14(current channel).

2) Verify cipher suite IPMI raw cmd for invalid channels and expects
response code 0xcc.

3) Verify cipher suite IPMI raw cmd with one byte more and less for
valid channel and expects response code as 0xc7.

Added keyword on lib/ipmi_client.robot to check invalid ipmi cmd.

Added keyword to get invalid channel list in lib/bmc_network_utils.robot.

Tested: Run robot ipmi/test_ipmi_cipher.robot

Signed-off-by: Nagarjun B <nagarjunb@ami.com>
Change-Id: Id510a6a7bb4c58770fdd04b32bf5ae9f276e2f39

show more ...

Changes in ipmi/test_ipmi_sel.robot

- Verify Clear SEL After Cold Reset

Removed ipmi raw cold reset command and added IPMI MC Reset Cold (RUN)

Modified Fetch Any Sensor From Sensor List keyword,

Changes in ipmi/test_ipmi_sel.robot

- Verify Clear SEL After Cold Reset

Removed ipmi raw cold reset command and added IPMI MC Reset Cold (RUN)

Modified Fetch Any Sensor From Sensor List keyword, Omitted discrete sensor and randomly selected
one threshold based sensor in lib/ipmi_client.robot.

Signed-off-by: ganesanb <ganesanb@ami.com>
Change-Id: I7fb4880bcd4681ec2bb40a27d632bdc0be98f9d3

show more ...

Add new SEL test cases

Changes:
- Added validation for Reserver ID, Most Recent Timestamps,
Clear SEL and modifications in Add SEL Entry and Reserver ID

Testcases Modified:
- Ve

Add new SEL test cases

Changes:
- Added validation for Reserver ID, Most Recent Timestamps,
Clear SEL and modifications in Add SEL Entry and Reserver ID

Testcases Modified:
- Verify Reserve SEL
New Testcases:
- Verify Add SEL Entry For Any Random Sensor
- Verify IPMI SEL Most Recent Addition Timestamp
- Verify IPMI SEL Most Recent Erase Timestamp
- Verify Clear SEL With Invalid Reservation ID
- Verify Reservation ID Erasure Status
- Verify Clear SEL After Cold Reset

Verify Add SEL Entry For Any Random Sensor
- Modified with create SEL by sensor number and type taken i
from sensor list and sdr get. Verified the result with sel elist last 1

Verify Reserve SEL
- Added condition to check if the sel entry is empty.

Verify IPMI SEL Most Recent Addition Timestamp
- Gets Most Recent Addition Timestamp from IPMI Sel Info raw command
and validate against sel entry date. If no sel entry present, newi
sel entry will be created and validates the SEL date againt IPMI
Sel Most Recent Addition Timestamp.

Verify IPMI SEL Most Recent Erase Timestamp
- Clears the SEL and validates Most Recent Erase Timestamp from SEL
Info against bmc current time. Also verifies if Most Recent Addition
Timestamp is not available.

Verify Clear SEL With Invalid Reservation ID
- Creates two reservation id, stores first reservation id created and
tries to clear sel with stored reservation id. Once a new reservationi
id is created, previous reservation id generated will no longer be valid.

Verify Reservation ID Erasure Status
- Creates a reservation id, clears the sel using the reservation id created,
generate a new reservation id, check the erasure status using new reservation id

Verify Clear SEL After Cold Reset
- Creates a new reservation id, runs cold reset from lanplus, once bmc is booted,
checks whether the generated reservation id is accessible.

Tested: Run robot ipmi/test_ipmi_sel.robot

Signed-off-by: chithrag <chithrag@ami.com>
Signed-off-by: George Keishing <gkeishin@in.ibm.com>
Change-Id: I3cd71447debaa6ddca05a9d7613e369bea6514b6
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Adding Testcases for Set In Progress, Set MAC Address, Get Cipher suite privilege, Set Authentication Type support, Set IP Address Source.

Testcases :
- Verify Set In Progress
- Verify Invaild S

Adding Testcases for Set In Progress, Set MAC Address, Get Cipher suite privilege, Set Authentication Type support, Set IP Address Source.

Testcases :
- Verify Set In Progress
- Verify Invaild Set MAC Address Via IPMI
- Verify Get and Set MAC Address Via IPMI
- Verify Cipher Suite privilege
- Verify SET On Authentication Type
- Verify IP Address Source Set To Address Loaded By BIOS
- Verify IP Address Source Set To Address Obtained By BMC
- Verify IP Address Source Set To Unspecified Address Source

Request data for chassis status present in data/ipmi_raw_cmd_table.py

Verify Set In Progress - Sets the Set In progress byte to set-inprogress and set-complete. Verifies the response byte.

Verify Invaild Set MAC Address Via IPMI - Sets the invalid MAC address given in variable section and verifies the error code.

Verify Get and Set MAC Address Via IPMI - Sets the valid MAC Address and verifies it. Restores the default MAC address once the test is complete.

Verify Cipher Suite privilege - Get the Cipher Suite privilege and verifies the response byte and cipher suite length.

Verify Set On Authentication Type - Verifies set Authentication type support and verified error response byte since it is read only byte.

Verify IP Address Source Set To Address Loaded By BIOS - verified set IP address source to address loaded by BIOS or system software and verify error response code.

Verify IP Address Source Set To Address Obtained By BMC - verified set IP address source to address obtained by BMC running other address assignment protocol and verify error response code.

Verify IP Address Source Set To Unspecified Address Source - verified set IP address source to unspecified address and verify error response code.

Tested: Run robot ipmi/test_ipmi_network_verificaton.robot

Signed-off-by: chithrag <chithrag@ami.com>
Change-Id: I6ac5eca06d1bc9b61f999a532fa5c34647d76aba

show more ...

Created New script for IPMI Set/Get SEL Time

Pre-requisite Condition : Client Machine and BMC should be in Same TimeZone (example : UST).
Mismatch of Timezones result in miscalculation of SEL Time d

Created New script for IPMI Set/Get SEL Time

Pre-requisite Condition : Client Machine and BMC should be in Same TimeZone (example : UST).
Mismatch of Timezones result in miscalculation of SEL Time due to different Timezone in Client Machine.

IPMI Raw command variables are defined under ../data/ipmi_raw_cmd_table.py
Python basic functionalities are defined under lib/ipmi_client.robot, lib/ipmi_utils.py and lib/utils.py files.

Test the Set/Get SEL Time functionality and compare the result against BMC Native command (date).

Set the Time Sync Mode from NTP to Manual to Set SEL Time.
Time Sync Mode change performed via REDFISH URI.
Performs the change in Time Sync Mode with Test Setup and Teardown Execution with default NETWORK_TIMEOUT provided under ../lib/resource.robot

NETWORK_RESTART_TIME added for Set SEL Time and Add SEL Entry as the corresponding command takes approx 5 seconds for the operation to reflect.

Current SEL time identified via BMC Native command (date) and perform SEL Time operations.

Script Verifies SEL Time for various scenarios such as,
- Get current time from BMC and add future year and compare against BMC native command (date),
- Gets BMC Current Time and Adds 15 minutes and compare against BMC native command (date),
- Gets BMC Current Time and subtracts 1 day and compare against BMC native command (date),
- Add SEL Entry for all the above scenarios and compare against BMC native command (date).

Tested: Run robot ipmi/test_ipmi_sel_time.robot

Signed-off-by: chithrag <chithrag@ami.com>
Change-Id: Ied129b96e38351d59780326c71f875dc50ce33f5

show more ...

IPMI SOL log file path default

Changes:
- Default the SOL in user execution directory logs/
- Update Power on and off to use IPMI methods

This changes is to avoid leaving files under /tmp/ wh

IPMI SOL log file path default

Changes:
- Default the SOL in user execution directory logs/
- Update Power on and off to use IPMI methods

This changes is to avoid leaving files under /tmp/ which will
eventually flush on the reboot but user using server running
the test hardly reboot the system. The existing scheme works
ok if running on local or docker instances but still not a
good idea to dump onto /tmp/.

Resolves openbmc/openbmc-test-automation#2132

Change-Id: Ia699f7faf0df1badc5fcd37b638dc0008ae2bc5f
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Resolve multiple keywords indirection

1) Multiple keywords with name 'Login' found. Give the full name of the keyword you want to use:
Redfish.Login
SSHLibrary.Login

Change-Id: I4d34d9136a5

Resolve multiple keywords indirection

1) Multiple keywords with name 'Login' found. Give the full name of the keyword you want to use:
Redfish.Login
SSHLibrary.Login

Change-Id: I4d34d9136a5108cb302769a6e6cd1c2bfce2e411
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Add IPMI timeout option "-N" to the command execution

Changes:
- By default 3 seconds timeout
- User can override the timeout by using CLI option
"-v IPMI_TIMEOUT:<value>"

Resolves o

Add IPMI timeout option "-N" to the command execution

Changes:
- By default 3 seconds timeout
- User can override the timeout by using CLI option
"-v IPMI_TIMEOUT:<value>"

Resolves openbmc/openbmc-test-automation#2111

Change-Id: I7cabd060f3652e4f9ebf98029e204c53f89ed14f
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Updated FOR loop syntax to new robot version

Signed-off-by: Marissa Garza <garzam@us.ibm.com>
Change-Id: Iad394c40eef9508db6840ed9692d102910a5c5df

Moved IPMI soft sutdown test to new ipmi bucket

Change-Id: I0cc890d8b999cb4287a1687d590433db62d9728b
Signed-off-by: Rahul Maheshwari <rahulmaheshwari@in.ibm.com>