Test documentation typo fixes using codespell tool

Changes:
- Fix typo in code documentation and test name

Tested: - Using codespell tool.

Change-Id: Ia1b65bddc01a4b1c103af9f2094d87da11c8895

Test documentation typo fixes using codespell tool

Changes:
- Fix typo in code documentation and test name

Tested: - Using codespell tool.

Change-Id: Ia1b65bddc01a4b1c103af9f2094d87da11c88953
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Signed-off-by: Patrick Will

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I944f1915ece753f72a3fa654902d445a9749d0f9

show more ...

Revert "black: re-format"

This reverts commit 5731818de0ce446ceaafc7e75ae39da1b69942ae.

Signed-off-by: George Keishing <gkeishin@in.ibm.com>
Change-Id: Ie61cdc8c7f2825b0d9d66be87a6a3a058de2b372

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: If1010ead857d413

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: If1010ead857d41364c024bf8145a979a9377d382
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Update python code for python 3.8 or higher compatibility

Changes:
- Update shebang directive to use python3 explicitly.
- remove preexec_fn feature which is deprecated in higher
py

Update python code for python 3.8 or higher compatibility

Changes:
- Update shebang directive to use python3 explicitly.
- remove preexec_fn feature which is deprecated in higher
python version 3.8 and above.
- bufsize fix, from documentation bufsize 1 means line buffered
(only usable if universal_newlines=True i.e., in a text mode)
refer: https://docs.python.org/3/library/subprocess.html
- Fix SyntaxWarning: "is" with "=="

Change-Id: Ib96c1ba8c2327d6774d0d731b48ca7e61a4a297a
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

New valid_float, valid_date_time functions

Change-Id: I844fed7bbaba4dd57a6c79d8b64ab96444ca8a36
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

Change several python and robot files to 110 chars

Taking advantage of current team limit of 110 chars.

Change-Id: If7ab51fe894889967b8c8bb2f2fa4664f01117d5
Signed-off-by: Michael Walsh <micwalsh@u

Change several python and robot files to 110 chars

Taking advantage of current team limit of 110 chars.

Change-Id: If7ab51fe894889967b8c8bb2f2fa4664f01117d5
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

gen_valid functions not failing bad args

- If a caller passed an invalid argument to a validation function,
no objection was made:

Valid Value var1 valid_value=['this']

In this example, va

gen_valid functions not failing bad args

- If a caller passed an invalid argument to a validation function,
no objection was made:

Valid Value var1 valid_value=['this']

In this example, valid_value is incorrect. It should be
valid_values.

With this fix, the program will fail with a message like this:

TypeError: valid_value() got an unexpected keyword argument
'valid_value'

Change-Id: Ie3c00ee1c23cc3e96502f12e11cae6e22471aaf1
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

New valid_length and fix valid_range

- New valid_length function
- Also fixed some errors in valid_range

Change-Id: I1a9856ee796388d189060f9b860cd88ff3e9e16c
Signed-off-by: Michael Walsh <micwalsh@

New valid_length and fix valid_range

- New valid_length function
- Also fixed some errors in valid_range

Change-Id: I1a9856ee796388d189060f9b860cd88ff3e9e16c
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

New valid_program() function

Change-Id: I0ac45502b6a4e8a38d7ec4b18bdd9df8c995ca66
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

Change Rvalid to Valid

Change all references to keywords like "Rvalid Values" to "Valid Values".
"Rvalid Values" has been deprecated.

Change-Id: I1b418fa69e5753c8bfb9e6a06a8b566359e10cae
Signed-off

Change Rvalid to Valid

Change all references to keywords like "Rvalid Values" to "Valid Values".
"Rvalid Values" has been deprecated.

Change-Id: I1b418fa69e5753c8bfb9e6a06a8b566359e10cae
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Overhaul of gen_robot_valid.py

- Change from "Rvalid" to "Valid" name prefix. Defined an rvalid_value
alias to preserve backward compatibility.

- The validation functions' approach has been stan

Overhaul of gen_robot_valid.py

- Change from "Rvalid" to "Valid" name prefix. Defined an rvalid_value
alias to preserve backward compatibility.

- The validation functions' approach has been standardized so that all
of the functions look quite similar to each other except for the
function name and the corresponding name of the gen_valid support
function being called.

- Docstrings have been standardized with several goals in mind:
- Making them easier to maintain in this program.
- Making them more palatable for use by robot's libdoc function.

- Since all of the validation functions' docstrings share a lot of
common text, the docstrings are manipulated after the function
have been defined. Namely, each one has a standard header pre-pended
to it.

- Added wrappers for gen_valid functions that were previously lacking:
valid_type()
valid_dir_path()
valid_file_path()
valid_path()
valid_list()
valid_dict()

Change-Id: I9c1b6822887d12a347a391e6b8f6086c581131af
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Remove use of deprecated rprint functions

For each of the rprint functions, there is a corresponding gen_print function
that can be used instead.

Change-Id: I89c6e0b63cac7aee92da7dc7945e41300128796

Remove use of deprecated rprint functions

For each of the rprint functions, there is a corresponding gen_print function
that can be used instead.

Change-Id: I89c6e0b63cac7aee92da7dc7945e413001287967
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Python 2.7x and 3.xx compatibility fixes

Change-Id: I84eb3bf7691fa867acadf9dae8c4f56a9781bf73
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

rvalid_value support for python-like list literals

The caller of this function may code this single line:

Rvalid Value var1 valid_values=["one", "two"]

Instead of these 2 lines:

${valid

rvalid_value support for python-like list literals

The caller of this function may code this single line:

Rvalid Value var1 valid_values=["one", "two"]

Instead of these 2 lines:

${valid_values}= Create List one two
Rvalid Value var1 valid_values=${valid_values}

Change-Id: Ic893c15661e167e2a4711cf10509548ddbc595c8
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Formatted python files to follow PEP 8 python code standards.

- Changed the python files in the openbmc-test-automation
directory to conform to python code style standards with
the excepti

Formatted python files to follow PEP 8 python code standards.

- Changed the python files in the openbmc-test-automation
directory to conform to python code style standards with
the exception of E402 and E501.
- Resolves openbmc/openbmc-test-automation#1308

Change-Id: I109995c2d248f5a6bb2c0e3c76a6144c8f3aac2e
Signed-off-by: Joy Onyerikwu <onyekachukwu.joy.onyerikwu@ibm.com>
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

New Valid Range keywords

Change-Id: If278430af8eb121ebc911940fd6a4c9a04fbb4d7
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

Fixed PEP 8 style using autopep8

Used autopep8 to correct styling.
Ran autopep8 on openbmc-test-automation, autopep8 is not
able to fix all styling issues. There is still around
1000 styling violati

Fixed PEP 8 style using autopep8

Used autopep8 to correct styling.
Ran autopep8 on openbmc-test-automation, autopep8 is not
able to fix all styling issues. There is still around
1000 styling violations in openbmc-test-automation.
More information on autopep8 can be found here,
https://pypi.python.org/pypi/autopep8

Change-Id: Iddc131da1d74d978eb3dd0fdd6ce5d0a0e49b0f8
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Remove hashtag lines from all .py files.

Change-Id: Ib2b52f6ff71c8f553e0cfb1936c8e0917e70c619
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

Fixed non-standard doc strings in gen_robot_valid.py.

Change-Id: Idc43d8538ee783d1ff5426bad0bd722cda7d5f21
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

Eliminate reference to sprint_robot_error_report.

lib/gen_robot_valid.py
- I changed 2 calls to sprint_robot_error_report to sprint_error_report since
sprint_robot_error_report is no longer de

Eliminate reference to sprint_robot_error_report.

lib/gen_robot_valid.py
- I changed 2 calls to sprint_robot_error_report to sprint_error_report since
sprint_robot_error_report is no longer defined.

Change-Id: Ieea4c11c6e5f8bf17ef2859419302a13d01c292e
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Fixes and new support functions.

lib/gen_print.py:
sprint_varx: Fixed error in handling hex parm.

lib/gen_robot_print.py
- I added support for GEN_ROBOT_PRINT_DEBUG environment variable.
- I

Fixes and new support functions.

lib/gen_print.py:
sprint_varx: Fixed error in handling hex parm.

lib/gen_robot_print.py
- I added support for GEN_ROBOT_PRINT_DEBUG environment variable.
- I added the following new functions:
- set_quiet_default
- sprvars
- sprint_robot_pgm_header
- sprint_robot_error_report
- sissuing_keyword
- sprint_auto_vars

lib/gen_robot_valid.py: New file.

Change-Id: I78fc30fe430323267bfd2ffaede102c0aa8dfc82
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...