black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Signed-off-by: Patrick Will

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I944f1915ece753f72a3fa654902d445a9749d0f9

show more ...

pycodestyle: Module level import not at top of file

Changes:
- Added NOQA on python files import to skip CI
- Fix import order reported by CI.

Tested:
- CI will catch this if there i

pycodestyle: Module level import not at top of file

Changes:
- Added NOQA on python files import to skip CI
- Fix import order reported by CI.

Tested:
- CI will catch this if there is error

Change-Id: I39a11d3e815a08488671ed948f073828e19aee37
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Revert "Fix for module level import not at top of file"

This reverts commit 47375aa789dcb11ba969895f61dfb12a773e2164.

Signed-off-by: George Keishing <gkeishin@in.ibm.com>
Change-Id: Icc40562b861262

Revert "Fix for module level import not at top of file"

This reverts commit 47375aa789dcb11ba969895f61dfb12a773e2164.

Signed-off-by: George Keishing <gkeishin@in.ibm.com>
Change-Id: Icc40562b861262d8fb72d68b43654334985eea4d

show more ...

Revert "black: re-format"

This reverts commit 5731818de0ce446ceaafc7e75ae39da1b69942ae.

Signed-off-by: George Keishing <gkeishin@in.ibm.com>
Change-Id: Ie61cdc8c7f2825b0d9d66be87a6a3a058de2b372

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: If1010ead857d413

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: If1010ead857d41364c024bf8145a979a9377d382
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Fix for module level import not at top of file

Change-Id: I1994b58a027cdac3bf4084b77db61bc646aaaba6
Signed-off-by: Sridevi Ramesh <sridevra@in.ibm.com>

E275 missing whitespace after keyword

Changes:
- CI gerrit failed due to pycodestyle strict checking

Tested:
- CI gerrit should pass

Change-Id: I3bfcae57626fd484a9222da8532a413a0da6f610
S

E275 missing whitespace after keyword

Changes:
- CI gerrit failed due to pycodestyle strict checking

Tested:
- CI gerrit should pass

Change-Id: I3bfcae57626fd484a9222da8532a413a0da6f610
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Remove read command directive for SSH start execution

This cause hang waiting on read command output from which the
output is never going to get returned.

Change-Id: If8b7af3ba57926cfab2eb565287baf

Remove read command directive for SSH start execution

This cause hang waiting on read command output from which the
output is never going to get returned.

Change-Id: If8b7af3ba57926cfab2eb565287baf6e39bd9536
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Add logging for OS login and execution

Change-Id: If82fd383137aef0f8e67f8f97da4452fde142ba5
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Update python code for python 3.8 or higher compatibility

Changes:
- Update shebang directive to use python3 explicitly.
- remove preexec_fn feature which is deprecated in higher
py

Update python code for python 3.8 or higher compatibility

Changes:
- Update shebang directive to use python3 explicitly.
- remove preexec_fn feature which is deprecated in higher
python version 3.8 and above.
- bufsize fix, from documentation bufsize 1 means line buffered
(only usable if universal_newlines=True i.e., in a text mode)
refer: https://docs.python.org/3/library/subprocess.html
- Fix SyntaxWarning: "is" with "=="

Change-Id: Ib96c1ba8c2327d6774d0d731b48ca7e61a4a297a
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Change several python and robot files to 110 chars

Taking advantage of current team limit of 110 chars.

Change-Id: If7ab51fe894889967b8c8bb2f2fa4664f01117d5
Signed-off-by: Michael Walsh <micwalsh@u

Change several python and robot files to 110 chars

Taking advantage of current team limit of 110 chars.

Change-Id: If7ab51fe894889967b8c8bb2f2fa4664f01117d5
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

execute_ssh_command to handle ConnectionResetError

Change-Id: If0ea8770e627e0c91436287fd5dc93a19c380e21
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

Modify gen_robot_ssh exception handling for py3

The symptom being addressed is the following:

UnboundLocalError: local variable 'login_exception' referenced before
assignment

For a line of code li

Modify gen_robot_ssh exception handling for py3

The symptom being addressed is the following:

UnboundLocalError: local variable 'login_exception' referenced before
assignment

For a line of code like this:

except Exception as login_exception:

In py3, the login_exception is only in scope in the exception handling
block.

Change-Id: I59e00f427f93be7234dd180dfefb05bc55ded374
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Fix print_var calls: new fmt, indent, etc.

Changed print_var calls to correctly use new arguments:
- fmt
- indent
- col1_width

Change-Id: If80088d5b69865074fd510421b918da7fd8e874e
Signed-off-by:

Fix print_var calls: new fmt, indent, etc.

Changed print_var calls to correctly use new arguments:
- fmt
- indent
- col1_width

Change-Id: If80088d5b69865074fd510421b918da7fd8e874e
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Python 2.7x and 3.xx compatibility fixes

Change-Id: I84eb3bf7691fa867acadf9dae8c4f56a9781bf73
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Revert "execute_ssh_command convert parms to int"

This reverts commit 9bc60f67d22370d0aacaebfccd7fc46f8ad5e8e1.

Change-Id: I28471f1150d66f686c7639d652535eebc7c08bad

execute_ssh_command convert parms to int

This makes the function easier to use by robot programs

Change-Id: Iffd8657bcdac214cb13ec7bba6e86b28f4e6602f
Signed-off-by: Michael Walsh <micwalsh@us.ibm.c

execute_ssh_command convert parms to int

This makes the function easier to use by robot programs

Change-Id: Iffd8657bcdac214cb13ec7bba6e86b28f4e6602f
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

execute_ssh_command: Add traceback print to log.html

- When encountering an untolerated exception, debugging is much
easier with the addition of gp.lprintn(traceback.format_exc()).
This prints

execute_ssh_command: Add traceback print to log.html

- When encountering an untolerated exception, debugging is much
easier with the addition of gp.lprintn(traceback.format_exc()).
This prints the original trace stack to the log.html file.

Change-Id: I2367a15edb3cc8321740fff4ad7f1bfc960731c5
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

execute_ssh_command: fix 'rc referenced before assignment' error

Change-Id: Ia7bd29f630fd4ccea2e414b9ce41bb811f584f88
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

execute_ssh_command: handle 'Timeout opening channel'

This resolves recent systest/htx_hardbootme_test.robot failures that
look like this:

except_type: paramiko.ssh_exception.SSHException
except_v

execute_ssh_command: handle 'Timeout opening channel'

This resolves recent systest/htx_hardbootme_test.robot failures that
look like this:

except_type: paramiko.ssh_exception.SSHException
except_value: Timeout opening channel.

Change-Id: I1d5fa8353c0e11376c37a2b65c2093ec71775014
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Fix python3.x errors

Error: ModuleNotFoundError: No module named 'exceptions'

Resolves openbmc/openbmc-test-automation#1428

Change-Id: Ie0956670e8345dcda880feb02b7d96a045695a4c
Signed-off-by: Ge

Fix python3.x errors

Error: ModuleNotFoundError: No module named 'exceptions'

Resolves openbmc/openbmc-test-automation#1428

Change-Id: Ie0956670e8345dcda880feb02b7d96a045695a4c
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Put login_ssh into try/except block

Fixing a NoValidConnectionsError failure encountered in DVT.

Change-Id: I6107dce43e44d6fbdd9c5a622b8466d1d61bc05a
Signed-off-by: Michael Walsh <micwalsh@us.ibm.c

Put login_ssh into try/except block

Fixing a NoValidConnectionsError failure encountered in DVT.

Change-Id: I6107dce43e44d6fbdd9c5a622b8466d1d61bc05a
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Added time_out parm to execute_ssh_command definition

Change-Id: I3964b70a130f66d0645280b8587b51c87e5ce2b7
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

execute_ssh_command ignore_err=1 fix on login fail

When execute_ssh_command is called with ignore_err=1 and the login
fails (e.g. 'Authentication failed for user 'root'.'), it does not
ignore the er

execute_ssh_command ignore_err=1 fix on login fail

When execute_ssh_command is called with ignore_err=1 and the login
fails (e.g. 'Authentication failed for user 'root'.'), it does not
ignore the error as it should.

Added a try/except block to handle this scenario.

Change-Id: Id65c49b43f32faaac86ee076718058e5aae6087b
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Formatted python files to follow PEP 8 python code standards.

- Changed the python files in the openbmc-test-automation
directory to conform to python code style standards with
the excepti

Formatted python files to follow PEP 8 python code standards.

- Changed the python files in the openbmc-test-automation
directory to conform to python code style standards with
the exception of E402 and E501.
- Resolves openbmc/openbmc-test-automation#1308

Change-Id: I109995c2d248f5a6bb2c0e3c76a6144c8f3aac2e
Signed-off-by: Joy Onyerikwu <onyekachukwu.joy.onyerikwu@ibm.com>
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...