black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Signed-off-by: Patrick Will

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I944f1915ece753f72a3fa654902d445a9749d0f9

show more ...

Revert "black: re-format"

This reverts commit 5731818de0ce446ceaafc7e75ae39da1b69942ae.

Signed-off-by: George Keishing <gkeishin@in.ibm.com>
Change-Id: Ie61cdc8c7f2825b0d9d66be87a6a3a058de2b372

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: If1010ead857d413

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: If1010ead857d41364c024bf8145a979a9377d382
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Update python code for python 3.8 or higher compatibility

Changes:
- Update shebang directive to use python3 explicitly.
- remove preexec_fn feature which is deprecated in higher
py

Update python code for python 3.8 or higher compatibility

Changes:
- Update shebang directive to use python3 explicitly.
- remove preexec_fn feature which is deprecated in higher
python version 3.8 and above.
- bufsize fix, from documentation bufsize 1 means line buffered
(only usable if universal_newlines=True i.e., in a text mode)
refer: https://docs.python.org/3/library/subprocess.html
- Fix SyntaxWarning: "is" with "=="

Change-Id: Ib96c1ba8c2327d6774d0d731b48ca7e61a4a297a
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

ArgumentDefaultsHelpMultilineFormatter class

This allows the argparse user to split lines in the help text prolog
by including a "%%n" sequence.

Change-Id: If76b6217b71405c098619e76b97610de043d2a32

ArgumentDefaultsHelpMultilineFormatter class

This allows the argparse user to split lines in the help text prolog
by including a "%%n" sequence.

Change-Id: If76b6217b71405c098619e76b97610de043d2a32
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

New sync_args function

Change-Id: Ie1ed4cb5d13112957b156e6a9db7662ebc90f9a3
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

New terminate_descendants suite

New scheme to facilitate the termination of child processes.

A caller may set termination preferences via a call to
set_term_options(). If term_options are set, gen

New terminate_descendants suite

New scheme to facilitate the termination of child processes.

A caller may set termination preferences via a call to
set_term_options(). If term_options are set, gen_exit_function()
will call terminate_descendants() to process the term_options.

The new supporting functions are as follows:

- set_term_options()
- match_process_by_pgm_name()
- select_processes_by_pgm_name()
- sprint_process_report()
- get_descendant_info()
- terminate_descendants()

Change-Id: Icf5ef18954a48184139825fe98a248b4a1ca8889
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

gen_exit_function: set ignore_err to 1

ignore_err influences the way shell_cmd processes errors. Since we're
doing exit processing, we don't want to stop the program due to a
shell_cmd failure.

Ch

gen_exit_function: set ignore_err to 1

ignore_err influences the way shell_cmd processes errors. Since we're
doing exit processing, we don't want to stop the program due to a
shell_cmd failure.

Change-Id: Ib4833707461b77bb3fe0ee4d907fb36f431770b7
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Change several python and robot files to 110 chars

Taking advantage of current team limit of 110 chars.

Change-Id: If7ab51fe894889967b8c8bb2f2fa4664f01117d5
Signed-off-by: Michael Walsh <micwalsh@u

Change several python and robot files to 110 chars

Taking advantage of current team limit of 110 chars.

Change-Id: If7ab51fe894889967b8c8bb2f2fa4664f01117d5
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

gen_arg changes to support improved py template

- gen_exit_function: New function which can replace or supplement
caller's exit_function.
- gen_signal_handler: New function to replace caller's sig

gen_arg changes to support improved py template

- gen_exit_function: New function which can replace or supplement
caller's exit_function.
- gen_signal_handler: New function to replace caller's signal_handler
function.
- gen_post_validation: Changes to use gen_exit_function and
gen_signal_handler.
- gen_setup(): New function to replace these lines in original
python_pgm_template:

gen_get_options(parser, stock_list)

validate_parms()

qprint_pgm_header()

Change-Id: Ib08e3f073557116cedea617c3f68df99ed4ab767
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Fix print_var calls: new fmt, indent, etc.

Changed print_var calls to correctly use new arguments:
- fmt
- indent
- col1_width

Change-Id: If80088d5b69865074fd510421b918da7fd8e874e
Signed-off-by:

Fix print_var calls: new fmt, indent, etc.

Changed print_var calls to correctly use new arguments:
- fmt
- indent
- col1_width

Change-Id: If80088d5b69865074fd510421b918da7fd8e874e
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Python 2.x and 3.x compatible changes

Changes:
- Update imports and syntax.

Resolves openbmc/openbmc-test-automation#1426

Change-Id: I4cf400429c5f863ed8f30d24fa871b1c564d9f2a
Signed-off-by: G

Python 2.x and 3.x compatible changes

Changes:
- Update imports and syntax.

Resolves openbmc/openbmc-test-automation#1426

Change-Id: I4cf400429c5f863ed8f30d24fa871b1c564d9f2a
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Formatted python files to follow PEP 8 python code standards.

- Changed the python files in the openbmc-test-automation
directory to conform to python code style standards with
the excepti

Formatted python files to follow PEP 8 python code standards.

- Changed the python files in the openbmc-test-automation
directory to conform to python code style standards with
the exception of E402 and E501.
- Resolves openbmc/openbmc-test-automation#1308

Change-Id: I109995c2d248f5a6bb2c0e3c76a6144c8f3aac2e
Signed-off-by: Joy Onyerikwu <onyekachukwu.joy.onyerikwu@ibm.com>
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

New exit_on_error mode for gen_arg.py

Change-Id: I271dd889ceeff2975acb33e65cbfe3179b653d47
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

Fixed PEP 8 style using autopep8

Used autopep8 to correct styling.
Ran autopep8 on openbmc-test-automation, autopep8 is not
able to fix all styling issues. There is still around
1000 styling violati

Fixed PEP 8 style using autopep8

Used autopep8 to correct styling.
Ran autopep8 on openbmc-test-automation, autopep8 is not
able to fix all styling issues. There is still around
1000 styling violations in openbmc-test-automation.
More information on autopep8 can be found here,
https://pypi.python.org/pypi/autopep8

Change-Id: Iddc131da1d74d978eb3dd0fdd6ce5d0a0e49b0f8
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Remove hashtag lines from all .py files.

Change-Id: Ib2b52f6ff71c8f553e0cfb1936c8e0917e70c619
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

Changes to process_plug_in_packages.py.

- Made some pep8 corrections to parser.add_arguement().
- Added valid_integer(shell_rc) check.
- Added shell_rc shift left (which was specified in help

Changes to process_plug_in_packages.py.

- Made some pep8 corrections to parser.add_arguement().
- Added valid_integer(shell_rc) check.
- Added shell_rc shift left (which was specified in help text but not
implemented).
- Change to convert shell_rc to int for consistent processing.

lib/gen_arg.py
- Made some pep8 corrections to parser.add_arguement().
- set_pgm_arg: New function.

Change-Id: I7726c80bb3312a96ee5dc670b50e47e4d3c7aaa3
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Adding new function and fixing some bugs in general purpose py files.

gen_args.py:
sprint_args()
I made corrections to col1_width processing when indent is not zero.

gen_print.py:
get_arg_n

Adding new function and fixing some bugs in general purpose py files.

gen_args.py:
sprint_args()
I made corrections to col1_width processing when indent is not zero.

gen_print.py:
get_arg_name:
I fixed a bug.
sprint_varx:
I added support for printing OrderedDict objects and robot DotDict objects.
I added support for having the hex arg double as a "print None" for string objects.
sprint_pgm_header:
I added support for linefeed arg.
sissuing:
I added support for test_mode parm.
sprintn:
New function.

gen_valid.py:
svalid_value:
New function:
valid_value:
Now calls svalid_value.

svalid_integer:
New function:
valid_integer:
Now calls svalid_integer.

Change-Id: I161086d1148e4559fcc57b7d749cc3fb810dc19f
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Providing plug-in support:

Typically, a test program is written to perform certain basic tests on a test
machine. For example, one might write an "obmc_boot" program that performs
various boot test

Providing plug-in support:

Typically, a test program is written to perform certain basic tests on a test
machine. For example, one might write an "obmc_boot" program that performs
various boot tests on the Open BMC machine.

Experience has shown that over time, additional testing needs often arise.
Examples of such additional testing needs might include:

- Data base logging of results
- Performance measurements
- Memory leak analysis
- Hardware verification
- Error log (sels) analysis
- SOL_console

The developer could add additional parms to obmc_boot and likewise add
supporting code in obmc_boot each time a need arises. Users would employ
these new functions as follows:

obmc_boot --perf=1 --mem_leak=1 --db_logging=1 --db_userid=xxxx

However, another option would be to add general-purpose plug-in support to
obmc_boot. This would allow the user to indicate to obmc_boot which plug-in
packages it ought to run. Such plug-in packages could be written in any
langauge whatsoever: Robot, python, bash, perl, C++.

An example call to obmc_boot would then look something like this:

obmc_boot --plug_in_dir_paths="Perf:Mem_leak:DB_logging"

Now all the obmc_boot developer needs to do is call the plug-in processing
module (process_plug_in_packages.py) at various call points which are agreed
upon by the obmc_boot developer and the plug-in developers. Example call
points which can be implemented are:

setup - Called at the start of obmc_boot
pre_boot - Called before each boot test initiated by obmc_boot
post_boot - Called after each boot test initiated by obmc_boot
cleanup - Called at the end of obmc_boot

This allows the choice of options to be passed as data to obmc_boot. The
advantages of this approach are:
- Much less maintenance of the original test program (obmc_boot).
- Since plug-ins are separate from the main test program, users are free to
have plug-ins that suit their environments. One user may wish to log results
to a database that is of no interest to the rest of the world. Such a plug-in
can be written and need never be pushed to gerrit/github.
- One can even write temporary plug-ins designed just to collect data or stop
when a particular defect occurs.

In our current environment, the concept has proven exceedingly useful. We
have over 40 permanent plug-ins and in our temp plug-in directory, we still
have over 80 plug-ins.

Change-Id: Iee0ea950cffaef202d56da4dae7c044b6366a59c
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...