Use importlib.util to replace imp

Since the imp module is deprecated and scheduled for removal in
Python 3.12 in favor of importlib, update the relevant libraries to
resolve any ModuleNotFoundError

Use importlib.util to replace imp

Since the imp module is deprecated and scheduled for removal in
Python 3.12 in favor of importlib, update the relevant libraries to
resolve any ModuleNotFoundError issues with Python 3.12.

Changes:
- use import importlib.util instead of import imp

Tested:
- Ran basic test pass with Python 3.10 and 3.12.

Change-Id: I25dde939dd25268b2ae329b0121858bec20ed03c
Signed-off-by: Brian Ma <chma0@nuvoton.com>

show more ...

Test documentation typo fixes using codespell tool

Changes:
- Fix typo in code documentation and test name

Tested: - Using codespell tool.

Change-Id: Ia1b65bddc01a4b1c103af9f2094d87da11c8895

Test documentation typo fixes using codespell tool

Changes:
- Fix typo in code documentation and test name

Tested: - Using codespell tool.

Change-Id: Ia1b65bddc01a4b1c103af9f2094d87da11c88953
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Signed-off-by: Patrick Will

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I944f1915ece753f72a3fa654902d445a9749d0f9

show more ...

pycodestyle: Module level import not at top of file

Changes:
- Added NOQA on python files import to skip CI
- Fix import order reported by CI.

Tested:
- CI will catch this if there i

pycodestyle: Module level import not at top of file

Changes:
- Added NOQA on python files import to skip CI
- Fix import order reported by CI.

Tested:
- CI will catch this if there is error

Change-Id: I39a11d3e815a08488671ed948f073828e19aee37
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Revert "Fix for module level import not at top of file"

This reverts commit 47375aa789dcb11ba969895f61dfb12a773e2164.

Signed-off-by: George Keishing <gkeishin@in.ibm.com>
Change-Id: Icc40562b861262

Revert "Fix for module level import not at top of file"

This reverts commit 47375aa789dcb11ba969895f61dfb12a773e2164.

Signed-off-by: George Keishing <gkeishin@in.ibm.com>
Change-Id: Icc40562b861262d8fb72d68b43654334985eea4d

show more ...

Revert "black: re-format"

This reverts commit 5731818de0ce446ceaafc7e75ae39da1b69942ae.

Signed-off-by: George Keishing <gkeishin@in.ibm.com>
Change-Id: Ie61cdc8c7f2825b0d9d66be87a6a3a058de2b372

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: If1010ead857d413

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: If1010ead857d41364c024bf8145a979a9377d382
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Fix for module level import not at top of file

Change-Id: I1994b58a027cdac3bf4084b77db61bc646aaaba6
Signed-off-by: Sridevi Ramesh <sridevra@in.ibm.com>

Collect all dumps available on BMC

Change-Id: I370959d86397f5e1cb50db56d5d99c88eadd76fb
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

FFDC to handle root and sudo user

Added bash -c; just to fake load the command bash so that
it doesnt hang in bash and continue execution shell command

Change-Id: I5254a2ed83e4ca8b4fef0edf305564150

FFDC to handle root and sudo user

Added bash -c; just to fake load the command bash so that
it doesnt hang in bash and continue execution shell command

Change-Id: I5254a2ed83e4ca8b4fef0edf3055641504414205
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Update python code for python 3.8 or higher compatibility

Changes:
- Update shebang directive to use python3 explicitly.
- remove preexec_fn feature which is deprecated in higher
py

Update python code for python 3.8 or higher compatibility

Changes:
- Update shebang directive to use python3 explicitly.
- remove preexec_fn feature which is deprecated in higher
python version 3.8 and above.
- bufsize fix, from documentation bufsize 1 means line buffered
(only usable if universal_newlines=True i.e., in a text mode)
refer: https://docs.python.org/3/library/subprocess.html
- Fix SyntaxWarning: "is" with "=="

Change-Id: Ib96c1ba8c2327d6774d0d731b48ca7e61a4a297a
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Add HB dumps collection in FFDC

Change-Id: I08d2113cd633154e267ec18fe8d373c657b10a45
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Remove use of deprecated terse() on print_var

terse is now the default.

Change-Id: If25901eea7fdfa502b012cb995242790e7f6176d
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

Fixed Rprint Vars fmt arg in doc

Fixed Rprint Vars in doc string to show proper use of fmt argument.

Change-Id: Ib02d34bcfe7ecf4cb7743c5ea53361192867cdff
Signed-off-by: Michael Walsh <micwalsh@us.i

Fixed Rprint Vars fmt arg in doc

Fixed Rprint Vars in doc string to show proper use of fmt argument.

Change-Id: Ib02d34bcfe7ecf4cb7743c5ea53361192867cdff
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

dump_to_dict not working for empty dump subdirs

Example:

In /var/lib/phosphor-debug-collector/dumps, there are the following
subdirectories. However, 11 is empty.

11 12 13 14 15 16

Change-I

dump_to_dict not working for empty dump subdirs

Example:

In /var/lib/phosphor-debug-collector/dumps, there are the following
subdirectories. However, 11 is empty.

11 12 13 14 15 16

Change-Id: Ifca568de68ad62e5492b79aae2f01edd7ee431da
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Python 2.7x and 3.xx compatibility fixes

Change-Id: I84eb3bf7691fa867acadf9dae8c4f56a9781bf73
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Formatted python files to follow PEP 8 python code standards.

- Changed the python files in the openbmc-test-automation
directory to conform to python code style standards with
the excepti

Formatted python files to follow PEP 8 python code standards.

- Changed the python files in the openbmc-test-automation
directory to conform to python code style standards with
the exception of E402 and E501.
- Resolves openbmc/openbmc-test-automation#1308

Change-Id: I109995c2d248f5a6bb2c0e3c76a6144c8f3aac2e
Signed-off-by: Joy Onyerikwu <onyekachukwu.joy.onyerikwu@ibm.com>
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Fixed PEP 8 style using autopep8

Used autopep8 to correct styling.
Ran autopep8 on openbmc-test-automation, autopep8 is not
able to fix all styling issues. There is still around
1000 styling violati

Fixed PEP 8 style using autopep8

Used autopep8 to correct styling.
Ran autopep8 on openbmc-test-automation, autopep8 is not
able to fix all styling issues. There is still around
1000 styling violations in openbmc-test-automation.
More information on autopep8 can be found here,
https://pypi.python.org/pypi/autopep8

Change-Id: Iddc131da1d74d978eb3dd0fdd6ce5d0a0e49b0f8
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Added new scp_dumps function to retrieve all dumps from bmc.

Change-Id: I1ac532566e111fc122f12b50dcba8ce06b0bb1c3
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

Created dump_utils.py with get_dump_dict and valid_dump.

Change-Id: Ia59e126213eb7d32ce25b13ee118a2379200dbe7
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>