Fix time difference failure for IPMI SEL

Changes:

Fix time difference failure for IPMI SEL
Remove redundant FFDC method call in test teardown
Move printn from setup to test setup

Tested:
Tested ch

Fix time difference failure for IPMI SEL

Changes:

Fix time difference failure for IPMI SEL
Remove redundant FFDC method call in test teardown
Move printn from setup to test setup

Tested:
Tested changes on BMC environment

Resolves openbmc-test-automation#2246

Change-Id: I4e37e7c48c76e779df752670094844e5b40122b9
Signed-off-by: Sridevi Ramesh <sridevra@in.ibm.com>

show more ...

Switch from Force Tags to Test Tags

Force Tags is deprecated in Robot 7.0 and will eventually
warn and then after that stop working. Test Tags performs
the same function per docs.

Change-Id: I7cf30

Switch from Force Tags to Test Tags

Force Tags is deprecated in Robot 7.0 and will eventually
warn and then after that stop working. Test Tags performs
the same function per docs.

Change-Id: I7cf305754b247b995a05d8da3b9de9ed613ecae2
Signed-off-by: Matt Fischer <matthew.fischer@hpe.com>

show more ...

Robot Framework 7.0 changes

Update robot code syntax overall in the repo

Changes:
- Update the requirement.txt package version for robot
- The '[Return]' setting is deprecated.
Use the

Robot Framework 7.0 changes

Update robot code syntax overall in the repo

Changes:
- Update the requirement.txt package version for robot
- The '[Return]' setting is deprecated.
Use the 'RETURN' statement instead.
- Singular section headers like '*** Test Case ***'
are deprecated. Use plural format like
'*** Test Cases ***' instead.
- Singular section headers like '*** Variable ***'
are deprecated

Tested:
- Ran from sandbox with the version
$ robot --version
Robot Framework 7.0 (Python 3.10.12 on linux)

and also tested on latest python version

Robot Framework 7.0 (Python 3.11.9 on linux)

Change-Id: I54e85f9d799556c63b9a39f79483f83e9b980768
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Add new force tags for the IPMI suites

Changes:
- Add tag name for the suite

Tested:
- NA

Change-Id: I1f87ede8c5241d34a3cf7ae988b5ffc43e84408b
Signed-off-by: George Keishing <gkeishin@in.

Add new force tags for the IPMI suites

Changes:
- Add tag name for the suite

Tested:
- NA

Change-Id: I1f87ede8c5241d34a3cf7ae988b5ffc43e84408b
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

IPMI: Moved resource ../lib/ipmi_client.robot line to the first line on settings section.

Issue Faced:
- While running script individually if ipmi_client robot resource was not on first line

IPMI: Moved resource ../lib/ipmi_client.robot line to the first line on settings section.

Issue Faced:
- While running script individually if ipmi_client robot resource was not on first line
in the settings section on the script then arguments from resource.robot are not passing
to the keywords while framing the ipmi commands.

Changes:
- Moved resource ../lib/ipmi_client.robot to the first line on settings section in few scripts.

Tested:
- Ran All The Scripts Successfully

Change-Id: I879366bf034f9cd4db7ae05b337f64b2b44362eb
Signed-off-by: ganesanb <ganesanb@ami.com>

show more ...

Update test documentation and spacing

Changes:
- No testcase documentation (RequireTestDocumentation)
- Line has trailing whitespace (TrailingWhitespace)
- Line is too long (exceeds 1

Update test documentation and spacing

Changes:
- No testcase documentation (RequireTestDocumentation)
- Line has trailing whitespace (TrailingWhitespace)
- Line is too long (exceeds 110 characters) (LineTooLong)

Tested:
- python3 -m rflint -rA robot_standards -R robot_custom_rules.py <suites>
o

Change-Id: I65428f73132c9d539b98a030458c455d1db1f116
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

SEL Script Changes

ipmi/test_ipmi_sel_time.robot script changes
- In test_ipmi_sel_time.robot script created an time difference list and from time difference list
date and time will be either increm

SEL Script Changes

ipmi/test_ipmi_sel_time.robot script changes
- In test_ipmi_sel_time.robot script created an time difference list and from time difference list
date and time will be either incremented or decremented.

- Removed Identify SEL Time Future DateTime and Identify SEL Time DateTime Delay and added Identify SEL Time keyword
for incrementing or decrementing date and time.

- Modified Verify Last SEL Added keyword previously sel elist last 1 command was used to get last sel entry but sometimes
while adding sel time at the same time there may be an chance other sel also can be generated. so handled the code to get
complete sel elist via ipmi sel elist command and fetch the sel entry based on sensor name and event type. keyword also
renamed to Verify SEL Added.

ipmi/test_ipmi_sel.robot
- As Get Data And Byte From SDR sensor keyword was modified based on the modification
remodified the variable for this keyword.
- Like ipmi_sel_time.robot script verify sel entry command was modified.

lib/ipmi_client.robot
- Get Data And Byte From SDR Sensor keyword return variable ${field_data} was removed.

Tested:
- Tested ipmi/test_ipmi_sel_time.robot script.
- Tested ipmi/test_ipmi_sel.robot script.

Signed-off-by: ganesanb <ganesanb@ami.com>
Change-Id: If0342c07c16ecc83a0cc092e6f3476eea42d63f5

show more ...

Changes in ipmi/test_ipmi_sel_time.robot

Keyword renamed
- "Fetch Any Sensor From Sensor List" keyword was renamed to "Fetch One Threshold Sensor From Sensor List"

Signed-off-by: ganesanb <ganesan

Changes in ipmi/test_ipmi_sel_time.robot

Keyword renamed
- "Fetch Any Sensor From Sensor List" keyword was renamed to "Fetch One Threshold Sensor From Sensor List"

Signed-off-by: ganesanb <ganesanb@ami.com>
Change-Id: I269c919873bef86214b52b2bce27499cd6b0895b

show more ...

Fix documentation and LineTooLong in the test suite

Fixes:
- Documetnation spacing for arguments
- Bellow LineTooLong changes

+ ipmi/test_ipmi_sel_time.robot
W: 508, 110: Line is too long (

Fix documentation and LineTooLong in the test suite

Fixes:
- Documetnation spacing for arguments
- Bellow LineTooLong changes

+ ipmi/test_ipmi_sel_time.robot
W: 508, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 564, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 582, 110: Line is too long (exceeds 110 characters) (LineTooLong)

Change-Id: I2fafac9f7cb4f1f969d9aa4921336ecfeb73eb7d
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Fix Line is too long in test suite

+ ipmi/test_ipmi_network_verificaton.robot
W: 208, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 224, 110: Line is too long (exceeds 110 characte

Fix Line is too long in test suite

+ ipmi/test_ipmi_network_verificaton.robot
W: 208, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 224, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 276, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 286, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 295, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 368, 110: Line is too long (exceeds 110 characters) (LineTooLong)
+ ipmi/test_ipmi_poh_counter.robot
W: 22, 110: Line is too long (exceeds 110 characters) (LineTooLong)
+ ipmi/test_ipmi_user.robot
W: 386, 110: Line is too long (exceeds 110 characters) (LineTooLong)
+ ipmi/test_ipmi_cold_reset.robot
W: 95, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 176, 110: Line is too long (exceeds 110 characters) (LineTooLong
+ ipmi/test_ipmi_inband_sdr.robot
W: 204, 110: Line is too long (exceeds 110 characters) (LineTooLong)
+ ipmi/test_ipmi_chassis.robot
W: 64, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 74, 110: Line is too long (exceeds 110 characters) (LineTooLong)
+ ipmi/test_ipmi_sel_time.robot
W: 7, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 9, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 13, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 15, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 186, 110: Line is too long (exceeds 110 characters) (LineTooLong)
+ ipmi/test_ipmi_systeminfo_parameters.robot
W: 98, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 109, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 154, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 175, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 211, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 293, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 313, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 421, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 422, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 441, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 442, 110: Line is too long (exceeds 110 characters) (LineTooLong)
W: 498, 110: Line is too long (exceeds 110 characters) (LineTooLong)

Change-Id: I193c22c648e9fe77f017896a4ca19e35cd7adfc2
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Fix tagging mismatch in test suite

Fix typo and test vs tag mismatch as shown bellow:

$ awk -f check_robot_tags.awk ipmi/test_ipmi_sel_time.robot
--- ipmi/test_ipmi_sel_time.robot:
Set SEL Time On

Fix tagging mismatch in test suite

Fix typo and test vs tag mismatch as shown bellow:

$ awk -f check_robot_tags.awk ipmi/test_ipmi_sel_time.robot
--- ipmi/test_ipmi_sel_time.robot:
Set SEL Time On NTP Mode
Verify_SEL_Set_Time_On_NTP_Mode

--- ipmi/test_ipmi_sel_time.robot:
Verify SEL Time In SEL Entry For Past Date And Time
Verify_SEL_Time_In_SEL_Entry_For_Past_Date_And_Tine

Change-Id: Ic0f5d80dc5248b2b16eaa5946dc568fff1fdc2d0
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Created New script for IPMI Set/Get SEL Time

Pre-requisite Condition : Client Machine and BMC should be in Same TimeZone (example : UST).
Mismatch of Timezones result in miscalculation of SEL Time d

Created New script for IPMI Set/Get SEL Time

Pre-requisite Condition : Client Machine and BMC should be in Same TimeZone (example : UST).
Mismatch of Timezones result in miscalculation of SEL Time due to different Timezone in Client Machine.

IPMI Raw command variables are defined under ../data/ipmi_raw_cmd_table.py
Python basic functionalities are defined under lib/ipmi_client.robot, lib/ipmi_utils.py and lib/utils.py files.

Test the Set/Get SEL Time functionality and compare the result against BMC Native command (date).

Set the Time Sync Mode from NTP to Manual to Set SEL Time.
Time Sync Mode change performed via REDFISH URI.
Performs the change in Time Sync Mode with Test Setup and Teardown Execution with default NETWORK_TIMEOUT provided under ../lib/resource.robot

NETWORK_RESTART_TIME added for Set SEL Time and Add SEL Entry as the corresponding command takes approx 5 seconds for the operation to reflect.

Current SEL time identified via BMC Native command (date) and perform SEL Time operations.

Script Verifies SEL Time for various scenarios such as,
- Get current time from BMC and add future year and compare against BMC native command (date),
- Gets BMC Current Time and Adds 15 minutes and compare against BMC native command (date),
- Gets BMC Current Time and subtracts 1 day and compare against BMC native command (date),
- Add SEL Entry for all the above scenarios and compare against BMC native command (date).

Tested: Run robot ipmi/test_ipmi_sel_time.robot

Signed-off-by: chithrag <chithrag@ami.com>
Change-Id: Ied129b96e38351d59780326c71f875dc50ce33f5

show more ...