5b916aa7 | 30-Apr-2023 |
Hans de Goede <hdegoede@redhat.com> |
leds: cht-wcove: Add support for breathing mode use hw_pattern sysfs API
The hw-blinking of the LED controller in the Whiskey Cove PMIC can also be used for a hw-breathing effect.
As discussed duri
leds: cht-wcove: Add support for breathing mode use hw_pattern sysfs API
The hw-blinking of the LED controller in the Whiskey Cove PMIC can also be used for a hw-breathing effect.
As discussed during review of v2 of the submission of the new leds-cht-wcove driver, the LED subsystem already supports breathing mode on several other LED controllers using the hw_pattern interface.
Implement a pattern_set callback to implement breathing mode modelled after the breathing mode supported by the SC27xx breathing light and Crane EL15203000 LED drivers. The Whiskey Cove PMIC's breathing mode is closer to the EL15203000 one then to the SC27xx one since it does not support staying high / low for a specific time, it only supports rise and fall times.
As such the supported hw_pattern and the documentation for this is almost a 1:1 copy of the pattern/docs for the EL15203000 breathing mode.
Suggested-by: Jacek Anaszewski <jacek.anaszewski@gmail.com> Link: https://lore.kernel.org/all/6beed61c-1fc6-6525-e873-a8978f5fbffb@gmail.com/ Signed-off-by: Hans de Goede <hdegoede@redhat.com> Link: https://lore.kernel.org/r/20230430195952.862527-4-hdegoede@redhat.com Signed-off-by: Lee Jones <lee@kernel.org>
show more ...
|
57fbfb3b | 18-Apr-2023 |
Alexander Dahl <ada@thorsis.com> |
docs: leds: ledtrig-oneshot: Fix spelling mistake
It's no comparison, but a "first this, then that" situation.
Signed-off-by: Alexander Dahl <ada@thorsis.com> Acked-by: Pavel Machek <pavel@ucw.cz>
docs: leds: ledtrig-oneshot: Fix spelling mistake
It's no comparison, but a "first this, then that" situation.
Signed-off-by: Alexander Dahl <ada@thorsis.com> Acked-by: Pavel Machek <pavel@ucw.cz> Signed-off-by: Lee Jones <lee@kernel.org> Link: https://lore.kernel.org/r/20230418113402.188391-1-ada@thorsis.com
show more ...
|
a8fd44cb | 19-Mar-2023 |
Bagas Sanjaya <bagasdotme@gmail.com> |
Documentation: leds: MT6370: Use bullet lists for timing variables
The timing description contains list of timing pattern variables, but it uses code block without indentation instead. Switch to bul
Documentation: leds: MT6370: Use bullet lists for timing variables
The timing description contains list of timing pattern variables, but it uses code block without indentation instead. Switch to bullet list as it is better fit for this purpose.
While at it, substitute "load" for "duty" because the variables control timing for current load into the device.
Link: https://lore.kernel.org/oe-kbuild-all/202303182310.tB1mUzU7-lkp@intel.com/ Fixes: 4ba9df04b7ac66 ("docs: leds: Add MT6370 RGB LED pattern document") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com> Signed-off-by: Lee Jones <lee@kernel.org> Link: https://lore.kernel.org/r/20230319074903.13075-4-bagasdotme@gmail.com
show more ...
|
cc087c0b | 19-Mar-2023 |
Bagas Sanjaya <bagasdotme@gmail.com> |
Documentation: leds: mt6370: Properly wrap hw_pattern chart
The pattern diagram (chart) of /sys/class/leds/<led>/hw_pattern is wrapped in literal code block. However, the block indentation is interr
Documentation: leds: mt6370: Properly wrap hw_pattern chart
The pattern diagram (chart) of /sys/class/leds/<led>/hw_pattern is wrapped in literal code block. However, the block indentation is interrupted by Icurr axis label, hence below warnings:
Documentation/leds/leds-mt6370-rgb.rst:39: WARNING: Literal block ends without a blank line; unexpected unindent. Documentation/leds/leds-mt6370-rgb.rst:41: WARNING: Line block ends without a blank line. Documentation/leds/leds-mt6370-rgb.rst:46: WARNING: Unexpected indentation. Documentation/leds/leds-mt6370-rgb.rst:44: WARNING: Inline substitution_reference start-string without end-string.
Fix the chart indentation by adding 4 more spaces so that the axis label is in the code block.
Link: https://lore.kernel.org/oe-kbuild-all/202303182310.tB1mUzU7-lkp@intel.com/ Fixes: 4ba9df04b7ac66 ("docs: leds: Add MT6370 RGB LED pattern document") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com> Acked-by: Pavel Machek <pavel@ucw.cz> Signed-off-by: Lee Jones <lee@kernel.org> Link: https://lore.kernel.org/r/20230319074903.13075-3-bagasdotme@gmail.com
show more ...
|
1d105d6c | 19-Mar-2023 |
Bagas Sanjaya <bagasdotme@gmail.com> |
Documentation: leds: Add MT6370 doc to the toctree
Commit 4ba9df04b7ac66 ("docs: leds: Add MT6370 RGB LED pattern document") adds documentation for Mediatek MT6370 RGB LED device, but forgets to inc
Documentation: leds: Add MT6370 doc to the toctree
Commit 4ba9df04b7ac66 ("docs: leds: Add MT6370 RGB LED pattern document") adds documentation for Mediatek MT6370 RGB LED device, but forgets to include it to leds toctree index.
Add the missing entry.
Link: https://lore.kernel.org/oe-kbuild-all/202303182310.tB1mUzU7-lkp@intel.com/ Fixes: 4ba9df04b7ac66 ("docs: leds: Add MT6370 RGB LED pattern document") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com> Acked-by: Pavel Machek <pavel@ucw.cz> Signed-off-by: Lee Jones <lee@kernel.org> Link: https://lore.kernel.org/r/20230319074903.13075-2-bagasdotme@gmail.com
show more ...
|
e98a860f | 23-May-2022 |
Bjorn Andersson <bjorn.andersson@linaro.org> |
leds: qcom-lpg: Require pattern to follow documentation
The leds-trigger-pattern documentation describes how the brightness of the LED should transition linearly from one brightness value to the nex
leds: qcom-lpg: Require pattern to follow documentation
The leds-trigger-pattern documentation describes how the brightness of the LED should transition linearly from one brightness value to the next, over the given delta_t.
But the pattern engine in the Qualcomm LPG hardware only supports holding the brightness for each entry for the period. This subset of patterns can be represented in the leds-trigger-pattern by injecting zero-time transitions after each entry in the pattern, resulting in a pattern that pattern that can be rendered by the LPG.
Rework LPG pattern interface to require these zero-time transitions, to make it comply with this subset of patterns and reject the patterns it can't render.
Fixes: 24e2d05d1b68 ("leds: Add driver for Qualcomm LPG") Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> Signed-off-by: Pavel Machek <pavel@ucw.cz>
show more ...
|