serial: Fix attribute for mctp_serial_tx_fn

cppcheck complains about the function attribute previously at the end.

Change-Id: I781af654e56b062040ae6f553d9ba3a5148ce1b9
Signed-off-by: Matt Johnston

serial: Fix attribute for mctp_serial_tx_fn

cppcheck complains about the function attribute previously at the end.

Change-Id: I781af654e56b062040ae6f553d9ba3a5148ce1b9
Signed-off-by: Matt Johnston <matt@codeconstruct.com.au>

show more ...

libmctp-serial: Format with clang-format

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I5707481b48a916a15d860aea7a2aa7ccbf2faa67

mctp-demux-daemon: Exploit binding mctp_*_init_pollfd() APIs

Once bindings are correctly implemented as async the daemon itself will
follow.

Finally, now they're unused, drop the mctp_*_get_fd() AP

mctp-demux-daemon: Exploit binding mctp_*_init_pollfd() APIs

Once bindings are correctly implemented as async the daemon itself will
follow.

Finally, now they're unused, drop the mctp_*_get_fd() APIs as they're
strictly less powerful.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ibc2bbc1d75b031e4422429d606e6345d794cb44d

show more ...

bindings: Add mctp_*_init_pollfd() API

The new API allows the binding to own the poll(2) parameters, providing
the opportunity for it to properly idle when it's unable to send control
messages. Desp

bindings: Add mctp_*_init_pollfd() API

The new API allows the binding to own the poll(2) parameters, providing
the opportunity for it to properly idle when it's unable to send control
messages. Despite this, we hold off on adjusting the behaviour directly
in this commit, as it would constitute a regression until
mctp-demux-daemon has also been converted to exploit the new API.

Change-Id: Ic5a7c5a943566a0f36695daa64457440886fb2ab
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

serial: Add mctp_serial_destroy()

Provide an abstraction to clean up memory to avoid false-positives from
leak sanitizers.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I3b8b044c81cb5b

serial: Add mctp_serial_destroy()

Provide an abstraction to clean up memory to avoid false-positives from
leak sanitizers.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I3b8b044c81cb5ba99fb91261d5bf952993497dd7

show more ...

serial: Fix unused result warning for write()

serial.c: In function ‘mctp_binding_serial_tx’:
serial.c:145:3: warning: ignoring return value of ‘write’, declared with
attribute warn_unused_result [-

serial: Fix unused result warning for write()

serial.c: In function ‘mctp_binding_serial_tx’:
serial.c:145:3: warning: ignoring return value of ‘write’, declared with
attribute warn_unused_result [-Wunused-result]
145 | write(serial->fd, serial->txbuf, len);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
CCLD libmctp.la

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ie85426ee2c33bc11f730a9ce66a5c6c7c841b920

show more ...

API: Add binding accessors to generic struct mctp_binding

Rather than have every binding include their own wrappers around
binding<->core functions, introduce an accessor to retrieve the struct
mctp

API: Add binding accessors to generic struct mctp_binding

Rather than have every binding include their own wrappers around
binding<->core functions, introduce an accessor to retrieve the struct
mctp_binding from each.

This means we no longer need the binding-specific registration
callbacks. However, we do now need a ->start callback, to allow bindings
to perform post-registration init.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Change-Id: I6cee9e93f37520f85c155a0ca34017cc0675552c

show more ...

serial: Add non-fileio interface to serial binding

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Change-Id: I86d04368bdb5b2348f947717c1806cbbbdd29b17

autotools: Install headers

Use the _HEADERS automake variables to install headers appropriately.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

LICENSE: add GPLv2 license option.

As per the MCTP design document
(https://github.com/openbmc/docs/blob/master/designs/mctp.md), a
dual-licence (GPLv2+ and Apache-2.0) gives us flexibility with inc

LICENSE: add GPLv2 license option.

As per the MCTP design document
(https://github.com/openbmc/docs/blob/master/designs/mctp.md), a
dual-licence (GPLv2+ and Apache-2.0) gives us flexibility with including
libcmtp code into various firmware environments.

This change adds GPLv2+ as a license option. All current contributors
have agreed to this change.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

show more ...

Merge branch 'externc' of https://github.com/dkodihal/libmctp

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Add extern "C" to headers

Add extern "C" to headers so that they can be included by cpp code.

Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>

Initial MCTP core code

Just a skeleton of the MCTP library at present.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>