clang-tidy: Replace NULL with nullptr

Replaced all instances of NULL with nullptr to improve type safety
and clarity, as nullptr is the modern C++ standard for null pointers.

Tested: Build verified

clang-tidy: Replace NULL with nullptr

Replaced all instances of NULL with nullptr to improve type safety
and clarity, as nullptr is the modern C++ standard for null pointers.

Tested: Build verified

Change-Id: I0e0749db217667d9c3f51f8fac6cb58e8915e8d2
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I98f262c24e427f4228b184715d7ad88b0d7060f6
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: Ifdce925775a753cb71bfe44f3229d434b173283b
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

writefrudata: remove vla

Variable length arrays are not allowed in standard C++. Remove them
in favor of std::vector.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Id6e4d6f287bf59

writefrudata: remove vla

Variable length arrays are not allowed in standard C++. Remove them
in favor of std::vector.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Id6e4d6f287bf59bdb5888b1a2d34e41d72572548

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I59041b73cc8b15c2a3800911540e1a10011f6150
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Idab99ed8fdb9bdf5cc0e130d576f55d256df9cce

show more ...

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic5d65c069f9d15ccbb81419180edcf119f8ee08e

show more ...

writefrudata: validate multi-record data

It is fail to parse FRU data with multi-record area available as its
header data is different from other areas.
Support validate multi-record data so that ca

writefrudata: validate multi-record data

It is fail to parse FRU data with multi-record area available as its
header data is different from other areas.
Support validate multi-record data so that can parse FRU data with
multi-record enabled.

Tested:
1. Check if the FRU with multi-record can be parsed.
2. Check IPMI fru print command.
FRU Device Description : Builtin FRU Device (ID 0)
Chassis Type : Rack Mount Chassis
Chassis Serial : A1A1-A000-0000000000123
Board Mfg Date : Tue Feb 4 00:00:00 2020 UTC
Board Mfg : AmpereComputing(R)
Board Product : MT.JADE
Board Serial : 9510002CJ0LA
Board Part Number : B81.03010.0001
Product Manufacturer : AmpereComputing(R)
Product Name : MT.JADE
Product Part Number : AC82830AC10C
Product Version : PR010
Product Serial : AMPX3A1-A000-0000000000123

Signed-off-by: Thang Q. Nguyen <thang@os.amperecomputing.com>
Change-Id: I163c5c7bff2f7315e9c6b610f5074c37bc167ccf

show more ...

writefrudata: variable rc scope reduction

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I0f3e943e27d856937aa7cc6ddf6c579e4e309b2d

debug: add details on notify failure

There can be more than one service providing this method, therefore
output what service failed, and additionally the path.

Signed-off-by: Patrick Venture <ventu

debug: add details on notify failure

There can be more than one service providing this method, therefore
output what service failed, and additionally the path.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I44232418849ac435689a7859aa0baeb3aec5bc90

show more ...

writefrudata: update error message for FRU not found

Update the error message for FRU not found to specify that the FRU isn't
found in the generated source.

Signed-off-by: Patrick Venture <venture@

writefrudata: update error message for FRU not found

Update the error message for FRU not found to specify that the FRU isn't
found in the generated source.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I1f624950ec995b40af178f3cc0006b26abf1d9fa

show more ...

Convert host-ipmid -> libipmid

phosphor-host-ipmid now exposes a library along with headers for
interfacing with the ipmi daemon. Compile and link against the new
library.

Change-Id: Ib222df1605afe

Convert host-ipmid -> libipmid

phosphor-host-ipmid now exposes a library along with headers for
interfacing with the ipmi daemon. Compile and link against the new
library.

Change-Id: Ib222df1605afe277457f34eb69a3d65c663325b7
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

writefrudata: Fix verifyFruData to skip CRC check for internal use area.

The contents of the internal use area are not defined beyond the first
byte, which means that we should not expect its last b

writefrudata: Fix verifyFruData to skip CRC check for internal use area.

The contents of the internal use area are not defined beyond the first
byte, which means that we should not expect its last byte to be a CRC
for the area.

Change-Id: I15aba7f48e13f8a93c5a6b7e3262d9227da5dad7
Signed-off-by: Oskar Senft <osk@google.com>

show more ...

writefrudata: add doxygen for methods

Add doxygen comments for methods.

Change-Id: Ifc155279a21b258300dadd409abfb617652159dc
Signed-off-by: Patrick Venture <venture@google.com>

writefrudata: drop extra parens in call to parse

Drop extra parentheses around parameters in call to parse_fru_area.
This involves changing a casting from c-style to a static_cast<>.

Change-Id: I28

writefrudata: drop extra parens in call to parse

Drop extra parentheses around parameters in call to parse_fru_area.
This involves changing a casting from c-style to a static_cast<>.

Change-Id: I281a950146fd296f8c9b15bd6dfc8562ad9b14bc
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

IPMIFruArea: Drop unused dbus debug

Drop unused dbus debug code. There were no calls to set the values and
the debug printing them would therefore always print empty strings.

Change-Id: I767baf9f3

IPMIFruArea: Drop unused dbus debug

Drop unused dbus debug code. There were no calls to set the values and
the debug printing them would therefore always print empty strings.

Change-Id: I767baf9f3450c9944396930069089a6bbb6e5c6a
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

writefrudata: add missing curly braces for style

OpenBMC style dictates conditional statements needs curly braces.

Change-Id: Iff7066dec2e7a376f2a97e67591ba95b7aa8549d
Signed-off-by: Patrick Ventur

writefrudata: add missing curly braces for style

OpenBMC style dictates conditional statements needs curly braces.

Change-Id: Iff7066dec2e7a376f2a97e67591ba95b7aa8549d
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

writefrudata: drop unused sd-bus.h

Drop unused sd-bus.h header.

Change-Id: I0a55cd3aa5a551d7fa04706d7e0c5b6b275efcf5
Signed-off-by: Patrick Venture <venture@google.com>

writefrudata: rename all variables per openbmc style

OpenBMC style declares variables be lower camel and not snake case.

Change-Id: Iec348bf9825caecc976f654a37ac149a5981c94b
Signed-off-by: Patrick

writefrudata: rename all variables per openbmc style

OpenBMC style declares variables be lower camel and not snake case.

Change-Id: Iec348bf9825caecc976f654a37ac149a5981c94b
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

writefrudata: fixup function naming per style

Fixup function naming to lowerCamelCase for OpenBMC style guide.

Change-Id: I8c8eda9f4aad29aadd092329248c97a556f22b9a
Signed-off-by: Patrick Venture <v

writefrudata: fixup function naming per style

Fixup function naming to lowerCamelCase for OpenBMC style guide.

Change-Id: I8c8eda9f4aad29aadd092329248c97a556f22b9a
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

update: use sdbusplus instead of sd_bus raw pointers

Update code to use sdbusplus instead of raw sd_bus pointers.

Change-Id: I80cd4492480824827c27fbf19eb54487e28d3b75
Signed-off-by: Patrick Venture

update: use sdbusplus instead of sd_bus raw pointers

Update code to use sdbusplus instead of raw sd_bus pointers.

Change-Id: I80cd4492480824827c27fbf19eb54487e28d3b75
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

writefrudata: add missing constness

Set iterator to const reference where possible.

Change-Id: I2d5d766990d49df3e6a6fef743698053413152fc
Signed-off-by: Patrick Venture <venture@google.com>

writefrudata: cleanup extra parentheses

Cleanup extra parentheses from calling accessors against object pointer,
which is actually a reference to a unique_ptr.

Change-Id: Icf47bf376947d1afb0753c18b

writefrudata: cleanup extra parentheses

Cleanup extra parentheses from calling accessors against object pointer,
which is actually a reference to a unique_ptr.

Change-Id: Icf47bf376947d1afb0753c18be66417e2bac4507
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

IPMIFruArea: apply naming convention to member functions

Apply naming convention to member functions.

Change-Id: I3b0516592dd4225f7be43c3d9cdcc9c8853d20b7
Signed-off-by: Patrick Venture <venture@go

IPMIFruArea: apply naming convention to member functions

Apply naming convention to member functions.

Change-Id: I3b0516592dd4225f7be43c3d9cdcc9c8853d20b7
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

IPMIFruArea: move source into separate fru_area.cpp

Move the implementation of the class into its own source file.

Change-Id: I02d941dd8173f0cede8cdfe8af1fdc5f5418abb4
Signed-off-by: Patrick Ventur

IPMIFruArea: move source into separate fru_area.cpp

Move the implementation of the class into its own source file.

Change-Id: I02d941dd8173f0cede8cdfe8af1fdc5f5418abb4
Signed-off-by: Patrick Venture <venture@google.com>

show more ...