clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: Ia647f7c9c2dfb8dab46de151ef03f95aba460e78
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

change vector constructor for gcc-14

gcc-14, with the latest Yocto sync, fails with the following compile
failure:

```
| ../git/ipmbbridged.cpp:724:34: error: value computed is not used [-Werror=un

change vector constructor for gcc-14

gcc-14, with the latest Yocto sync, fails with the following compile
failure:

```
| ../git/ipmbbridged.cpp:724:34: error: value computed is not used [-Werror=unused-value]
| 724 | std::vector<uint8_t> buffer(0);
```

Attempt using the default constructor, which should be equivalent,
instead.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I2d79813a52354bb00d992d6edfd9e2cc3a3ceacf

show more ...

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: I0d3acfeb002b6e3e8356b4f1c2a960c53ecadf2e
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

Update language in ipmbbridge to be more inclusive

Use more inclusive terminology inside of ipmbbridge repo.

Tested: No functional change. Verified on Intel system that ipmb.service
runs and Ipmb c

Update language in ipmbbridge to be more inclusive

Use more inclusive terminology inside of ipmbbridge repo.

Tested: No functional change. Verified on Intel system that ipmb.service
runs and Ipmb channel still gets published on DBus.

Change-Id: I70577a3b28e209a38bcd3d2ec99dd17b09a2d723
Signed-off-by: Matt Simmering <matthew.simmering@intel.com>

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I5e93cd3dd8350b503c35f60adca83c9a71631631
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clean up unused parameter warnings

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I2275db73fbec06dffe4120b50e0816c110f4f358

fix different signedness comparison

../ipmbbridged.cpp:368:12: warning: comparison of integer expressions of different signedness: ‘int’ and ‘const size_t’ {aka ‘const long unsigned int’} [-Wsign-co

fix different signedness comparison

../ipmbbridged.cpp:368:12: warning: comparison of integer expressions of different signedness: ‘int’ and ‘const size_t’ {aka ‘const long unsigned int’} [-Wsign-compare]

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I12bff463c9422f050a572f0936ca5488a461c807

show more ...

simplify sequence number processing

Newer GCC didn't like the complexity of the sequence calculation,
so simplify it.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I884a34e4317c2d3

simplify sequence number processing

Newer GCC didn't like the complexity of the sequence calculation,
so simplify it.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I884a34e4317c2d33b33abf45687ae159f150f84b

show more ...

clang-format: update with latest

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie5bec2584d7e8914e333cdb3be28eb96ac786b29

Add missing include

list was included through a dependency on sdbusplus which no longer
provides it, so it needs to be explicitly included here.

Change-Id: Iad2862e06fd31a95b9bbecb7246504833bc5f42d

Add missing include

list was included through a dependency on sdbusplus which no longer
provides it, so it needs to be explicitly included here.

Change-Id: Iad2862e06fd31a95b9bbecb7246504833bc5f42d
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>

show more ...

Change io_service to io_context

This was renamed a while back in boost to be compliant with the
std::executors proposal.

Change-Id: I2bda7bf0e3e010a4162073b579bb744901597062
Signed-off-by: Ed Tanou

Change io_service to io_context

This was renamed a while back in boost to be compliant with the
std::executors proposal.

Change-Id: I2bda7bf0e3e010a4162073b579bb744901597062
Signed-off-by: Ed Tanous <edtanous@google.com>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I728089e5aefdb363993e3b338aed803f2553bdcd

show more ...

exception: catch by reference

`catch` should always be done by reference to avoid object slicing and
excess copy-constructor calls. Preference is for exceptions to also
be caught 'const'. (Both of

exception: catch by reference

`catch` should always be done by reference to avoid object slicing and
excess copy-constructor calls. Preference is for exceptions to also
be caught 'const'. (Both of these come from the C++ Core Guidelines)

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic8cd1e138220e501699525e9c8d53cd581e2598c

show more ...

Ipmbbridge: Add host Identification support for ipmid.

Added hostId support for ipmid. This helps in identifying
host and sending host id to ipmid for multi host support.
Host ids are configured thr

Ipmbbridge: Add host Identification support for ipmid.

Added hostId support for ipmid. This helps in identifying
host and sending host id to ipmid for multi host support.
Host ids are configured through channel config json.

TESTED : Built Facebook YosemiteV2 & Tiogapass images and loaded on
the target hardware. We are able to see hostId's for all the hosts.

Note : This is the follow-up patch for multiple channels
support in ipmbbridge.
https://gerrit.openbmc-project.xyz/c/openbmc/ipmbbridge/+/34579

Signed-off-by: Kumar Thangavel <thangavel.k@hcl.com>
Change-Id: Ie232d61a0e1f69d2a48d472160ba58a1ea64a6d7

show more ...

Ipmbbridge: Add support for multiple sub channel.

Added Multiple sub channels support for ipmb and me
type to communicate with more than one device of same type.

ChannelType supports only two chann

Ipmbbridge: Add support for multiple sub channel.

Added Multiple sub channels support for ipmb and me
type to communicate with more than one device of same type.

ChannelType supports only two channels ME and ipmb.
Using combination of devIndex and channelType approach,
can support multiple sub channels without affecting the
existing functionalities.

Single host or channel, "devIndex" will be set default index as 0.

For multiple channel under same type need to provide devIndex in
json configurations. This approach uses the sendRequest method's
first parameter values for MSB 6 bits as "devIndex" and
the remaining 2 bits as "channelType".

TESTED : Built Facebook YosemiteV2 & Tiogapass images and loaded on
the target hardware. We are able to see BMC to all
host communications through Ipmb.

Signed-off-by: Kumar Thangavel <thangavel.k@hcl.com>
Change-Id: I20a7231993a0dd1f9d396dde114837380302dc76

show more ...

bug fix for different ipmb communication

If running ipmb command by aardvark, it need run into
ipmb command execution, but under "else" condition, it
would quit before running into the command execu

bug fix for different ipmb communication

If running ipmb command by aardvark, it need run into
ipmb command execution, but under "else" condition, it
would quit before running into the command execution.
After remove the "else" condition, it can run into the
command execution.

Tested:
python.exe transport_i2c.py -a 0x20 -n 0x18 -c 0x01

Change-Id: I5ab8a71a8b04f78c82e91120503b9bb0b89f697b
Signed-off-by: Chen Yugang <yugang.chen@linux.intel.com>

show more ...

Remove broadcast limitation of ipmb channel

Currently it only supports broadcast(slave address 0)
message for ipmb channel, but need to support other
slave address message,so, remove the limitation

Remove broadcast limitation of ipmb channel

Currently it only supports broadcast(slave address 0)
message for ipmb channel, but need to support other
slave address message,so, remove the limitation of
broadcast slave address.

Tested:
it's tested by communication for other slave address.

Change-Id: Ib00ba2e51e4febbe675a3c2609221d09205ecdf8
Signed-off-by: Chen Yugang <yugang.chen@linux.intel.com>

show more ...

Fix includes

sdbusplus dropped the asio.hpp #include, which this daemon was relying
on. Fix to only include the things we need.

Tested:
Code builds. Do not have system to test ipmb functionality,

Fix includes

sdbusplus dropped the asio.hpp #include, which this daemon was relying
on. Fix to only include the things we need.

Tested:
Code builds. Do not have system to test ipmb functionality, but
unlikely to be broken.

Signed-off-by: Ed Tanous <ed@tanous.net>
Change-Id: I4bdd097bd3509f9b08e2863c2421108aa0b0c658

show more ...

Customize ipmbbridge as per upstream IPMB driver

Mqueue slave driver is not upstream and there is a new IPMB
driver which is upstream in kernel and this application has
been modified as per driver p

Customize ipmbbridge as per upstream IPMB driver

Mqueue slave driver is not upstream and there is a new IPMB
driver which is upstream in kernel and this application has
been modified as per driver packet format.

Also using same node for sending IPMB data to device. No need to
define master device.

Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
Change-Id: I8286c41970f680aae2c452331739fa934e41fd4a

show more ...

Support broadcast message

1. Support send/recv broadcast message
2. Fix an issue of inconsistent addr between src addr of incoming message
and target addr of response

Tested:
1. CMC broadcast messa

Support broadcast message

1. Support send/recv broadcast message
2. Fix an issue of inconsistent addr between src addr of incoming message
and target addr of response

Tested:
1. CMC broadcast message can be sent and received (BNP)
2. IPMI command injected to i2c bus0 via IPMB header can return correct value (WFP)

Change-Id: Ic03ee4ef6552a40d20594c4abb337f71ae5763eb
Signed-off-by: Qiang XU <qiang.xu@linux.intel.com>

show more ...

Support dynamically update BMC slave address

On multi-node platform, the BMC slave address is determined by node ID,
so the BMC slave address needs to be updated after node ID detection.
This patch

Support dynamically update BMC slave address

On multi-node platform, the BMC slave address is determined by node ID,
so the BMC slave address needs to be updated after node ID detection.
This patch makes slave-mqueue configurable at run time using 'new_device'
and 'delete-device' sysfs interfaces.
The sample to change BMC slave addr:
(Assume original slave addr is 0x20, but it should be 0x22)
echo "0x1010" > /sys/bus/i2c/devices/i2c-0/delete_device
echo "slave-mqueue 0x1011" > /sys/bus/i2c/devices/i2c-0/new_device

Dependency:
[DTS] remove ipmb0 node to support dynamically update BMC slave address

Tested:
1. The I2C slave message can be received correctly after CMC sends signal
of "updateBmcSlaveAddr" (BNP)
2. Check sys file of slave device exists by command like
"ls -l /sys/bus/i2c/devices/0-1011/slave-mqueue" (BNP)
3. IPMI command injected to bus0 via IPMB header can return correct value (WFP)

Change-Id: Ie55715cf940f19e10d265ae7efec4d4bf55744a2
Signed-off-by: Qiang XU <qiang.xu@linux.intel.com>

show more ...

Make use of new IPMI method call API

tested: checked communication by injecting I2C traffic via aardvark,
everything is working fine
aardvark<->I2C<->IPMB<->IPMI

Change-Id: Ie2a982e710473cfa5948383

Make use of new IPMI method call API

tested: checked communication by injecting I2C traffic via aardvark,
everything is working fine
aardvark<->I2C<->IPMB<->IPMI

Change-Id: Ie2a982e710473cfa594838328730b98affc2cb39
Signed-off-by: Dawid Frycki <dawid.frycki@intel.com>

show more ...

Read channel configuration from JSON file

Read channel information from /usr/share/ipmbbridge/ipmb-channels.json
allowing platforms to override this information.

Signed-off-by: Amithash Prasad <ami

Read channel configuration from JSON file

Read channel information from /usr/share/ipmbbridge/ipmb-channels.json
allowing platforms to override this information.

Signed-off-by: Amithash Prasad <amithash@fb.com>
Change-Id: I161cf72840ff211c270fe56a86e6d3ebd65f170c

show more ...

Suppress I2C error logs while it's retrying

I2C IPMB channel is not an error-free channel because it's in
a multi-master environment basically so IPMB spec itself suggests
retries on I2C communicati

Suppress I2C error logs while it's retrying

I2C IPMB channel is not an error-free channel because it's in
a multi-master environment basically so IPMB spec itself suggests
retries on I2C communication.

To prevent misunderstanding of the log in journal, this commit
suppress the error log printing out with making it print a log
only when it fails all tries.

Change-Id: I710d5aff63f69cf822cdd35b2bfcd7d91fb0410b
Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>

show more ...

Stop using old i2c-tools header

Update to using the new headers.

Closes #3

Tested-by: Still built

Change-Id: I80b8ec5a38ae0c2e8952387695f4a35516fe81e0
Signed-off-by: James Feist <james.feist@linu

Stop using old i2c-tools header

Update to using the new headers.

Closes #3

Tested-by: Still built

Change-Id: I80b8ec5a38ae0c2e8952387695f4a35516fe81e0
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...