Fix build errors with GCC 14

Fix various build errors exposed after updating to GCC 14.

Change-Id: Iec680182785b32650741115ed7d758b2b6bf7d38
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: Id2036ab746164981596b3ee36259f3ca5d3f1334
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

sdbusplus: avoid deprecated phosphor::Timer

sdbusplus had an older type named `phosphor::Timer` which was
recently renamed to `sdbusplus::Timer`. Update the code to use
the new type alias.

Change-

sdbusplus: avoid deprecated phosphor::Timer

sdbusplus had an older type named `phosphor::Timer` which was
recently renamed to `sdbusplus::Timer`. Update the code to use
the new type alias.

Change-Id: I694f0624eae2cdbb071ab97fe019cd5684615541
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

changes needed for meson build

Fix warnings that the meson build turns into errors.

Tested: builds without warnings.

Change-Id: I66b02c4c616f37d09ceba61c494903acc3d28bd5
Signed-off-by: Vernon Maue

changes needed for meson build

Fix warnings that the meson build turns into errors.

Tested: builds without warnings.

Change-Id: I66b02c4c616f37d09ceba61c494903acc3d28bd5
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Fix object path of chassis intrusion

The chassis intrusion object path got updated upstream.
This fix aligns with latest sensor path.

Change-Id: I34841746f9f1b6795a7175659fb4ff71d562b816
Signed-off

Fix object path of chassis intrusion

The chassis intrusion object path got updated upstream.
This fix aligns with latest sensor path.

Change-Id: I34841746f9f1b6795a7175659fb4ff71d562b816
Signed-off-by: Matt Simmering <matthew.simmering@intel.com>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I59c0a8c4b89131ecd3e9a841ed37ef3b8dcf8e9d
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Set Chassis Intrusion status dynamically

Set the Chassis Intrusion status in the Get Chassis Status command
dynamically by checking for the Chassis Intrusion service.

Tested:
Chassis Intrusion stat

Set Chassis Intrusion status dynamically

Set the Chassis Intrusion status in the Get Chassis Status command
dynamically by checking for the Chassis Intrusion service.

Tested:
Chassis Intrusion status is set as active on a platform with the service
running. Chassis Intrusion status is set as inactive on a platform
without the service running.

Signed-off-by: Matt Simmering <matthew.simmering@intel.com>
Change-Id: I5eb503d3d0b456aad5c6b16a585aa10e18e8a0e1

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie7375047bd567aa052d3bd35a6dd7008779a05b4

show more ...

catch exceptions as const

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ia9932efb6a9335e80b3f2376d2d62e1b65866f44

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9915c0207bbca91296548e7a1e707e499c3d7838

show more ...

Add channel support to Get System Restart Cause

Channel was previously unsupported. This adds the channel support that
is available from the ipmi::Context. It also reworks the D-Bus calls
made in th

Add channel support to Get System Restart Cause

Channel was previously unsupported. This adds the channel support that
is available from the ipmi::Context. It also reworks the D-Bus calls
made in that command to use the yielding variants now that the
ipmi::Context is present.

Tested: before: ipmitool -I lanplus ... raw 0 7
00 00
after: ipmitool -I lanplus ... raw 0 7
00 03

Change-Id: I94727c945f4fcf7fb5420960acb828e979a8e3bc
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

[Chassis]: Validate reserved field content is zero

In Set Front Panel Button Enables Command, byte-1’s [7:4] is reserved.
Return InvalidFieldRequest when reserved content is non-zero.
Tested:
~# ipm

[Chassis]: Validate reserved field content is zero

In Set Front Panel Button Enables Command, byte-1’s [7:4] is reserved.
Return InvalidFieldRequest when reserved content is non-zero.
Tested:
~# ipmitool raw 0x00 0x0a 0x10
Unable to send RAW command (channel=0x0 netfn=0x0 lun=0x0 cmd=0xa rsp=0xcc)
:Invalid data field in request

Signed-off-by: sunitakx <sunitax.kumari@linux.intel.com>
Change-Id: I20284f741ce7e2c235d48ba905d922db5c9d2885

show more ...

Fix build issues

* Fix casting issues that are causing the build to fail.
* Fix gtest warnings by updating the source revision

Change-Id: Id6eb6b1fef335f88e7e12074f712b82ecd1a233a
Signed-off-by: Ja

Fix build issues

* Fix casting issues that are causing the build to fail.
* Fix gtest warnings by updating the source revision

Change-Id: Id6eb6b1fef335f88e7e12074f712b82ecd1a233a
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Update to latest clang-format

Update to clang-format-10

Change-Id: I1c33ef7115c7a1459164d71f63921019d2dc9a98
Signed-off-by: James Feist <james.feist@linux.intel.com>

Updated privilege for set front panel command

Updated the execution privilege settings to
'Admin' for Set Front Panel Button enables
command as per IPMI spec.

Tested:
Tested Front Panel Enable comm

Updated privilege for set front panel command

Updated the execution privilege settings to
'Admin' for Set Front Panel Button enables
command as per IPMI spec.

Tested:
Tested Front Panel Enable command with different
privileged users and works only with Admin privilege.

Change-Id: I0a23a04321afb45107ac582bede40582c9ccc13c
Signed-off-by: AppaRao Puli <apparao.puli@linux.intel.com>

show more ...

Use the new RestartCause interface

Tested:
Combined with the RestartCause changes ran 'ipmitool raw 0 7'
and 'ipmitool chassis restart_cause' commands and confirmed that
they correctly return the cu

Use the new RestartCause interface

Tested:
Combined with the RestartCause changes ran 'ipmitool raw 0 7'
and 'ipmitool chassis restart_cause' commands and confirmed that
they correctly return the current RestartCause.

Change-Id: I8361040b12db6567ea48157b9f2e048054e8df1d
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Support IPMI command as last power event in chassis status

This change uses the IPMI command restart cause to determine
if the last power event was from an IPMI command.

Tested:
Pressed the physica

Support IPMI command as last power event in chassis status

This change uses the IPMI command restart cause to determine
if the last power event was from an IPMI command.

Tested:
Pressed the physical power button:
ipmitool chassis status
Last Power Event :

ipmitool power on
ipmitool chassis status
Last Power Event : command

Change-Id: I974d025087218d3ca0aab7327f89993fdf9c2fc9
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Show chassis identify status in chassis status response

This saves the chassis identify status and returns it as part
of the chassis status command.

Tested:
Chassis identify status is bits 5:4 of t

Show chassis identify status in chassis status response

This saves the chassis identify status and returns it as part
of the chassis status command.

Tested:
Chassis identify status is bits 5:4 of the third byte:
Chassis identify off:
ipmitool raw 0 1
01 10 40 70

Set chassis identify to indefinite:
ipmitool raw 0 4 0 1
ipmitool raw 0 1
01 10 60 70

Press the physical ID button to disable identify:
ipmitool raw 0 1
01 10 40 70

Set chassis identify to temporary:
ipmitool raw 0 4
ipmitool raw 0 1
01 10 50 70

Wait for timeout:
ipmitool raw 0 1
01 10 40 70

Change-Id: I4bdd2052d26c665b9d9ce3e01f4b5399336d0e6e
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Add Get System Restart Cause command

This change overrides the Get System Restart Cause command to
use the RestartCause DBus property.

Tested:
ipmitool chassis restart_cause
System restart cause: p

Add Get System Restart Cause command

This change overrides the Get System Restart Cause command to
use the RestartCause DBus property.

Tested:
ipmitool chassis restart_cause
System restart cause: power-up due to restore-previous power policy
ipmitool power cycle
Chassis Power Control: Cycle
ipmitool chassis restart_cause
System restart cause: chassis power control command

Change-Id: I2023f958bdc4d8abf18c25b701709cbd83c0b9b0
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Update AC fail check to new DBus parameter

PFail was removed from DBus and replaced with a new parameter
in settings. This changes the Get Chassis Status command to
check the new parameter to get t

Update AC fail check to new DBus parameter

PFail was removed from DBus and replaced with a new parameter
in settings. This changes the Get Chassis Status command to
check the new parameter to get the AC fail status.

Tested:
After AC cycle:
ipmitool chassis status
Last Power Event : ac-failed

Change-Id: I019a48c1347dced5b81866ec3dcd81c5964561fd
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Add Set Front Panel Button Enables command

This change overrides the chassis status and set front panel
button enables commands to use the new Buttons interface.

Tested:
ipmitool raw 0 0xa 7
ipmito

Add Set Front Panel Button Enables command

This change overrides the chassis status and set front panel
button enables commands to use the new Buttons interface.

Tested:
ipmitool raw 0 0xa 7
ipmitool chassis status
System Power : on
Power Overload : false
Power Interlock : inactive
Main Power Fault : false
Power Control Fault : false
Power Restore Policy : always-off
Last Power Event :
Chassis Intrusion : inactive
Front-Panel Lockout : inactive
Drive Fault : false
Cooling/Fan Fault : false
Sleep Button Disable : not allowed
Diag Button Disable : allowed
Reset Button Disable : allowed
Power Button Disable : allowed
Sleep Button Disabled: false
Diag Button Disabled : true
Reset Button Disabled: true
Power Button Disabled: true

ipmitool raw 0 0xa 0
ipmitool chassis status
System Power : on
Power Overload : false
Power Interlock : inactive
Main Power Fault : false
Power Control Fault : false
Power Restore Policy : always-off
Last Power Event :
Chassis Intrusion : inactive
Front-Panel Lockout : inactive
Drive Fault : false
Cooling/Fan Fault : false
Sleep Button Disable : not allowed
Diag Button Disable : allowed
Reset Button Disable : allowed
Power Button Disable : allowed
Sleep Button Disabled: false
Diag Button Disabled : false
Reset Button Disabled: false
Power Button Disabled: false

Change-Id: I12b6c19483404bee2d481e08260d878bd5aa99c5
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Change the ID LED from on to blinking for identify command

The ID LED will be blinking on ipmi identify command,
And will be on/off when ID button is pressed.

Tested:
Pressed on the ID button, the

Change the ID LED from on to blinking for identify command

The ID LED will be blinking on ipmi identify command,
And will be on/off when ID button is pressed.

Tested:
Pressed on the ID button, the ID LED will be on/off
ipmitool chassis identify 10, the ID LED will be blinking 10 seconds

Change-Id: Ib0bef20e6716096c59e722597fbac25187b4d174
Signed-off-by: Yong Li <yong.b.li@linux.intel.com>
Signed-off-by: Yuan Li <yuan.li@linux.intel.com>

show more ...