clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: Id2036ab746164981596b3ee36259f3ca5d3f1334
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Change OS state busname and objpath

Change the busname and object path of OS state interface.

This commit relies on the patch below:
[1] https://gerrit.openbmc.org/c/openbmc/x86-power-control/+/695

Change OS state busname and objpath

Change the busname and object path of OS state interface.

This commit relies on the patch below:
[1] https://gerrit.openbmc.org/c/openbmc/x86-power-control/+/69589

Change-Id: Ia7a1aedb0d034f292d16a31e4da5f7317cde4d50
Signed-off-by: Potin Lai <potin.lai@quantatw.com>

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I1367c2eabf95f27b5acb08b9e6fd6eedcb77377f
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

changes needed for meson build

Fix warnings that the meson build turns into errors.

Tested: builds without warnings.

Change-Id: I66b02c4c616f37d09ceba61c494903acc3d28bd5
Signed-off-by: Vernon Maue

changes needed for meson build

Fix warnings that the meson build turns into errors.

Tested: builds without warnings.

Change-Id: I66b02c4c616f37d09ceba61c494903acc3d28bd5
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I59c0a8c4b89131ecd3e9a841ed37ef3b8dcf8e9d
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Condense std::variants

Where possible, reduce to a single std::variant type to reduce binary
size.

Change-Id: I73b59765109ce1ccd7339f0e214d1ec3929e1ffc
Signed-off-by: Jason M. Bills <jason.m.bills@

Condense std::variants

Where possible, reduce to a single std::variant type to reduce binary
size.

Change-Id: I73b59765109ce1ccd7339f0e214d1ec3929e1ffc
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>

show more ...

biosConfigCommands: Add check for invalid paramSel

Add additional check in Get Payload IPMI
command for parameter selection. Check
that it's a valid parameter.

Tested: When parameter selection is

biosConfigCommands: Add check for invalid paramSel

Add additional check in Get Payload IPMI
command for parameter selection. Check
that it's a valid parameter.

Tested: When parameter selection is set above max
we're returning the expected error code 0xcc
instead of 0xff.

Change-Id: I77f94a164fb9f05a7d17ad558a9afb91b762b6c8
Signed-off-by: Matt Simmering <matthew.simmering@intel.com>

show more ...

Fix for restoring Default values in BIOS

Enabling restoreDefaultvalue bit in Get Stored BIOS Setup Password
to restore Default values in BIOS and setting back to 0 when NoAction.

Tested:
1. POST -

Fix for restoring Default values in BIOS

Enabling restoreDefaultvalue bit in Get Stored BIOS Setup Password
to restore Default values in BIOS and setting back to 0 when NoAction.

Tested:
1. POST - /redfish/v1/Systems/system/Bios/Actions/Bios.ResetBios
2. Perform Reset BIOS
3. Command: Get Stored BIOS Setup Password(0x30 0xd8)
Response: flag bit is enabled

Signed-off-by: Snehalatha Venkatesh <snehalathax.v@intel.com>
Change-Id: If819e6b3b16661a43e59d47aa367a9475912b5bc

show more ...

Removing IsSystemInterface from biosconfigmanager

IsSystemInterface functionality is handled by whitelist filter.

Tested:
OOB commands work as expected.
Case-1: RMCPP interface
Command: ipmitool -I

Removing IsSystemInterface from biosconfigmanager

IsSystemInterface functionality is handled by whitelist filter.

Tested:
OOB commands work as expected.
Case-1: RMCPP interface
Command: ipmitool -I lanplus -H xx.xx.xx.xx -U debuguser -P 0penBmc1
-C 17 raw 0x30 0xd8
Response: Unable to send RAW command (channel=0x0 netfn=0x30 lun=0x0
cmd=0xd8 rsp=0xd4): Insufficient privilege level
Case-2: KCS interface
Working as expected from BIOS to BMC before CoreBIOSdone/POSTComplete
and blocking after CoreBIOSdone/POSTComplete.

Signed-off-by: Arun Lal K M <arun.lal@intel.com>
Change-Id: Ica3bec4a2f72d072718a7310d493692332a6d5bb

show more ...

Use consistent error code in biosconfigcommands.

biosconfigcommands is checking for IsSystemInterface and
getPostCompleted to throw error for OOB IPMI commands.
But the error code was inconsistent.

Use consistent error code in biosconfigcommands.

biosconfigcommands is checking for IsSystemInterface and
getPostCompleted to throw error for OOB IPMI commands.
But the error code was inconsistent.

Fix added to make error code consistent.
If not IsSystemInterface, error code is ipmi::responseCommandNotAvailable
If getPostCompleted, error code is ipmi::ipmiCCNotSupportedInCurrentState

Tested:
By sending following OOB BIOS commands:
1) Set Payload (0xD5), for type payload type 0.
2) Set BIOS Password Hash info (D7).
3) Set BIOS Feature Capability (D3).
4) Get BIOS Feature Capability (D4).

And verified that after post complete, correct error was thrown.

Signed-off-by: Arun Lal K M <arun.lal@intel.com>
Change-Id: Ie0e1337e4be74a0f5ebb9576ccdff4072fc51bf1

show more ...

Fix Get Payload Data failing for type 0 and 5 files.

Issue: Get Payload Data for type 0 and type 5 is giving command response
error(0xce).

Fix: Added validation code to get response data.

Tested:

Fix Get Payload Data failing for type 0 and 5 files.

Issue: Get Payload Data for type 0 and type 5 is giving command response
error(0xce).

Fix: Added validation code to get response data.

Tested:
Before Fix:
Command: ipmitool raw 0x30 0xd6 1 5 0 0 0 0 0x44 0 0 0
Response:
Unable to send RAW command (channel=0x0 netfn=0x30 lun=0x0 cmd=0xd6
rsp=0xce): Command response could not be provided

After Fix:
Case-1: For Payload type 0
Command: Get Payload Info
ipmitool raw 0x30 0xd6 0x0 0x0
Response :
00 00 00 47 36 04 00 62 c8 b8 62 00 01 3a 43 a9
61
Command: Get Payload Data
ipmitool raw 0x30 0xd6 1 0 0 0 0 0 0x08 0 0 0
Response:
00 08 00 00 00 06 bb c3 29 5d 00 00 00 01 22 54
ac
Case-2: For Payload type 5
1. Create Payload 5
Command: Set Payload Start Info
ipmitool raw 0x30 0xd5 0 5 0 0 0x44 0 0 0 0xc 0xab 0xc2 0x53 0x0
Response: Success with Reservation ID
Command: Set Payload In Progress
ipmitool raw 0x30 0xd5 1 5 <ReservationID> 0 0 0 0 0x44 0 0 0 0xc 0xab
0xc2 0x53 0x50 0x58 0x4F 0x24 0x44 00 0x20 00 0x02 0x4E 0x81 00 0x03 00
0x03 0xF8 0x02 00 00 0x79 0x18 00 0x04 00 0x07 00 00 00 00 00 00 00
0x02 0x24 00 00 0xE8 0x7E 0xF8 0x83 0x06 00 00 00 00 00 00 00 00 00 00
00 00 0x7F 00 0x07 00 00 0x81 00 00 00 00 00 00 00 00 00
Response: Success
Command: Set Payload End Transfer
ipmitool raw 0x30 0xd5 2 5 <ReservationID>
Response: Success
2. Reboot BMC
3. Check for Payload 5 file in /var/oob folder
4. Check with Get Payload
Command: Get Payload Info
ipmitool raw 0x30 0xd6 0 5
Response:
00 00 05 44 00 00 00 0c ab c2 53 00 01 fc 43 a9
61
Command: Get Payload Data
ipmitool raw 0x30 0xd6 1 5 0 0 0 0 0x44 0 0 0
Response: Success with data

Signed-off-by: Snehalatha Venkatesh <snehalathax.v@intel.com>
Change-Id: I198fa005f1732f80d5eb94550ab6cabd0f3754be

show more ...

Use correct OSStatus in biosconfigcommands to detect post completed.

biosconfigcommands was checking for "OperatingState" as value of
interface xyz.openbmc_project.State.OperatingSystem.Status, but

Use correct OSStatus in biosconfigcommands to detect post completed.

biosconfigcommands was checking for "OperatingState" as value of
interface xyz.openbmc_project.State.OperatingSystem.Status, but
"OperatingState" is not in list of valid enum in OSStatus.

Fix: use "Standby" or
"xyz.openbmc_project.State.OperatingSystem.Status.OSStatus.Standby"

Tested
By sending following OOB BIOS commands:
1) Set Payload (0xD5), for type payload type 0.
2) Set BIOS Password Hash info (D7).
3) Set BIOS Feature Capability (D3).

And verified that after post complete, above commands are blocked.

Signed-off-by: Arun Lal K M <arun.lal@intel.com>
Change-Id: Id3a80b91645af72faf3d5715c1e933086b7dd148

show more ...

Add extra validation for GetPayloadData

Issue: GetPayloadData gives command response error when
greater data length is given.

Fix: Added extra validation to give correct response

Tested:
Before fi

Add extra validation for GetPayloadData

Issue: GetPayloadData gives command response error when
greater data length is given.

Fix: Added extra validation to give correct response

Tested:
Before fix:
1. To get datalength
Command : ipmitool raw 0x30 0xd6 0x0 0x0
Response:
00 00 00 cb 36 04 00 2a 5f 12 28 00 01 6d 2e 52
5c
Case-1: When data length is invalid
Command : ipmitool raw 0x30 0xd6 1 0 0 0 0 0 0 0 0 0x05
Response:
Unable to send RAW command (channel=0x0 netfn=0x30 lun=0x0 cmd=0xd6
rsp=0xce): Command response could not be provided
Case-2:When data length is valid
Command : ipmitool raw 0x30 0xd6 1 0 0x09 0 0 0 0xcb 0 0 0
Response:
Unable to send RAW command (channel=0x0 netfn=0x30 lun=0x0 cmd=0xd6
rsp=0xce): Command response could not be provided

After fix:
1. Repeat 1 in before fix to get data length
Case-1: When data length is invalid
Command : ipmitool raw 0x30 0xd6 1 0 0 0 0 0 0 0 0 0x05
Response:
Unable to send RAW command (channel=0x0 netfn=0x30 lun=0x0 cmd=0xd6
rsp=0xcc): Invalid data field in request
Case-2:When data length is valid
Command : ipmitool raw 0x30 0xd6 1 0 0x09 0 0 0 0xcb 0 0 0
Response: //Success

Signed-off-by: Snehalatha Venkatesh <snehalathax.v@intel.com>
Change-Id: I85d9648cb48991510c3a016a9d6bc6ef65904259

show more ...

Add support for Enumeration in BIOSConfig

Bios knobs have options (possible set of values for the knob) as Enumaration,
Hence BMC must treat it as type enumuration and not as string.

Bios knobs hav

Add support for Enumeration in BIOSConfig

Bios knobs have options (possible set of values for the knob) as Enumaration,
Hence BMC must treat it as type enumuration and not as string.

Bios knobs have options (possible set of values for the knob) as
Enumaration,Hence BMC must treat it as type enumuration and not as
string.

This change is also to support the following change in bios-settings-mgr
https://gerrit.openbmc-project.xyz/c/openbmc/bios-settings-mgr/+/49126

Tested:
By giving following commands and making sure functionalities
are not affected.

1) GET to
/Registries/BiosAttributeRegistry/BiosAttributeRegistry/

2) GET to
Systems/system/Bios/Settings

3) PATCH to
Systems/system/Bios/Settings

Redfish validator result:
1) For /redfish/v1/Registries/
Counter({'metadataNamespaces': 2295, 'pass': 2053, 'skipOptional': 1267,
'warnDeprecated': 232, 'passGet': 11, 'warningPresent': 6,
'serviceNamespaces': 5})
Validation has succeeded.

2) For /redfish/v1/Systems/system/Bios/
Counter({'pass': 7405, 'metadataNamespaces': 2295, 'skipOptional': 14,
'serviceNamespaces': 4, 'passGet': 2, 'passAction': 2, 'reflink': 1,
'warningPresent': 1})
Validation has succeeded.

Signed-off-by: Arun Lal K M <arun.lal@intel.com>
Change-Id: Ib86b0dbd3536a33fa85c8bb9897901b8220c4539

show more ...

catch exceptions as const

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ia9932efb6a9335e80b3f2376d2d62e1b65866f44

Fix support for Get Payload.

Get Payload is split into two as follows:
1) Get Payload Info (ipmitool raw 0x30 0xd6 0 1):
Return info of Payload1 (pending list) data

2) Get Payload data (ipmitool ra

Fix support for Get Payload.

Get Payload is split into two as follows:
1) Get Payload Info (ipmitool raw 0x30 0xd6 0 1):
Return info of Payload1 (pending list) data

2) Get Payload data (ipmitool raw 0x30 0xd6 1 1):
Return Payload1 (pending list) data.

Note: Pending list is the BIOS knobs edited by patch to
https://<IP>/redfish/v1/Systems/system/Bios/Settings,
which is stored in BMC.

Tested:
Step 1)
Patch to https://<IP>/redfish/v1/Systems/system/Bios/Settings
with the following data:
{
"data":{
"Ce2LmLoggingEn": "0x0",
"CoreCrashLogDisable": "0x1",
"CpuCrashLogClear": "0x0",
"DfxEadrDebugLogs": "0x1",
"DfxFadrDebugLogs": "0x1",
"WheaLogMemoryEn": "0x1"
}
}

Step 2)
Give command ipmitool raw 0x30 0xd6 0 1

Response:
00 00 01 7e 00 00 00 08 4c d3 e9 00 01 a8 9e 00
00

Step 3)
Give command ipmitool raw 0x30 0xd6 1 1 0x09 0 0 0 0x7e 0 0 0

Response:
01 75 00 00 00 89 51 07 a0 69 6e 67 45 6e 3d 30
78 30 0a 43 6f 72 65 43 72 61 73 68 4c 6f 67 44
69 73 61 62 6c 65 3d 30 78 31 0a 43 70 75 43 72
61 73 68 4c 6f 67 43 6c 65 61 72 3d 30 78 30 0a
44 66 78 45 61 64 72 44 65 62 75 67 4c 6f 67 73
3d 30 78 31 0a 44 66 78 46 61 64 72 44 65 62 75
67 4c 6f 67 73 3d 30 78 31 0a 57 68 65 61 4c 6f
67 4d 65 6d 6f 72 79 45 6e 3d 30 78 31 0a

Signed-off-by: Arun Lal K M <arun.lal@intel.com>
Change-Id: I6a3bec66f78c2c9b6296e3dbba7743971b372f75

show more ...

Add depex support in bios.xml parsing.

Added logic to execute depex expression for every knob in bios.xml.
knob is added to BiosAttributeRegistry only if depex evaluation result
is TRUE.

Tested:
By

Add depex support in bios.xml parsing.

Added logic to execute depex expression for every knob in bios.xml.
knob is added to BiosAttributeRegistry only if depex evaluation result
is TRUE.

Tested:
By giving GET Request to
'redfish/v1/Registries/BiosAttributeRegistry/BiosAttributeRegistry'.
Output sample showing few knobs added becuase depex evaluation result
was TRUE:

{
"AttributeName": "AEPErrorInjEn",
"CurrentValue": "0x00",
"DefaultValue": "0x00",
"DisplayName": "AEPErrorInjEn",
"HelpText": "Enable/Disable PMem Error Injection",
"MenuPath": "./",
"ReadOnly": false,
"Type": "String",
"Value": [
{
"OneOf": "0x0"
},
{
"OneOf": "0x1"
}
]
}
{
"AttributeName": "wrVrefCenter",
"CurrentValue": "0x01",
"DefaultValue": "0x01",
"DisplayName": "wrVrefCenter",
"HelpText": "Write Vref Centering Disable/Enable",
"MenuPath": "./",
"ReadOnly": false,
"Type": "String",
"Value": [
{
"OneOf": "0x0"
},
{
"OneOf": "0x1"
}
]
}

Following are few knobs rejected becuase depex evaluation
result was FALSE:

<knob type="scalar" setupType="oneof" name="PfrProvision"
varstoreIndex="04" prompt="PFR Provision"
description="Selectable if PFR is not locked." size="1"
offset="0x0126"
depex="Sif( PfrSupported _EQU_ 0 ) _AND_ Gif( PfrLockStatus _EQU_ 1 OR
PfrProvisionStatus _EQU_ 1 )"
default="0x00" CurrentVal="0x00">
<options>
<option text="Disable" value="0x0"/>
<option text="Enable" value="0x1"/>
</options>
</knob>

<knob type="scalar" setupType="oneof" name="SataHotPlugController0_0"
varstoreIndex="01" prompt="
Hot Plug" description="Designates this port as Hot Pluggable." size="1"
offset="0x0119"
depex="Sif( PchSata_0 _EQU_ 0 ) _AND_
Sif( SataExternalController0_0 _EQU_ 1 )" default="0x00"
CurrentVal="0x00">
<options>
<option text="Disabled" value="0x0"/>
<option text="Enabled" value="0x1"/>
</options>
</knob>

Signed-off-by: Arun Lal K M <arun.lal@intel.com>
Change-Id: Iff1ea01fb06200e21cc7f2a2e0fdfdff70376581

show more ...

OOB NV File Handling flow is corrected.

1.OOB NV files are restored properly after BMC reset
2.Added File Error handling

Tested:
Get OOB BIOS capability
ipmitool raw 0x30 0xd4

Set OOB BIOS Capabil

OOB NV File Handling flow is corrected.

1.OOB NV files are restored properly after BMC reset
2.Added File Error handling

Tested:
Get OOB BIOS capability
ipmitool raw 0x30 0xd4

Set OOB BIOS Capability
ipmitool raw 0x30 0xd3 0x16 0 0 0

SetPayload Start Info :
ipmitool raw 0x30 0xd5 0 3 0 0 0x44 0 0 0 0xc 0xab 0xc2 0x53 0x0
Success with Reservation ID
SetPayload InProgress :
ipmitool raw 0x30 0xd5 1 3 <Reservation ID> 0 0 0 0 0x44 0 0 0
0xc 0xab 0xc2 0x53 0x50 0x58 0x4F 0x24 0x44 00 0x20 00 0x02
0x4E 0x81 00 0x03 00 0x03 0xF8 0x02 00 00 0x79 0x18 00
0x04 00 0x07 00 00 00 00 00 00 00 0x02 0x24 00 00 0xE8
0x7E 0xF8 0x83 0x06 00 00 00 00 00 00 00 00 00 00 00 00
0x7F 00 0x07 00 00 0x81 00 00 00 00 00 00 00 00 00
EndOfTransfer:
ipmitool raw 0x30 0xd5 2 3 <Reservation ID>
Success with data
Reboot the BMC
reboot

Get Payload Info:
ipmitool raw 0x30 0xd6 0 3
Success with data
Get Payload:
ipmitool raw 0x30 0xd6 1 3 0 0 0 0 0x44 0 0 0
Success with data

Delete the Payload3 File:
Get Payload Info
ipmitool raw 0x30 0xd6 0 3
0xFF // Unspecified Error

Get Payload :
ipmitool raw 0x30 0xd6 1 3 0 0 0 0 0x44 0 0 0
0xFF // Unspecified Error

Signed-off-by: Suryakanth Sekar <suryakanth.sekar@linux.intel.com>
Change-Id: I6c09e4154d4a33557fe02449f20e820204a8e0f5

show more ...

fix: correct SetBiosPwdHash and GetBiosPwdHash cmd

As per recent EDK core, there is a change in BIOS password handling.
User password option in BIOS setup is removed for security reasons.
Also, move

fix: correct SetBiosPwdHash and GetBiosPwdHash cmd

As per recent EDK core, there is a change in BIOS password handling.
User password option in BIOS setup is removed for security reasons.
Also, moved to SHA256 algo and seed size is increased from 16 bytes
to 32 bytes.

This change is to correct the two password handling commands to comply
with the the new bios changes.

Tested:
Executed both the commands D7 and D8 through KCS interface.
Verified cmd response is success and as expected.

Signed-off-by: Ayushi Smriti <smriti.ayushi@linux.intel.com>
Change-Id: I8fbd1623c5feaf33a9a8f91905bb1773163fbbae

show more ...

Fix issue on BaseBIOSTable updating

All attributes can be generated, but fail to
modify BaseBIOSTable property due to struct changed.

Tested:
oem command could change BaseBIOSTable correctly.
root@

Fix issue on BaseBIOSTable updating

All attributes can be generated, but fail to
modify BaseBIOSTable property due to struct changed.

Tested:
oem command could change BaseBIOSTable correctly.
root@intel-obmc:~# ipmitool raw 0x30 0xd5 2 0 0

Jan 01 00:38:37 intel-obmc ipmid[199]: ipmiOEMSetPayload : Convert XML into native-dbus DONE
Jan 01 00:38:37 intel-obmc ipmid[199]: generateAttributesData
Jan 01 00:38:37 intel-obmc ipmid[199]: QuietBoot
Jan 01 00:38:37 intel-obmc ipmid[199]: OnboardNICEnable_0
Jan 01 00:38:37 intel-obmc ipmid[199]: OnboardNICPortEnable_0
Jan 01 00:38:37 intel-obmc ipmid[199]: OnboardNICPortEnable_1
Jan 01 00:38:37 intel-obmc ipmid[199]: OnboardNICPortEnable_2
Jan 01 00:38:37 intel-obmc ipmid[199]: OnboardNICPortEnable_3
Jan 01 00:38:37 intel-obmc ipmid[199]: OnboardNICEnable_1
Jan 01 00:38:37 intel-obmc ipmid[199]: OnboardNICPortEnable_4
Jan 01 00:38:37 intel-obmc ipmid[199]: OnboardNICPortEnable_5
Jan 01 00:38:37 intel-obmc ipmid[199]: OnboardNICPortEnable_6
Jan 01 00:38:37 intel-obmc ipmid[199]: OnboardNICPortEnable_7
Jan 01 00:38:37 intel-obmc ipmid[199]: IB1_PXE
Jan 01 00:38:37 intel-obmc ipmid[199]: OnboardNICIOMPortPXEEnable_8
Jan 01 00:38:37 intel-obmc ipmid[199]: OnboardNICIOMPortPXEEnable_9
Jan 01 00:38:37 intel-obmc ipmid[199]: OnboardNICIOMPortPXEEnable_10
Jan 01 00:38:37 intel-obmc ipmid[199]: OnboardNICIOMPortPXEEnable_11
Jan 01 00:38:37 intel-obmc ipmid[199]: IB2_PXE
Jan 01 00:38:37 intel-obmc ipmid[199]: OnboardNICIOMPortPXEEnable_12
Jan 01 00:38:37 intel-obmc ipmid[199]: OnboardNICIOMPortPXEEnable_13
Jan 01 00:38:37 intel-obmc ipmid[199]: OnboardNICIOMPortPXEEnable_14
Jan 01 00:38:37 intel-obmc ipmid[199]: OnboardNICIOMPortPXEEnable_15
Jan 01 00:38:37 intel-obmc ipmid[199]: Pci64BitResourceAllocation

root@intel-obmc:~# busctl call xyz.openbmc_project.BIOSConfigManager /xyz/openbmc_project/bios_config/manager org.freedesktop.DBus.Properties Get ss xyz.openbmc_project.BIOSConfig.Manager BaseBIOSTable --json=pretty |more
{
"type" : "v",
"data" : [
{
"type" : "a{s(sbsssvva(sv))}",
"data" : {
"ADDDCEn" : [
"xyz.openbmc_project.BIOSConfig.Manager.AttributeType.String",
false,
"ADDDC Sparing",
"Enable/Disable Adaptive Double Device Data Correction Sparing.",
"./Advanced/Memory Configuration/Memory RAS and Performance Configuration/ADDDC Sparing",
{
"type" : "s",
"data" : "0x00"
},
{
"type" : "s",
"data" : "0x00"
},
[
[
"xyz.openbmc_project.BIOSConfig.Manager.BoundType.OneOf",
{
"type" : "s",
"data" : "0x1"
}
],
[
"xyz.openbmc_project.BIOSConfig.Manager.BoundType.OneOf",
{
"type" : "s",
"data" : "0x0"
}
]
]
],
"ADREn" : [
"xyz.openbmc_project.BIOSConfig.Manager.AttributeType.String",
false,
"Enable ADR",
"Enables the detecting and enabling of ADR.",
"./Advanced/Memory Configuration/Enable ADR",
{
"type" : "s",
"data" : "0x01"
},

Change-Id: I8c0183c5738d008f617c4e6e1a44a53e3e8bde82
Signed-off-by: Kuiying Wang <kuiying.wang@intel.com>

show more ...

Fix the ResetBIOS value from bios-settings-mgr srv

GetStoredHash command always return 0xCE becuase fail to
get the proper resetBIOS value from ReadResetBIOSSettings function

Fix: Added proper Rese

Fix the ResetBIOS value from bios-settings-mgr srv

GetStoredHash command always return 0xCE becuase fail to
get the proper resetBIOS value from ReadResetBIOSSettings function

Fix: Added proper ResetBIOS value check in ReadResetBIOSSettings
function and also corrected the seedData filename.

Tested:

GetStoredHash command is working fine.
ipmitool raw 0x30 0xd8 // Request
02 18 de c8 83 d1 5d cc 58 a4 f1 af ee f0 2a 9c
d0 12 83 45 eb f7 06 72 62 e9 dd f5 1d 78 68 13
41 63 2c 8a fb 9f 01 17 30 6c 69 b8 1d 67 d6 6d
13 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00 75 99 3f 96 e2 e0 81 2d 4e 40 b7 ee 2a be a3
6a 9d c9 69 6b 3a d3 6c 04 a0 0b 41 82 0c a4 b1
48 2b 92 7a 2a 23 7f 86 5b 22 6b e7 08 31 87 b8
14 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00

Signed-off-by: Suryakanth Sekar <suryakanth.sekar@linux.intel.com>
Change-Id: Ie15cfa06371b7c77901fb10b9bc61f70ae0dd0c9

show more ...

Status-BIT4/BIT5 contain Password Hash status

In setPasswordHash command, status- BIT4/ BIT5 contain password
status.so we need to filter out the status bit for checking the
supported Algorithm. St

Status-BIT4/BIT5 contain Password Hash status

In setPasswordHash command, status- BIT4/ BIT5 contain password
status.so we need to filter out the status bit for checking the
supported Algorithm. Status BIT4 and BIT5 are used in
bios-settings-mgr service.

Tested:
SetPassword Hash command is working fine.

Signed-off-by: Suryakanth Sekar <suryakanth.sekar@linux.intel.com>
Change-Id: I8f3005c5b9fc1928f1728d86939625d3583da2e6

show more ...

IPMI OEM Commands for OOB bios config

Four IPMI OEM commands are defined and implemented for the
communication beteween BIOS and BMC.
cmdSetBIOSCap = 0xD3;
cmdGetBIOSCap = 0xD4;
cmdSetPayload = 0xD5

IPMI OEM Commands for OOB bios config

Four IPMI OEM commands are defined and implemented for the
communication beteween BIOS and BMC.
cmdSetBIOSCap = 0xD3;
cmdGetBIOSCap = 0xD4;
cmdSetPayload = 0xD5;
cmdGetPayload = 0xD6;
cmdSetPasswordHashInfo = 0xD7;
cmdGetStoredPasswordHash = 0xD8;

Added the OTA Payload Type

Tested:
1. ipmitool is working well for these 6 commands
2. passed unit test w/ bios and bios.xml is generated successfully

Change-Id: Ic318c18ca6d59c3ad6e10df9ffb2b22a38a55ddf
Signed-off-by: Kuiying Wang <kuiying.wang@intel.com>
Signed-off-by: Suryakanth Sekar <suryakanth.sekar@linux.intel.com>

show more ...