Improve SDR sensor number mapping for sensor nums above 510

The recent submission to support SDR records defining Type 01 records
for sensors did not work when the system had more than 510 sensors.

Improve SDR sensor number mapping for sensor nums above 510

The recent submission to support SDR records defining Type 01 records
for sensors did not work when the system had more than 510 sensors. A
recent change supplied a system that enumerated more sensors then IPMI
can support. The change highlighted an error in how the Type 01
records were built.

This commit handles systems with a larger set of sensors. The code for
handling SDR # 511 correctly creates sensor number 768. It then fills
sensors to the limit of LUN 3.

Tested:
A SUT that supplied 1946 sensors was used to implement and test the
code.
Test cases:
"ipmitool sdr elist" returns 765 sensors
"ipmitool sensor list" returns 765 sensors
"ipmitool -l <lun> raw 4 0x2d <sn>" performed the correct behavior for
luns 0-3, sensor numbers 0, 254, 255.

Change-Id: I8e5160c93e79a366b897554efdd60e2edcd3594a
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>

show more ...

Fix sensor missing issue.

There is issue for "BMC randomly unable to get sensor readings".
When invoking "ipmitool sdr" from Linux OS (host), it only
returns three sensors like following partial rec

Fix sensor missing issue.

There is issue for "BMC randomly unable to get sensor readings".
When invoking "ipmitool sdr" from Linux OS (host), it only
returns three sensors like following partial records:
[root@localhost ~]# ipmitool sdr
CPU Power | 0 Watts | ok
Memory Power | 0 Watts | ok
Total Power | 0 Watts | ok
[root@localhost ~]#

There 2 caches sensorTree and sensorDataRecords.
When sensorDataRecords cache and sensorTree cache is not sync,
which causes this issue, like sensorTree cache has 10 sensors
but there are just 5 sensors in sensorDataRecords cache.
Most important sensorDataRecords cache is not necessary,
ipmiStorageGetSDR could get data from dbus directly and
no any performance impact.

Using sensorMapUpdatePeriod(10s) but not sensorMapSdrUpdatePeriod(60s),
60 seconds are too long to answer user with some SDR content
at the first time of BMC bootup.

Tested:
All sensors could be listed even at booting phase.
Could print correct sensor set along with the boot progress.

root@intel-obmc:~# ipmitool sdr
CPU Power | 202 Watts | ok
Memory Power | 0 Watts | ok
Total Power | 312 Watts | ok
root@intel-obmc:~# ipmitool sdr
System Airflow | 14 unspecified | ok
PSU1 In Current | 1.18 Amps | ok
PSU1 Out Current | 20.80 Amps | ok
PSU2 In Current | 0 Amps | ok
PSU2 Out Current | no reading | ns
Pwm 1 | 29.79 unspecifi | ok
Pwm 2 | 29.79 unspecifi | ok
Pwm 3 | 29.79 unspecifi | ok
Pwm 4 | 29.79 unspecifi | ok
Pwm 5 | 29.79 unspecifi | ok
Pwm 6 | 29.79 unspecifi | ok
Pwm 13 | 29.79 unspecifi | ok
Pwm 14 | 29.79 unspecifi | ok
Pwm 15 | 29.79 unspecifi | ok
Pwm 16 | 29.79 unspecifi | ok
Pwm PSU1 Fan 1 | 39.98 unspecifi | ok
Pwm PSU1 Fan 2 | 39.98 unspecifi | ok
.............
PVCCD HV CPU1 | 1.18 Volts | ok
PVCCFA EHV FIVRA | 1.16 Volts | ok
PVCCINFAON CPU1 | 1.11 Volts | ok
PVCCIN CPU1 | 1.68 Volts | ok
PVNN PCH AUX | 1.03 Volts | ok
root@intel-obmc:~#

Change-Id: I729d9bcbf91f0e96c62fb5f5ebe0240a0eaa47df
Signed-off-by: Kuiying Wang <kuiying.wang@intel.com>
Signed-off-by: Helen Huang <he.huang@linux.intel.com>
Signed-off-by: Kuiying Wang <kuiying.wang@intel.com>

show more ...

Allow more than 256 IPMI sensors in a system

Systems with more than 255 IPMI sensors report strange values for
sensors assigned beyond the 255 limit for a single LUN. This is due to
the sensor numbe

Allow more than 256 IPMI sensors in a system

Systems with more than 255 IPMI sensors report strange values for
sensors assigned beyond the 255 limit for a single LUN. This is due to
the sensor number assignment rolling over to 0, and then applying the
most recent SDR values to the sensor calculation.

This change assigns up to 255 sensors to a single LUN (0xFF is
reserved). When the 256th sensor is assigned the sensor gets placed in
the LUN. LUNs 0, 1, and 3 are used, as LUN 2 is special.

Another guard has been created that throws an exception when more than
765 sensors have been assigned. This makes it obvious to the system
designer the limit for IPMI sensors has been reached.

Tested:
Forced the maxmimum number of sensors in the system to be 63 per LUN.

"ipmitool sdr elist" returned correct values for every sensor even
when the sensor number displayed in the printout matched the value of
a sensor printed earlier.

"ipmitool sensor get P3V3" returns a valid reading. In my test "P3V3"
was in LUN1.

"ipmitool raw 4 0x20 0" reported 63 sensors for LUN0, and that LUN0
and LUN1 had sensors.

"ipmitool raw -l 1 4 0x20 0" reported the remaining sensor count.

"ipmitool raw 0xa 0x2d 0" returns the correct value for LUN0 Sensor 0

"ipmitool raw -l 1 0xa 0x2d 0" returns the correct value for LUN1
Sensor 0

Change-Id: Ic1708b66339e57b1b765f5a9a684e829a0ec8fba
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>

show more ...

Update to latest clang-format

Update to clang-format-10

Change-Id: I1c33ef7115c7a1459164d71f63921019d2dc9a98
Signed-off-by: James Feist <james.feist@linux.intel.com>

Corrected threshold readingmasks for Type01sensors

Issue: The upper and lower threshold reading mask(Byte 16,18)
in SDR Type01 sensors are not set under any conditions.

Fix: Setting the threshold m

Corrected threshold readingmasks for Type01sensors

Issue: The upper and lower threshold reading mask(Byte 16,18)
in SDR Type01 sensors are not set under any conditions.

Fix: Setting the threshold mask based on its respective threshold
conditions.

Tested:
1.Issue Get SDR command for [u,l][c,nc] sensors.
2.Check theresponse for the bits 5,4 of Byte 16 and 18 (lower and upper)
are set correctly for respective sensors.

Signed-off-by: Rashmi RV <rashmi.r.v@linux.intel.com>
Change-Id: I119560b937bf24c0173acb72cb95aa56d3311314

show more ...

sensorcommands: move get sensor event status

Rewrite "Get sensor event status" cmd to new IPMI provider API

Tested:
1. verified ipmitool get sensor event status is same both before and
after the ch

sensorcommands: move get sensor event status

Rewrite "Get sensor event status" cmd to new IPMI provider API

Tested:
1. verified ipmitool get sensor event status is same both before and
after the changes
Before:
Command: ipmitool raw 0x04 0x2B 0x35
Response: 80 00 00 00 00
After:
Command: ipmitool raw 0x04 0x2B 0x35
Response: 80 00 00 00 00

Signed-off-by: jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: I3f2bd7d7a77deae266acbd691326242930e021ef
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

sensorcommands.hpp: use quotes for project headers

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I46b8b3831b89f977fd77f87f192f51872c8246e5

sensorcommands: add missing headers

Add headers for types used by this file. Compilation breaks if the
header ordering changes.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I41bc

sensorcommands: add missing headers

Add headers for types used by this file. Compilation breaks if the
header ordering changes.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I41bc2cb3606c5c07ee6afd2aa12aed1903c8ec50

show more ...

sensorcommands:move set sen thresh & get sen event

Rewrite "Set sen thres&Get sen event enable" cmds to new IPMI prov API

Tested:
verified using ipmitool sensor commands.
a. set sensor threshold
b.

sensorcommands:move set sen thresh & get sen event

Rewrite "Set sen thres&Get sen event enable" cmds to new IPMI prov API

Tested:
verified using ipmitool sensor commands.
a. set sensor threshold
b. get sensor event enable

Signed-off-by: jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: I0f98db69e5e303b704af899d30d59a81e5a7ea9b

show more ...

Update getThreshold to new API

This command is broken out into a "getIPMIThresholds" function
and the actual handler so that the SDR can call the same code
to get thresholds into IPMI format. Doing

Update getThreshold to new API

This command is broken out into a "getIPMIThresholds" function
and the actual handler so that the SDR can call the same code
to get thresholds into IPMI format. Doing this caused quite a
bit of rewrite so I updated it to the new API as well.

Tested: IPMI sensor list thresholds still worked.

Change-Id: If6f33574d61549ec0e70955f3d1867af8d698246
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Sensor Reading Get: Add threshold byte

Third byte should show threshold status based on
spec. Add the threshold data and update to the new
api.

Tested: Sensor list still worked, used sensor overide

Sensor Reading Get: Add threshold byte

Third byte should show threshold status based on
spec. Add the threshold data and update to the new
api.

Tested: Sensor list still worked, used sensor overide
to modify threshold and saw byte in sensor get. sdr elist
also started showing status.

Change-Id: Ic08555563b62048f334b5cb4aaedcd3fcef1f5f7
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Add sensor deassert tracking

Get sensor event status command needs this information.

Tested: Used sensor override and made fan cross a threshold,
then go back. Get sensor event status command had c

Add sensor deassert tracking

Get sensor event status command needs this information.

Tested: Used sensor override and made fan cross a threshold,
then go back. Get sensor event status command had correct
bits set.

Change-Id: I8d8c7203ea6cb1d0e467f6267445e2d7395426a6
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Fix set sensor threshold command number

0x28 -> 0x26

Tested-by: Now works at 0x26

Change-Id: I0b1bac6e0bc17d9886f838de125bab5a1e985681
Signed-off-by: James Feist <james.feist@linux.intel.com>

Move SensorSubTree declaration to ipmi scope

Move SensorSubTree declaration to ipmi scope
Issue: Unable to resolve this symbol during loading of this
library, which is due to definition & declaratio

Move SensorSubTree declaration to ipmi scope

Move SensorSubTree declaration to ipmi scope
Issue: Unable to resolve this symbol during loading of this
library, which is due to definition & declaration being in different
scope.

Unit-Test:
Verified that library is loaded properly and ipmitool sensor list
works.

Change-Id: I243e0033d0b76a14c0976f16bd6b893c0e96cb55
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

Move getSensorConnection to header file

Move getSensorConnection to header file, so that the same
can be used by ipmi-providers Set Sensor override command

Change-Id: Ic6c313eb2bc07710c175b7908647a

Move getSensorConnection to header file

Move getSensorConnection to header file, so that the same
can be used by ipmi-providers Set Sensor override command

Change-Id: Ic6c313eb2bc07710c175b7908647a800f5fe45a0
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

Add Intel-specific IPMI sensor commands

Also includes SDR storage commands that are required to support
the 'ipmitool sensor list' command.

Change-Id: Id1830097d93882114085fce723f0b92367b2db48
Sign

Add Intel-specific IPMI sensor commands

Also includes SDR storage commands that are required to support
the 'ipmitool sensor list' command.

Change-Id: Id1830097d93882114085fce723f0b92367b2db48
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...