clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I6083e412d8356a97b5213a138f370bfeb43a69b3
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I768b8efcac262ef07cf75f06486c6144c090e91a

show more ...

Fix typo

Caught by a newer compiler. This was a legitimate bug.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I92758be667ddfd969269e671a73334b0929a1750

sdbusplus: object: don't use 'bool' argument constructor

`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.

sdbusplus: object: don't use 'bool' argument constructor

`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.
It is time to remove this boolean to make it more observable which
actions are being used in applications. Map all `true` occurrences to
`action::defer_emit`.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I7adbc8df11fa75f33f7d3437ea5ceae4ea6ca9d2

show more ...

catch exceptions as const

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If8dcf70005aebd4ca633b91d6f96badf4a5cd326

Switch SdBusError to generic sdbusplus exception

SdBusError was never supposed to be caught outside of sdbusplus.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Iee1e200cbcf70d6ba548b4

Switch SdBusError to generic sdbusplus exception

SdBusError was never supposed to be caught outside of sdbusplus.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Iee1e200cbcf70d6ba548b492042bd6dc0f5e2ba8

show more ...

sdbusplus: remove deprecated variant_ns

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib20d8676d474bcb020a5ffababd77d901360d192

Updates for new association interface

The association interface name changed to
xyz.openbmc_project.Association.Definitions and its property changed to
Associations. Update the code accordingly.

T

Updates for new association interface

The association interface name changed to
xyz.openbmc_project.Association.Definitions and its property changed to
Associations. Update the code accordingly.

Tested: Created an event log with a callout association, and verified
that the correct callout object was created.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Id48b6f2093410757ca6119cda09544d81f708ba5

show more ...

Fixup std::variant usage

This change refactors mapbox::variant specific usage onto an API that
mapbox::variant and std::variant both support.

Tested:
Run through unit tests.

Change-Id: Ic35953

Fixup std::variant usage

This change refactors mapbox::variant specific usage onto an API that
mapbox::variant and std::variant both support.

Tested:
Run through unit tests.

Change-Id: Ic35953b4772398495129830ed0d4455409f844ea
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Use C++17 optional and any

The optional and any types are no longer experimental
in C++17.

Change-Id: I0b507b73fdd13afe531bef7a2ce308ebc8a3da7d
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

clang-format updates

Run with clang-format-6.0 and update to latest .clang-format
as listed in the docs repository.

Change-Id: I40fb686cc66adf56b2c1b5277ac1c44b64b89349
Signed-off-by: Matt Spinler

clang-format updates

Run with clang-format-6.0 and update to latest .clang-format
as listed in the docs repository.

Change-Id: I40fb686cc66adf56b2c1b5277ac1c44b64b89349
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Handle SdBusError exceptions

sdbusplus can now throw exceptions, so while they aren't expected
the code should handle them.

Tested: Create and delete error logs

Change-Id: I7cd596d628922ae3811fca

Handle SdBusError exceptions

sdbusplus can now throw exceptions, so while they aren't expected
the code should handle them.

Tested: Create and delete error logs

Change-Id: I7cd596d628922ae3811fca227ae2ca123d8134d6
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Restore Callout objects

Restore any saved Callout objects when the application starts
up and creates its interfaces for all existing error logs.

For each error log, it will look in the save directo

Restore Callout objects

Restore any saved Callout objects when the application starts
up and creates its interfaces for all existing error logs.

For each error log, it will look in the save directory for it
to find any saved Callout files. If there is one, it will
restore a Callout object from it.

The default path it looks in is:
/var/lib/ibm-logging/errors/N/callouts/ where N is an error
log entry ID.

The code will look for all numerically named files in that
directory to restore. If it is unsuccessful, it will delete
the file since it is corrupt and move on to the next one.

Tested: Restart ibm-log-manager and check that the callout
objects were preserved via looking at D-Bus.

Resolves openbmc/openbmc#2973

Change-Id: I8bc1dac3748a39e2c3a33d763e75ff90e5da668e
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Create the Callout objects

If a new error log has the association interface, and the
inventory item it points to implements the Asset interface,
create a Callout object for it and persist it.

It wi

Create the Callout objects

If a new error log has the association interface, and the
inventory item it points to implements the Asset interface,
create a Callout object for it and persist it.

It will be persisted to a file like:
/var/lib/ibm-logging/errors/N/callouts/M where N is an error
log entry ID and M is the callout instance number.

Tested: Verify new D-Bus objects for callouts.

Change-Id: I90e9cf76edd7c2517de22cee64c3b979c482efa8
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Use different code paths for create and restore

There are 2 slightly different code paths for when
the code starts up and creates error log objects via
a GetManagedObjects call versus when it create

Use different code paths for create and restore

There are 2 slightly different code paths for when
the code starts up and creates error log objects via
a GetManagedObjects call versus when it creates a single
new object on an InterfacesAdded callback.

The latter case involves creating all new interface
objects for an error log entry. The former case involves
creating brand new interface objects for the interfaces
that did not need to be persisted, and restoring the data
for the objects that did.

Tested: Run through both code paths

Change-Id: I4e05324f315153a501271499a50ea00b3e5808c0
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Add support for child D-Bus objects

Add the ability for the Manager class to store D-Bus objects
that are children of the main interface objects, where being
a child just means the object path exten

Add support for child D-Bus objects

Add the ability for the Manager class to store D-Bus objects
that are children of the main interface objects, where being
a child just means the object path extends the parent path.

There can be multiple of these objects per logging entry, and
they have the same lifespan as the parent objects.

This is in preparation for creating callout objects for an
error log, where a log can have multiple callouts.

Tested: When child objects are created and stored, they show
up on D-Bus until deleted.

Change-Id: I00c612db183b74654f529a7a694bb62856766413
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Create an erase() function

This function is used to delete any objects associated
with an entry ID.

Tested: Erases still work

Change-Id: If80c54b502d64e5d5b3826b303ffe516def1fe8f
Signed-off-by: Ma

Create an erase() function

This function is used to delete any objects associated
with an entry ID.

Tested: Erases still work

Change-Id: If80c54b502d64e5d5b3826b303ffe516def1fe8f
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Revert "Implement the Delete interface"

This reverts commit 433beadcb8b0af4ebdc05e2b46be0be0ac3085e6.

As objects will be deleted on phosphor-logging interfaces removed
signals, the Delete interface

Revert "Implement the Delete interface"

This reverts commit 433beadcb8b0af4ebdc05e2b46be0be0ac3085e6.

As objects will be deleted on phosphor-logging interfaces removed
signals, the Delete interface is no longer required.

Tested: Ensure the REST Delete calls still work via the
InterfacesRemoved handler.

Change-Id: I08f0b8fddf85ed1122175b1a66b9e2decbbf6cdf
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Revert "Implement the DeleteAll interface"

This reverts commit 2cfceb4623c83c04ebe49c5dcae7da877c1c5c8b.

As objects will be deleted on phosphor-logging interfaces removed
signals, the DeleteAll int

Revert "Implement the DeleteAll interface"

This reverts commit 2cfceb4623c83c04ebe49c5dcae7da877c1c5c8b.

As objects will be deleted on phosphor-logging interfaces removed
signals, the DeleteAll interface is no longer required.

Tested: Ensure DeletaAll still works via InterfacesRemoved handling.

Change-Id: I842b0e839faa464c49b818f11bd8c555736acd6e
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Revert "Remove the interfaces removed handler"

Listening for the interfaces removed signal is required so
that ibm-logging can remove its objects when phosphor-logging
prunes its entries after hitti

Revert "Remove the interfaces removed handler"

Listening for the interfaces removed signal is required so
that ibm-logging can remove its objects when phosphor-logging
prunes its entries after hitting capacity.

Previously, ibm-logging depended on someone calling Delete or
DeleteAll to remove objects.

This reverts commit 19ff79fafee4bdf695ae71522715e16bedb1349a.

Tested: Delete xyz.openbmc_project.Logging entries and verify
these logs get deleted too.

Change-Id: Ib172100cc455563fc026330182d46b96f97679b5
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Remove the interfaces removed handler

Now that the delete and delete-all interfaces are implemented,
the interfaces removed signal handler is no longer needed to
know when to delete objects.

In fac

Remove the interfaces removed handler

Now that the delete and delete-all interfaces are implemented,
the interfaces removed signal handler is no longer needed to
know when to delete objects.

In fact, it breaks the REST server because on a Delete call
the following would happen:
1) The server calls Delete on the logging entry in
xyz.openbmc_project.Logging.
2) The removal of that object would call our interfaces
removed handler, which would delete our logging object.
3) The REST server would try to call Delete on our object
and would fail because we already deleted it.

Resolves openbmc/openbmc#3120

Change-Id: Ibfa1faacb0ff27cd7e7e92e35bfd0f972020d361
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Implement the DeleteAll interface

Implement the xyz.openbmc_project.Collection.DeleteAll
interface to delete all logging entries.

Change-Id: I007dd8408ebb4e30bf3d3a3c431d747248620aa4
Signed-off-by:

Implement the DeleteAll interface

Implement the xyz.openbmc_project.Collection.DeleteAll
interface to delete all logging entries.

Change-Id: I007dd8408ebb4e30bf3d3a3c431d747248620aa4
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Implement the Delete interface

Implement the xyz.openbmc_project.Object.Delete interface
to delete an IBM logging object.

This is required because if someone calls Delete on an entry
in /xyz/openbm

Implement the Delete interface

Implement the xyz.openbmc_project.Object.Delete interface
to delete an IBM logging object.

This is required because if someone calls Delete on an entry
in /xyz/openbmc_project/logging/, the REST server will also
call Delete on the corresponding object here.

Change-Id: I742320e49bcf1b371840dda4c7f5b1d0f572ad6a
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Create wrapper function for adding an interface

Put the code that places an interface object into the
map of entries into a common function.

Change-Id: I14af6771fcf6ec36fbd055d9c1f19cb0304aa130
Sig

Create wrapper function for adding an interface

Put the code that places an interface object into the
map of entries into a common function.

Change-Id: I14af6771fcf6ec36fbd055d9c1f19cb0304aa130
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Enable clang-format

Ideally would have done this from the beginning,
but better later than never.

Change-Id: Ib4c73085c4817496c9f2ee505c19149a67b394dc
Signed-off-by: Matt Spinler <spinler@us.ibm.co

Enable clang-format

Ideally would have done this from the beginning,
but better later than never.

Change-Id: Ib4c73085c4817496c9f2ee505c19149a67b394dc
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...