#
7c15db6f |
| 19-Feb-2025 |
William A. Kennington III <wak@google.com> |
ncsid: Use PACKET_MR_PROMISC
Using IFF_PROMISC is dangerous because it requires us to set the IF flag. The if flags cannot be set atomically, and they are expected to be owned and managed by systemd
ncsid: Use PACKET_MR_PROMISC
Using IFF_PROMISC is dangerous because it requires us to set the IF flag. The if flags cannot be set atomically, and they are expected to be owned and managed by systemd-networkd. NCSId will sometimes race with systemd-networkd and discard the IFF_UP flag and prevent the interface from coming up during boot.
PACKET_MR_PROMISC does not depend on the flags and will not conflict with other processes using the interface.
Change-Id: I4c193e73bff789e079e859d2b98c2477b2956d54 Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
#
d980e4fc |
| 18-Dec-2024 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: re-format for clang-19
clang-format-19 isn't compatible with the clang-format-18 output, so we need to reformat the code with the latest version. A few parameters in clang-tidy have b
clang-format: re-format for clang-19
clang-format-19 isn't compatible with the clang-format-18 output, so we need to reformat the code with the latest version. A few parameters in clang-tidy have been deprecated, so adjust the style file accordingly.
See Ie2f6eb3b043f2d655c9df806815afd7971fd0947 for updated style. See I88192b41ab7a95599a90915013579608af7bc56f for clang-19 enablement.
Change-Id: Iae27e5bd313778cb732d5e87598cd94cc6b13cb4 Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
#
a9a98258 |
| 18-Sep-2023 |
Willy Tu <wltu@google.com> |
ncsid: Fix if_packet warnings
The new Docker CI now hits the following error. ``` /usr/include/linux/if_packet.h:24:17: error: flexible array member 'sockaddr_ll::<unnamed union>::<unnamed struct>::
ncsid: Fix if_packet warnings
The new Docker CI now hits the following error. ``` /usr/include/linux/if_packet.h:24:17: error: flexible array member 'sockaddr_ll::<unnamed union>::<unnamed struct>::sll_addr_flex' not at end of 'class ncsi::SockIO' 24 | __DECLARE_FLEX_ARRAY(unsigned char, sll_addr_flex); | ^~~~~~~~~~~~~~~~~~~~ ../subprojects/ncsid/src/ncsi_sockio.h:55:15: note: next member 'const int ncsi::SockIO::kpoll_timeout_' declared here 55 | const int kpoll_timeout_ = 10; | ^~~~~~~~~~~~~~ ../subprojects/ncsid/src/ncsi_sockio.h:29:7: note: in the definition of 'class ncsi::SockIO' 29 | class SockIO : public net::SockIO ```
Removed the sockaddr_ll variable.
Change-Id: I67e700f6cd728bfbc822c1b8661915f8306711a1 Signed-off-by: Willy Tu <wltu@google.com>
show more ...
|
#
adb8ffe4 |
| 17-Jul-2023 |
Willy Tu <wltu@google.com> |
iwyu: Cleanup include headers
Triggered iwyu and add/remove used headers.
Change-Id: Iadbdb459563b3c89baf2d56f90a540342d020cd5 Signed-off-by: Willy Tu <wltu@google.com>
|
#
1285115c |
| 17-Mar-2021 |
William A. Kennington III <wak@google.com> |
meson: Fix build with 0.57.1
Meson doesn't like that we are symlinking subprojects outside the subproject directory. If we invert the links we are able to build again.
We also need to fix any proje
meson: Fix build with 0.57.1
Meson doesn't like that we are symlinking subprojects outside the subproject directory. If we invert the links we are able to build again.
We also need to fix any projects passing arguments which they don't actually accept.
Change-Id: Ie7adf82afabc1becc85c36b3cc632e8ebd4cae5b Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
#
dab96f13 |
| 18-Feb-2021 |
Brandon Kim <brandonkim@google.com> |
Adding google license header to source files
This was done automatically using this script:
https://github.com/google/addlicense
``` go get -u github.com/google/addlicense $HOME/go/bin/addlicense
Adding google license header to source files
This was done automatically using this script:
https://github.com/google/addlicense
``` go get -u github.com/google/addlicense $HOME/go/bin/addlicense -c "Google LLC" -l apache . ```
Manually added the license headers to meson.build files as well
Signed-off-by: Brandon Kim <brandonkim@google.com> Change-Id: I7a17364912c8af2317a1d47a4222f7b3bdc5dc98
show more ...
|
#
7d6fa42f |
| 08-Feb-2021 |
William A. Kennington III <wak@google.com> |
ncsid: Import from gBMC
This is the initial code drop from gBMC.
Google-Bug-Id: 179618516 Upstream: 1e71af914bc8c54d8b91d0a1cf377e2696713c2f Change-Id: Ic653e8271dacd205e04f2bc713071ef2ec5936a4 Sig
ncsid: Import from gBMC
This is the initial code drop from gBMC.
Google-Bug-Id: 179618516 Upstream: 1e71af914bc8c54d8b91d0a1cf377e2696713c2f Change-Id: Ic653e8271dacd205e04f2bc713071ef2ec5936a4 Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|