Use new template gbmc-bare-metal-active@.target

The systemd target gbmc-bare-metal-active.target is being changed to a
template, in order to support multi-host systems. The LinuxBootDone IPMI
comman

Use new template gbmc-bare-metal-active@.target

The systemd target gbmc-bare-metal-active.target is being changed to a
template, in order to support multi-host systems. The LinuxBootDone IPMI
command handler starts this target, so going forward, it needs to use
the systemd target gbmc-bare-metal-active@0.target, to indicate host 0.
This IPMI command is only used on single-host machines, so we can
hard-code the host number in this case.

Tested:
Exercised the LinuxBootDone IPMI command. First, set the flags
/run/bm-drive-cleaning-done-ack.flag and /run/bm-ready.flag on the BMC,
then ran the following IPMI command on the host
$ ./ipmitool raw 0x2e 0x32 0x79 0x2b 0x00 0x11
79 2b 00 11
Confirmed that the gbmc-bare-metal-active@0.target got started.

Change-Id: Iba16c3fb378eb13f17e8d48fd3a45b8b1f1da84a
Signed-off-by: John Wedig <johnwedig@google.com>

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I8c81e5e5b6bd1ec4bdd52aa9039ef1c4bbef088d
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

handler: Fix getBMInstanceProperty to read spaces

std::getline should be used to avoid terminating the read when there are
spaces.

Tested:
Before:
~# cat /run/bm-instance/asset-tag
testing space
~#

handler: Fix getBMInstanceProperty to read spaces

std::getline should be used to avoid terminating the read when there are
spaces.

Tested:
Before:
~# cat /run/bm-instance/asset-tag
testing space
~# ipmitool raw 0x2e 0x32 0x79 0x2b 0x00 0x17 0x00
79 2b 00 17 07 74 65 73 74 69 6e 67

After:
~# cat /run/bm-instance/asset-tag
testing space
~# ipmitool raw 0x2e 0x32 0x79 0x2b 0x00 0x17 0x00
79 2b 00 17 0d 74 65 73 74 69 6e 67 20 73 70 61 63 65

Signed-off-by: Brandon Kim <brandonkim@google.com>
Change-Id: Ia13880e385150487dfe07c4aabf7b3edc814ccf0

show more ...

bm_instance: Create a new handler

This OEM handler will get properties from tmpfs to serve over IPMI.

Tested:
~# cat /run/bm-instance/asset-tag
12345
~# ipmitool raw 0x2e 0x32 0x79 0x2b 0x00 0x17 0

bm_instance: Create a new handler

This OEM handler will get properties from tmpfs to serve over IPMI.

Tested:
~# cat /run/bm-instance/asset-tag
12345
~# ipmitool raw 0x2e 0x32 0x79 0x2b 0x00 0x17 0x00
79 2b 00 17 05 31 32 33 34 35
...
...
(Verified this works for all 7 sub commands)

Signed-off-by: Brandon Kim <brandonkim@google.com>
Change-Id: I191b6f4994d91ada49a3332a8e93a3a305561904

show more ...

Add new oem command to set accel power mode

Signed-off-by: Gaurav Gandhi <gauravgandhi@google.com>
Change-Id: Ie0b47477b7ae9e8ae206ac0645571a7a79dbda40

all: Use stdplus::print over std::fprintf

Replacing `std::fprintf` with `stdplus::print`.
No logical change.

Tested: Buildable.
Signed-off-by: Michael Shen <gpgpgp@google.com>
Change-Id: I7050885c1

all: Use stdplus::print over std::fprintf

Replacing `std::fprintf` with `stdplus::print`.
No logical change.

Tested: Buildable.
Signed-off-by: Michael Shen <gpgpgp@google.com>
Change-Id: I7050885c13e33244a4128aa519d163fd5b725098

show more ...

File System: Dependency Injection and Mock

1. Add an abstract FileSystemInterface for Dependency Injection
2. Add FileSystemWrapper for real file system operations, which is
called in produciton

File System: Dependency Injection and Mock

1. Add an abstract FileSystemInterface for Dependency Injection
2. Add FileSystemWrapper for real file system operations, which is
called in produciton
3. Add FileSystemMock for unit test mock only
4. Add bm_mode_transition_unittest.cpp to cover file system based bm
mode transition

Tested:
1/14 eth OK 0.22s
2/14 flash OK 0.21s
3/14 machine OK 0.12s
4/14 bmc_mode OK 0.05s
5/14 cable OK 0.27s
6/14 cpld OK 0.25s
7/14 entity OK 0.24s
8/14 google_accel_oob OK 0.20s
9/14 pcie OK 0.11s
10/14 poweroff OK 0.09s
11/14 psu OK 0.08s
12/14 pcie_bifurcation OK 0.07s
13/14 bm_mode_transition OK 0.29s
14/14 handler OK 0.44s

Ok: 14
Expected Fail: 0
Fail: 0
Unexpected Pass: 0
Skipped: 0
Timeout: 0

Change-Id: I8d0d9096fbeee7af1946d7e73f548e4a249d3bee
Signed-off-by: Hao Zhou <haoooamazing@google.com>

show more ...

Add IPMI OEM command LinuxBootDone

Add a new OEM command for LinuxBoot to notify the BMC when it is about
to kexec into the OS. This is intended to give the BMC a chance to
prepare for an untrusted

Add IPMI OEM command LinuxBootDone

Add a new OEM command for LinuxBoot to notify the BMC when it is about
to kexec into the OS. This is intended to give the BMC a chance to
prepare for an untrusted OS, e.g. disable any interfaces it doesn't want
the OS to have access to.

Tested:
Exercised the new OEM command using ipmitool
$ ipmitool raw 0x2e 0x32 0x79 0x2b 0x00 0x11
79 2b 00 11

Change-Id: Ica76d77cdde48cebfbced32d8e7e860b559074e8
Signed-off-by: John Wedig <johnwedig@google.com>

show more ...

Add flags for bmc modes transitions

1. When /run/bm-drive-cleaning-done.flag is present, it means cleaning
is done and we are in BM_MODE. Also, it is acked by renaming flag to
bm-drive-cleani

Add flags for bmc modes transitions

1. When /run/bm-drive-cleaning-done.flag is present, it means cleaning
is done and we are in BM_MODE. Also, it is acked by renaming flag to
bm-drive-cleaning-done-ack.flag
2. if not case 1, when /run/bm-drive-cleaning-done-ack.flag is present,
it means the cleaing is done and acked
3. if not case 2, when bm-ready.flag is present, it means we are in
BM_CLEANING_MODE. /run/bm-drive-cleaning.flag is created if needed
4. otherwise, we are in NON_BM_MODE

Tested:
bm-ready.flag is not present. Respond Non-BM mode:

ipmitool raw 0x2e 0x32 0x79 0x2b 0x00 0x10
79 2b 00 10 00

bm-ready.flah is present. For next call, respond Cleaning Mode and
bm-drive-cleaning.flag is created:

ipmitool raw 0x2e 0x32 0x79 0x2b 0x00 0x10
79 2b 00 10 02

keep responding Cleaning Mode until bm-drive-cleaning-done.flag is
created. So cleaning is done and for next call, respond BM mode and
rename bm-drive-cleaning-done.flag to bm-drive-cleaning-done-ack.flag:

ipmitool raw 0x2e 0x32 0x79 0x2b 0x00 0x10
79 2b 00 10 01

Change-Id: Id8a6049550631c30c68a536313b81a8d800fede0
Signed-off-by: Hao Zhou <haoooamazing@google.com>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I0a1783b101aa4e7d4b80fd5e1fc1b2beb86c5caa

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Change-Id: Ie3b9c52f1fe18c89432ee7eb5d8023e028565541
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

handler: Add check for file existence for BM mode

/tmp/BMReady.flag indicates that we are in BM mode.

Tested:
Verified both cases -
- Mar 21 11:17:52 ipmid[1130]: /tmp/BMReady.flag exists so we mus

handler: Add check for file existence for BM mode

/tmp/BMReady.flag indicates that we are in BM mode.

Tested:
Verified both cases -
- Mar 21 11:17:52 ipmid[1130]: /tmp/BMReady.flag exists so we must be in BM mode
- Mar 21 10:37:04 ipmid[1076]: Unable to find /tmp/BMReady so we must not be in BM mode

Signed-off-by: Brandon Kim <brandonkim@google.com>
Change-Id: I9fa99b40afea7e48ce7e1f9c47e8f081b71b897f

show more ...

Move bmc mode enum to a header file

Tested:

Response in BM Mode:
ipmitool raw 0x2e 0x32 0x79 0x2b 0x00 0x10
79 2b 00 14 01

Response in Non-BM Mode:
ipmitool raw 0x2e 0x32 0x79

Move bmc mode enum to a header file

Tested:

Response in BM Mode:
ipmitool raw 0x2e 0x32 0x79 0x2b 0x00 0x10
79 2b 00 14 01

Response in Non-BM Mode:
ipmitool raw 0x2e 0x32 0x79 0x2b 0x00 0x10
79 2b 00 14 00

Signed-off-by: Nikhil Namjoshi <nikhilnamjoshi@google.com>
Change-Id: I3e0ca730ccaed74c3195eb3a4002719077251745

show more ...

Add ipmi OEM handler to get the BMC mode

The response can indicate one of the BMC mode
below
0 -> Non Bare Metal Mode
1 -> Bare Metal Mode
2 -> Bare Metal Cleaning Mode

The Bare Metal Cleaning Mode

Add ipmi OEM handler to get the BMC mode

The response can indicate one of the BMC mode
below
0 -> Non Bare Metal Mode
1 -> Bare Metal Mode
2 -> Bare Metal Cleaning Mode

The Bare Metal Cleaning Mode is not
yet supported

Tested:

Response in BM Mode

ipmitool raw 0x2e 0x32 0x79 0x2b 0x00 0x10
79 2b 00 14 01

Response in Non-BM Mode

ipmitool raw 0x2e 0x32 0x79 0x2b 0x00 0x10
79 2b 00 14 00

Signed-off-by: Nikhil Namjoshi <nikhilnamjoshi@google.com>
Change-Id: I34474fd04f9aed35bd71725805ed52a5df8ab8c9

show more ...

accel: rename `accelOobGetDbus` to `getBus`

accelOobGetDbus returns a dbus bus which can be leverage by others.
Rename it to a more common name.

Tested: Unittest passed.
Signed-off-by: Michael Shen

accel: rename `accelOobGetDbus` to `getBus`

accelOobGetDbus returns a dbus bus which can be leverage by others.
Rename it to a more common name.

Tested: Unittest passed.
Signed-off-by: Michael Shen <gpgpgp@google.com>
Change-Id: I0e48f7f6a49c09b397d52e9343bc3e32ca41d9d8

show more ...

all: cleanup, prefer "ipmid/api-types.hpp" type to "ipmid/api.h" type

Tested: N/A
Signed-off-by: Michael Shen <gpgpgp@google.com>
Change-Id: Id3e9f206516c55b3605835b32d6cd2b488c52a60

pcie_bifurcation: Fetch bifurcation at a PCIe slot with hardcoded values

This will read a json config and return the bifurcation based on that.
It will read the configure file in a persistent file t

pcie_bifurcation: Fetch bifurcation at a PCIe slot with hardcoded values

This will read a json config and return the bifurcation based on that.
It will read the configure file in a persistent file to see if it is
valid machine config and return the bifurcation information
accordingly.

For example,
If it is valid config, it will return 8x8 for PE1,3,4,6.

Tested:
Unit tests passed.

Physical Tests.

PE0 -> no bifurcation
PE1 -> x8x8

```
$ ipmitool raw 0x2e 0x32 0x79 0x2b 0x00 0x0f 0
79 2b 00 0b 00

$ ipmitool raw 0x2e 0x32 0x79 0x2b 0x00 0x0f 1
79 2b 00 0b 02 08 08
```

Change-Id: I44aefbfb26372f8bc0069343c8a6d07d3cf6f42d
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

Add IPMI interface for CustomAccel service

Change-Id: I28a8976e382b457233ac521e9ab71f75abe029d1
Signed-off-by: Steve Foreman <foremans@google.com>

Add Google Copyright 2021

Change-Id: I26020265613218d0c8df85b83772856bfc555e86
Signed-off-by: Willy Tu <wltu@google.com>

eth: Support looking up alternate interace channels

This makes it possible to use the GetEthDevice command to look up
interfaces other than the default NCSI interface.

Change-Id: I3a5563743a28b39ad

eth: Support looking up alternate interace channels

This makes it possible to use the GetEthDevice command to look up
interfaces other than the default NCSI interface.

Change-Id: I3a5563743a28b39adc753d8957f68f0bc330cf3a
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

handler: Don't hardcode channel information

We can use the functions from the ipmi daemon to get the proper channel
for the named NIC.

Change-Id: I9f479ec90bffed147a68131a6dda5aebd9cfc910
Signed-of

handler: Don't hardcode channel information

We can use the functions from the ipmi daemon to get the proper channel
for the named NIC.

Change-Id: I9f479ec90bffed147a68131a6dda5aebd9cfc910
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Add new google ipmi sys command: SysHostPowerOff

New google ipmi sys command to let the BMC knows host shutdown,
allow host to gracefully shutdown and disable the watchdog with given
time delay.

Si

Add new google ipmi sys command: SysHostPowerOff

New google ipmi sys command to let the BMC knows host shutdown,
allow host to gracefully shutdown and disable the watchdog with given
time delay.

Signed-off-by: Yunyun Lin <linyuny@google.com>
Change-Id: I02171c9cfed57ae5d10d66b515e4ab7ee8856466

show more ...

Add OEM command to request flash size

The BMC flash is `/dev/mtd0` and the size can found in
`/sys/class/mtd/mtd0/size`. This OEM command will request that
information with MTDINFO.

Tested:
Success

Add OEM command to request flash size

The BMC flash is `/dev/mtd0` and the size can found in
`/sys/class/mtd/mtd0/size`. This OEM command will request that
information with MTDINFO.

Tested:
Successfully requested the flash size information with ipmitool.

```
cat /sys/class/mtd/mtd0/size
67108864
```
67108864 / 1024 / 1024 = 64MB flash

```
ipmitool raw 0x2e 0x32 0x79 0x2b 0x00 0x09
79 2b 00 09 00 00 00 04
```
Output in little endian.
0x04000000 -> 67108864

Change-Id: Iec1b33503d1166a42ceef4b8491e5c19c3a077fe
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

Add sys command for powercycle on host shutdown.

The new command will trigger a power cycle the next time the host shuts
down. This can exist in parallel with the existing mechanism to trigger
a pow

Add sys command for powercycle on host shutdown.

The new command will trigger a power cycle the next time the host shuts
down. This can exist in parallel with the existing mechanism to trigger
a power cycle after a specified time interval.

The implementation of host state detection and power cycling is platfrom
specific; the new command will just add a temporary file that marks the
system ready to powercycle on the next shutdown. Usually, a systemd unit
would be enabled by the presence of this file to handle the power
cycling process.

Signed-off-by: Shounak Mitra <shounak@google.com>
Change-Id: I0cc40307748fb996be3f6062d8cba1a4b5049683

show more ...

Remove globally constructed variables

Using global variables that have construction order dependencies on each
other do not guarantee the expected execution order. We had an issue
where the defaultC

Remove globally constructed variables

Using global variables that have construction order dependencies on each
other do not guarantee the expected execution order. We had an issue
where the defaultConfigPath is not constructed from the string in
handler.cpp before it was used to construct the Handler impl.

This resolves the issue by removing runtime constructed global variables
entirely.

Change-Id: I868f34782d22d3b2b07be303a05f58b9c9f8c8b8
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...