History log of /openbmc/fb-ipmi-oem/src/storagecommands.cpp (Results 1 – 19 of 19)
Revision Date Author Comments
# 010dee04 16-Aug-2024 Patrick Williams <patrick@stwcx.xyz>

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: Ide19264aa5b2b01a5102b4b2a9cf226ba8dec699
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...


# d79f89e7 05-Dec-2023 Patrick Williams <patrick@stwcx.xyz>

sdbusplus: avoid deprecated phosphor::Timer

sdbusplus had an older type named `phosphor::Timer` which was
recently renamed to `sdbusplus::Timer`. Update the code to use
the new type alias.

Change-

sdbusplus: avoid deprecated phosphor::Timer

sdbusplus had an older type named `phosphor::Timer` which was
recently renamed to `sdbusplus::Timer`. Update the code to use
the new type alias.

Change-Id: Ied1acfff806faeb131c1f55b3cc518f117c487a9
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...


# 5a7a04da 10-Jan-2024 Potin Lai <potin.lai@quantatw.com>

storagecommands: fix sensorTree never updated

Swap the sequence of sensorTree.empty() and getSensorSubtree() in if
statement.
This will fix the issue of sensorTree never get updated.

Change-Id: I22

storagecommands: fix sensorTree never updated

Swap the sequence of sensorTree.empty() and getSensorSubtree() in if
statement.
This will fix the issue of sensorTree never get updated.

Change-Id: I225c3641145643ef481aec977ebd4b8b277b2dc8
Signed-off-by: Potin Lai <potin.lai@quantatw.com>

show more ...


# 8713427c 06-Oct-2023 cchoux <cosmo.chou@quantatw.com>

fix the last "next record ID" missing in the Get SDR response

In current implementation, the last SDRs are for FRUIDs (Type 10h).
After fixing this issue, we can list all FRUIDs by the command,
"ipm

fix the last "next record ID" missing in the Get SDR response

In current implementation, the last SDRs are for FRUIDs (Type 10h).
After fixing this issue, we can list all FRUIDs by the command,
"ipmitool fru print".

Change-Id: I8ca22bea9a20128f268cf23bf6c92b352e901d67
Signed-off-by: Cosmo Chou <cosmo.chou@quantatw.com>

show more ...


# b2ae88b4 12-Sep-2023 cchoux <cosmo.chou@quantatw.com>

support specifying MB FRU eeprom path

The MB FRUID should be exposed with ID 0 for BIOS to get the data to
fill out SMBIOS table during POST. However, current IDs depend on the
ordering of the FruDe

support specifying MB FRU eeprom path

The MB FRUID should be exposed with ID 0 for BIOS to get the data to
fill out SMBIOS table during POST. However, current IDs depend on the
ordering of the FruDevice object paths.

(1) Using the object with "Type: EEPROM" and "Name: MB FRU" in the
EntityManager to figure out the MB FRU eeprom path. Other FRUIDs still
depend on the ordering of the FruDevice object paths.

example of the entity-manager config:
```
{
"Address": "$address",
"Bus": "$bus",
"Name": "MB FRU",
"Type": "EEPROM"
},
```

(2) For System GUID that BIOS populates into SMBIOS table during POST,
also use the MB FRU eeprom path instead of the hardcoding eeprom path.

Change-Id: If950c471f92b99180bab1a629d56d3a912d3b5f4
Signed-off-by: Cosmo Chou <cosmo.chou@quantatw.com>

show more ...


# 4de58763 01-Sep-2023 Potin Lai <potin.lai@quantatw.com>

storagecommands: Extended I2C bus size to 16-bit

The entity-manager and phosphor-host-ipmid changed the D-Bus signature
of the I2C bus number variable from 8-bit to 16-bit.

This commit extented bus

storagecommands: Extended I2C bus size to 16-bit

The entity-manager and phosphor-host-ipmid changed the D-Bus signature
of the I2C bus number variable from 8-bit to 16-bit.

This commit extented bus size to 16-bit to fix signature mismatch.

Signed-off-by: Potin Lai <potin.lai@quantatw.com>
Change-Id: I37d229bc19b59817ce39ac22d81ef8776feaf8cc

show more ...


# 2405ae98 10-May-2023 Patrick Williams <patrick@stwcx.xyz>

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: Id3ff2ed97fd733b2bbfe6e4890c2e6dd8c212085
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...


# 2ca4aa0e 01-Feb-2023 Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>

usb-dbg: Support sensor out of threshold message present

Description:
- Modified sensors config for greatlakes platform those currently supported.
- Support OCP debug card sensor frame threshold m

usb-dbg: Support sensor out of threshold message present

Description:
- Modified sensors config for greatlakes platform those currently supported.
- Support OCP debug card sensor frame threshold message shown when sensor value is out of threshold.
e.g “P0_temp XXC/UCR”
- Support OCP debug card screen blink and invert the color if the sensor out of threshold.

Test Case:
Sensor threshold message should be shown on debug card when the sensor value is out of threshold.

Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>
Change-Id: I894b50bee33ad84abc07c5aa086fe1b798b7079b

show more ...


# 8ee95d69 20-Dec-2022 Potin Lai <potin.lai@quantatw.com>

storagecommands: fix getSensorMap() error

The CriSensor frame display wrong sensor value due to
GetManagedObjects method call failed in getSensorMap().

Parsing correct path to avoid GetManagedObjec

storagecommands: fix getSensorMap() error

The CriSensor frame display wrong sensor value due to
GetManagedObjects method call failed in getSensorMap().

Parsing correct path to avoid GetManagedObjects call failed.

Tested on Bletchley.

Signed-off-by: Potin Lai <potin.lai@quantatw.com>
Change-Id: I2fd57d61105f3a6619204be9c93a1db316cb83f7

show more ...


# cd315e07 22-Jul-2022 Patrick Williams <patrick@stwcx.xyz>

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I5763a3249f5c8baba800cf5886cb0df4d6b21e58

show more ...


# e39f9393 15-Jun-2022 Willy Tu <wltu@google.com>

build: Convert project to meson and C++20

Cleanedup all build warnings and updated the header to point to the
latest ipmid.

Change-Id: Ife89b51cda0137c8632fc24525efc131817e07b8
Signed-off-by: Willy

build: Convert project to meson and C++20

Cleanedup all build warnings and updated the header to point to the
latest ipmid.

Change-Id: Ife89b51cda0137c8632fc24525efc131817e07b8
Signed-off-by: Willy Tu <wltu@google.com>

show more ...


# 35d12546 06-Oct-2021 Patrick Williams <patrick@stwcx.xyz>

catch exceptions as const

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ia4086e77ad205e9a6a73a6ca570036818e3069fe


# 17cf1349 02-Nov-2020 Vijay Khemka <vijaykhemka@fb.com>

Add fru get area info command

Added fru get area info command which is required for "ipmi fru"
command. Earlier it was supported through ipmid but with latest
change in ipmid supporting only phospho

Add fru get area info command

Added fru get area info command which is required for "ipmi fru"
command. Earlier it was supported through ipmid but with latest
change in ipmid supporting only phosphor-fru, needed to add this
command here.

I would prefer to add entity manager fru support including this
command in phosphor-ipmid which is the best way.

Tested: verified using "ipmi fru" command

Change-Id: I0adff8caa89efc9c30dc8ae17ba91d1e325ba925
Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>

show more ...


# 63c99be4 27-May-2020 Vijay Khemka <vijaykhemka@fb.com>

Update to clang 10

Change code style to clang 10.

Change-Id: I42b0819bbeaf9dc68a99065d2df0e6ceb2eeedd0
Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>


# ef0efbc4 13-May-2020 Patrick Williams <patrick@stwcx.xyz>

sdbusplus: remove deprecated variant_ns

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Id44aa42872ecddf18bf75db92369681942dfbc5c


# 58bd5d84 13-Dec-2019 Vijay Khemka <vijaykhemka@fb.com>

Add critical sensor units to lcd display

Get sensor type from path and add its unit to output
on debug card LCD display.

Tested: verified with lcd debug card screen.

Change-Id: I7caf7d7b58d2566261

Add critical sensor units to lcd display

Get sensor type from path and add its unit to output
on debug card LCD display.

Tested: verified with lcd debug card screen.

Change-Id: I7caf7d7b58d25662614ee38b1c84d5d32808d2f3
Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>

show more ...


# 427b2762 12-Dec-2019 Vijay Khemka <vijaykhemka@fb.com>

Add support for debug card critical sensors

List of critical sensors read from json file cri_sensors.json
and its name along with current values will be displayed on
debug card screen.

Tested: veri

Add support for debug card critical sensors

List of critical sensors read from json file cri_sensors.json
and its name along with current values will be displayed on
debug card screen.

Tested: verified with lcd debug card screen.

Change-Id: I1c7968b1d57efa9bf5e4cf8c7396fbeecbfbfd3a
Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>

show more ...


# 1b6fae3f 25-Mar-2019 Vijay Khemka <vijaykhemka@fb.com>

Removing utils.cpp

Removed utils.cpp and using it from libipmid, Also updated
as per new ipmid code.

Change-Id: Ife5241104c7c093a9f3125a7c56b1c67fa203d97
Signed-off-by: Vijay Khemka <vijaykhemka@fb

Removing utils.cpp

Removed utils.cpp and using it from libipmid, Also updated
as per new ipmid code.

Change-Id: Ife5241104c7c093a9f3125a7c56b1c67fa203d97
Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>

show more ...


# e7d23d0e 08-Mar-2019 Vijay Khemka <vijaykhemka@fb.com>

Adding FB OEM commands

Added Facebook OEM IPMI commands for Host as welll as IPMB with
ME and debug card

Change-Id: I794b0a293bec1416ca409e8a269cd34b81c592a8
Signed-off-by: Vijay Khemka <vijaykhemk

Adding FB OEM commands

Added Facebook OEM IPMI commands for Host as welll as IPMB with
ME and debug card

Change-Id: I794b0a293bec1416ca409e8a269cd34b81c592a8
Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>

show more ...