meson: use phosphor-logging for debug statements

There is no need to individually patch each file to enable debug
logging.

All the different definitions of 'bool debug' are removed in favor of
usin

meson: use phosphor-logging for debug statements

There is no need to individually patch each file to enable debug
logging.

All the different definitions of 'bool debug' are removed in favor of
using phosphor-logging.

Change-Id: Ia9a8ecfa4ea220f588d7cf2d291b14067e0391e7
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: Id49ad73c860533f4658c909e86d6dc8e1423efb4
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Update clang-tidy

Fix a bunch of minor issues, ignore others. We use a lot of global
variables. Enabling a check will hopefully make sure we don't add more.

Change-Id: Ie76053d4afc95a5372b70b2fb7

Update clang-tidy

Fix a bunch of minor issues, ignore others. We use a lot of global
variables. Enabling a check will hopefully make sure we don't add more.

Change-Id: Ie76053d4afc95a5372b70b2fb768be464468cec0
Signed-off-by: Ed Tanous <ed@tanous.net>

show more ...

Call linkMux after async buildDevice

linkMux is supposed to only be called after buildDevice returns
successfully, but the latter function may return success even when it
fails and retries asynchron

Call linkMux after async buildDevice

linkMux is supposed to only be called after buildDevice returns
successfully, but the latter function may return success even when it
fails and retries asynchronously. We need to move the linkMux call into
buildDevice to always be called at the right time.

Tested: Confirmed channel name links were created for a mux device.

Change-Id: I67657250e392e0db92e562eac130ca85e5a022e7
Signed-off-by: Jonathan Doman <jonathan.doman@intel.com>

show more ...

Update terminology used within repo

Change terms to more inclusive language. This update is only for
variables that are internal.

Change-Id: I91c44d1f9513c9a4ef52352d5842e1fe9e8f4f8d
Signed-off-by

Update terminology used within repo

Change terms to more inclusive language. This update is only for
variables that are internal.

Change-Id: I91c44d1f9513c9a4ef52352d5842e1fe9e8f4f8d
Signed-off-by: Matt Simmering <matthew.simmering@intel.com>

show more ...

Refactor unnecessary shared_ptr usage

No need to use shared_ptr for a uint64_t. Instead just use optional to
check whether it was loaded from the JSON.

For devices without a Bus+Address specified,

Refactor unnecessary shared_ptr usage

No need to use shared_ptr for a uint64_t. Instead just use optional to
check whether it was loaded from the JSON.

For devices without a Bus+Address specified, skip the deviceIsCreated()
check and 5x retry, since there is no point to that for non-I2C devices.

Tested: Confirmed EM still creates/probes an i2c device exposed in an
active config. For a test INA219 device exposed without an Address,
confirmed that the kernel error message (i2c i2c-x: new_device: Can't
parse I2C address) is only output once instead of 5 times.

Change-Id: Ib3778559235b19d9846b3bb973a795e82e37b123
Signed-off-by: Jonathan Doman <jonathan.doman@intel.com>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I07b444d4ae00b0fce52a846f2bff2e6b99fb971c
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Replace ExportTempate createsHWMon boolean with an enumeration type

The createsHWMon boolean in the ExportTemplate structure applies an
important initialization strategy for some I2C devies. When ne

Replace ExportTempate createsHWMon boolean with an enumeration type

The createsHWMon boolean in the ExportTemplate structure applies an
important initialization strategy for some I2C devies. When new I2C
devices are added to the map of potential I2C devices it is common for
entries to be copied, and pasted, without review of all of the
parameters.

This change is an attempt to reduce copy/paste errors. An enumeration
provides better guidance for initializing the new entry.

Tested:
Confirmed, during debug, the correct initialization path is taken
based upon the hasHWMonDir value.
Confirmed I2C entries are still initialized.

Change-Id: I9141e1875ee99bfe1e7abdc616fb5ea2446e40ba
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>

show more ...

Make clang-tidy changes

clang-tidy has a number of checks it recommends. These checks are
documented in the next commit, but make the code pass our coding
standard.

Tested:
Minor changes made by t

Make clang-tidy changes

clang-tidy has a number of checks it recommends. These checks are
documented in the next commit, but make the code pass our coding
standard.

Tested:
Minor changes made by the robot.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I6cfaab92211af9c4c1eccd981ba9fe7b8c523457

show more ...

overlay: Simplify path-checking in buildDevice

We know the path we're looking for, so we don't need to go into
directory reading and recursion to check if it's there, we can just do a
direct lookup

overlay: Simplify path-checking in buildDevice

We know the path we're looking for, so we don't need to go into
directory reading and recursion to check if it's there, we can just do a
direct lookup instead.

Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
Change-Id: Ica84ebc757fc990b1a2477f162008f0f36d937bd

show more ...

overlay: Simplify check/retry logic

deviceIsCreated() should know the value of 'createsHWMon' when
determining what path to check for, not 'retrying'. While changing that
in its caller (buildDevice

overlay: Simplify check/retry logic

deviceIsCreated() should know the value of 'createsHWMon' when
determining what path to check for, not 'retrying'. While changing that
in its caller (buildDevice()), make the logical flow more intuitive:
first check if it's already there, if not try to create it, and only
delete and retry if that doesn't take effect.

Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
Change-Id: I5c42581c4e862d1730ea0dcc63d0a039302a4af1

show more ...

overlay: Factor out deviceDirName() routine

Replace a couple open-coded instances of this pattern with a dedicated
function, and rename a variable in deviceIsCreate() to avoid potential
confusion be

overlay: Factor out deviceDirName() routine

Replace a couple open-coded instances of this pattern with a dedicated
function, and rename a variable in deviceIsCreate() to avoid potential
confusion between 'dirName' and 'directoryName'.

Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
Change-Id: Ib3bc2591ec996dda296b82e5fcc3dc1300878ff1

show more ...

overlay: Rename devicePath as busPath

It's the path to the sysfs directory representing an i2c bus, not a
device on that bus; let's name it to reflect that.

Signed-off-by: Zev Weiss <zev@bewilderbe

overlay: Rename devicePath as busPath

It's the path to the sysfs directory representing an i2c bus, not a
device on that bus; let's name it to reflect that.

Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
Change-Id: I1525f45cc2fd4a9690dc261fbe93ea734952057e

show more ...

overlay: Fix missing space in error message

Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
Change-Id: Ia950f27295166b65155df65aa998f4328c509279

treewide: comply with the OpenBMC style guidelines

The guidelines say cpp source code filenames should be lower_snake_case:
https://github.com/openbmc/docs/blob/master/cpp-style-and-conventions.md#f

treewide: comply with the OpenBMC style guidelines

The guidelines say cpp source code filenames should be lower_snake_case:
https://github.com/openbmc/docs/blob/master/cpp-style-and-conventions.md#files

Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Change-Id: Ia04017b0eb9a65ce1303af5b6dc36e730410fd91

show more ...