clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: I81aff1005be025ddb4405f384513c8e5e20bf6f4
Signed-off-by: Patrick Williams <p

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: I81aff1005be025ddb4405f384513c8e5e20bf6f4
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Apply misc-include-cleaner fixes

misc-include-cleaner seems to have found a lot more things all of a
sudden. Unclear why the result has changed, but we can just fix the
issues.

Tested: Clang-tidy

Apply misc-include-cleaner fixes

misc-include-cleaner seems to have found a lot more things all of a
sudden. Unclear why the result has changed, but we can just fix the
issues.

Tested: Clang-tidy now passes. Code compiles.

Change-Id: Iab045cc183f0daef663b4d5ac901200a42807987
Signed-off-by: Ed Tanous <etanous@nvidia.com>

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: Ib7af6345a7b9e858700bd81645fe87d9d7e9d0fb
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Add modernize-redundant-void-arg

Enable this check and fix the failures.

Change-Id: I89b13daf1161be40564367562bb9c8c0c459e1d0
Signed-off-by: Ed Tanous <ed@tanous.net>

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I73acd9daf41b52bcc3f6af9a1c38c5f162ae76b2
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Avoid thresholds vector update while iterating

new data is pushed on thresholds vector while it is being iterated.
vector insertion can resize vector length. Resize in vector cause
invalidation of i

Avoid thresholds vector update while iterating

new data is pushed on thresholds vector while it is being iterated.
vector insertion can resize vector length. Resize in vector cause
invalidation of iterators and further operation iterator is undefined
behaviour(i.e. crash).
Iterate through vector by indexing it from beginning to original size.

Tested:
No cashes were observed with thresholds vector iteration.

Change-Id: Idf1d017847fa77128922a38eb6e33e0fa5702f3d
Signed-off-by: Vikash Chandola <vikash.chandola@intel.com>

show more ...

Rename Sensor class variable

The name of the entity-manager D-Bus interface the sensor was created
from was stored in a variable called objectType. Rename that to
configInterface to make it obvious

Rename Sensor class variable

The name of the entity-manager D-Bus interface the sensor was created
from was stored in a variable called objectType. Rename that to
configInterface to make it obvious it's an interface name.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I5258ebf12c6aa565a6a2ea286cd2724fd54cf986

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I0d10afa582342818b9d90b168f6f39f71ce4e0f4
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
[AJ: regenerate using .clang-format from openbmc/docs@f44abd66eca8]
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

Deassert thresholds when sensor is unavailable

Some dbus-sensors applications allows you to specify "PowerState"
parameter for its sensors in the configarition. With this parameter
sensor is sampled

Deassert thresholds when sensor is unavailable

Some dbus-sensors applications allows you to specify "PowerState"
parameter for its sensors in the configarition. With this parameter
sensor is sampled/checked against its thresholds only if certain
system conditions are met.
Therefore if sensor becomes unavailable because of the "PowerState"
parameter, all its threshold states must be deasserted.

Tested: tested on the AMD DaytonaX CRB. It is a 2-socket board. For
the test only 1 CPU was installed. In this case voltage sensors that
measure voltages for CPU2 and configured with '"PowerState": "On"'
assert their thresholds when the system is powered on.
Before the patch even if the system is powered off after that, these
voltage sensors stay with the asserted thresholds. Because of that
webui will continue to displays these sensors with a 'Critical' status.
After the patch if system is powered off, the voltage sensors deasset
all their thresholds and the sensors correctly change their status to
'OK' in webui.

Change-Id: Id6a33f15c18ca7aa30e8c449ab9c9e239673dd1f
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

sensors: Align source structure away from anti-patterns

The anti-patterns document comments on source structure, specifically
on placing internal headers in a parallel subtree[1]. dbus-sensors is an

sensors: Align source structure away from anti-patterns

The anti-patterns document comments on source structure, specifically
on placing internal headers in a parallel subtree[1]. dbus-sensors is an
example of violating this anti-pattern, so fix it.

[1]: https://github.com/openbmc/docs/blob/master/anti-patterns.md#placing-internal-headers-in-a-parallel-subtree

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I50ecaddd53fa9c9b7a0441af9de5e60bd94e47c6

show more ...