sensorpaths: adjust case for 'utilization'

The path case 'Utilization' doesn't match the dbus specifications.
This issue was reported on Discord[1]. Change to lowercase to match
the rest of the pat

sensorpaths: adjust case for 'utilization'

The path case 'Utilization' doesn't match the dbus specifications.
This issue was reported on Discord[1]. Change to lowercase to match
the rest of the paths and the specifications.

[1]: https://discord.com/channels/775381525260664832/1187158775438778408/1298446074738118797

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I16cf1f9dc327cce0ea14b252f41c55eff73ead9a

show more ...

Enable misc-include-cleaner

Change-Id: I22099a0f95b2eb884dec7d95cee0bdd0c159fd1f
Signed-off-by: Ed Tanous <ed@tanous.net>

sensors: Align source structure away from anti-patterns

The anti-patterns document comments on source structure, specifically
on placing internal headers in a parallel subtree[1]. dbus-sensors is an

sensors: Align source structure away from anti-patterns

The anti-patterns document comments on source structure, specifically
on placing internal headers in a parallel subtree[1]. dbus-sensors is an
example of violating this anti-pattern, so fix it.

[1]: https://github.com/openbmc/docs/blob/master/anti-patterns.md#placing-internal-headers-in-a-parallel-subtree

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I50ecaddd53fa9c9b7a0441af9de5e60bd94e47c6

show more ...

Update link to the Value.interface.yaml

Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
Change-Id: I95b1db1f07612a3e5604bbf043cc00f731bd3a8c

Fixes Units for Temperature & Pressure for Hwmon

For pressure the units are Pascals and was missing in SensorPaths.cpp
Also changed to align with the rest of dbus-sensors and set units
as sensor_pat

Fixes Units for Temperature & Pressure for Hwmon

For pressure the units are Pascals and was missing in SensorPaths.cpp
Also changed to align with the rest of dbus-sensors and set units
as sensor_paths::unitDegreesC and sensor_paths::unitPascals instead
of literal string constants.

Tested: on Everest's Storm King Op Panels with busctl introspect \
--no-pager xyz.openbmc_project.HwmonTempSensor /xyz/openbmc_project/\
sensors/temperature/Ambient_1_Temp and with
busctl introspect --no-pager xyz.openbmc_project.HwmonTempSensor \
/xyz/openbmc_project/sensors/pressure/Station_Pressure
the .Unit fields are now align with the rest of dbus-sensors

Signed-off-by: Bruce Mitchell <bruce.mitchell@linux.vnet.ibm.com>
Change-Id: I46ce300d1f04e05c65196d69f6201db8ba266ad9

show more ...

Add Unit property to dbus interfaces

Previously, the lack of the Unit property on the Value interfaces
provided by dbus-sensors meant that readings from its sensors weren't
displayed in phosphor-web

Add Unit property to dbus interfaces

Previously, the lack of the Unit property on the Value interfaces
provided by dbus-sensors meant that readings from its sensors weren't
displayed in phosphor-webui/webui-vue. Here it's added as an extra
parameter to setInitialProperties, allowing sensors that handle multiple
types of data (e.g. IpmbSensor, PSUSensor) to determine the appropriate
string to pass once they've had time to determine that.

Tested: PSUSensor, ADCSensor, CPUSensor, TachSensor, and HwmonTempSensor
all have an appropriate Unit property available on dbus, and are
displayed in webui-vue.

Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
Change-Id: I5e6df74cc42d9fb84852c5bf3ea5d3b383a16cdc

show more ...

Fix bug in name escaping for PSUSensor

PSU sensor has a bug where if the name includes any invalid characters,
it crashes when attempting to launch. This is a problem, and very much
not expected be

Fix bug in name escaping for PSUSensor

PSU sensor has a bug where if the name includes any invalid characters,
it crashes when attempting to launch. This is a problem, and very much
not expected behavior.

The root cause of this is that PSU combine event is creating a dbus API
path from the object name, but neglects to escape it properly.

The previous method to escape this was inlined inside sensor.hpp, so
that has been promoted to a new utility function, escapeForDbus which
can return an escaped name string to use in paths.

Through the course of adding this to the sensors namespace and including
it, it turns out that "sensors" is overloaded, and including it causes
both compile time errors from the overloaded name, and link time errors
from the lack of "inline" on the utility methods. This commit also as a
matter of cleanup moves everything in SensorPaths.hpp into an
alternative file, SensorPaths.cpp, and includes that file in sensor
utils.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Id9ed915e7e0e13ee7bded67a785ab0fa58982ca8

show more ...