#
504af5a0 |
| 03-Feb-2025 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: update latest spec and reformat
Copy the latest format file from the docs repository and apply.
Change-Id: I2f0b9d0fb6e01ed36a2f34c750ba52de3b6d15d1 Signed-off-by: Patrick Williams <p
clang-format: update latest spec and reformat
Copy the latest format file from the docs repository and apply.
Change-Id: I2f0b9d0fb6e01ed36a2f34c750ba52de3b6d15d1 Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
#
d7857201 |
| 28-Jan-2025 |
Ed Tanous <etanous@nvidia.com> |
Fix includes
Clang-tidy misc-include-cleaner appears to now be enforcing significantly more headers than previously. That is overall a good thing, but forces us to fix some issues. This commit is
Fix includes
Clang-tidy misc-include-cleaner appears to now be enforcing significantly more headers than previously. That is overall a good thing, but forces us to fix some issues. This commit is largely just taking the clang-recommended fixes and checking them in. Subsequent patches will fix the more unique issues.
Note, that a number of new ignores are added into the .clang-tidy file. These can be cleaned up over time as they're understood. The majority are places where boost includes a impl/x.hpp and x.hpp, but expects you to use the later. include-cleaner opts for the impl, but it isn't clear why.
Change-Id: Id3fdd7ee6df6c33b2fd35626898523048dd51bfb Signed-off-by: Ed Tanous <etanous@nvidia.com> Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
#
3d66430a |
| 29-Jan-2025 |
Ed Tanous <etanous@nvidia.com> |
Move hostlogger utilities
clang-tidy misc-include-fixer tries to remove the log_services.hpp include from systems_logsevices_hostlogger.hpp file. This causes these two helper functions to go missin
Move hostlogger utilities
clang-tidy misc-include-fixer tries to remove the log_services.hpp include from systems_logsevices_hostlogger.hpp file. This causes these two helper functions to go missing.
These arguably should've been moved in 7945eeed0fe8f9c7bf07669294499ae0108da1d3 where we created this file, but the second best time to plant a tree is now, so move them.
Tested: Code compiles. No test harnesses for hostlogger.
Change-Id: Ic0693472deb6c3bd355f042a0105661fa0873dfe Signed-off-by: Ed Tanous <etanous@nvidia.com>
show more ...
|
#
40e9b92e |
| 10-Sep-2024 |
Ed Tanous <etanous@nvidia.com> |
Use SPDX identifiers
SPDX identifiers are simpler, and reduce the amount of cruft we have in code files. They are recommended by linux foundation, and therefore we should do as they allow.
This pa
Use SPDX identifiers
SPDX identifiers are simpler, and reduce the amount of cruft we have in code files. They are recommended by linux foundation, and therefore we should do as they allow.
This patchset does not intend to modify any intent on any existing copyrights or licenses, only to standardize their inclusion.
[1] https://www.linuxfoundation.org/blog/blog/copyright-notices-in-open-source-software-projects
Change-Id: I935c7c0156caa78fc368c929cebd0f068031e830 Signed-off-by: Ed Tanous <etanous@nvidia.com>
show more ...
|
#
3d45ef66 |
| 04-Sep-2024 |
Gunnar Mills <gmills@us.ibm.com> |
Fix getLogEntryCollection privilege
This is the LogEntryCollection, fix the privilege to reflect that. This doesn't do anything since both are privilegeSetLogin. [1][2].
[1]: https://github.com/ope
Fix getLogEntryCollection privilege
This is the LogEntryCollection, fix the privilege to reflect that. This doesn't do anything since both are privilegeSetLogin. [1][2].
[1]: https://github.com/openbmc/bmcweb/blob/d193e0082c3fc7d4f4c34dd5fa86e95c036c938d/redfish-core/include/registries/privilege_registry.hpp#L906 [2]: https://github.com/openbmc/bmcweb/blob/d193e0082c3fc7d4f4c34dd5fa86e95c036c938d/redfish-core/include/registries/privilege_registry.hpp#L898
Found in review on https://gerrit.openbmc.org/c/openbmc/bmcweb/+/74274/4
Tested: None. Inspection only.
Change-Id: I1c6f80fe5260a38f4acda31ea43a344d9bc89857 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
#
7945eeed |
| 03-Sep-2024 |
Ed Tanous <etanous@nvidia.com> |
Break out host logger into methods
Similar to what we've done elsewhere, break out hostlogger into methods rather than long lambdas.
Tested: Code compiles
Change-Id: I34e31fc92782e98750e475bb6175c
Break out host logger into methods
Similar to what we've done elsewhere, break out hostlogger into methods rather than long lambdas.
Tested: Code compiles
Change-Id: I34e31fc92782e98750e475bb6175c8ea4b665b9f Signed-off-by: Ed Tanous <etanous@nvidia.com>
show more ...
|
#
e21126ec |
| 03-Sep-2024 |
Ed Tanous <etanous@nvidia.com> |
Break out hostlogger
Similar to what we've done elsewhere, break out hostlogger into its own file.
Tested: Code compiles.
Change-Id: Ib9a48577878f57eb7ed4e3cf6b84a58a3ec203f6 Signed-off-by: Ed Tan
Break out hostlogger
Similar to what we've done elsewhere, break out hostlogger into its own file.
Tested: Code compiles.
Change-Id: Ib9a48577878f57eb7ed4e3cf6b84a58a3ec203f6 Signed-off-by: Ed Tanous <etanous@nvidia.com>
show more ...
|