Searched hist:"1899 c111" (Results 1 – 2 of 2) sorted by relevance
/openbmc/linux/drivers/net/ethernet/sfc/ |
H A D | nic.c | 1899c111 Wed May 22 12:03:35 CDT 2013 Ben Hutchings <bhutchings@solarflare.com> sfc: Fix IRQ cleanup in case of a probe failure
The lifetime of an irq_cpu_rmap is odd: we have to allocate it before installing IRQ handlers and free it before removing the IRQ handlers. As a result of this asymmetry, it was omitted from some failure paths.
On another failure path, we could try to remove IRQ handlers we had not yet installed.
Move the irq_cpu_rmap allocation and freeing alongside IRQ handler installation and removal, in efx_nic_{init,fini}_interrupts(). Count the number of IRQ handlers successfully installed and only remove those on the failure path.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com> 1899c111 Wed May 22 12:03:35 CDT 2013 Ben Hutchings <bhutchings@solarflare.com> sfc: Fix IRQ cleanup in case of a probe failure The lifetime of an irq_cpu_rmap is odd: we have to allocate it before installing IRQ handlers and free it before removing the IRQ handlers. As a result of this asymmetry, it was omitted from some failure paths. On another failure path, we could try to remove IRQ handlers we had not yet installed. Move the irq_cpu_rmap allocation and freeing alongside IRQ handler installation and removal, in efx_nic_{init,fini}_interrupts(). Count the number of IRQ handlers successfully installed and only remove those on the failure path. Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
|
H A D | efx.c | 1899c111 Wed May 22 12:03:35 CDT 2013 Ben Hutchings <bhutchings@solarflare.com> sfc: Fix IRQ cleanup in case of a probe failure
The lifetime of an irq_cpu_rmap is odd: we have to allocate it before installing IRQ handlers and free it before removing the IRQ handlers. As a result of this asymmetry, it was omitted from some failure paths.
On another failure path, we could try to remove IRQ handlers we had not yet installed.
Move the irq_cpu_rmap allocation and freeing alongside IRQ handler installation and removal, in efx_nic_{init,fini}_interrupts(). Count the number of IRQ handlers successfully installed and only remove those on the failure path.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com> 1899c111 Wed May 22 12:03:35 CDT 2013 Ben Hutchings <bhutchings@solarflare.com> sfc: Fix IRQ cleanup in case of a probe failure The lifetime of an irq_cpu_rmap is odd: we have to allocate it before installing IRQ handlers and free it before removing the IRQ handlers. As a result of this asymmetry, it was omitted from some failure paths. On another failure path, we could try to remove IRQ handlers we had not yet installed. Move the irq_cpu_rmap allocation and freeing alongside IRQ handler installation and removal, in efx_nic_{init,fini}_interrupts(). Count the number of IRQ handlers successfully installed and only remove those on the failure path. Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
|