clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: Iee5e9ffc9cdaefb7db5577a9c422c1e9646253f2
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: Id1ca559acc1ae45b4605a1bb9d74ef3d7e5aa1c5
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: Ia0723b61eb4d30a47e69de0fb3f8de9256e56f83
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

fix GCC 13 issues

The latest version of GCC raises two issues:

- cstdint is not included automatically as often so we need to
explicitly include it whenever using `uint*` class types.

fix GCC 13 issues

The latest version of GCC raises two issues:

- cstdint is not included automatically as often so we need to
explicitly include it whenever using `uint*` class types.

- Certain move operations are detected as unnecessary and subverting
RVO.

Fix both of these issues.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I4124c91c8e5cce3b85a6284d3cc8dfc2a8494a76

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I3edadffec0ea11e0a52d9b060167e9a9a38f1972
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic0fe1ed7e19cf114b8666d49d4d670c7d9ec595d

show more ...

clang-format: update to latest version

Pick up latest .clang-format file from the docs repository.
Fix formatting on all files.
Minor compile fixes due to GCC10 and sdbusplus changes.

Signed-off-by

clang-format: update to latest version

Pick up latest .clang-format file from the docs repository.
Fix formatting on all files.
Minor compile fixes due to GCC10 and sdbusplus changes.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie1f7a4e59b6cf015310effef50d558ff59731024

show more ...

sdbusplus: replace message::variant with std::variant

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I664c4982aa03664728d7375d78dfae6e595c2d20

sdbusplus: remove deprecated variant_ns

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I3c785d33984b7c3af8671432c194db34be360b52

build: drop autotools

With previously added support for building with meson/ninja autotools
support is no longer required.

Change-Id: I80654ada9d099a57447ded73da71f39293cd2f0a
Signed-off-by: Brad B

build: drop autotools

With previously added support for building with meson/ninja autotools
support is no longer required.

Change-Id: I80654ada9d099a57447ded73da71f39293cd2f0a
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

build: add support for building with meson

Follow the OpenBMC herd and support a more modern, more comprehensible,
more performant build framework.

To build using meson:
meson build
ninja -C bu

build: add support for building with meson

Follow the OpenBMC herd and support a more modern, more comprehensible,
more performant build framework.

To build using meson:
meson build
ninja -C build
ninja -C build install

Maintained support for:
Configurable dbus parameters:
INPUT_HISTORY_BUSNAME_ROOT= -> -Dinput-history-busname-root=
INPUT_HISTORY_SENSOR_ROOT = -> -Dinput-history-sensor-root=
UCD90160 support:
UCD90160_DEF_YAML_FILE= -> -Ducd90160-yaml=
--enable-turn-off-ucd90160-access = -> -Ducd90160-access=

Added -Dtests to match de-facto OpenBMC meson usage conventions.

Dropped UCD90160_DEF_OUTPUT_DIR. Much like the destination of
intermediate artifacts like object files are not configurable, the
location of the generated UCD definition file should not be configurable
either.

Dropped support for --enable-oe-sdk rpath munging. This was a
workaround for broken oe sdks that don't figure out the correct rpath
when running make check or ninja test.

Tested by building with both meson and autotools and then compared build
artifacts from each build system:
generated source code is the same
generated binaries have the same symbols

Ran existing unit tests (which passed) using ninja test.

Change-Id: Iac80ba1fe5c2d01abe0e0a95e0bec03b8b828ef5
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

Power supply input faults resolution

If the AC power is plugged in when the system is totally off,
psu-monitor doesn't get to resolve errors because it can not see their
states change from faulted t

Power supply input faults resolution

If the AC power is plugged in when the system is totally off,
psu-monitor doesn't get to resolve errors because it can not see their
states change from faulted to not faulted.

Tested:

Physically cut off power and reapplied it to check for any incorrect LED
indications for the power supply. Checked error logs to make sure input
power faults were resolved.

Signed-off-by: Aatir Manzur <aatrapps@gmail.com>
Change-Id: I893b67fabc9075fdd0ea3ae3a2912bc443cbadf8

show more ...

Fix association path when resolving input faults

When the C++ object mapper replaced the original python one, it
changed the name of the association interface. Update this code
to match that.

Test

Fix association path when resolving input faults

When the C++ object mapper replaced the original python one, it
changed the name of the association interface. Update this code
to match that.

Tested: Input faults can now be resolved.

Change-Id: Idd0f355de82cc2b18399a50c24f28b20c9e2902f
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Remove the witherspoon prefix from the PSU monitor

The Swift system is a follow-on to the Witherspoon system. The plan is
to re-use the power supply monitor application on Swift, while
continuing to

Remove the witherspoon prefix from the PSU monitor

The Swift system is a follow-on to the Witherspoon system. The plan is
to re-use the power supply monitor application on Swift, while
continuing to work on Witherspoon systems. Removing the witherspoon
prefix from the app to avoid confusion.

Tested: Built and flashed image to Witherspoon system. Verified power
sequencer and power supply monitor logged errors via 'obmcutil
chassiskill' command.

Change-Id: I4c7275c3b14b3b3724abb98b8d43610df4f9c2a3
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>

show more ...

build: install into bin instead of sbin

Installs into bin instead of sbin per guidelines.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Id782714cdf6f8345330ba1cf241c615be8256bbf

power_supply: Fix duplicate variant value

mapbox::variant is fine with having a variant contain duplicate types.
However std::variant thrips a static assert if you duplicate the types
contained in t

power_supply: Fix duplicate variant value

mapbox::variant is fine with having a variant contain duplicate types.
However std::variant thrips a static assert if you duplicate the types
contained in the variant. This is just a refactor that will not affect
behavior.

Tested:
Compiled and run through unit tests.

Change-Id: I99628f8f520ff58df35eee1d51772b0e93f2d9fd
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Remove unused is_method_error calls

According to
https://lists.ozlabs.org/pipermail/openbmc/2018-October/013696.html,
message::is_method_error() will never fail and it doesn't need to
be called anym

Remove unused is_method_error calls

According to
https://lists.ozlabs.org/pipermail/openbmc/2018-October/013696.html,
message::is_method_error() will never fail and it doesn't need to
be called anymore.

Change-Id: I3199c201a3d89c90ff61484018846d9edca48eec
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Start using .clang-format

Used the one from docs/style/cpp.

Change-Id: I3bdc2b353bf18a437266b362d8205b8463a9ce2b
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

timer: Remove in favor of sdeventplus/timer

This change removes the ad-hoc timer implementation and uses the common
one that comes with sdeventplus.

Tested: Compiled

Change-Id: Id3b7e464a472a74217

timer: Remove in favor of sdeventplus/timer

This change removes the ad-hoc timer implementation and uses the common
one that comes with sdeventplus.

Tested: Compiled

Change-Id: Id3b7e464a472a7421785601634af58f681ebd3a6
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

event: Remove in favor of sdeventplus

Use the new library provided to all openbmc projects instead of rolling
our own managed pointer.

Tested: Compiled

Change-Id: I4993d4340e0e0aa5898e73ef815baa81

event: Remove in favor of sdeventplus

Use the new library provided to all openbmc projects instead of rolling
our own managed pointer.

Tested: Compiled

Change-Id: I4993d4340e0e0aa5898e73ef815baa81b0e8a2bc
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: I8af78

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: I8af789c1e0fef9938baced40315b525199636601
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Use s.c_str() in log messages

Partly Resolves openbmc/openbmc 2905

Tested: static_assert only

Change-Id: Ic5ca81bd4367d7ca8023bb791b74b938f6f2b68e
Signed-off-by: Joseph Reynolds <jrey@us.ibm.com>

Skip other fault checks if inputFault count bump

If an input fault was seen and we have started bumping the counter, do
not bother checking the other faults that occur while power is supposed
to be

Skip other fault checks if inputFault count bump

If an input fault was seen and we have started bumping the counter, do
not bother checking the other faults that occur while power is supposed
to be on. The power good will be de-asserted, than fans will likely
start spinning down, we cannot have an input over-current with no input
current, etc.

Resolves: openbmc/openbmc#2873

Change-Id: Ic8a14cbd0472229b618f63c9e829bc5468d44100
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>

show more ...

Clear powerOnFault when inputFault cleared

The de-glitch counting for powerOnFault (ShouldBeOnFault) will stop when
a fault is found. The flag indicating a fault is found will be set if an
input fau

Clear powerOnFault when inputFault cleared

The de-glitch counting for powerOnFault (ShouldBeOnFault) will stop when
a fault is found. The flag indicating a fault is found will be set if an
input fault is found. This also de-asserts Power_Good# and sets
UNIT_IS_OFF. The power supply cannot be on and have Power_Good# asserted
if it has an input fault. Clear the powerOnFault when inputFault is
cleared in order to reset the de-glitch to match up with the power on
delay.

Change-Id: I31f9db41077d89ebec01908eb916974102635c87
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>

show more ...

Only log input fault error when power is on

If the system power is on and a INPUT or VIN_UV fault is detected, log
an error with the appropriate metadata. If the power is off, just put an
informatio

Only log input fault error when power is on

If the system power is on and a INPUT or VIN_UV fault is detected, log
an error with the appropriate metadata. If the power is off, just put an
informational message in the journal.

Resolves: openbmc/openbmc#2771

Change-Id: I1e30177e9f1f4d44a8b9cc1af9ef064d3eb37be4
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>

show more ...