clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: Iee5e9ffc9cdaefb7db5577a9c422c1e9646253f2
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I3edadffec0ea11e0a52d9b060167e9a9a38f1972
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

Change-Id: Ic70a9bbc0d86851d5c9885e9be891545b27628b4
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

python: fix flake8 warnings and format with black

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9ef346717ca33a27172c6de10bab1de98ead0546

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic0fe1ed7e19cf114b8666d49d4d670c7d9ec595d

show more ...

clang-format: update to latest version

Pick up latest .clang-format file from the docs repository.
Fix formatting on all files.
Minor compile fixes due to GCC10 and sdbusplus changes.

Signed-off-by

clang-format: update to latest version

Pick up latest .clang-format file from the docs repository.
Fix formatting on all files.
Minor compile fixes due to GCC10 and sdbusplus changes.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie1f7a4e59b6cf015310effef50d558ff59731024

show more ...

migrate to python3

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If5f169a06a86ab09d053651fc3f54e45378f91eb

build: drop autotools

With previously added support for building with meson/ninja autotools
support is no longer required.

Change-Id: I80654ada9d099a57447ded73da71f39293cd2f0a
Signed-off-by: Brad B

build: drop autotools

With previously added support for building with meson/ninja autotools
support is no longer required.

Change-Id: I80654ada9d099a57447ded73da71f39293cd2f0a
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

build: add support for building with meson

Follow the OpenBMC herd and support a more modern, more comprehensible,
more performant build framework.

To build using meson:
meson build
ninja -C bu

build: add support for building with meson

Follow the OpenBMC herd and support a more modern, more comprehensible,
more performant build framework.

To build using meson:
meson build
ninja -C build
ninja -C build install

Maintained support for:
Configurable dbus parameters:
INPUT_HISTORY_BUSNAME_ROOT= -> -Dinput-history-busname-root=
INPUT_HISTORY_SENSOR_ROOT = -> -Dinput-history-sensor-root=
UCD90160 support:
UCD90160_DEF_YAML_FILE= -> -Ducd90160-yaml=
--enable-turn-off-ucd90160-access = -> -Ducd90160-access=

Added -Dtests to match de-facto OpenBMC meson usage conventions.

Dropped UCD90160_DEF_OUTPUT_DIR. Much like the destination of
intermediate artifacts like object files are not configurable, the
location of the generated UCD definition file should not be configurable
either.

Dropped support for --enable-oe-sdk rpath munging. This was a
workaround for broken oe sdks that don't figure out the correct rpath
when running make check or ninja test.

Tested by building with both meson and autotools and then compared build
artifacts from each build system:
generated source code is the same
generated binaries have the same symbols

Ran existing unit tests (which passed) using ninja test.

Change-Id: Iac80ba1fe5c2d01abe0e0a95e0bec03b8b828ef5
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

build: fix some warnings

Fix a couple of warnings:

-Werror=unused-parameter
-Werror=non-virtual-dtor

so we can use meson's warning_level=3 and -Werror without build
failures.

Change-Id: Id3c15c2f

build: fix some warnings

Fix a couple of warnings:

-Werror=unused-parameter
-Werror=non-virtual-dtor

so we can use meson's warning_level=3 and -Werror without build
failures.

Change-Id: Id3c15c2fee70799bee98a8d2890c33ab5ebfd563
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

Don't try to read GPIOs when no device path

For certain PGOOD faults, the code may try to read a GPIO off of an IO
expander to further isolate the error. If there was a problem with the
device driv

Don't try to read GPIOs when no device path

For certain PGOOD faults, the code may try to read a GPIO off of an IO
expander to further isolate the error. If there was a problem with the
device driver detecting that IO expander, then the code was running down
a path where it would still try to read that IO expander, but using an
empty device path which would just generate extra error traces in the
journal. Avoid this by checking for this empty path and then not
reading those GPIOs.

Change-Id: I40a3e0c13e392fa58d87f53c8911eb96c9cd7f2c
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Add YAML and error function for MEM_GOODx faults

Add a section to the error and metadata YAML files for the MEM_GOODx
faults. Use that to update/generate a new elog-errors.hpp include file.

Update

Add YAML and error function for MEM_GOODx faults

Add a section to the error and metadata YAML files for the MEM_GOODx
faults. Use that to update/generate a new elog-errors.hpp include file.

Update the power sequencer source to have a memGoodFault function for
handling callouts for MEM_GOODx type errors.

Change-Id: Ia08dc88f29f00f749e7995f97f37647b02135a2b
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>

show more ...

Update to get GPIOAnalysis from parsing YAML

Change-Id: I54958ce49496464e601ff9c6f2b081ee8d2c07be
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>

Update to get GPIConfigs from parsing YAML

Change-Id: Ie7b905761ece27bd19a9f0e6e0a7eeb9434fdd3a
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>

Update to get RailNames from parsing YAML

Change-Id: Ibcecb592fb4ef61efe5d8ba32bef8af0f979dc98
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>

Update script and template to parse index and path

Change-Id: Ibe4ce9aa9f16c915934c44c49337b30e2ea4b67b
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>

Fill in example YAML file based on Witherspoon

Change-Id: Ib42605a551f5a0c8c61e5aaf71f05e54da2cb7e4
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>

Use YAML for UCD definitions

Use a Python script to generate the UCD power sequencer information
needed for the pseq-monitor application.

Change-Id: I51f4b61bb4f22705584b73ba599b517780fa9adc
Signed

Use YAML for UCD definitions

Use a Python script to generate the UCD power sequencer information
needed for the pseq-monitor application.

Change-Id: I51f4b61bb4f22705584b73ba599b517780fa9adc
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>

show more ...

Cleanup: Use filesystem instead of experimental

The GCC version bump in Yocto 2.6 allows for use of std::filesystem
instead of std::experimental::filesystem.

Change-Id: Ibfd6c285bcbd6695e5cd4e3090f

Cleanup: Use filesystem instead of experimental

The GCC version bump in Yocto 2.6 allows for use of std::filesystem
instead of std::experimental::filesystem.

Change-Id: Ibfd6c285bcbd6695e5cd4e3090ffa214fc861499
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>

show more ...

Remove witherspoon prefix from power sequencer app

The Swift system is a follow-on system very similar to the Witherspoon.
The plan is to re-use this application for Swift, while continuing to
suppo

Remove witherspoon prefix from power sequencer app

The Swift system is a follow-on system very similar to the Witherspoon.
The plan is to re-use this application for Swift, while continuing to
support Witherspoon, without the confusion of having a witherspoon
executable/app on a Swift system.

Tested: Built and flashed image to Witherspoon system. Verified process
running, powered on, and verified faults logged by executing 'obmcutil
chassiskill'.

Change-Id: I32f2c67d12d4a6038b19f6a02cd7de5166f1d1f8
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>

show more ...

build: install into bin instead of sbin

Installs into bin instead of sbin per guidelines.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Id782714cdf6f8345330ba1cf241c615be8256bbf

Fix I2C dev path for the 5.0 kernel

In the 5.0 Linux kernel, an I2C device path segment changed:
i2c@1e78a000 -> bus@1e78a000

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I7ad726

Fix I2C dev path for the 5.0 kernel

In the 5.0 Linux kernel, an I2C device path segment changed:
i2c@1e78a000 -> bus@1e78a000

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I7ad7262812de3792dbae85b6f252ec6cbbdc333e

show more ...

Start using .clang-format

Used the one from docs/style/cpp.

Change-Id: I3bdc2b353bf18a437266b362d8205b8463a9ce2b
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

timer: Remove in favor of sdeventplus/timer

This change removes the ad-hoc timer implementation and uses the common
one that comes with sdeventplus.

Tested: Compiled

Change-Id: Id3b7e464a472a74217

timer: Remove in favor of sdeventplus/timer

This change removes the ad-hoc timer implementation and uses the common
one that comes with sdeventplus.

Tested: Compiled

Change-Id: Id3b7e464a472a7421785601634af58f681ebd3a6
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

event: Remove in favor of sdeventplus

Use the new library provided to all openbmc projects instead of rolling
our own managed pointer.

Tested: Compiled

Change-Id: I4993d4340e0e0aa5898e73ef815baa81

event: Remove in favor of sdeventplus

Use the new library provided to all openbmc projects instead of rolling
our own managed pointer.

Tested: Compiled

Change-Id: I4993d4340e0e0aa5898e73ef815baa81b0e8a2bc
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...