7d6b44cb | 23-Mar-2024 |
Ed Tanous <ed@tanous.net> |
Upgrade vue3 and all dependencies
Start the process of porting everything to Vue 3. I have most things working. npm run-scripts build works, npm install works. prettier passes. Styles load, logi
Upgrade vue3 and all dependencies
Start the process of porting everything to Vue 3. I have most things working. npm run-scripts build works, npm install works. prettier passes. Styles load, login works, webui loads.
This was primarily done using the linked documents below. It makes the following design decisions: 1. Vue is put in compat 2 mode, which allows most of the components to work as-is. 2. Bootstrap v4 is used along with bootstrap-vue to keep our components working. 3. Minor changes are made to load the latest versions of vue-router, vuex, and vue-i18n.
I suspect this patchset is good enough to start with, and we can clean up the broken things one patchset at a time. The things that need to happen are:
1. Get remaining features working again. This primiarily is vue-i18n for mixins, and non vue components. This likely needs to be done by not pulling in i18n into the non vue components, then using the .Vue files to do the internationalization in the component context, NOT in the mixin context. Alternatively, we could drop MixIns alltogether. 2. Get custom styles working again. Previously, we used some path hackery in vue.config.js to optionally pre-load styles. This stops working now that we're required to @import our modules. Likely we need some rearangement of the paths such that custom styles are a complete replacement (possibly importing the original) rather than additive with overrides. That's a guess, but I don't really see anyone else doing customization the way we've defined it here. 3. Bootstrap 5 no longer requires ANY custom vue modules, as it has dropped the jquery dependency. We won't be able to pull in bootstrap 5 all at once, so pull in bootstrap 5 under an alias, like "bootstrap5" that we can optionally import 5 or 4. 4. One at a time, start porting components over to Vue3 syntax and bootstrap 5. This will be the bulk of the manual work and review.
The only thing I think left is getting unit tests passing, which I commented out the pre-commit hook to make this PR.
Tested: Code builds. Needs better testing.
[1] https://router.vuejs.org/guide/migration/ [2] https://vue-i18n.intlify.dev/guide/migration/vue3 [3] https://vuelidate-next.netlify.app/migration_guide.html#package-name-and-imports
Change-Id: I5bb3187b9efbf2e4ff63e57994bc528756e2a981 Signed-off-by: Ed Tanous <ed@tanous.net>
show more ...
|
51abe87f | 20-Apr-2024 |
Ed Tanous <ed@tanous.net> |
Inline the header svg
Ideally we wouldn't have to pull down this file on every load, and we could just inline it. This commit implements inlining. Note, that this requires a minor modification to
Inline the header svg
Ideally we wouldn't have to pull down this file on every load, and we could just inline it. This commit implements inlining. Note, that this requires a minor modification to the unit test, as the inline header remains when unit tests are run. It's not clear at this time how to make inlining plugin operate on unit tests, but it doesn't seem terribly important.
Tested: Loading the webui no longer shows a download of logo-header
Change-Id: Iaa5be5b5a84e0ad6e1f430113f929032835c9f1c Signed-off-by: Ed Tanous <ed@tanous.net>
show more ...
|
665235c6 | 27-Feb-2024 |
Ed Tanous <ed@tanous.net> |
Add empty authentication module
New versions of vuex warn if there are modules that are used in an element that haven't had their namespace defined. This module isn't actually used in the test, so
Add empty authentication module
New versions of vuex warn if there are modules that are used in an element that haven't had their namespace defined. This module isn't actually used in the test, so add an empty Vuex module that matches the name of AuthenticationStore, so the test can pass.
Change-Id: I5bceb3e1e0bad603028cfb17fa95b020d68ceb4d Signed-off-by: Ed Tanous <ed@tanous.net>
show more ...
|
2f7f657d | 28-Feb-2024 |
Konstantin Aladyshev <aladyshev22@gmail.com> |
Correct AppNavigation snapshot to pass unit tests
The commit "Add SNMP alerts page and test hooks" (7c1cfe7e25957fc915fc9790bdf78887295b1fee) has added a new page to the navigation, but didn't chang
Correct AppNavigation snapshot to pass unit tests
The commit "Add SNMP alerts page and test hooks" (7c1cfe7e25957fc915fc9790bdf78887295b1fee) has added a new page to the navigation, but didn't change the shanpshot. As a result this broke the unit tests. Perform "npx jest --updateSnapshot" to automatically correct the AppNavigation snapshot.
Tested: Did npm run test:unit and it passed.
Change-Id: I9f9dbf235013d8736d958d5c8d19eb3d75c575ba Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com> Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
aeb19816 | 23-Nov-2022 |
Damian Celico <damianx.celico@intel.com> |
Added route restrictions based on user privilege
This commit allows us to add 'exclusiveToRoles' field to route config files, with the list of roles that can access this resource, if needed. In this
Added route restrictions based on user privilege
This commit allows us to add 'exclusiveToRoles' field to route config files, with the list of roles that can access this resource, if needed. In this case, only Administrator can access Virtual-Media page and SOL console, and it is blocked for other users.
Signed-off-by: Sivaprabu Ganesan <sivaprabug@ami.com> Change-Id: Ibcee18bd92d97c34414ecaf2caf6af28070c5538
show more ...
|
df8cf6ac | 14-Jun-2022 |
wangqi02 <wangqi02@inspur.com> |
Fix an undefined issue in UT
Change-Id: Id9bbacb752c142f712e4e5e752b74c5bac848d81 Signed-off-by: wangqi02 <wangqi02@inspur.com> |
05887b50 | 10-Jan-2022 |
Sandeepa Singh <sandeepa.singh@ibm.com> |
Add Key clear page under Operations section
This page will allow privileged user to clear encrypted keys. - Only admin and CE login user will be able to see the page - The UI will be different for b
Add Key clear page under Operations section
This page will allow privileged user to clear encrypted keys. - Only admin and CE login user will be able to see the page - The UI will be different for both, admin and CE login user(service) - This page is IBM only
Signed-off-by: Sandeepa Singh <sandeepa.singh@ibm.com> Change-Id: Ic6fe3454de815629a6b2250daa99ab21f2b316c3
show more ...
|
932aff93 | 26-Aug-2021 |
Derick Montague <derick.montague@ibm.com> |
Update login page layout
This update will:
- Change the positioning of the form to be on the left - Add the built on OpenBMC logo to the bottom right corner of the screen - Add the ability to inclu
Update login page layout
This update will:
- Change the positioning of the form to be on the left - Add the built on OpenBMC logo to the bottom right corner of the screen - Add the ability to include a GUI custom name using a .env variable. If the variable is not present, the login page will not include the <h1> section heading element. - Remove the word "logo" from the alt attribute for the company logo image used in the application header and on the login page.
Github story: https://github.com/openbmc/webui-vue/issues/63
Signed-off-by: Derick Montague <derick.montague@ibm.com> Change-Id: I83ac5aecff0b3858c3ab5f38ab1aaa603d59acf1
show more ...
|
4dd7eabf | 16-Aug-2021 |
Sukanya Pandey <sukapan1@in.ibm.com> |
Add system information on Appheader page
- Model type and serial number are newly added system info data on Appheader. - On small screens and below system information(model type, serial number and a
Add system information on Appheader page
- Model type and serial number are newly added system info data on Appheader. - On small screens and below system information(model type, serial number and asset tag) will be hidden. - On large screen and below model type and serial number will be visible but asset tag will be hidden. - For all other screens all the system info will be visible.
Signed-off-by: Sukanya Pandey <sukapan1@in.ibm.com> Change-Id: Ia844a26f658083cbd5fa9c8f3f6bea8b65ddcd11
show more ...
|
6dba4be6 | 28-Jul-2021 |
Sandeepa Singh <sandeepa.singh@ibm.com> |
IA update: Add resource management section
This is the sixth commit for information architecture changes and has the following changes:
- Resource management section has been added - Carbon icon us
IA update: Add resource management section
This is the sixth commit for information architecture changes and has the following changes:
- Resource management section has been added - Carbon icon used for resource management section is data--base--alt - Manage power usage page from operations has been moved to resource management - Manage power usage page has been updated to power page
Signed-off-by: Sandeepa Singh <sandeepa.singh@ibm.com> Change-Id: If3feb994dbad19dd6cfb1507d976d09643c8e4d6
show more ...
|
b440616c | 26-Jul-2021 |
Sandeepa Singh <sandeepa.singh@ibm.com> |
IA update: Update access and control section
This is the fifth commit of the information architecture changes and has the following changes:
- The icon for access and control has been updated - Acc
IA update: Update access and control section
This is the fifth commit of the information architecture changes and has the following changes:
- The icon for access and control has been updated - Access and control section has been updated to security and access section - Security settings page has been updated to policies page and moved to security and access section - Client sessions page has been updated to sessions page - Local user management page has been updated to user management page - SSL certificates page has been updated to certificates page
Signed-off-by: Sandeepa Singh <sandeepa.singh@ibm.com> Change-Id: Ie93cee9002742ecf7d33615636f4f159f4395fc4
show more ...
|
f67f769f | 19-Jul-2021 |
Sandeepa Singh <sandeepa.singh@ibm.com> |
IA update: Update configuration to settings
This is the fourth update to information architecture changes and has the following changes:
- The configuration section is updated to settings - The dat
IA update: Update configuration to settings
This is the fourth update to information architecture changes and has the following changes:
- The configuration section is updated to settings - The date and time settings page is updated to date and time - The network settings page is updated to network - The power restore policy page in operations section is moved to settings section
Signed-off-by: Sandeepa Singh <sandeepa.singh@ibm.com> Change-Id: I6f5ab25f5227530be430bd39a4d9629b3bf09d8b
show more ...
|
68cbbe90 | 14-Jul-2021 |
Sandeepa Singh <sandeepa.singh@ibm.com> |
IA update: Update control section to operations
This is the third update to the information architecture changes and has the following changes:
- The control section has been updated to operations
IA update: Update control section to operations
This is the third update to the information architecture changes and has the following changes:
- The control section has been updated to operations - The server led page has been removed - The firmware page is moved to operations section
Signed-off-by: Sandeepa Singh <sandeepa.singh@ibm.com> Change-Id: I2e23da447890d7bee51892e1f782d5f2db6dded4
show more ...
|
7affc529 | 06-Jul-2021 |
Sandeepa Singh <sandeepa.singh@ibm.com> |
IA update: Update health section
This is the second update to information architecture changes and has the following changes:
- Health section is updated to hardware status section - Hardware statu
IA update: Update health section
This is the second update to information architecture changes and has the following changes:
- Health section is updated to hardware status section - Hardware status page is updated to inventory and LEDs page - Route for sensors page has been updated
Signed-off-by: Sandeepa Singh <sandeepa.singh@ibm.com> Change-Id: Ia1ba3a15a243a00f59a2ec646132436eb355a999
show more ...
|
828dda9b | 28-Jun-2021 |
Derick Montague <derick.montague@ibm.com> |
IA update: Add logs and update overview icon
This is the first patchset of the information architecture changes. These changes are the result of several months of design research with users to impro
IA update: Add logs and update overview icon
This is the first patchset of the information architecture changes. These changes are the result of several months of design research with users to improve the existing information architecture (IA). More information can we found in the Github story.
This patchset will add a Logs section and move event logs and dumps from the Health section to the new Logs section. It will also update the icon used for the Overview page.
Github story: https://github.com/openbmc/webui-vue/issues/56
Testing: 1. IBM build: - Logs contained Event logs and dumps - Both pages rendered when clicking link 2. Intel build - Logs contained Event logs only - Logs page rendered when clicking link 3. Tested default build - Logs contained Event logs only - Logs page rendered when clicking link
Signed-off-by: Derick Montague <derick.montague@ibm.com> Change-Id: I4621837202cf5ad3469d6ea460d9a5bdc79c8816
show more ...
|
30731f1e | 22-Jul-2021 |
Dixsie Wolmers <dixsie@ibm.com> |
Update app nav test spec with post codes
Ran NPM run test:update to update app nav test spec after post codes were merged.
Signed-off-by: Dixsie Wolmers <dixsie@ibm.com> Change-Id: I4d168c80844a327
Update app nav test spec with post codes
Ran NPM run test:update to update app nav test spec after post codes were merged.
Signed-off-by: Dixsie Wolmers <dixsie@ibm.com> Change-Id: I4d168c80844a32732282a6f42d9cc9288463cf66
show more ...
|
71114feb | 06-May-2021 |
Derick Montague <derick.montague@ibm.com> |
Replace use of the term host with server
This patchset focuses on the global store use for server power operations and impacts several pages in the interface.
For consistency, both in the UI and th
Replace use of the term host with server
This patchset focuses on the global store use for server power operations and impacts several pages in the interface.
For consistency, both in the UI and the code base, we are replacing the term host with server. This change impacts both the user and the developer experience. Maintaining consistency in naming allows both developers and users to form a mental model of the overall system and will help remove confusion when interacting with the UI and editing the interface.
Testing: 1. Tested shutdown, power on, and reboot and verified the icons and page sections in the site header and the server power operations page update as expected during power operations. 2. Verified the one-time boot operations alert is displayed to the user when changing the boot settings on the server power operations page 3 Tested factory reset and validated the correct information message is displayed to the user with the server power off and on when performing the factory reset functions. 4. Verified the SOL Console status icon updates correctly during power operations. 5. Verified the alert message is displayed on the firmware update page when the server is powered on.
Signed-off-by: Derick Montague <derick.montague@ibm.com> Change-Id: I88499a746364ab80f16a8b350d550407d094e95d
show more ...
|
1915d8c4 | 25-Mar-2021 |
Dixsie <dixsie@ibm.com> |
Update all minor and patch releases
Updated NPM packages with minor and patch releases only.
Tested the UI locally and by building copying to the BMC and running in an overlay and did not observe b
Update all minor and patch releases
Updated NPM packages with minor and patch releases only.
Tested the UI locally and by building copying to the BMC and running in an overlay and did not observe breaking changes.
Major releases are not updated in this commit as they require additional testing and code updates to address breaking changes and will be updated separately once those updates are stable.
Signed-off-by: Dixsie Wolmers <dixsie@ibm.com> Change-Id: I73c952a75a1148c5852a18d73b9065083fd8e94c
show more ...
|
da9f0a6e | 14-Feb-2021 |
Derick Montague <derick.montague@ibm.com> |
Add factory reset page
This new page will be included in the Control section of the primary navigation. The user will be able to choose between two different reset actions.
The user can make the
Add factory reset page
This new page will be included in the Control section of the primary navigation. The user will be able to choose between two different reset actions.
The user can make the following calls: - /redfish/v1/Systems/system/Bios/Actions/Bios.ResetBios - /redfish/v1/Managers/bmc/Actions/Manager.ResetToDefaults
Signed-off-by: Derick Montague <derick.montague@ibm.com> Change-Id: I32a10dbce27a03fb84e24d7eae7c44eef9cffea5
show more ...
|
80267970 | 16-Feb-2021 |
Derick Montague <derick.montague@ibm.com> |
Fix skip link 404 error on refresh bug
Problem: When a user uses the skip link anchor to skip the navigation, the route was being changed to /#main-content. This route does not exist. If a user were
Fix skip link 404 error on refresh bug
Problem: When a user uses the skip link anchor to skip the navigation, the route was being changed to /#main-content. This route does not exist. If a user were to manually refresh the page, it would return a 404. This link is critical to meet accessibility guidelines and is needed by users that navigate with a keyboard.
The challenge is that we need to mirror a full page refresh on all route changes, so we set focus on the app-header element on each route change. When we click the skip to navigation link, there should not be a route change. All we need is to set focus on the <main> element so that the user can tab to the first tabbable element in the main content section.
Solution: - Use a native <a> element with an attached click event handler - Prevent the default action of adding the hash to the URL - Create a global mixin to reuse for route changes and skip link activation - Emit an event that can be listened for to call the global mixin
Signed-off-by: Derick Montague <derick.montague@ibm.com> Change-Id: I4c2301b02f608eeb376ed2d1bd809f3d5c1bf545
show more ...
|
be6858c0 | 16-Dec-2020 |
Sukanya Pandey <sukapan1@in.ibm.com> |
Add power restore policy page
- This page will show how the system boots once power is restored after a power disturbance.
- API used to fetch the JSON: /redfish/v1/JsonSchemas/ComputerSystem/C
Add power restore policy page
- This page will show how the system boots once power is restored after a power disturbance.
- API used to fetch the JSON: /redfish/v1/JsonSchemas/ComputerSystem/ComputerSystem.json - API used to fetch the current policy and to save updated policy: /redfish/v1/Systems/system/
Signed-off-by: Sukanya Pandey <sukapan1@in.ibm.com> Change-Id: I203bd3c5d26071b882cce6b9950cdb3fb1deb212
show more ...
|
6e89ba6c | 29-Jan-2021 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Update failing unit tests
Accessibility updates for icon only buttons required updates to snapshot unit tests.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: Ia2bb1576f53d3f38
Update failing unit tests
Accessibility updates for icon only buttons required updates to snapshot unit tests.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: Ia2bb1576f53d3f38c4c68879b5273edd3d33b92d
show more ...
|
5ecdd666 | 05-Jan-2021 |
Sukanya Pandey <sukapan1@in.ibm.com> |
Add unit test cases for search component
Signed-off-by: Sukanya Pandey <sukapan1@in.ibm.com> Change-Id: I9721a9bc8b1fce850b824a2f9d7a6d199c5e0236 |
b31a448d | 29-Dec-2020 |
SurenNeware <sneware9@in.ibm.com> |
Add unit test cases for loading bar component
Signed-off-by: Suren Neware <sneware9@in.ibm.com> Change-Id: Ifcb488df080bd64ce9e9865befd4c044a73589e1 |
9faf55ed | 05-Jan-2021 |
Derick Montague <derick.montague@ibm.com> |
Run test script as part of the pre-commit hook
Now that we have added more unit testing, it will be beneficial to run the unit test script prior to check in. Eventually, we will want this to be part
Run test script as part of the pre-commit hook
Now that we have added more unit testing, it will be beneficial to run the unit test script prior to check in. Eventually, we will want this to be part of the CI build process since Git pre-hooks can be avoided.
Signed-off-by: Derick Montague <derick.montague@ibm.com> Change-Id: I59aad81a470176d2f6a5afeb130661c642f4d259
show more ...
|