a5dbf55f | 13-Jan-2025 |
Huy Le Anh <hule@amperecomputing.com> |
Boot settings: remove oneTimeBootEnabled check
The commit [1] added oneTimeBootEnabled as condition to display he Boot settings menu. It is not reasonable as the option is disabled by default [2] an
Boot settings: remove oneTimeBootEnabled check
The commit [1] added oneTimeBootEnabled as condition to display he Boot settings menu. It is not reasonable as the option is disabled by default [2] and users can configure for a selected boot option to be applied once or permanent. This commit removes the check so that the menu is displayed when the boot source option is supported.
Tested: 1. Log in to BMC Web and go to the server-power-operations page 2. The boot settings options are shown.
[1]: https://github.com/openbmc/webui-vue/commit/918526f20c16a05c261a56814657942a707323dd
[2]: https://github.com/openbmc/openbmc/blob/f8b0a12a3781e1f771630cad1244016b1ed6f8cd/meta-phosphor/recipes-phosphor/settings/phosphor-settings-manager/boot_type.override.yml#L19
Change-Id: I1efd2ae0c201744076e3fb00229c81847e940687 Signed-off-by: Huy Le Anh <hule@amperecomputing.com>
show more ...
|
85b2d315 | 12-Nov-2024 |
Shane Lin <hslin@nvidia.com> |
Rename host firmware to bios firmware
Problem: - Host firmware naming was inconsistent with actual functionality
Changes: - Rename hostFirmware to biosFirmware in store - Update component names and
Rename host firmware to bios firmware
Problem: - Host firmware naming was inconsistent with actual functionality
Changes: - Rename hostFirmware to biosFirmware in store - Update component names and references - Modify i18n translation keys
Tested: - Verified store mutations/actions - Confirmed component rendering - Checked i18n translations - npx eslint without error related to 'host'
Change-Id: Ib97e4682f649d4a52f65e69df50422d84f23e916 Signed-off-by: Shane Lin <hslin@nvidia.com>
show more ...
|
b4498672 | 16-Nov-2024 |
HuyLe <hule@amperecomputing.com> |
Fix the KVM terminal screen not displaying
During the upgrade to Vue 3 [1], the initialization of the selector, including the definitions of height, display type, background, overflow, etc., was ign
Fix the KVM terminal screen not displaying
During the upgrade to Vue 3 [1], the initialization of the selector, including the definitions of height, display type, background, overflow, etc., was ignored, resulting in the KVM screen not displaying the terminal interface. This commit helps to import these properties for the KVM from the _kvm.scss file to fix bug [2].
Tested: 1. Go to the OBMC web page. 2. Go to the KVM page and check that it works normally 3. By minifying and zooming in on the web browser, the KVM screen adjusts automatically. 4. Switch between different pages. 5. Return to the KVM page and check that it works normally.
[1]. https://github.com/openbmc/webui-vue/blob/master/src/App.vue#L38 [2]. Bug: https://github.com/openbmc/webui-vue/issues/128
Change-Id: I1842c914e27dd5c68fe20f49999712b68c1e93a5 Signed-off-by: Huy Le Anh <hule@amperecomputing.com>
show more ...
|
918526f2 | 19-Sep-2024 |
Shubhi Garg <shgarg@nvidia.com> |
Fix power operations as per DMTF redfish spec
[Problem Description]:
1) Power Operations page uses "Orderly" and "Immediate" strings for "Graceful reboot/shutdown" and "Force reboot/shutdown". Thes
Fix power operations as per DMTF redfish spec
[Problem Description]:
1) Power Operations page uses "Orderly" and "Immediate" strings for "Graceful reboot/shutdown" and "Force reboot/shutdown". These names do not align according to redfish spec and causes user confusion.
2) For boot settings, if "BootSourceOverrideEnabled" flag is false, WebUI allows to modify boot options.
[Changes]:
1) Changed reboot/shutdown naming convention as per DMTF redfish spec to view correct names on WebUI.
2) Added info-tooltip to give detailed information on Reboot/Shutdown options. Information is referenced from: https://redfish.dmtf.org/schemas/v1/Resource.json#/definitions/ResetType
3) Added "oneTimeBootEnabled" condition check to render BootSettings if condition is true. "oneTimeBootEnabled" checks BootSourceOverrideEnabled flag, if true then BootSettings will be able to modify boot options.
[Testing]: 1) Load WebUI with the changes and go to Power operations page. 2) Check reboot shutdown names have changes to Graceful reboot/shutdown" and "Force reboot/shutdown". 3) Check if BootSettings template renders as expected.
Change-Id: I5a86e05ee03167ebb93ffd381af3a47c277990fd Signed-off-by: Shubhi Garg <shgarg@nvidia.com>
show more ...
|
69be824a | 23-Sep-2024 |
Surya Venkatesan <suryav@ami.com> |
Invalid feedback if condition change
For required, invalid format, minlength, maxlength, date, pattern validation if condition change in the few components
Change-Id: Id8eebc140301e48dde833a604ca92
Invalid feedback if condition change
For required, invalid format, minlength, maxlength, date, pattern validation if condition change in the few components
Change-Id: Id8eebc140301e48dde833a604ca92426ebf77c9c Signed-off-by: Surya Venkatesan <suryav@ami.com>
show more ...
|
1a814b9f | 23-Sep-2024 |
Surya Venkatesan <suryav@ami.com> |
LDAP and server power operation page fix
In LDAP loading declare outside the form, form validation condition change, server power operation page validation added and i18n method changed in the event
LDAP and server power operation page fix
In LDAP loading declare outside the form, form validation condition change, server power operation page validation added and i18n method changed in the event log store.
Change-Id: I903b4dec7da1a5a2cc8441c65693c57201405d70 Signed-off-by: Surya Venkatesan <suryav@ami.com>
show more ...
|
f1ccca3f | 23-Sep-2024 |
Surya Venkatesan <suryav@ami.com> |
Factory reset modal popup and validation issue
In vue3 i18n is not return the object value from the locale, so unable to do the for loop in Setting list. Remove the for loop and implement the separa
Factory reset modal popup and validation issue
In vue3 i18n is not return the object value from the locale, so unable to do the for loop in Setting list. Remove the for loop and implement the separate list for reset bios and reset to default. And implement the useVuelidate in the factory reset page.
Change-Id: I10833742475b90f7c5349a5b995ff04e93c306de Signed-off-by: Surya Venkatesan <suryav@ami.com>
show more ...
|
00355b65 | 12-Sep-2024 |
Surya Venkatesan <suryav@ami.com> |
Firmware page vuelidate and form file error fix
While add a file in the form file vuelidate error occurs and global component form file not return a file, by emit the $event in form file fix the iss
Firmware page vuelidate and form file error fix
While add a file in the form file vuelidate error occurs and global component form file not return a file, by emit the $event in form file fix the issue.
Change-Id: Icbeddc7a3faa262f12e85268206ae70950f37905 Signed-off-by: Surya Venkatesan <suryav@ami.com>
show more ...
|
de23ea23 | 11-Jul-2024 |
Surya V <suryav@ami.com> |
Vuelidate, I18n, and filter are upgraded to vue3
While navigating to the pages i18n, vuelidate, and filters errors occurred. i18n, and vuelidate code changes in each page adapted to vue3. Filter glo
Vuelidate, I18n, and filter are upgraded to vue3
While navigating to the pages i18n, vuelidate, and filters errors occurred. i18n, and vuelidate code changes in each page adapted to vue3. Filter global function for date and time format implemented in the main.js file and those files which as called the filter functions.
Change-Id: If1a2ee22d47750faef1c35ef2c263299067d9a20 Signed-off-by: Surya Venkatesan <suryav@ami.com>
show more ...
|
7d6b44cb | 23-Mar-2024 |
Ed Tanous <ed@tanous.net> |
Upgrade vue3 and all dependencies
Start the process of porting everything to Vue 3. I have most things working. npm run-scripts build works, npm install works. prettier passes. Styles load, logi
Upgrade vue3 and all dependencies
Start the process of porting everything to Vue 3. I have most things working. npm run-scripts build works, npm install works. prettier passes. Styles load, login works, webui loads.
This was primarily done using the linked documents below. It makes the following design decisions: 1. Vue is put in compat 2 mode, which allows most of the components to work as-is. 2. Bootstrap v4 is used along with bootstrap-vue to keep our components working. 3. Minor changes are made to load the latest versions of vue-router, vuex, and vue-i18n.
I suspect this patchset is good enough to start with, and we can clean up the broken things one patchset at a time. The things that need to happen are:
1. Get remaining features working again. This primiarily is vue-i18n for mixins, and non vue components. This likely needs to be done by not pulling in i18n into the non vue components, then using the .Vue files to do the internationalization in the component context, NOT in the mixin context. Alternatively, we could drop MixIns alltogether. 2. Get custom styles working again. Previously, we used some path hackery in vue.config.js to optionally pre-load styles. This stops working now that we're required to @import our modules. Likely we need some rearangement of the paths such that custom styles are a complete replacement (possibly importing the original) rather than additive with overrides. That's a guess, but I don't really see anyone else doing customization the way we've defined it here. 3. Bootstrap 5 no longer requires ANY custom vue modules, as it has dropped the jquery dependency. We won't be able to pull in bootstrap 5 all at once, so pull in bootstrap 5 under an alias, like "bootstrap5" that we can optionally import 5 or 4. 4. One at a time, start porting components over to Vue3 syntax and bootstrap 5. This will be the bulk of the manual work and review.
The only thing I think left is getting unit tests passing, which I commented out the pre-commit hook to make this PR.
Tested: Code builds. Needs better testing.
[1] https://router.vuejs.org/guide/migration/ [2] https://vue-i18n.intlify.dev/guide/migration/vue3 [3] https://vuelidate-next.netlify.app/migration_guide.html#package-name-and-imports
Change-Id: I5bb3187b9efbf2e4ff63e57994bc528756e2a981 Signed-off-by: Ed Tanous <ed@tanous.net>
show more ...
|
e2c716a9 | 28-Jul-2024 |
Leo Xu <yongquanx@nvidia.com> |
Add support for MultipartHttpPushUri in fw push
According to the Redfish Firmware Update Whitepaper [1] due to the vendor-specific details of this operation, HttpPushUri has been deprecated in f
Add support for MultipartHttpPushUri in fw push
According to the Redfish Firmware Update Whitepaper [1] due to the vendor-specific details of this operation, HttpPushUri has been deprecated in favor of multipartHTTP push updates.
Availability of update methods is determined from the UpdateService response.
If MultipartHttpPushUri is found it will be preferred over HttpPushUri
Tested: -Firmware update by performed via MultipartHttpPushUri
[1]: https://www.dmtf.org/sites/default/files/standards/documents/DSP2062_1.0.1.pdf
Change-Id: I184a889514d5f9f9598f35b2281404335bc0bc82 Signed-off-by: Leo Xu <yongquanx@nvidia.com>
show more ...
|
bc49e091 | 11-Jun-2024 |
Nikhil Ashoka <a.nikhil@ibm.com> |
Removed TFTP code update option
- Removed TFTP server firmware update ability in the UI.
Signed-off-by: Nikhil Ashoka <a.nikhil@ibm.com> Change-Id: Icbeddc7a3faa262f12e85268206ae70850f37905 |
d1ef18e6 | 06-Apr-2024 |
Paul Fertser <fercerpav@gmail.com> |
Focus default action in modal windows
Users of common WIMP GUIs (as opposed to interfaces primarily meant for touch input) expect dialog boxes to have keyboard focus set on the button for default ac
Focus default action in modal windows
Users of common WIMP GUIs (as opposed to interfaces primarily meant for touch input) expect dialog boxes to have keyboard focus set on the button for default action so that it can be executed by a single key press. Usually that is chosen to proceed with the operation but in cases where that leads to data loss the UI designers often pre-select Cancel as a precaution.
This patch adds suitable property to all invocations of msgBoxConfirm() method of `this.$bvModal` BootstrapVue object. For regular actions the confirmation button is selected and can be activated by Enter or Space bar. For actions deemed dangerous Cancel is focused instead so it takes two key presses (first being Tab to shift the focus) to prooceed.
This also improves accessibility following the Web Content Accessibility Guidelines (WCAG) published by W3C.
Tested: manually verified that modals are consistently shown with the specified button focused, Enter and Space bar key presses produce the same effect as left pointer button click: when Cancel is focused it just closes the window, when OK is focused it sends the corresponding request to the Redfish endpoint.
Change-Id: I66bfd02e48e08dc18994b11bbdd5d6b3ea27047f Signed-off-by: Paul Fertser <fercerpav@gmail.com>
show more ...
|
8132399c | 27-Feb-2024 |
Ed Tanous <ed@tanous.net> |
Reformat files with new linter
All changes should be whitespace, and were done using npm run-script lint.
Change-Id: I943c6b435c5c872841af5affc1e89910468b5ca6 Signed-off-by: Ed Tanous <ed@tanous.ne
Reformat files with new linter
All changes should be whitespace, and were done using npm run-script lint.
Change-Id: I943c6b435c5c872841af5affc1e89910468b5ca6 Signed-off-by: Ed Tanous <ed@tanous.net>
show more ...
|
c3cf3610 | 27-Jan-2022 |
Kenneth Fullbright <kennyneedsmilky@gmail.com> |
Update Firmware page interactions when system is powered on
- if isServerPowerOffRequired is true & !isServerOff is true a warning will be shown that the server must be powered off to switch images
Update Firmware page interactions when system is powered on
- if isServerPowerOffRequired is true & !isServerOff is true a warning will be shown that the server must be powered off to switch images and update the firmware.
- When system power is on, the switch to "running button" is disabled.
Signed-off-by: Kenneth Fullbright <kennyneedsmilky@gmail.com> Change-Id: I65a24984c36f6ae39d715f4fa66e9884d031cb20
show more ...
|
37b22a13 | 12-May-2023 |
Nikhil Ashoka <a.nikhil@ibm.com> |
WebSocket tries to connect with 'console/default' instead of 'console0'
- This patchset will try to connect to the WebSocket with the path 'console/default'. - Until now, we were connecting to 'con
WebSocket tries to connect with 'console/default' instead of 'console0'
- This patchset will try to connect to the WebSocket with the path 'console/default'. - Until now, we were connecting to 'console0'.
Signed-off-by: Nikhil Ashoka <a.nikhil@ibm.com> Change-Id: I6136e09458284b76f5b03f89be247db3e3ff82fd
show more ...
|
fb6c6de9 | 14-Jun-2023 |
Konstantin <sulwirld@gmail.com> |
Fix kvm session and add event bus
Bug description: Before this commit KVM window wasn't being closed after logging out
Test: Step1. Launch webui on browser and see KVM page on /#/operations
Fix kvm session and add event bus
Bug description: Before this commit KVM window wasn't being closed after logging out
Test: Step1. Launch webui on browser and see KVM page on /#/operations/kvm. Step2. Open additional window using 'Open in new tab'. Step3. Navigate to another page. For example, /#/operations/key-clear. Step4. Logout. Window is still open.
Change-Id: Ife79ebca41eb4d588c0b8f4fae06135420eda155 Signed-off-by: Konstantin Maskov <sulwirld@gmail.com>
show more ...
|
e78d10b7 | 03-Mar-2023 |
kirankumarb07 <kirankumarb@ami.com> |
After the session expired redirect to login page
If the user switches pages between the KVM and Virtual Media pages after the session has expired, it won't redirect to the login page.
So I have add
After the session expired redirect to login page
If the user switches pages between the KVM and Virtual Media pages after the session has expired, it won't redirect to the login page.
So I have added the system redfish API call in the create method to check the session timeout status. If the session is expired, the API call will get a 401 status, and WEBUI will be redirected to the login page.
Change-Id: I069768ee0cef41afb4e6aa770bb8bec6565a16bd Signed-off-by: Kirankumarb07 Ballapalli <kirankumarb@ami.com>
show more ...
|
b63e9d9a | 07-Feb-2023 |
kirankumarb07 <kirankumarb@ami.com> |
SOL console opened in a new tab shows an error
When the SOL console is opened in a new window, the status of the SOL connection is displayed as "disconnected." And the error message is displaying, "
SOL console opened in a new tab shows an error
When the SOL console is opened in a new window, the status of the SOL connection is displayed as "disconnected." And the error message is displaying, "The system must be powered on to connect."
I have added this patch to get the systems API call to get the server status when SOL is opened in a new window.
Change-Id: I971947fea0980605d400d46bb1e18b2d20164602 Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>
show more ...
|
b89eed27 | 12-Jan-2023 |
kirankumarb07 <kirankumarb@ami.com> |
Closed KVM new window after WEBUI logged out
Description:
When KVM is opened in new window, after WEB UI is logged out, opened KVM window is not getting closed. It remains opened and accessible.
R
Closed KVM new window after WEBUI logged out
Description:
When KVM is opened in new window, after WEB UI is logged out, opened KVM window is not getting closed. It remains opened and accessible.
Root Cause:
There is not handle to close the KVM new window after the WEB UI logged out.
Fix:
Added the KVM window opened information in store, and checked that information to close the window.
Tested:
Step 1: Login to WEB UI Step 2: Navigate to Operations -> KVM Step 3: Open KVM in new window Step 4: Click Logout in WEB UI
Result:
After successful log out, KVM new window is closed as expected.
Change-Id: Iab8e54d3088a08fb0ae9b581b2647fc0ab5460bd Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>
show more ...
|
83ca596d | 25-Nov-2022 |
glukhov.mikhail <mikl@greenfil.ru> |
Fix SOL status
Only when the host is turned off should the status be "Disconnected". For other host states, the SOL status should be Connected.
Test: enabled my host in DiagnosticMode. Now SOL stat
Fix SOL status
Only when the host is turned off should the status be "Disconnected". For other host states, the SOL status should be Connected.
Test: enabled my host in DiagnosticMode. Now SOL status is "Connected", before the patch it was "Disconnected
Signed-off-by: glukhov.mikhail <mikl@greenfil.ru> Change-Id: I000b181f71d7ee5bd243a3c6a6d03ea7a9ea0ef7
show more ...
|
ed7278a2 | 26-Sep-2022 |
glukhov.mikhail <mikl@greenfil.ru> |
Added correct diagnostic mode display
Before the patch, the diagnostic mode was displayed as "Not available", after the patch "Diagnostic mode".
Test: in the console run the command "busctl set-pro
Added correct diagnostic mode display
Before the patch, the diagnostic mode was displayed as "Not available", after the patch "Diagnostic mode".
Test: in the console run the command "busctl set-property xyz.openbmc_project.State.Host \ /xyz/openbmc_project/state/host0 \ xyz.openbmc_project.State.Host CurrentHostState \ s "xyz.openbmc_project.State.Host.HostState.DiagnosticMode". open the "Server power operations" page, check the Server status
Signed-off-by: glukhov.mikhail <mikl@greenfil.ru> Change-Id: I90d04e05188eb92c4c4b38fe578ae36db0424b5c
show more ...
|
78372d63 | 08-Mar-2022 |
Xiaochao Ma <maxiaochao@inspur.com> |
SOL: fix socket close exception
When the sol page is opened, a socket is opened; when the sol page is closed, the socket is not closed (console print is also exception). It only closes when you log
SOL: fix socket close exception
When the sol page is opened, a socket is opened; when the sol page is closed, the socket is not closed (console print is also exception). It only closes when you log out. Fix this condition to 'close socket when SOL page is exited'.
test: Enter the SOL page-->console print'websocket console0/ opened' -->close the SOL page -->console print'websocket console0/ closed. code: 1000 reason: '
Signed-off-by: Xiaochao Ma <maxiaochao@inspur.com> Change-Id: I0f406c2085aec303d6e5139d57b31ed6f244a155
show more ...
|
19b2cfba | 21-Feb-2022 |
Kenneth Fullbright <kennyneedsmilky@gmail.com> |
Removed alert message from Update firmware component
There shouldn't be an alert message in the update firmware component.
- Took away the alert from the Update firmware component.
Signed-off-by:
Removed alert message from Update firmware component
There shouldn't be an alert message in the update firmware component.
- Took away the alert from the Update firmware component.
Signed-off-by: Kenneth Fullbright <kennyneedsmilky@gmail.com> Change-Id: I1ab97fbba39fb2d7639707cceaf75b71531fa971
show more ...
|
1d9257e5 | 31-Jan-2022 |
Nikhil Ashoka <a.nikhil@ibm.com> |
Update SOL console page alert message
- if the status of the SOL console is disconnected, an alert message will be displays that System must be powered on to connect
Signed-off-by: Nikhil Ashoka <a
Update SOL console page alert message
- if the status of the SOL console is disconnected, an alert message will be displays that System must be powered on to connect
Signed-off-by: Nikhil Ashoka <a.nikhil@ibm.com> Change-Id: I4cdf99954f3a4e129404facf2992dadf63e62f70
show more ...
|