Prevent error when EfficiencyRatings is undefined

Use optional chaining on the element access
and on the property access to prevent TypeError

Fixes: https://github.com/openbmc/webui-vue/issues/135

Prevent error when EfficiencyRatings is undefined

Use optional chaining on the element access
and on the property access to prevent TypeError

Fixes: https://github.com/openbmc/webui-vue/issues/135

Change-Id: Ic58d4ef086e5d0a43a44b6388b3d1d450c79d224
Signed-off-by: Hariharan Rangasamy <hariharanr@ami.com>

show more ...

Improved performance in Sensors page

- The Sensors page takes too long to load, It is because we are
trying to call the redfish endpoint: /Sensors' Members one by one
and setting in the GUI. The

Improved performance in Sensors page

- The Sensors page takes too long to load, It is because we are
trying to call the redfish endpoint: /Sensors' Members one by one
and setting in the GUI. The change made is that we are using the
query parameters' expand option to call only once and get all
the required responses.

- We are using query parameters only for those which have MaxLevels>0,
else calling the APIs one by one.

- Tested: Checked on a p10 system. For 306 records, it used to take
1 minute 20 seconds, now takes 7 seconds to load.

Signed-off-by: Nikhil Ashoka <a.nikhil@ibm.com>
Change-Id: Ife3447e48d4f5617dcf4563ceac486e4502b2de1

show more ...

inventory: move serial console to system

SerialConsole was deprecated in Manager v1_10_0 and has been
removed in bmcweb [1].

Because the SerialConsole values were not available anymore, the
Manager

inventory: move serial console to system

SerialConsole was deprecated in Manager v1_10_0 and has been
removed in bmcweb [1].

Because the SerialConsole values were not available anymore, the
Managers were not displayed because "setBmcInfo" couldn't find the
"SerialConsole" properties. THe following error will be logged:

```
TypeError: Cannot read properties of undefined (reading 'ConnectTypesSupported')
at Wa.setBmcInfo (app.25e72670.js:58:745295)
at app.25e72670.js:50:2774
at app.25e72670.js:50:10113
at Array.forEach (<anonymous>)
at app.25e72670.js:50:10092
at Wa._withCommit (app.25e72670.js:50:11953)
at Wa.commit (app.25e72670.js:50:10066)
at Wa.commit (app.25e72670.js:50:9518)
at o.commit (app.25e72670.js:50:2216)
at app.25e72670.js:58:745747
```

[1]: https://github.com/openbmc/bmcweb/commit/fa800c8a141aa4b209269e0fb50cae34aa24f75d

Tested: BMC manager being listed in the inventory and serial console
variables being displayed for the system.

Change-Id: I1a24178717805ca50eef2c89042c0bd9ede1d5bc
Signed-off-by: Tan Siewert <tan@siewert.io>

show more ...

Vuelidate, I18n, and filter are upgraded to vue3

While navigating to the pages i18n, vuelidate, and filters errors
occurred. i18n, and vuelidate code changes in each page adapted to
vue3. Filter glo

Vuelidate, I18n, and filter are upgraded to vue3

While navigating to the pages i18n, vuelidate, and filters errors
occurred. i18n, and vuelidate code changes in each page adapted to
vue3. Filter global function for date and time format implemented
in the main.js file and those files which as called the filter
functions.

Change-Id: If1a2ee22d47750faef1c35ef2c263299067d9a20
Signed-off-by: Surya Venkatesan <suryav@ami.com>

show more ...

Replace fixed paths with response from API

Currently, the Redfish request used fixed URIs, modify the code to use
the BMC and System paths got from response of API calls.
For CertificateStore, since

Replace fixed paths with response from API

Currently, the Redfish request used fixed URIs, modify the code to use
the BMC and System paths got from response of API calls.
For CertificateStore, since it was using the URL for constant variable
assignment, changed the constant CERTIFICATE_TYPES to method call.

Change-Id: I330b7272083e3e6993aae5705aae170b8e9a4659
Signed-off-by: Sean Zhang <xiazhang@nvidia.com>

show more ...

Added toast notification for identify LEDs

- Added success toast notification messages for identify
LEDs present at Inventory and LEDs page and Overview.

- Import of Toast was not present in Over

Added toast notification for identify LEDs

- Added success toast notification messages for identify
LEDs present at Inventory and LEDs page and Overview.

- Import of Toast was not present in Overview's Inventory
card and DIMM slot table, fixed it.

Signed-off-by: Nikhil Ashoka <a.nikhil@ibm.com>
Change-Id: If9ad84e66f6f15616cb8af51b1e84d8d06b1afd0

show more ...

Display Power Supply Inventory from PowerSubsystem

Switch Power Supply information to use information from the new
PowerSubsystem since bmcweb enabled this by default, any other modern
Redfish imple

Display Power Supply Inventory from PowerSubsystem

Switch Power Supply information to use information from the new
PowerSubsystem since bmcweb enabled this by default, any other modern
Redfish implementation should have this schema enabled.

Tested: On Ampere MtJade platform
1. Login to WebUI; Hardware Status; Inventory
2. Inventory information for power supplies is displayed.

Change-Id: Iad59d0145b47bcd5eb3cb4ff852e50da976a6005
Signed-off-by: HuyLe <hule@amperecomputing.com>

show more ...

Move to new ThermalSubsystem

Remove VUE_APP_FAN_DATA_FROM_THERMAL_SUBSYSTEM. Assume any Redfish
implementation we are using has the new ThermalSubsystem. bmcweb, the
only webserver, webui-vue suppor

Move to new ThermalSubsystem

Remove VUE_APP_FAN_DATA_FROM_THERMAL_SUBSYSTEM. Assume any Redfish
implementation we are using has the new ThermalSubsystem. bmcweb, the
only webserver, webui-vue supports today, enabled this by default at
https://gerrit.openbmc.org/c/openbmc/bmcweb/+/69228

ThermalSubsystem, PowerSubsystem has been out since 2020.4, so it is
reasonable to assume it is there in any modern Redfish
implementation.

Tested: Nabil tested and verified this worked.

Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
Change-Id: I4952daf30f9b654234dd0e838adebc38cc8c380f

show more ...

Reformat files with new linter

All changes should be whitespace, and were done using npm run-script
lint.

Change-Id: I943c6b435c5c872841af5affc1e89910468b5ca6
Signed-off-by: Ed Tanous <ed@tanous.ne

Reformat files with new linter

All changes should be whitespace, and were done using npm run-script
lint.

Change-Id: I943c6b435c5c872841af5affc1e89910468b5ca6
Signed-off-by: Ed Tanous <ed@tanous.net>

show more ...

Fix pressing Refresh button not removing deleted sensors

Issue: when clicking the Refresh button at top right corner of the
WebUI, sensors that were removed from Redfish are not removed from the
Web

Fix pressing Refresh button not removing deleted sensors

Issue: when clicking the Refresh button at top right corner of the
WebUI, sensors that were removed from Redfish are not removed from the
WebUI but still shown with old sensor values.
Root cause: current code keeps a list of sensors. Click on Refresh
button just checks and updates sensors returned by Redfish, it does not
check if sensors are still present or not. This is incorrect for
sensors on hot plug devices or PLDM sensors when the sensor source is
not available. In this case, sensors are completely removed instead of
just their values changed to n/a.
Solution: Initialize an empty array sensor state to retrieve
existing sensor data whenever loading sensors.

Change-Id: Ifb0c0586fdba22b6f446c58b3d5b937a3f3ee750
Signed-off-by: HuyLe <hule@amperecomputing.com>

show more ...

Fan data from Thermal or ThermalSubsystem API

Fan data API switch in Inventory and LEDs page based on
environment variable VUE_APP_FAN_DATA_FROM_THERMAL_SUBSYSTEM.

Backend Support PR:

https://gerr

Fan data from Thermal or ThermalSubsystem API

Fan data API switch in Inventory and LEDs page based on
environment variable VUE_APP_FAN_DATA_FROM_THERMAL_SUBSYSTEM.

Backend Support PR:

https://gerrit.openbmc.org/c/openbmc/bmcweb/+/57533

Change-Id: I95ac9f9cef97bdab84a179b3e318eb37ab11752b
Signed-off-by: Sivaprabu Ganesan <sivaprabug@ami.com>

show more ...

Drop processor and memory summary status display

Redfish deprecated the Processor/Memory Summary Status (state, health,
healthrollup) attributes. Please refer to redfish spec for more details:
https

Drop processor and memory summary status display

Redfish deprecated the Processor/Memory Summary Status (state, health,
healthrollup) attributes. Please refer to redfish spec for more details:
https://redfish.dmtf.org/schemas/v1/ComputerSystem.v1_20_0.json

These attributes are already removed from the bmcweb code:
https://gerrit.openbmc.org/c/openbmc/bmcweb/+/62731

So currently webui-vue tries to access not present attributes and fails,
and since these fields are not marked as optional, 'Server Overview'
card fails to display.

Drop processor and memory summary status attributes handling to correct
the issue.

Change-Id: I7fb956a0a310c6bd85560169b1ca0a64c19dc824
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

Add fields to the DIMM inventory table

There is a request to see three additional fields from Redfish in the
DIMM inventory table: https://github.com/openbmc/webui-vue/issues/107.

This change adds

Add fields to the DIMM inventory table

There is a request to see three additional fields from Redfish in the
DIMM inventory table: https://github.com/openbmc/webui-vue/issues/107.

This change adds Manufacturer, Error correction, and Rank count data
from Redfish into the DIMM inventory table.

Tested:
Confirmed that the three fields show in the table with the correct data
from Redfish.

Change-Id: I6f1fc5103649abf8350e5b5c107c11eea3d1a599
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>

show more ...

Remove hardcoded chassis from Fan store

This change removes the hardcoded chassis URL from FanStore. Now
the URL is taken from the odata.id.

Signed-off-by: MichalX Szopinski <michalx.szopinski@inte

Remove hardcoded chassis from Fan store

This change removes the hardcoded chassis URL from FanStore. Now
the URL is taken from the odata.id.

Signed-off-by: MichalX Szopinski <michalx.szopinski@intel.com>
Change-Id: I59e4d46a8aaa453f6662f4f396f32d7fad18fb91

show more ...

Fixed sensor mismatch issue with IPMI and redfish

Description:
The sensor count in WebUI is mismatched when compared to
IPMI and REDFISH responses. When Web UI is iterating the
sensor response prope

Fixed sensor mismatch issue with IPMI and redfish

Description:
The sensor count in WebUI is mismatched when compared to
IPMI and REDFISH responses. When Web UI is iterating the
sensor response property, the iteration is stopped when
the key value is undefined. As a result, the sensor details
in the web UI are incorrect. So added the code changes to
check the property value in every iteration, whether the
value is present or not.

Tested:
Step 1: Login to WEB UI
Step 2: Navigate to Hardware Status and Sensors
Step 3: Check the sensor details with IPMI and redfish response
Step 4: All the sensors and those details in the IPMI and redfish
response are listing in Web UI

Change-Id: Icf5098b3dd2413851e755d9ede17a8501cbb7411
Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>

show more ...

Removed the MemorySize

Removed the MemorySize field for DIMMs,
because it is missing in Redfish
```
https://www.dmtf.org/sites/default/files/standards/documents/DSP8010.zip
```

Change-Id: I12f37a60

Removed the MemorySize

Removed the MemorySize field for DIMMs,
because it is missing in Redfish
```
https://www.dmtf.org/sites/default/files/standards/documents/DSP8010.zip
```

Change-Id: I12f37a601e429060765960f3c66b5249b84eabe7
Signed-off-by: Glukhov Mikhail <mikl@greenfil.ru>

show more ...

Fix In-page "Refresh" button doesn't update sensor readings

The reason for this problem is uniqBy always keep the first one when removing repetition

Resolves: https://github.com/openbmc/webui-vue/i

Fix In-page "Refresh" button doesn't update sensor readings

The reason for this problem is uniqBy always keep the first one when removing repetition

Resolves: https://github.com/openbmc/webui-vue/issues/60

Change-Id: Iec87d7845e694b0f2a14de4061ae113eac492fc0
Signed-off-by: wangqi02 <wangqi02@inspur.com>

show more ...

Add missing Model mapping to Chassis Store

Add missing "model" mapping on "Hardware status" tab in chassis
section.

Signed-off-by: MichalX Szopinski <michalx.szopinski@intel.com>
Change-Id: I9a6bd4

Add missing Model mapping to Chassis Store

Add missing "model" mapping on "Hardware status" tab in chassis
section.

Signed-off-by: MichalX Szopinski <michalx.szopinski@intel.com>
Change-Id: I9a6bd4a7e4fbaaac72aa8d59cc065ba0bea040bd

show more ...

Add values to system inventory table

TotalSystemMemoryGiB and CoreCount field is not present.

Added TotalSystemMemoryGiB under Memory summary
Added CoreCount under Processor summary

Signed-off-by:

Add values to system inventory table

TotalSystemMemoryGiB and CoreCount field is not present.

Added TotalSystemMemoryGiB under Memory summary
Added CoreCount under Processor summary

Signed-off-by: Nikhil Ashoka <a.nikhil@ibm.com>
Change-Id: I598abc7c05dd5113db0071ecd71bbcc32ad696c4

show more ...

Fixed Assembly table Identify LED switches

Identify LED should toggle on/off successfully

Rewrote the patch code to work with the Redfish schema

Set LocationIndicatorActive to true:
curl -k -H "X-

Fixed Assembly table Identify LED switches

Identify LED should toggle on/off successfully

Rewrote the patch code to work with the Redfish schema

Set LocationIndicatorActive to true:
curl -k -H "X-Auth-Token: $token" -X PATCH -d '
{
"Assemblies":[
{"MemberId" : "0", "LocationIndicatorActive":true},
{"MemberId": "1", "LocationIndicatorActive":true}
]
}'
https://${bmc}/redfish/v1/Chassis/chassis/Assembly

MemberId is required to reference which assembly LED to toggle

Signed-off-by: Kenneth Fullbright <kennyneedsmilky@gmail.com>
Change-Id: Id0a3cf4dc533f6a0205be9fd037b13f92647cc00

show more ...

Add missing properties to Dimms table

- Added the following properties: Base module type, Bus width bits,
Capacity MiB, Data width bits, Enabled, Operating speed Mhz

- Design has been updated for D

Add missing properties to Dimms table

- Added the following properties: Base module type, Bus width bits,
Capacity MiB, Data width bits, Enabled, Operating speed Mhz

- Design has been updated for Dimms table

Signed-off-by: Sandeepa Singh <sandeepa.singh@ibm.com>
Change-Id: Ifd77071abd9544120c1904065275ccc00dd8d862

show more ...

Add Dimms table missing properties

- Added the following properties: Model, Description, Spare part number,
Location Number, Memory type, Memory size, Identify led

- Design has been updated for Dim

Add Dimms table missing properties

- Added the following properties: Model, Description, Spare part number,
Location Number, Memory type, Memory size, Identify led

- Design has been updated for Dimms table on inventory page

Signed-off-by: Sandeepa Singh <sandeepa.singh@ibm.com>
Change-Id: Ife61396bd70c29df1b5ea55091adc8c6813b5cdc

show more ...

Add Assemblies schema to Hardware Status - Inventory and LEDs

Signed-off-by: Sneha Patel <Snehaben.Patel@ibm.com>
Change-Id: I1a4edae664d008a4f618d03d62e2319d8157ed6d

Location codes on Hardware status-Inventory and LEDs

Display location number on hardware inventory items

Signed-off-by: Sneha Patel <Snehaben.Patel@ibm.com>
Change-Id: Ib5555191f21ac4546d0b2e2af5b3

Location codes on Hardware status-Inventory and LEDs

Display location number on hardware inventory items

Signed-off-by: Sneha Patel <Snehaben.Patel@ibm.com>
Change-Id: Ib5555191f21ac4546d0b2e2af5b395aaa3a5357e

show more ...

Use a 'V' symbol for voltage unit

Currently webui-vue displays all sensor data with units written as
symbols ('A', 'W', 'C', 'RPM') except for voltage which is written as
'Volts'.
Use a 'V' symbol f

Use a 'V' symbol for voltage unit

Currently webui-vue displays all sensor data with units written as
symbols ('A', 'W', 'C', 'RPM') except for voltage which is written as
'Volts'.
Use a 'V' symbol for voltage unit for unification.

Change-Id: I257b6d6bf1d099f62a861430a6448368b56dace1
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...