de23ea23 | 11-Jul-2024 |
Surya V <suryav@ami.com> |
Vuelidate, I18n, and filter are upgraded to vue3
While navigating to the pages i18n, vuelidate, and filters errors occurred. i18n, and vuelidate code changes in each page adapted to vue3. Filter glo
Vuelidate, I18n, and filter are upgraded to vue3
While navigating to the pages i18n, vuelidate, and filters errors occurred. i18n, and vuelidate code changes in each page adapted to vue3. Filter global function for date and time format implemented in the main.js file and those files which as called the filter functions.
Change-Id: If1a2ee22d47750faef1c35ef2c263299067d9a20 Signed-off-by: Surya Venkatesan <suryav@ami.com>
show more ...
|
7d6b44cb | 23-Mar-2024 |
Ed Tanous <ed@tanous.net> |
Upgrade vue3 and all dependencies
Start the process of porting everything to Vue 3. I have most things working. npm run-scripts build works, npm install works. prettier passes. Styles load, logi
Upgrade vue3 and all dependencies
Start the process of porting everything to Vue 3. I have most things working. npm run-scripts build works, npm install works. prettier passes. Styles load, login works, webui loads.
This was primarily done using the linked documents below. It makes the following design decisions: 1. Vue is put in compat 2 mode, which allows most of the components to work as-is. 2. Bootstrap v4 is used along with bootstrap-vue to keep our components working. 3. Minor changes are made to load the latest versions of vue-router, vuex, and vue-i18n.
I suspect this patchset is good enough to start with, and we can clean up the broken things one patchset at a time. The things that need to happen are:
1. Get remaining features working again. This primiarily is vue-i18n for mixins, and non vue components. This likely needs to be done by not pulling in i18n into the non vue components, then using the .Vue files to do the internationalization in the component context, NOT in the mixin context. Alternatively, we could drop MixIns alltogether. 2. Get custom styles working again. Previously, we used some path hackery in vue.config.js to optionally pre-load styles. This stops working now that we're required to @import our modules. Likely we need some rearangement of the paths such that custom styles are a complete replacement (possibly importing the original) rather than additive with overrides. That's a guess, but I don't really see anyone else doing customization the way we've defined it here. 3. Bootstrap 5 no longer requires ANY custom vue modules, as it has dropped the jquery dependency. We won't be able to pull in bootstrap 5 all at once, so pull in bootstrap 5 under an alias, like "bootstrap5" that we can optionally import 5 or 4. 4. One at a time, start porting components over to Vue3 syntax and bootstrap 5. This will be the bulk of the manual work and review.
The only thing I think left is getting unit tests passing, which I commented out the pre-commit hook to make this PR.
Tested: Code builds. Needs better testing.
[1] https://router.vuejs.org/guide/migration/ [2] https://vue-i18n.intlify.dev/guide/migration/vue3 [3] https://vuelidate-next.netlify.app/migration_guide.html#package-name-and-imports
Change-Id: I5bb3187b9efbf2e4ff63e57994bc528756e2a981 Signed-off-by: Ed Tanous <ed@tanous.net>
show more ...
|
8132399c | 27-Feb-2024 |
Ed Tanous <ed@tanous.net> |
Reformat files with new linter
All changes should be whitespace, and were done using npm run-script lint.
Change-Id: I943c6b435c5c872841af5affc1e89910468b5ca6 Signed-off-by: Ed Tanous <ed@tanous.ne
Reformat files with new linter
All changes should be whitespace, and were done using npm run-script lint.
Change-Id: I943c6b435c5c872841af5affc1e89910468b5ca6 Signed-off-by: Ed Tanous <ed@tanous.net>
show more ...
|
e21b2fed | 31-Mar-2023 |
kirankumarb07 <kirankumarb@ami.com> |
Filter the event log data by severity and status
In the event logs page, if the filter options are selected for both severity and status, it displays row that falls into either of the two categories
Filter the event log data by severity and status
In the event logs page, if the filter options are selected for both severity and status, it displays row that falls into either of the two categories: severity or status.
The filter options are in two categories: severity [OK, Warning, Critical], and status [Resolved, Unresolved]
If select the filter options "Critical" on severity and "Unresolved" on status, it shows every row whose status is "Unresolved" whether its severity is "Ok" or "Warning", If the row data is "Critical" or "Unresolved", it shows in the table. As per the filter selection, it shouldn't show the row data that has "Ok" or "Warning" but the status is "Unresolved"; it should show only the row data that is in both "Critical" and "Unresolved".
This commit will work as follows: if different categories are selected, that will be applied with an "and" logic, and within the same category, it will be applied with an "or" logic.
Change-Id: I5ddf6e5ebe35c961306e68885febf6f2324ebaee Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>
show more ...
|
9726f9a7 | 07-Sep-2021 |
Dixsie Wolmers <dixsie@ibm.com> |
Rename TableDataFormatter mixin to DataFormatter
Mixin was renamed to reflect usage on all components, not only tables.
Signed-off-by: Dixsie Wolmers <dixsie@ibm.com> Change-Id: Ic962ba879fffa39b9f
Rename TableDataFormatter mixin to DataFormatter
Mixin was renamed to reflect usage on all components, not only tables.
Signed-off-by: Dixsie Wolmers <dixsie@ibm.com> Change-Id: Ic962ba879fffa39b9f6f93446771fbf6f67915d0
show more ...
|
dc6b3cde | 20-May-2021 |
Dixsie Wolmers <dixsie@ibm.com> |
Add quicklinks to hardware status page
- Renames SetFocusMixin to JumpLinkMixin to better describe what the mixin is for: jump links like quick links and skip to main content - Adds scrollToOffset m
Add quicklinks to hardware status page
- Renames SetFocusMixin to JumpLinkMixin to better describe what the mixin is for: jump links like quick links and skip to main content - Adds scrollToOffset method to JumpLinkMixin methods to scroll to selected page elements - Scroll offset is required to show table header below the nav header - Setting focus is required for accessibility
Signed-off-by: Dixsie Wolmers <dixsie@ibm.com> Change-Id: I500a2d70727c5a78aeae4a6193ba22a38e4f0b6f
show more ...
|
7a57faae | 30-Apr-2021 |
Sukanya Pandey <sukapan1@in.ibm.com> |
Resolve bug while selecting the checkboxes
-While selecting the checkbox in the table, user have to click twice to select the data. -The issue occured after upgrading vue-bootstrap. -vue-bootstrap
Resolve bug while selecting the checkboxes
-While selecting the checkbox in the table, user have to click twice to select the data. -The issue occured after upgrading vue-bootstrap. -vue-bootstrap community improved the code for checkbox toggling which causes the issue, openBmc code is been updated to support the new changes.
Signed-off-by: Sukanya Pandey <sukapan1@in.ibm.com> Change-Id: I0e3c3e2248c22bcf805eb6f0b73378bcf4e8ea61
show more ...
|
80267970 | 16-Feb-2021 |
Derick Montague <derick.montague@ibm.com> |
Fix skip link 404 error on refresh bug
Problem: When a user uses the skip link anchor to skip the navigation, the route was being changed to /#main-content. This route does not exist. If a user were
Fix skip link 404 error on refresh bug
Problem: When a user uses the skip link anchor to skip the navigation, the route was being changed to /#main-content. This route does not exist. If a user were to manually refresh the page, it would return a 404. This link is critical to meet accessibility guidelines and is needed by users that navigate with a keyboard.
The challenge is that we need to mirror a full page refresh on all route changes, so we set focus on the app-header element on each route change. When we click the skip to navigation link, there should not be a route change. All we need is to set focus on the <main> element so that the user can tab to the first tabbable element in the main content section.
Solution: - Use a native <a> element with an attached click event handler - Prevent the default action of adding the hash to the URL - Create a global mixin to reuse for route changes and skip link activation - Emit an event that can be listened for to call the global mixin
Signed-off-by: Derick Montague <derick.montague@ibm.com> Change-Id: I4c2301b02f608eeb376ed2d1bd809f3d5c1bf545
show more ...
|
f92e2969 | 09-Feb-2021 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Add enhancements to BVToastMixin
Adds ability to create toasts with multi-lined body content and options to include a timestamp and application refresh action.
Signed-off-by: Yoshie Muranaka <yoshi
Add enhancements to BVToastMixin
Adds ability to create toasts with multi-lined body content and options to include a timestamp and application refresh action.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I30b1da04a0e0b5f29a419950462d1ca35e207552
show more ...
|
ba91c499 | 27-Oct-2020 |
SurenNeware <sneware9@in.ibm.com> |
Update data option for components using Mixin data
- Removed all the data options from all the mixins. - Updated component data property relying on data property defined in mixin. - Export data pr
Update data option for components using Mixin data
- Removed all the data options from all the mixins. - Updated component data property relying on data property defined in mixin. - Export data property from mixin file itself.
Signed-off-by: Suren Neware <sneware9@in.ibm.com> Change-Id: I4aeffcb333bbaf5b78bcadd711b3169b0b4cb10e
show more ...
|
edb8a774 | 29-Oct-2020 |
Sukanya Pandey <sukapan1@in.ibm.com> |
Resolve custom-event-name-casing lint warnings
Signed-off-by: Sukanya Pandey <sukapan1@in.ibm.com> Change-Id: I9eea4eac3b8cacc216fc9ad1011e51622622e75f |
602e98aa | 21-Oct-2020 |
Derick Montague <derick.montague@ibm.com> |
Update linting packages to use latest
- 99% of changes were small syntax changes that were changed by the lint command. There were a couple of small manual changes to meet the property order pattern
Update linting packages to use latest
- 99% of changes were small syntax changes that were changed by the lint command. There were a couple of small manual changes to meet the property order patterns established as part of the vue:recommended guidelines.
There are rules that were set from errors to warnings and new stories are being opened to address those issues.
Testing: - Successfully ran npm run serve - Successfully ran npm run lint - Verified functionality works as expected, e.g. success and failure use cases - Resolved any JavaScript errors thrown to the console
Signed-off-by: Derick Montague <derick.montague@ibm.com> Change-Id: Ie082f31c73ccbe8a60afa8f88a9ef6dbf33d9fd2
show more ...
|
b53e0868 | 08-Sep-2020 |
Dixsie Wolmers <dixsie@ibm.com> |
Fix hardware status expand button accessiblity
- Aria label added to provide screen readers context for button action - Title added to chevron icon to display label on hover
Signed-off-by: Dixsie W
Fix hardware status expand button accessiblity
- Aria label added to provide screen readers context for button action - Title added to chevron icon to display label on hover
Signed-off-by: Dixsie Wolmers <dixsie@ibm.com> Change-Id: Ib8c0cef36d7aa61e0b4b0ac7fdabffb7e8a0a17a
show more ...
|
c2862dcc | 11-Sep-2020 |
SurenNeware <sneware9@in.ibm.com> |
Add icon to the toast component
- Add status icon to the toast component. - Add a method that return title with associated icon.
Signed-off-by: Suren Neware <sneware9@in.ibm.com> Change-Id: Iae75e3
Add icon to the toast component
- Add status icon to the toast component. - Add a method that return title with associated icon.
Signed-off-by: Suren Neware <sneware9@in.ibm.com> Change-Id: Iae75e3eec7317af6b25a0ed1bfa4cc72644f7cd7
show more ...
|
9b22b492 | 07-Sep-2020 |
Dixsie Wolmers <dixsie@ibm.com> |
Add table search filter clear button
- Adds ability to quickly clear a table input search field - Uses similar styling to password toggle icon and datepicker - Button style to be addressed in separa
Add table search filter clear button
- Adds ability to quickly clear a table input search field - Uses similar styling to password toggle icon and datepicker - Button style to be addressed in separate commit to match style guide
Signed-off-by: Dixsie Wolmers <dixsie@ibm.com> Change-Id: I18f2e01c28c00c7e7b2ad1af924070241caf36a5
show more ...
|
944840f0 | 04-Aug-2020 |
Sukanya Pandey <sukapan1@in.ibm.com> |
Remove date bug in event logs page
- Before this commit the filtering on date for offset timing wasnt working. -After this commit the filtering on date for UTC as well for offset is working as e
Remove date bug in event logs page
- Before this commit the filtering on date for offset timing wasnt working. -After this commit the filtering on date for UTC as well for offset is working as expected.
Signed-off-by: Sukanya Pandey <sukapan1@in.ibm.com> Change-Id: Ib627ce944c269dfe52b2ac4fd5670786ec05bb1f
show more ...
|
fcda2001 | 29-Jul-2020 |
Dixsie Wolmers <dixsie@ibm.com> |
Update Date and Time Settings to include UTC/offset label
Label updates allow the user to easily understand the expectation for entering time by using specific label text for "24 hour time" and remo
Update Date and Time Settings to include UTC/offset label
Label updates allow the user to easily understand the expectation for entering time by using specific label text for "24 hour time" and removing parenthesis from the helper text as parenthesis are not needed to in the input field.
UTC/offset is displayed based on user preference.
Signed-off-by: Dixsie Wolmers <dixsie@ibm.com> Change-Id: I41f98d9d16f0a4a81af39ce9b25768a1c0b89f08
show more ...
|
471f2e07 | 27-Jul-2020 |
Mateusz Gapski <mateuszx.gapski@intel.com> |
Disable elements on page during loading
Pages: Network settings, Date and time, LDAP, Manage power usage More details: https://github.com/openbmc/webui-vue/issues/15
Signed-off-by: Mateusz Gapski <
Disable elements on page during loading
Pages: Network settings, Date and time, LDAP, Manage power usage More details: https://github.com/openbmc/webui-vue/issues/15
Signed-off-by: Mateusz Gapski <mateuszx.gapski@intel.com> Change-Id: I02c5aaff180a4ce445b7135403a169a8db3704da
show more ...
|
0045400c | 22-Jun-2020 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Refactor global TableFilter component and mixin
Add key property to TableFilter component to make sure filtering is based on specific row property. Previously, the table filter was checking all row
Refactor global TableFilter component and mixin
Add key property to TableFilter component to make sure filtering is based on specific row property. Previously, the table filter was checking all row properties for matches.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I589886a0d487ac3ab8def585cc7286e61992afdb
show more ...
|
202c599e | 18-Jun-2020 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Update Sensors page to use table mixins
- Add number formatting to TableDataFormatter mixin - Use TableDataFormatter mixin to show different status icons for sensor status (OK, Warning, Critical)
Update Sensors page to use table mixins
- Add number formatting to TableDataFormatter mixin - Use TableDataFormatter mixin to show different status icons for sensor status (OK, Warning, Critical) - Use TableSortMixin to sort by status (OK, Warning, Critical)
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I99899bbc19db3529f0fdfe34be30b09d41456b42
show more ...
|
386df45f | 18-Jun-2020 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Update TableDataFormatter filename
Changed TableDataFormatter to TableDataFormatterMixin to be consistent with other Mixin files.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id
Update TableDataFormatter filename
Changed TableDataFormatter to TableDataFormatterMixin to be consistent with other Mixin files.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: Iae6528deda3099cf730150164739ee2fb64bbfe3
show more ...
|
54c6bfc2 | 12-Jun-2020 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Add BMC manager table to hardware status page
Add properties at /redfish/v1/Managers/bmc endpoint in a table with expandable row to view details.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmai
Add BMC manager table to hardware status page
Add properties at /redfish/v1/Managers/bmc endpoint in a table with expandable row to view details.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: Ieb32a9b2a535ddd7d24edcb68761c51eace2e5a8
show more ...
|
e24b17d2 | 08-Jun-2020 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Add DIMM slot table to hardware status page
Add items at /redfish/v1/Systems/system/Memory endpoint to DIMM slot table. The table is sortable and has a row expansion to view details. The code is cur
Add DIMM slot table to hardware status page
Add items at /redfish/v1/Systems/system/Memory endpoint to DIMM slot table. The table is sortable and has a row expansion to view details. The code is currently missing most properties needed to match the design. This table will need to be revisited when all properties are available.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I07cacf3403fe84431cb9fe0e4315069fc7baf27d
show more ...
|
5918b48a | 08-Jun-2020 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Add power supplies table to hardware status page
Adds items at /redfish/v1/Chassis/chassis/Power endpoint in Power supplies table. Table is sortable and has a row expansion to view details.
- Table
Add power supplies table to hardware status page
Adds items at /redfish/v1/Chassis/chassis/Power endpoint in Power supplies table. Table is sortable and has a row expansion to view details.
- Table sort mixin to reuse sort method for status values
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: Ib2953ad06be3fa25e9dbbbed34e37d09154431f5
show more ...
|
56ee769f | 28-May-2020 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Add Hardware status page and system table
Adds ability to see system information in table format with a row expansion details view. Modified tables styles to add table borders.
Created global mixin
Add Hardware status page and system table
Adds ability to see system information in table format with a row expansion details view. Modified tables styles to add table borders.
Created global mixin for table data formatting: - Show '--' for undefined or empty string values - Map Redfish health status options to status-icon values
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I5b45c37997647f5a265c1e84eb53f0b51699ee20
show more ...
|