#
883a0d59 |
| 23-Mar-2024 |
Ed Tanous <ed@tanous.net> |
i18n, vue-router and vuex upgrade
1. Configuration of i18n legacy as false. 2. Translation function t is called using the useI18n. 3. Used the i18n.global.t() function from i18n instead of this.$t()
i18n, vue-router and vuex upgrade
1. Configuration of i18n legacy as false. 2. Translation function t is called using the useI18n. 3. Used the i18n.global.t() function from i18n instead of this.$t() 4. Event bus error that occurred during logout. 5. Implemented vue-router 4.4.0 and vuex upgrade to 4.1.0
Change-Id: I9464d82c76dcc1445ce271983ea3ab9d7b03d265 Signed-off-by: Surya Venkatesan <suryav@ami.com>
show more ...
|
#
7d6b44cb |
| 23-Mar-2024 |
Ed Tanous <ed@tanous.net> |
Upgrade vue3 and all dependencies
Start the process of porting everything to Vue 3. I have most things working. npm run-scripts build works, npm install works. prettier passes. Styles load, logi
Upgrade vue3 and all dependencies
Start the process of porting everything to Vue 3. I have most things working. npm run-scripts build works, npm install works. prettier passes. Styles load, login works, webui loads.
This was primarily done using the linked documents below. It makes the following design decisions: 1. Vue is put in compat 2 mode, which allows most of the components to work as-is. 2. Bootstrap v4 is used along with bootstrap-vue to keep our components working. 3. Minor changes are made to load the latest versions of vue-router, vuex, and vue-i18n.
I suspect this patchset is good enough to start with, and we can clean up the broken things one patchset at a time. The things that need to happen are:
1. Get remaining features working again. This primiarily is vue-i18n for mixins, and non vue components. This likely needs to be done by not pulling in i18n into the non vue components, then using the .Vue files to do the internationalization in the component context, NOT in the mixin context. Alternatively, we could drop MixIns alltogether. 2. Get custom styles working again. Previously, we used some path hackery in vue.config.js to optionally pre-load styles. This stops working now that we're required to @import our modules. Likely we need some rearangement of the paths such that custom styles are a complete replacement (possibly importing the original) rather than additive with overrides. That's a guess, but I don't really see anyone else doing customization the way we've defined it here. 3. Bootstrap 5 no longer requires ANY custom vue modules, as it has dropped the jquery dependency. We won't be able to pull in bootstrap 5 all at once, so pull in bootstrap 5 under an alias, like "bootstrap5" that we can optionally import 5 or 4. 4. One at a time, start porting components over to Vue3 syntax and bootstrap 5. This will be the bulk of the manual work and review.
The only thing I think left is getting unit tests passing, which I commented out the pre-commit hook to make this PR.
Tested: Code builds. Needs better testing.
[1] https://router.vuejs.org/guide/migration/ [2] https://vue-i18n.intlify.dev/guide/migration/vue3 [3] https://vuelidate-next.netlify.app/migration_guide.html#package-name-and-imports
Change-Id: I5bb3187b9efbf2e4ff63e57994bc528756e2a981 Signed-off-by: Ed Tanous <ed@tanous.net>
show more ...
|
#
6e2cb978 |
| 24-Dec-2020 |
SurenNeware <sneware9@in.ibm.com> |
Fixed icon or text only button accessibility
- Add sr-only element to icon only buttons - Removed title from text only buttons
Signed-off-by: Suren Neware <sneware9@in.ibm.com> Change-Id: Ica57dec7
Fixed icon or text only button accessibility
- Add sr-only element to icon only buttons - Removed title from text only buttons
Signed-off-by: Suren Neware <sneware9@in.ibm.com> Change-Id: Ica57dec70401c04a9d7506306a406fe394e52113
show more ...
|
#
86e11ad3 |
| 04-Jan-2021 |
Derick Montague <derick.montague@ibm.com> |
Update class name and improve transition
The class name showBtn uses a camelCase naming convention and CSS selector names use the kebab-case naming convention. The z-index solution is not needed if
Update class name and improve transition
The class name showBtn uses a camelCase naming convention and CSS selector names use the kebab-case naming convention. The z-index solution is not needed if we hide the element with visibility. Using both opacity and visibility allows the transition to be elegant.
Signed-off-by: Derick Montague <derick.montague@ibm.com> Change-Id: Ie555f958daaadd2bc3a3777b6c2bc7d5e83a0cc5
show more ...
|
#
8eafd37b |
| 28-Dec-2020 |
SurenNeware <sneware9@in.ibm.com> |
Fixed Back to top button appearance issue
- Changed back to top button style when its getting disappear. - So that button should not come over the page contents.
Signed-off-by: Suren Neware <snewar
Fixed Back to top button appearance issue
- Changed back to top button style when its getting disappear. - So that button should not come over the page contents.
Signed-off-by: Suren Neware <sneware9@in.ibm.com> Change-Id: I0a013c2bcdd291edd9f52566130882360451a280
show more ...
|