cmd/otp: Fix struct storage type

Signed-off-by: Joel Stanley <joel@jms.id.au>

otp: print actual value for programming data region

Print actual value for data region, could be 0 or 1.

Signed-off-by: Neal Liu <neal_liu@aspeedtech.com>
Change-Id: I4ecdf6fde2e20403ba5d8de39d4fb0

otp: print actual value for programming data region

Print actual value for data region, could be 0 or 1.

Signed-off-by: Neal Liu <neal_liu@aspeedtech.com>
Change-Id: I4ecdf6fde2e20403ba5d8de39d4fb0fb4da6ac2f

show more ...

cmd/otp: Fix struct storage type

Signed-off-by: Joel Stanley <joel@jms.id.au>

otp: remove bit-field declaration

Fix integer comparison wrong problem by removing bit-field
declaration.

Signed-off-by: Neal Liu <neal_liu@aspeedtech.com>
Change-Id: Ia2465cf75025b9d6f1e606d5d5079

otp: remove bit-field declaration

Fix integer comparison wrong problem by removing bit-field
declaration.

Signed-off-by: Neal Liu <neal_liu@aspeedtech.com>
Change-Id: Ia2465cf75025b9d6f1e606d5d5079b309627b16a

show more ...

cmd/otp: Fix bitfield storage type

As pointed out by Zev, a one-bit bitfield should use an unsigned type to
avoid warnings from tools such as sparse.

Signed-off-by: Joel Stanley <joel@jms.id.au>

otp: write inversed compared data in OTP reg

The data used for comparison must be bit-wise inversed.

Signed-off-by: Neal Liu <neal_liu@aspeedtech.com>
Change-Id: Ib7d1de6d50e58b9e7ce20e1034c8031b94

otp: write inversed compared data in OTP reg

The data used for comparison must be bit-wise inversed.

Signed-off-by: Neal Liu <neal_liu@aspeedtech.com>
Change-Id: Ib7d1de6d50e58b9e7ce20e1034c8031b94504274

show more ...

cmd/otp: Fix error 'maybe-uninitialized'

The error is as below:
error: 'key_info.information' may be used uninitialized in this function
[-Werror=maybe-uninitialized]
1395 | printf("%s\n", key_in

cmd/otp: Fix error 'maybe-uninitialized'

The error is as below:
error: 'key_info.information' may be used uninitialized in this function
[-Werror=maybe-uninitialized]
1395 | printf("%s\n", key_info.information);

Change-Id: Id76623518cc5e9bd1c73ab04899d55c19dba8923
Signed-off-by: Jammy Huang <jammy_huang@aspeedtech.com>

show more ...

cmd/otp: Fix bitfield storage type

As pointed out by Zev, a one-bit bitfield should use an unsigned type to
avoid warnings from tools such as sparse.

Signed-off-by: Joel Stanley <joel@jms.id.au>

cmd/otp: Reduce size of otpkey

Don't store more information than is used. Saves 3KB.

Function old new delta
_otp_print_key

cmd/otp: Reduce size of otpkey

Don't store more information than is used. Saves 3KB.

Function old new delta
_otp_print_key 540 580 +40
otp_verify_boot_image 1276 1268 -8
a2_key_type 640 40 -600
a1_key_type 640 40 -600
a3_key_type 1024 64 -960
a0_key_type 1024 64 -960
Total: Before=266547, After=263459, chg -1.16%

Signed-off-by: Joel Stanley <joel@jms.id.au>

show more ...

cmd/otp: Use hashing API

Instead of calling the hashing functions directly, which uses the
software implementation of the algorithms, use the hash API which
allows the use of the HACE driver.

Saves

cmd/otp: Use hashing API

Instead of calling the hashing functions directly, which uses the
software implementation of the algorithms, use the hash API which
allows the use of the HACE driver.

Saves 12.5KB:

Before=279327, After=266547, chg -4.58%

Signed-off-by: Joel Stanley <joel@jms.id.au>

show more ...

cmd/otp: Use any MOD_EXP driver

Instead of requesting the ACRY driver specifically, ask for the first
DM device that implements MOD_EXP.

Selecting RSA ensures that one of the MOD_EXP drivers will b

cmd/otp: Use any MOD_EXP driver

Instead of requesting the ACRY driver specifically, ask for the first
DM device that implements MOD_EXP.

Selecting RSA ensures that one of the MOD_EXP drivers will be built in.
On Aspeed platforms this will be either the ACRY or the software
implementation; Kconfig logic stops both from being built in.

Signed-off-by: Joel Stanley <joel@jms.id.au>

show more ...

otp: add 'invalid' sub-command

'invalid' is used to invalid a key in OTP, it will set the key header
type to 0x0 of 0xf.

Signed-off-by: Johnny Huang <johnny_huang@aspeedtech.com>
Change-Id: Ibe4810

otp: add 'invalid' sub-command

'invalid' is used to invalid a key in OTP, it will set the key header
type to 0x0 of 0xf.

Signed-off-by: Johnny Huang <johnny_huang@aspeedtech.com>
Change-Id: Ibe4810e02ed42a2c3b09ddde9630cf245b898e78

show more ...

otp: add 'verify' sub-command

update otp tool to v2.0.0

Signed-off-by: Johnny Huang <johnny_huang@aspeedtech.com>
Change-Id: I575c549f872a0a76a4071067073316e01b4b10a9

otp: update image checksum to SHA384

Update otp image checksum algorithm from sha256 to sha384.

Change-Id: Ic1a191e0e726137526ebde9302ddb7ceca80bad8

cmd: aspeed: otp: fix otp status polling

add delay in otp status polling to fix hanhing issue.

Signed-off-by: Johnny Huang <johnny_huang@aspeedtech.com>
Change-Id: Ic7b8d68c95956ed989c40ed79adcc5ca

cmd: aspeed: otp: fix otp status polling

add delay in otp status polling to fix hanhing issue.

Signed-off-by: Johnny Huang <johnny_huang@aspeedtech.com>
Change-Id: Ic7b8d68c95956ed989c40ed79adcc5ca8df5fcd2

show more ...

otp: fix compatible issue for otp image

Current otp programming can accept otp image which is generated by
v1.x.x otp tool.

Signed-off-by: Johnny Huang <johnny_huang@aspeedtech.com>
Change-Id: I4d2

otp: fix compatible issue for otp image

Current otp programming can accept otp image which is generated by
v1.x.x otp tool.

Signed-off-by: Johnny Huang <johnny_huang@aspeedtech.com>
Change-Id: I4d230c6e38bdc09b7396157f115d2360aad93856

show more ...

otp: fix image info print format

Signed-off-by: Johnny Huang <johnny_huang@aspeedtech.com>
Change-Id: Ie73f2981e949e713b939ff8b58605f76604cd80e

otp: fix config info

fix 'keys retire' info

Signed-off-by: Johnny Huang <johnny_huang@aspeedtech.com>
Change-Id: Ifae8e1ecb5088495183cfa7884027c2c71ec86eb

otp: update otp tool version

1. fix A2 and above OTP mode register
2. add checking otptool version of otp image
3. fix otp scu register protect
4. add "scuprotect" subcommand
5. add "retire" subcomm

otp: update otp tool version

1. fix A2 and above OTP mode register
2. add checking otptool version of otp image
3. fix otp scu register protect
4. add "scuprotect" subcommand
5. add "retire" subcommand
6. check programmable before program

Signed-off-by: Johnny Huang <johnny_huang@aspeedtech.com>
Change-Id: Idb6f593cecd3512a5b8c8149a068657099f939f4

show more ...

otp: add 'otp info key' subcommand

add 'otp info key' subcommand to print key info.

Change-Id: Id8243f7a37dd53315da3120ddbd6d6f803dd8ac3

otp: add 'retire' subcommand

add 'retire' subcommand to retire otp key.

Signed-off-by: Johnny Huang <johnny_huang@aspeedtech.com>
Change-Id: Ie081ba726cc24fb90821381fb1038f18c4dd51f0

otp: add '0x' before hex print

Signed-off-by: Johnny Huang <johnny_huang@aspeedtech.com>
Change-Id: I57203718726e0e0445ca75f578768cee94d80ba6

otp: update otp prog subcommand for new image format

new otp image add scu protect partition, update 'prog' subcommand to
support that.

Signed-off-by: Johnny Huang <johnny_huang@aspeedtech.com>
Cha

otp: update otp prog subcommand for new image format

new otp image add scu protect partition, update 'prog' subcommand to
support that.

Signed-off-by: Johnny Huang <johnny_huang@aspeedtech.com>
Change-Id: I9f8e6d86d30ba2ae21b5b54d69e18ad4e91e492c

show more ...

otp: check image programmable before confirm

Signed-off-by: Johnny Huang <johnny_huang@aspeedtech.com>
Change-Id: I1cba741a3b42555b7fda3f7434e6e87521daee27

otp: check writable before programming bit

Signed-off-by: Johnny Huang <johnny_huang@aspeedtech.com>
Change-Id: I40229e4597b9943559ec1ac0d9b45b76f674518a