Revert "created AddReportFutureVersion dbus method"

This reverts commit 753e4b3c843dd5d1068949c4106a6389f0e0ffbc.

Reason for revert: Breaks bmcweb, same approach is needed for changed properties

C

Revert "created AddReportFutureVersion dbus method"

This reverts commit 753e4b3c843dd5d1068949c4106a6389f0e0ffbc.

Reason for revert: Breaks bmcweb, same approach is needed for changed properties

Change-Id: Id868159df916fcf0bdd7fc5062f8c51187fcc7e2

show more ...

async changes to support 40749

https://gerrit.openbmc-project.xyz/c/openbmc/sdbusplus/+/40749

Is currently proposing changing these APIs to use C++ asio style
callbacks instead of the javascript ca

async changes to support 40749

https://gerrit.openbmc-project.xyz/c/openbmc/sdbusplus/+/40749

Is currently proposing changing these APIs to use C++ asio style
callbacks instead of the javascript callbacks. This was the only usage
of these callbacks that I found, so this patchset is to move to the new
type.

Requires 40749 to be merged before this will build.

Signed-off-by: Ed Tanous <edtanous@google.com>
Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com>
Change-Id: I1e950c096e36d2150a94c459e794bbac7303100d

show more ...

created AddReportFutureVersion dbus method

New method will support CollectionTimeScope, CollectionDuration

In order to make not breaking interface changes bmcweb will switch to
AddReportFutureVersi

created AddReportFutureVersion dbus method

New method will support CollectionTimeScope, CollectionDuration

In order to make not breaking interface changes bmcweb will switch to
AddReportFutureVersion, then AddReport will be changed to match
AddReportFutureVersion, then redfish will switch back to use AddReport,
then AddReportFutureVersion will be removed.

Change-Id: I9cc906cc1fa7cdf27be7e433390c516f6bae3c50
Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com>

show more ...

clang-format-11: reformat

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I7053c31b9d6236342a4c151888d81fa2a393281d

Match DBus Trigger with phosphor-dbus-interfaces

Matched Trigger DBus interface to the one defined in
phosphor-dbus-interfaces repository. Changed enum (int) type to
string to reflect enum type defi

Match DBus Trigger with phosphor-dbus-interfaces

Matched Trigger DBus interface to the one defined in
phosphor-dbus-interfaces repository. Changed enum (int) type to
string to reflect enum type defined in Trigger.yaml.
Fixed style in boost_build_1.74.0.sh script.

Tested:
- Passed unit tests
- Verified manually Trigger DBus object in witherspoon image
on QEMU

Change-Id: I87175fc285afd182d1383da5879f89233b9de6a0
Signed-off-by: Wludzik, Jozef <jozef.wludzik@intel.com>

show more ...

Add simple Redfish tests

Added Redfish tests to validate connection between Redfish
Telemetry that is implemented in bmcweb and Telemetry service.

Change-Id: Iacc63aeb7f2852d5acac5d5615f98b402f7c44

Add simple Redfish tests

Added Redfish tests to validate connection between Redfish
Telemetry that is implemented in bmcweb and Telemetry service.

Change-Id: Iacc63aeb7f2852d5acac5d5615f98b402f7c4417
Signed-off-by: Wludzik, Jozef <jozef.wludzik@intel.com>

show more ...

Changed dbus add report interface

- metric parameters now take single sensor instead of list
- added interface support for new operation types

Tested:
- All telemetry tests are passing.

Signed-off

Changed dbus add report interface

- metric parameters now take single sensor instead of list
- added interface support for new operation types

Tested:
- All telemetry tests are passing.

Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com>
Change-Id: Id3a41c48e81a287e7d205ae1c747daa36d4cdb29

show more ...

Update README.md file

Added how to build section to README file. Updated references.

Signed-off-by: Wludzik, Jozef <jozef.wludzik@intel.com>
Change-Id: I8a9070d776119206e7c63fc61bc6975ea4f7d184

Fix meson file and remove warnings from compilation

Fixed meson file by applying proper dependency. Removed boost from
subprojects because boost does not support cmake and meson. User
is able to bui

Fix meson file and remove warnings from compilation

Fixed meson file by applying proper dependency. Removed boost from
subprojects because boost does not support cmake and meson. User
is able to build boost manually or using a script
boost_build_1.74.0.sh and set BOOST_ROOT variable to build files.
Then reruning meson should detect boost dependency with positive
result.

Removed all warnings from compilation by applying a new flag for
boost - BOOST_ALLOW_DEPRECATED_HEADERS, after boost update this
flag should be removed. Changed tmpnam() with temp_directory_path
provided by std::filesystem.

Tested:
- Built telemetry with success in cases when different components
are not installed on system: nlohmann, sdbusplus, googletest,
phosphor-logging.
- Using BOOST_ROOT variable that points to installation location
of boost allows to build telemetry wihtout boost installed on
system.
- Unit test passed.

Change-Id: I8d430f4c51b7bc6669c8533e1a76c4666efd4fc6
Signed-off-by: Wludzik, Jozef <jozef.wludzik@intel.com>

show more ...

Implement Trigger Actions

Now action is triggered when threshold is crossed. There are 3
actions: write message to journal, write message to journal as
Redfish Event and update an existing Report.
T

Implement Trigger Actions

Now action is triggered when threshold is crossed. There are 3
actions: write message to journal, write message to journal as
Redfish Event and update an existing Report.
To update an existing Report updateReading method is changed to
public. Added UpdateReport to ReportManager, now object is able
to update readings of any report using report name.

Tested:
- Unit tests passed
- Verified that logs are propagated to journal when threshold
is crossed

Change-Id: Iebca7c8b9ab9b50b4c401877ccf8c2f01f1e6f36
Signed-off-by: Wludzik, Jozef <jozef.wludzik@intel.com>

show more ...

Implement NumericThreshold for Trigger

Implemented NumericThreshold for Trigger that allows to set
expected threshold value for collection of sensors and monitors
if this value is crossed. Implement

Implement NumericThreshold for Trigger

Implemented NumericThreshold for Trigger that allows to set
expected threshold value for collection of sensors and monitors
if this value is crossed. Implemented detection of direction
when threshold value is crossed. Added initial interface that
is used to commit an action when threshold value is crossed.
Moved Sensor Cache from Report Factory to Telemetry class, now
Sensor Cache is shared between Report Factory and Trigger Factory.
Moved fetching sensor from Dbus to seperate header to have single
implementation for factories.
Disabled tests that uses boost coroutine because of false positive
that is catched by address sanitizer.

Tested:
- Passed unit tests
- Built in yocto envrionment with success
- Telemetry service started successfully in OpenBMC

Change-Id: I1ff7ab96174a27576786f0b9a71554fe1eeff436
Signed-off-by: Wludzik, Jozef <jozef.wludzik@intel.com>

show more ...

Add TriggerManager and Trigger objects

Implemented initial version of Trigger and TriggerManager DBus
interfaces. Now DBus user is able to add new Trigger and delete it.
There is no support for othe

Add TriggerManager and Trigger objects

Implemented initial version of Trigger and TriggerManager DBus
interfaces. Now DBus user is able to add new Trigger and delete it.
There is no support for other functionality added.

Tested:
- Built using yocto dependencies with success
- Unit tests passed
- Verified manually if Trigger and TriggerManager works as
expected

Change-Id: Ie68463526ecccc3be67cc7bfaaf9a9aa7326dee6
Signed-off-by: Wludzik, Jozef <jozef.wludzik@intel.com>

show more ...

Fix entries used by phosphor-logging

Fixed entires used by phosphor::logging::log function. Now logs
display proper information.

Tested: - Verified if logs contain correct entries

Change-Id: I5254

Fix entries used by phosphor-logging

Fixed entires used by phosphor::logging::log function. Now logs
display proper information.

Tested: - Verified if logs contain correct entries

Change-Id: I5254555aa55bbe06c882d7024db911812e6f3f63
Signed-off-by: Wludzik, Jozef <jozef.wludzik@intel.com>

show more ...

Add meson options to modify Telemetry consts

Added 'min-interval', 'max-reading-parameters' and 'max-reports'
to meson_options to allow user to control Telemetry constant
values. Now user is able to

Add meson options to modify Telemetry consts

Added 'min-interval', 'max-reading-parameters' and 'max-reports'
to meson_options to allow user to control Telemetry constant
values. Now user is able to adjust those values to platform.
Fixed checking maximal number of ReadingParameters in Report.
Synced type of properties with interface defined in
phosphor-dbus-interface.

Tested:
- Unit tests passes

Change-Id: Ie8c009931d9e5e22b30d7df82c81aaac8d68dd3e
Signed-off-by: Wludzik, Jozef <jozef.wludzik@intel.com>

show more ...

Add extra input validation for AddReport

Now AddReport checks if ReadingParams exceeds limits that is set
to 200. AddReport checks if interval is less than allowed interval
only for Periodic reports

Add extra input validation for AddReport

Now AddReport checks if ReadingParams exceeds limits that is set
to 200. AddReport checks if interval is less than allowed interval
only for Periodic reports. AddReport verify if only single sensor
for each reading parameters is provided.

Tested:
- Ran unit-tests with success.
- Added few reports in OpenBMC environment to check if results are
as expected.

Signed-off-by: Wludzik, Jozef <jozef.wludzik@intel.com>
Change-Id: Ife4f8a4cf6a8dc3fa526b66e4c698a57a733de48

show more ...

Update MAINTAINERS

Adding two main contributors to openbmc/telemetry as maintainers.

Thank you Jozef and Krzysztof for enormous work in delivering
the solution!

Signed-off-by: Adrian Ambrożewicz <

Update MAINTAINERS

Adding two main contributors to openbmc/telemetry as maintainers.

Thank you Jozef and Krzysztof for enormous work in delivering
the solution!

Signed-off-by: Adrian Ambrożewicz <adrian.ambrozewicz@intel.com>
Change-Id: I93cb028e6b2ba086ae5d4a87664de2ab2741cb05

show more ...

Review fixes for 'Created metric class'

- Changed metric to_json to dumpConfiguration returning LabeledTuple
- LabeledTuple can be created and assigned directly to json
- LabeledTuple can be readed

Review fixes for 'Created metric class'

- Changed metric to_json to dumpConfiguration returning LabeledTuple
- LabeledTuple can be created and assigned directly to json
- LabeledTuple can be readed from json using json.get<LabeledTuple>
- Added PrintTo for LabeledMetricParams, LabeledSensorParams
- Added helper method expectMake to ReportFactoryMock
- sensorPaths are serialized to tuple<service, path> instead of single
field with service and path separated via ':'
- Changed configuration version from 1 to 2

Change-Id: I7c45fb584687172f88fd549a93329264793b0b8e
Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com>

show more ...

Remove retry "GetProperty" on fail

Removed retry "GetProperty" on fail when sensor is not present.
Monitoring PropertiesChanged signal is enough to get the latest
value from sensor when it is added

Remove retry "GetProperty" on fail

Removed retry "GetProperty" on fail when sensor is not present.
Monitoring PropertiesChanged signal is enough to get the latest
value from sensor when it is added to dbus environment. Added
test that check if newly added properties to dbus environment
send PropertiesChanged signal.

Tested: - All unit tests passed

Change-Id: Ibe92b23dd062a6d48b0b6d5bc0dc2198bcfa7a5e
Signed-off-by: Wludzik, Jozef <jozef.wludzik@intel.com>

show more ...

Add support for EmitReadingsUpdate property

EmitReadingsUpdate property determines whether Readings
property emits PropertiesChange signal on update.
EmitReadingsUpdate can be used to reduce broadca

Add support for EmitReadingsUpdate property

EmitReadingsUpdate property determines whether Readings
property emits PropertiesChange signal on update.
EmitReadingsUpdate can be used to reduce broadcasting of
signals from Telemetry to lower DBus utilization and hide
Readings update information from other DBus applications.

Tested:
- Verify if properties are properly propated during Report
creation.
- Verify if emitting PropertiesCahgned signal for Readings
property is disabled when emitReadingsUpdate is set to false.
- Unit tests are passed with success.

Change-Id: I81be5bc17de6d583dd5820e091d077d474fe424e
Signed-off-by: Wludzik, Jozef <jozef.wludzik@intel.com>

show more ...

Created metric class

Metric collects updates from sensor. Report displays metric readings
depending on reportingType.

Tested:
- Added new units tests for Metric class
- All other unit tests are

Created metric class

Metric collects updates from sensor. Report displays metric readings
depending on reportingType.

Tested:
- Added new units tests for Metric class
- All other unit tests are passing

Change-Id: I19f4831fab163a4f9540cef7bb23e903ae90fddf
Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com>

show more ...

Added Update method to report on dbus

- Update method, updates timestamp and readings

Tested:
- Added new unit tests covering update method
- All existing unit tests are passing

Change-Id: I6b

Added Update method to report on dbus

- Update method, updates timestamp and readings

Tested:
- Added new unit tests covering update method
- All existing unit tests are passing

Change-Id: I6b3829126d9060dbaf436cbf8e6917294dc03134
Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com>

show more ...

Implement Report persistency

Now Report properties are stored in non-volatile memory. It allows
to restore Report after system restart. Persistency of a report is
controlled by Persistency property

Implement Report persistency

Now Report properties are stored in non-volatile memory. It allows
to restore Report after system restart. Persistency of a report is
controlled by Persistency property in Report interface.

Tested:
- Passed unit tests
- Verified that report is stored in /var/lib/telemetry dir
- Verified that report is restored from storage after telemetry
service start

Signed-off-by: Wludzik, Jozef <jozef.wludzik@intel.com>
Change-Id: Iccfe21603eecffc4e174a4403f699b03de320db9

show more ...

Fix CI job

Decreased meson version to 0.54.3 to enable CI jobs.
Fixed Invoke arguments in unit tests.

Change-Id: I75cdce3ebb2bffd7732db30b2f718a3728c277c8
Signed-off-by: Wludzik, Jozef <jozef.wludz

Fix CI job

Decreased meson version to 0.54.3 to enable CI jobs.
Fixed Invoke arguments in unit tests.

Change-Id: I75cdce3ebb2bffd7732db30b2f718a3728c277c8
Signed-off-by: Wludzik, Jozef <jozef.wludzik@intel.com>

show more ...

Added Periodic reportingType support to Report

When report interval expires report will collect readings from
metrics and update timestamp.

Tested:
- Added new units tests covering added code
-

Added Periodic reportingType support to Report

When report interval expires report will collect readings from
metrics and update timestamp.

Tested:
- Added new units tests covering added code
- All existing unit tests are passing

Change-Id: I7f23ca05d77efb0f18d2c0d0f138c524ffb4f6af
Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com>

show more ...

Add ReportManager and Report unit tests

Introduced ReportFactory to seperate Report and ReportManager
unit tests. Implemented mocks for Report, ReportManager and
ReportFactory classes. Added tests f

Add ReportManager and Report unit tests

Introduced ReportFactory to seperate Report and ReportManager
unit tests. Implemented mocks for Report, ReportManager and
ReportFactory classes. Added tests for DBus Properties and Methods
provided by telemetry service.

Tested:
- Ran unit-tests with success

Change-Id: I1860e280d26ee4becc52de98dd65e5697d26b376
Signed-off-by: Wludzik, Jozef <jozef.wludzik@intel.com>

show more ...