Enable disabled unit tests

Enabling tests that were initially disabled, most probably because
corresponding features had yet been in development.

Tested:
Lines coverage increased:
- src/report_mana

Enable disabled unit tests

Enabling tests that were initially disabled, most probably because
corresponding features had yet been in development.

Tested:
Lines coverage increased:
- src/report_manager.cpp: 94.2% -> 97.5%
- src/trigger_manager.cpp: 94.9% -> 99.0%
- src/utils/dbus_path_utils.cpp: 94.6% -> 100.0%

Change-Id: Id729c7f2e7e188d878b7348c710a09a4ceb40fd4
Signed-off-by: Michal Orzel <michalx.orzel@intel.com>

show more ...

Fix sanitizer issue

Resolve heap-use-after-free issue that started appearing after
googletest update. According to docs, AddGlobalTestEnvironment takes
ownerwhip of an Environment object passed ther

Fix sanitizer issue

Resolve heap-use-after-free issue that started appearing after
googletest update. According to docs, AddGlobalTestEnvironment takes
ownerwhip of an Environment object passed there and it's being destroyed
at the end of RUN_ALL_TESTS function. [1] Therefore any further usage of
that object will cause heap-use-after-free error.

Tested:
CI build passed

[1] https://google.github.io/googletest/advanced.html#global-set-up-and-tear-down

Change-Id: I517a7693a5692c4561de6a5e5ee8ebaf9d8cdc2d
Signed-off-by: Michal Orzel <michalx.orzel@intel.com>

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I956cf3cb1bbfc017c4d4dceb3195c1d0735b0605
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Verify reading parameters on update

Adds verification of ReadingParameter's metric count when property is
being updated. This brings consistency with behavior upon adding a new
report, where that sa

Verify reading parameters on update

Adds verification of ReadingParameter's metric count when property is
being updated. This brings consistency with behavior upon adding a new
report, where that same check is being made. Also adds a unit test for
that check.

Tested:
On platform, by updating report's ReadingParameter with object
containing metric count exceeding one specified by
`max-reading-parameters` project option. With this change applied, that
operation failed, as expected.

Change-Id: I06c8e21178d6bd554b62886e0e4f8cd0589f0d09
Signed-off-by: Michal Orzel <michalx.orzel@intel.com>

show more ...

Fix MD034 warnings

The following warnings are generated by using markdownlint analysis:
```
redfish-tests/README.md:23:4 MD034/no-bare-urls Bare URL used [Context: "https://localhost:443"]
redfish-t

Fix MD034 warnings

The following warnings are generated by using markdownlint analysis:
```
redfish-tests/README.md:23:4 MD034/no-bare-urls Bare URL used [Context: "https://localhost:443"]
redfish-tests/README.md:23:38 MD034/no-bare-urls Bare URL used [Context: "https://localhost:4443"]
```
Refer to markdown-lint [1] to fix MD034
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/034-no-bare-urls.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I90856ee4a0eb9b0079614207e0c16c679e578bf9

show more ...

Add gcovr config

Adds configuration file for gcovr coverage scan.

Change-Id: I27bdea88b5901cc18ccd8cfa333dc35b80bf1625
Signed-off-by: Michal Orzel <michalx.orzel@intel.com>

Add security check for directory symlinks

Currently only files symlink are verified during file operations.
This change is extending check to all directories in path.

Testing done:
- UTs are passin

Add security check for directory symlinks

Currently only files symlink are verified during file operations.
This change is extending check to all directories in path.

Testing done:
- UTs are passing

Signed-off-by: Szymon Dompke <szymon.dompke@intel.com>
Change-Id: I1f30de94872d2a25597d3549224cd90aa8fab634

show more ...

Adjust LogToRedfish trigger action to DMTF standard

This patch modifies messages sent to Redfish event log to be compliant
with message registry schema [1].

Tested:
On platform, with corresponding

Adjust LogToRedfish trigger action to DMTF standard

This patch modifies messages sent to Redfish event log to be compliant
with message registry schema [1].

Tested:
On platform, with corresponding bmcweb patch [2]. Verified that messages
appearing in Redfish event log are compliant with schema. UTs passed.

[1] https://redfish.dmtf.org/registries/Telemetry.1.0.0.json
[2] https://gerrit.openbmc.org/c/openbmc/bmcweb/+/72315

Change-Id: Ide3d5a13e5be077806df6398c5f51da41f7a7922
Signed-off-by: Michal Orzel <michalx.orzel@intel.com>

show more ...

Address Valgrind issues in CI

Fixes "uninitialized values" errors reported by Valgrind. Problem
occurred from lack of specializations of googletest's PrintTo functions
for several custom types.

Tes

Address Valgrind issues in CI

Fixes "uninitialized values" errors reported by Valgrind. Problem
occurred from lack of specializations of googletest's PrintTo functions
for several custom types.

Tested:
On local CI container. After applying this patch issues stopped
appearing.

Change-Id: I98d9fd19724bee15add7b19422a9ddc2e4cbef09
Signed-off-by: Michal Orzel <michalx.orzel@intel.com>

show more ...

meson: adjust nlohmann-json dependency

- Simplify nlohmann-json dependency in meson.build.
- Use consistent dependency variable names (based on Meson style).
- Align wrap file name with meson wrapdb

meson: adjust nlohmann-json dependency

- Simplify nlohmann-json dependency in meson.build.
- Use consistent dependency variable names (based on Meson style).
- Align wrap file name with meson wrapdb choice for the project.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I2e893fd8c300b36a16d704f2002bb966a6e52ce4

show more ...

meson_options.txt: Support for reading options from meson.options

Support has been added for reading options from meson.options instead
of meson_options.txt[1]. These are equivalent, but not using t

meson_options.txt: Support for reading options from meson.options

Support has been added for reading options from meson.options instead
of meson_options.txt[1]. These are equivalent, but not using the .txt
extension for a build file has a few advantages, chief among them
many tools and text editors expect a file with the .txt extension to
be plain text files, not build scripts.

[1] https://mesonbuild.com/Release-notes-for-1-1-0.html#support-for-reading-options-from-mesonoptions

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I90cc30833435f641223fe8e7f88458ae7fe1db95

show more ...

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: If193a9f16c90ba8ac423a

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: If193a9f16c90ba8ac423aec7e5660bea524ce891
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I016cb74930cc475843c30bd604e739058effa504
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Fix static code analysis tool failures

Uncaught exception (boost::system::system_error) is now caught.

Change-Id: I0aa88f173a982ecebfa999fd44ed864be709240c
Signed-off-by: Wojciech Tempczyk <wojciec

Fix static code analysis tool failures

Uncaught exception (boost::system::system_error) is now caught.

Change-Id: I0aa88f173a982ecebfa999fd44ed864be709240c
Signed-off-by: Wojciech Tempczyk <wojciechx.tempczyk@intel.com>

show more ...

Remove OWNERS which are unqualified

Commit cc8abc0be58c19acd088da455454fdf466a1745f added owners which
do not qualify based on the overall project requirements:

https://github.com/openbmc/docs/blob

Remove OWNERS which are unqualified

Commit cc8abc0be58c19acd088da455454fdf466a1745f added owners which
do not qualify based on the overall project requirements:

https://github.com/openbmc/docs/blob/master/community-membership.md#subproject-owner

There has been no response on Gerrit to an inquiry about this by anyone
currently listed as an OWNER. Removing the "owner add" portion of
cc8abc0be58c19acd088da455454fdf466a1745f until this can be resolved.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I3d0ed615056d33e29da100489fe14f454b473840

show more ...

passing owner responsibilities

Change-Id: I0561af6d0fac610c4ec77eb009ca040ac4f2002d
Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com>

Removed FutureVersion from API

Instead of using FutureVersion API currently used version is updated.
This change needs to be bumped together with [1]. API that utilized map
of variants to be more fl

Removed FutureVersion from API

Instead of using FutureVersion API currently used version is updated.
This change needs to be bumped together with [1]. API that utilized map
of variants to be more flexible and backwards compatible was reverted.
It was decided that straight forward API that is commonly used should be
used instead.

Removed MetricId property from Metric. In telemetry it was implemented
as a name for Metric, but it was supposed to work as described in [2].
Currently MetricId is not supported by telemetry service and property
was removed.

Tested:
- After chaging bmcweb to use new API old and new features are working
as expected

[1]: https://gerrit.openbmc.org/c/openbmc/bmcweb/+/44270
[2]: https://redfish.dmtf.org/schemas/v1/MetricReportDefinition.v1_4_2.json

Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com>
Change-Id: I5930a466a370f268d68f575a4a3db5ee9655e574

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I1ac255c58971ac5cc4697b8bb1069067aad02d18
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson: remove deprecated get_pkgconfig_variable

Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig

meson: remove deprecated get_pkgconfig_variable

Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig` keyword argument. Ensure meson 0.58 is required and update
the usage of all `get_pkgconfig_variable` and `get_variable` to be the
modern variant.

Change-Id: Ibd32733f23eed0d329756e97a65b12f2631f9a61
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Added security checks for symlinks

Added security checks which prevents service from interacting with
symlinks. It is not possible to list/delete/read/write to symlinks.

Tested:
Added unit tests wh

Added security checks for symlinks

Added security checks which prevents service from interacting with
symlinks. It is not possible to list/delete/read/write to symlinks.

Tested:
Added unit tests which confirm that:
- Symlinks cannot be removed
- Symlinks are not listed
- Symlinks cannot be overwritten
- Symlinks cannot be read

Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com>
Change-Id: I50d6d10dac81fd454e7e30520a7c47d5146be58c

show more ...

removed unused include

Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com>
Change-Id: I1cd4601a327c17f1bb5ada5b82600e1c886364f9

markdownlint: fix all warnings

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ida76b81ed6c4d02293517d48f80667f925a6c699

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: I66c89f20acb2c26

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: I66c89f20acb2c266c15ad9987b5c2b7548f976bd
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

Change-Id: I20c1cb77e30d3072e9a8709690306011319e9007
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

python: fix flake8 warnings and format with black

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I7bbfbc71139316873944ab1bbf010ce7f3db5511