clang-tidy: enable bugprone-unchecked-optional-ac

Add bugprone-unchecked-optional-access check to detect unsafe
std::optional access without prior value checks.

Change-Id: I0bc1d1a2c00fd926ee1da511

clang-tidy: enable bugprone-unchecked-optional-ac

Add bugprone-unchecked-optional-access check to detect unsafe
std::optional access without prior value checks.

Change-Id: I0bc1d1a2c00fd926ee1da5115fdcb386a71f6a1a
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-tidy: guard optional JSON access

Add explicit control flow before dereferencing
std::optional<nlohmann::json> in src/report_manager.cpp. Read fields
only on the engaged path to satisfy bugpron

clang-tidy: guard optional JSON access

Add explicit control flow before dereferencing
std::optional<nlohmann::json> in src/report_manager.cpp. Read fields
only on the engaged path to satisfy bugprone-unchecked-optional-access
and keep builds passing with -Werror. No functional changes.

Fixed below type errors

'''
../src/report_manager.cpp:186:30: error: unchecked access to optional value [bugprone-unchecked-optional-access,-warnings-as-errors]
186 | size_t version = data->at("Version").get<size_t>();
| ^~~~
../src/report_manager.cpp:191:28: error: unchecked access to optional value [bugprone-unchecked-optional-access,-warnings-as-errors]
191 | bool enabled = data->at("Enabled").get<bool>();
| ^~~~
../src/report_manager.cpp:192:31: error: unchecked access to optional value [bugprone-unchecked-optional-access,-warnings-as-errors]
192 | std::string& id = data->at("Id").get_ref<std::string&>();
| ^~~~
../src/report_manager.cpp:193:33: error: unchecked access to optional value [bugprone-unchecked-optional-access,-warnings-as-errors]
193 | std::string& name = data->at("Name").get_ref<std::string&>();
| ^~~~
'''

Change-Id: I76faad387fa3786b8770653c745c7ea05d525911
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

Remove LogToJournal trigger action

It has been decided to drop support to LogToLogService action on
Redfish, because it doesn't comply with specification in its current
form. Its dbus counterpart is

Remove LogToJournal trigger action

It has been decided to drop support to LogToLogService action on
Redfish, because it doesn't comply with specification in its current
form. Its dbus counterpart is LogToJournal, therefore this change
removes its implementation.

bmcweb patch: [1]
phosphor-dus-interfaces patch: [2]

Tested:
Verified manually that trigger with LogToJournal action cannot be
created. Unit tests passed.

[1] https://gerrit.openbmc.org/c/openbmc/bmcweb/+/84960
[2] https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/85268

Change-Id: I82989cdc8c5ab7df70f75614ff24700e14efc4e9
Signed-off-by: Michal Orzel <michalx.orzel@intel.com>

show more ...

Update OWNERS file

Swap repository owner to major contributor - Michal.
Add former contributor - Boleslaw - as a designated reviewer.

Change-Id: I9a0818d976ccbbf94e3dcfbc1086c29e217b0484
Signed-off

Update OWNERS file

Swap repository owner to major contributor - Michal.
Add former contributor - Boleslaw - as a designated reviewer.

Change-Id: I9a0818d976ccbbf94e3dcfbc1086c29e217b0484
Signed-off-by: Adrian Ambrożewicz <adrian.ambrozewicz@intel.com>

show more ...

Resolve coverity issues

* Added Rule of Five compliance to the reported classes
* Added explicit default destructors and assignment operators
* Corrected comparison statement

Tested:
UTs passed

Ch

Resolve coverity issues

* Added Rule of Five compliance to the reported classes
* Added explicit default destructors and assignment operators
* Corrected comparison statement

Tested:
UTs passed

Change-Id: Ifcfc1055e2e65d9f3ce10e3878ff3f1dd5d84929
Signed-off-by: Piotr Sulewski <piotrx.sulewski@intel.com>

show more ...

use sdbusplus unpack syntax

Rather than defining a variable and then reading it from a message,
sdbusplus also supports directly unpack-ing from the message. Use
this syntax instead as it is more e

use sdbusplus unpack syntax

Rather than defining a variable and then reading it from a message,
sdbusplus also supports directly unpack-ing from the message. Use
this syntax instead as it is more efficient and succinct.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I54b14bc229d055428ec3183c488976e659e44d09

show more ...

Remove deprecated "Thresholds" property and fix UTs

Thresholds have been split into "DiscreteThresholds" and
"NumericThresholds", remove deprecated property, update UTs

Tested:
UTs passed

Change-I

Remove deprecated "Thresholds" property and fix UTs

Thresholds have been split into "DiscreteThresholds" and
"NumericThresholds", remove deprecated property, update UTs

Tested:
UTs passed

Change-Id: I1959be879e9016b84fff7f7ae6cfad1f5d00e5aa
Signed-off-by: Boleslaw Ogonczyk Makowski <boleslawx.ogonczyk-makowski@intel.com>

show more ...

Fix trigger type for OnChange triggers

Triggers with no threshold parameters should be treated as ones that
activate on change of monitored metric values', with `Discrete` property
value set to true

Fix trigger type for OnChange triggers

Triggers with no threshold parameters should be treated as ones that
activate on change of monitored metric values', with `Discrete` property
value set to true. Otherwise they will be wrongly treated as numeric
triggers on Redfish side. This patch corrects this behavior.

Tested:
1. Created simple discrete trigger: `TestTriggerDiscreteOnChange`, with
`DiscreteTriggerCondition` set to `Changed`.
2. busctl introspect xyz.openbmc_project.Telemetry
/xyz/openbmc_project/Telemetry/Triggers/TelemetryService/
TestTriggerDiscreteOnChange
3. Verified that `Discrete` property is true

All unit tests have passed.

Change-Id: I06762c94b38a9da42a64c9a014d3f6dd47577176
Signed-off-by: Michal Orzel <michalx.orzel@intel.com>

show more ...

Update OWNERS

Change-Id: I3b9fde13549fb87b375f1afbd5bf8c04bc646cae
Signed-off-by: Adrian Ambrożewicz <adrian.ambrozewicz@intel.com>

meson: use non-deprecated systemd packageconfig

Systemd's packageconfig file has both `systemdsystemunitdir` and
`systemd_system_unit_dir` defined. The non-underscore one appears
to be a deprecated

meson: use non-deprecated systemd packageconfig

Systemd's packageconfig file has both `systemdsystemunitdir` and
`systemd_system_unit_dir` defined. The non-underscore one appears
to be a deprecated alias[1]. Move to the non-deprecated /
underscore-separated variant.

[1]: https://github.com/systemd/systemd/commit/4908de44b0a0409f84a7cdc5641b114d6ce8ba03

Change-Id: I4cf46ac6aea46dcbbacc439bc2a1dc90cffb32d4
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-tidy: Initial commit

Added initial .clang-tidy configuration file with recommended C++ checks
aligned with the OpenBMC-approved checklist. This setup enforces modern
C++ best practices and hel

clang-tidy: Initial commit

Added initial .clang-tidy configuration file with recommended C++ checks
aligned with the OpenBMC-approved checklist. This setup enforces modern
C++ best practices and helps catch common issues early in development.

Tested: verified build.

Change-Id: I7914c72f734f164793f04df1ca452e44fe3c9617
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-tidy: mark unused ioc field in test stub

The 'ioc' field in DbusSensorObject test stub is intentionally
unused but retained to align with the base implementation.

Marked it with [[maybe_unuse

clang-tidy: mark unused ioc field in test stub

The 'ioc' field in DbusSensorObject test stub is intentionally
unused but retained to align with the base implementation.

Marked it with [[maybe_unused]] to suppress clang-tidy's
-Wunused-private-field warning while preserving interface
consistency for future compatibility.

Error details:
'''
tests/src/stubs/dbus_sensor_object.cpp:17:5: error:
class ‘stubs::DbusSensorObject’ does not have any field named ‘ioc’
17 | ioc(ioc), bus(bus), objServer(objServer)
'''

Change-Id: Id86a671b255f98ea22fddca82c24ad2192727235
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-tidy: Improve const-correctness

Updated member functions to better reflect const-correctness,
enhancing code clarity and maintainability.

Change-Id: Ib3fdbd2164cb76ad7f0c454d37dd5c08652f78fc

clang-tidy: Improve const-correctness

Updated member functions to better reflect const-correctness,
enhancing code clarity and maintainability.

Change-Id: Ib3fdbd2164cb76ad7f0c454d37dd5c08652f78fc
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-tidy: Remove unused lambda captures

The following errors were reported during clang-tidy enablement due
to unused lambda captures.

'''
../src/metric.cpp:119:50: error: lambda capture 'this' i

clang-tidy: Remove unused lambda captures

The following errors were reported during clang-tidy enablement due
to unused lambda captures.

'''
../src/metric.cpp:119:50: error: lambda capture 'this' is not used [-Werror
'''

The fix involves removing these unused lambda captures.

Tested: Build and unit testing verified.

Change-Id: I6a4b42ea3df7513e1208638f427007680e2a15cf
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

fix random UT fails

Tests TestNumericThresholdWithDwellTime/SleepAfterEveryUpdate/2, 6 and 9
could fail randomly because next update happened at the same time when
timer from one of previous updates

fix random UT fails

Tests TestNumericThresholdWithDwellTime/SleepAfterEveryUpdate/2, 6 and 9
could fail randomly because next update happened at the same time when
timer from one of previous updates was supposed to expire - if update
got processed first, timer was canceled and test failed

Tested:
Before this change UTs failed almost 100% of the time on my machine,
with this change 0 failures in 500 iterations

Change-Id: I11940027fca377b7be67cb82b638bf162616d37e
Signed-off-by: Boleslaw Ogonczyk Makowski <boleslawx.ogonczyk-makowski@intel.com>

show more ...

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: Ic2bc1d98d8ad469a3477f9059ec890fc8339907d
Signed-off-by: Patrick Williams <p

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: Ic2bc1d98d8ad469a3477f9059ec890fc8339907d
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson: reformat with meson formatter

Apply the `meson format` results.

Change-Id: I0ff3dc51a6a4e8ea2edf03219e4578fcffe18748
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

Fix boost url

According to [1] boost url has been changed

[1]: https://github.com/boostorg/boost/issues/996#issuecomment-2567031602

Change-Id: I3f7b1de93caad6fe392b3f672102938087170aea
Signed-off-

Fix boost url

According to [1] boost url has been changed

[1]: https://github.com/boostorg/boost/issues/996#issuecomment-2567031602

Change-Id: I3f7b1de93caad6fe392b3f672102938087170aea
Signed-off-by: Boleslaw Ogonczyk Makowski <boleslawx.ogonczyk-makowski@intel.com>

show more ...

Remove variant from Thresholds interface

The Thresholds property on the Trigger interface is currently defined as
a relatively complex type:
variant<
array<discrete struct>
array<numeric struc

Remove variant from Thresholds interface

The Thresholds property on the Trigger interface is currently defined as
a relatively complex type:
variant<
array<discrete struct>
array<numeric struct>
>

This causes some oddities in unpacking given that Dbus properties are
already a variant, applications consuming this interface have to double
wrap the variant. This was confusing enough that bmcweb has to keep the
trigger types separate, and cannot use the common typing.

This commit changes by adding two new parameters
NumericThresholds: array<numeric struct>
DiscreteThresholds: array<discrete struct>

Which deduplicates the double wrapped variant.

The intent is that this duplicated interface will exist for a transition
period of a week or two, while bmcweb (the only user of this)
transitions the code to use the new properties, then a followup common
will drop the thresholds properly.

Tested: WIP

Change-Id: I6717d4075de53c91aa179a90c7a844c4a13534cc
Signed-off-by: Ed Tanous <ed@tanous.net>

show more ...

Fix CI compilation issue

Resolves maybe-uninitialized error for std::function object, which shows
when compiling with optimizations.

Tested:
CI build passed.

Change-Id: Ia6f07a23715f0bf34d19e100bc

Fix CI compilation issue

Resolves maybe-uninitialized error for std::function object, which shows
when compiling with optimizations.

Tested:
CI build passed.

Change-Id: Ia6f07a23715f0bf34d19e100bca94fc29cd0aa9f
Signed-off-by: Michal Orzel <michalx.orzel@intel.com>

show more ...

Enable disabled unit tests

Enabling tests that were initially disabled, most probably because
corresponding features had yet been in development.

Tested:
Lines coverage increased:
- src/report_mana

Enable disabled unit tests

Enabling tests that were initially disabled, most probably because
corresponding features had yet been in development.

Tested:
Lines coverage increased:
- src/report_manager.cpp: 94.2% -> 97.5%
- src/trigger_manager.cpp: 94.9% -> 99.0%
- src/utils/dbus_path_utils.cpp: 94.6% -> 100.0%

Change-Id: Id729c7f2e7e188d878b7348c710a09a4ceb40fd4
Signed-off-by: Michal Orzel <michalx.orzel@intel.com>

show more ...

Fix sanitizer issue

Resolve heap-use-after-free issue that started appearing after
googletest update. According to docs, AddGlobalTestEnvironment takes
ownerwhip of an Environment object passed ther

Fix sanitizer issue

Resolve heap-use-after-free issue that started appearing after
googletest update. According to docs, AddGlobalTestEnvironment takes
ownerwhip of an Environment object passed there and it's being destroyed
at the end of RUN_ALL_TESTS function. [1] Therefore any further usage of
that object will cause heap-use-after-free error.

Tested:
CI build passed

[1] https://google.github.io/googletest/advanced.html#global-set-up-and-tear-down

Change-Id: I517a7693a5692c4561de6a5e5ee8ebaf9d8cdc2d
Signed-off-by: Michal Orzel <michalx.orzel@intel.com>

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I956cf3cb1bbfc017c4d4dceb3195c1d0735b0605
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Verify reading parameters on update

Adds verification of ReadingParameter's metric count when property is
being updated. This brings consistency with behavior upon adding a new
report, where that sa

Verify reading parameters on update

Adds verification of ReadingParameter's metric count when property is
being updated. This brings consistency with behavior upon adding a new
report, where that same check is being made. Also adds a unit test for
that check.

Tested:
On platform, by updating report's ReadingParameter with object
containing metric count exceeding one specified by
`max-reading-parameters` project option. With this change applied, that
operation failed, as expected.

Change-Id: I06c8e21178d6bd554b62886e0e4f8cd0589f0d09
Signed-off-by: Michal Orzel <michalx.orzel@intel.com>

show more ...

Fix MD034 warnings

The following warnings are generated by using markdownlint analysis:
```
redfish-tests/README.md:23:4 MD034/no-bare-urls Bare URL used [Context: "https://localhost:443"]
redfish-t

Fix MD034 warnings

The following warnings are generated by using markdownlint analysis:
```
redfish-tests/README.md:23:4 MD034/no-bare-urls Bare URL used [Context: "https://localhost:443"]
redfish-tests/README.md:23:38 MD034/no-bare-urls Bare URL used [Context: "https://localhost:4443"]
```
Refer to markdown-lint [1] to fix MD034
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/034-no-bare-urls.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I90856ee4a0eb9b0079614207e0c16c679e578bf9

show more ...