meson: adjust nlohmann-json dependency

- Simplify nlohmann-json dependency in meson.build.
- Use consistent dependency variable names (based on Meson style).
- Align wrap file name with meson wrapdb

meson: adjust nlohmann-json dependency

- Simplify nlohmann-json dependency in meson.build.
- Use consistent dependency variable names (based on Meson style).
- Align wrap file name with meson wrapdb choice for the project.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I2e893fd8c300b36a16d704f2002bb966a6e52ce4

show more ...

meson_options.txt: Support for reading options from meson.options

Support has been added for reading options from meson.options instead
of meson_options.txt[1]. These are equivalent, but not using t

meson_options.txt: Support for reading options from meson.options

Support has been added for reading options from meson.options instead
of meson_options.txt[1]. These are equivalent, but not using the .txt
extension for a build file has a few advantages, chief among them
many tools and text editors expect a file with the .txt extension to
be plain text files, not build scripts.

[1] https://mesonbuild.com/Release-notes-for-1-1-0.html#support-for-reading-options-from-mesonoptions

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I90cc30833435f641223fe8e7f88458ae7fe1db95

show more ...

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: If193a9f16c90ba8ac423a

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: If193a9f16c90ba8ac423aec7e5660bea524ce891
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I016cb74930cc475843c30bd604e739058effa504
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Fix static code analysis tool failures

Uncaught exception (boost::system::system_error) is now caught.

Change-Id: I0aa88f173a982ecebfa999fd44ed864be709240c
Signed-off-by: Wojciech Tempczyk <wojciec

Fix static code analysis tool failures

Uncaught exception (boost::system::system_error) is now caught.

Change-Id: I0aa88f173a982ecebfa999fd44ed864be709240c
Signed-off-by: Wojciech Tempczyk <wojciechx.tempczyk@intel.com>

show more ...

Remove OWNERS which are unqualified

Commit cc8abc0be58c19acd088da455454fdf466a1745f added owners which
do not qualify based on the overall project requirements:

https://github.com/openbmc/docs/blob

Remove OWNERS which are unqualified

Commit cc8abc0be58c19acd088da455454fdf466a1745f added owners which
do not qualify based on the overall project requirements:

https://github.com/openbmc/docs/blob/master/community-membership.md#subproject-owner

There has been no response on Gerrit to an inquiry about this by anyone
currently listed as an OWNER. Removing the "owner add" portion of
cc8abc0be58c19acd088da455454fdf466a1745f until this can be resolved.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I3d0ed615056d33e29da100489fe14f454b473840

show more ...

passing owner responsibilities

Change-Id: I0561af6d0fac610c4ec77eb009ca040ac4f2002d
Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com>

Removed FutureVersion from API

Instead of using FutureVersion API currently used version is updated.
This change needs to be bumped together with [1]. API that utilized map
of variants to be more fl

Removed FutureVersion from API

Instead of using FutureVersion API currently used version is updated.
This change needs to be bumped together with [1]. API that utilized map
of variants to be more flexible and backwards compatible was reverted.
It was decided that straight forward API that is commonly used should be
used instead.

Removed MetricId property from Metric. In telemetry it was implemented
as a name for Metric, but it was supposed to work as described in [2].
Currently MetricId is not supported by telemetry service and property
was removed.

Tested:
- After chaging bmcweb to use new API old and new features are working
as expected

[1]: https://gerrit.openbmc.org/c/openbmc/bmcweb/+/44270
[2]: https://redfish.dmtf.org/schemas/v1/MetricReportDefinition.v1_4_2.json

Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com>
Change-Id: I5930a466a370f268d68f575a4a3db5ee9655e574

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I1ac255c58971ac5cc4697b8bb1069067aad02d18
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson: remove deprecated get_pkgconfig_variable

Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig

meson: remove deprecated get_pkgconfig_variable

Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig` keyword argument. Ensure meson 0.58 is required and update
the usage of all `get_pkgconfig_variable` and `get_variable` to be the
modern variant.

Change-Id: Ibd32733f23eed0d329756e97a65b12f2631f9a61
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Added security checks for symlinks

Added security checks which prevents service from interacting with
symlinks. It is not possible to list/delete/read/write to symlinks.

Tested:
Added unit tests wh

Added security checks for symlinks

Added security checks which prevents service from interacting with
symlinks. It is not possible to list/delete/read/write to symlinks.

Tested:
Added unit tests which confirm that:
- Symlinks cannot be removed
- Symlinks are not listed
- Symlinks cannot be overwritten
- Symlinks cannot be read

Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com>
Change-Id: I50d6d10dac81fd454e7e30520a7c47d5146be58c

show more ...

removed unused include

Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com>
Change-Id: I1cd4601a327c17f1bb5ada5b82600e1c886364f9

markdownlint: fix all warnings

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ida76b81ed6c4d02293517d48f80667f925a6c699

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: I66c89f20acb2c26

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: I66c89f20acb2c266c15ad9987b5c2b7548f976bd
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

Change-Id: I20c1cb77e30d3072e9a8709690306011319e9007
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

python: fix flake8 warnings and format with black

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I7bbfbc71139316873944ab1bbf010ce7f3db5511

simplified appendLimit implementation

AppendLimit is now set to max value by default. This simplifies the code
while keeping most of the feature functionality. This change increases
report version a

simplified appendLimit implementation

AppendLimit is now set to max value by default. This simplifies the code
while keeping most of the feature functionality. This change increases
report version and will cause older report to be deleted.

Tested:
- AppendLimit is set by default to max value
- Telemetry features are working as expected

Change-Id: I94c85393a9601c90c00776bf0bc814d85cbf006a
Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com>

show more ...

Redesigned error handling

Current error handling send only error code, which is not enough to
display detailed information. New error handling in additional to
error code send property name. This al

Redesigned error handling

Current error handling send only error code, which is not enough to
display detailed information. New error handling in additional to
error code send property name. This allows to send meaningful messages
back to used about errors.

Tested:
- Old redfish code properly handles errors (reads only error_code)
- Redfish version which read property name from error displays more
detailed error information

Change-Id: I54caa20881ac3f3e38cb295a3aa95ddab491303f
Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com>

show more ...

Update meson and subprojects

Few changes related to meson:
- GTest and boost were updated.
- Boost is now built locally in case it is not installed on system.
- Minor meson.build refactor.

Testing

Update meson and subprojects

Few changes related to meson:
- GTest and boost were updated.
- Boost is now built locally in case it is not installed on system.
- Minor meson.build refactor.

Testing done:
- local build is working fine, when subprojects are not installed on the
system,
- local build is working fine, when subprojects are installed on the
system,
- yocto build is working fine.

Signed-off-by: Szymon Dompke <szymon.dompke@intel.com>
Change-Id: Ib62092946d6ffafb1884d1ba3eab97bed243dd12

show more ...

Add missing header

Compilation was failing on g++-12, due to missing header in 1 file.

Testing done:
- Compilation works on g++-12

Signed-off-by: Szymon Dompke <szymon.dompke@intel.com>
Change-Id:

Add missing header

Compilation was failing on g++-12, due to missing header in 1 file.

Testing done:
- Compilation works on g++-12

Signed-off-by: Szymon Dompke <szymon.dompke@intel.com>
Change-Id: I658d9ff70dc02bcb541c6b42dff4e54b92a9e60f

show more ...

Fix sensor count not updating

When ReadingsParamaters are updated, sensor count may change. This
action should resize buffer and update value of "AppendLimit" property
in case it was not set by user

Fix sensor count not updating

When ReadingsParamaters are updated, sensor count may change. This
action should resize buffer and update value of "AppendLimit" property
in case it was not set by user.

Testing done:
-UTs passing

Signed-off-by: Szymon Dompke <szymon.dompke@intel.com>
Change-Id: I96486a808a3cce83c09936262304d0a1f55b3fd7

show more ...

Remove scripts directory

Scripts directory contains 2 files which were failing CI. They are not
needed and can be removed.

Testing done:
- CI is passing.

Signed-off-by: Szymon Dompke <szymon.dompk

Remove scripts directory

Scripts directory contains 2 files which were failing CI. They are not
needed and can be removed.

Testing done:
- CI is passing.

Signed-off-by: Szymon Dompke <szymon.dompke@intel.com>
Change-Id: Ib5f8168c7c3a2d49a482ef10658de292764616f7

show more ...

Use clang-format-15

Some files required reformating.

Testing done:
- Clang-format is passing on CI

Signed-off-by: Szymon Dompke <szymon.dompke@intel.com>
Change-Id: I39d53715840818ffabcb3903a5efc9

Use clang-format-15

Some files required reformating.

Testing done:
- Clang-format is passing on CI

Signed-off-by: Szymon Dompke <szymon.dompke@intel.com>
Change-Id: I39d53715840818ffabcb3903a5efc97639ed48df

show more ...

Persistency: store special double values

Json library handles infinity and NaN as null. During deserialization,
we expect a double and those files were marked as invalid and removed.
To prevent this

Persistency: store special double values

Json library handles infinity and NaN as null. During deserialization,
we expect a double and those files were marked as invalid and removed.
To prevent this behavior and preserve all double values, LabeledTuple
'to_json' and 'from_json' functions were improved to accommodate those
special values by using string literals.

Testing done:
- UTs added for double<=>json conversion.
- UTs passing.

Signed-off-by: Szymon Dompke <szymon.dompke@intel.com>
Change-Id: I9193df29cce1db28cda3c895d117d9f3bfca2c24

show more ...

Fix clang errors

- structs used in emplace_back now have defined constructor
- removed dead code from ensure

Testing done:
- CI tests are passing
- UTs are passing

Signed-off-by: Szymon Dompke <sz

Fix clang errors

- structs used in emplace_back now have defined constructor
- removed dead code from ensure

Testing done:
- CI tests are passing
- UTs are passing

Signed-off-by: Szymon Dompke <szymon.dompke@intel.com>
Change-Id: I3f56a3796e45d608c7a5d3da1f8c2d674d62f567

show more ...