#
cff70c14 |
| 27-Oct-2022 |
Krzysztof Grobelny <krzysztof.grobelny@intel.com> |
Removed FutureVersion from API
Instead of using FutureVersion API currently used version is updated. This change needs to be bumped together with [1]. API that utilized map of variants to be more fl
Removed FutureVersion from API
Instead of using FutureVersion API currently used version is updated. This change needs to be bumped together with [1]. API that utilized map of variants to be more flexible and backwards compatible was reverted. It was decided that straight forward API that is commonly used should be used instead.
Removed MetricId property from Metric. In telemetry it was implemented as a name for Metric, but it was supposed to work as described in [2]. Currently MetricId is not supported by telemetry service and property was removed.
Tested: - After chaging bmcweb to use new API old and new features are working as expected
[1]: https://gerrit.openbmc.org/c/openbmc/bmcweb/+/44270 [2]: https://redfish.dmtf.org/schemas/v1/MetricReportDefinition.v1_4_2.json
Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com> Change-Id: I5930a466a370f268d68f575a4a3db5ee9655e574
show more ...
|
#
32305f14 |
| 05-Jul-2022 |
Szymon Dompke <szymon.dompke@intel.com> |
Add length limit for user-defined values
Previously, the only limit for most user-defined values like id or name was the one enforced by dbus, which was fairly big. In order to save space used by pe
Add length limit for user-defined values
Previously, the only limit for most user-defined values like id or name was the one enforced by dbus, which was fairly big. In order to save space used by persistent data, new meson options were added, with length limit for those fields.
This directly impacts following dbus interfaces: - TriggerManager.AddTrigger: - Id - Name - Reports - Thresholds (only name of discrete threshold) - Trigger.Name - Trigger.Reports - Trigger.Thresholds (only name of discrete threshold) - ReportManager.AddReport(FutureVersion): - Id - Name - MetricParameters (metricId) - Report.Name - Report.ReadingParameters (metricId)
For Id fields we support 'prefixes', which also are limited, but those limit are separate. So if limit for prefix is set to 5 and limit for id/name is set to 5, following Ids are fine: - 12345/12345 - 12345 and following are not: - 123456/1234 - 1/123456
Testing done: - UTs are passing. - new limits are reflected when calling mentioned dbus interfaces.
Signed-off-by: Szymon Dompke <szymon.dompke@intel.com> Change-Id: I29291a1cc56a344d92fb65491c9186fdb90a8529
show more ...
|
#
973b4bb0 |
| 25-Apr-2022 |
Krzysztof Grobelny <krzysztof.grobelny@intel.com> |
fixing Set on report properties
Setting valid value for property which is incorrect for current configuration will result in OK response, but will change ErrorMessages property. ErrorMessages will c
fixing Set on report properties
Setting valid value for property which is incorrect for current configuration will result in OK response, but will change ErrorMessages property. ErrorMessages will contain information about error type and property name.
Tested: - Change interval from 1000 to 0 for periodic report changes status from Enabled to Disabled. - Change interval from 0 to 1000 for periodic report changes status from Disabled to Enabled.
Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com> Signed-off-by: Szymon Dompke <szymon.dompke@intel.com> Change-Id: I34add1ed0308b3da0850b1db6a67a217d11b6956
show more ...
|
#
493e62eb |
| 14-Feb-2022 |
Krzysztof Grobelny <krzysztof.grobelny@intel.com> |
made MetricValues persistent
MetricValues are persistent for reportUpdates AppendStopsWhenFull and reportingType different than OnRequest.
Tested: - New unit tests are passing - Confirmed MetricVal
made MetricValues persistent
MetricValues are persistent for reportUpdates AppendStopsWhenFull and reportingType different than OnRequest.
Tested: - New unit tests are passing - Confirmed MetricValues are preserved after restarting telemetry service
Change-Id: I7e1990fb391da9debb0d7df2f1dbda86473350cc Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com>
show more ...
|
#
fdb06a14 |
| 11-Feb-2022 |
Szymon Dompke <szymon.dompke@intel.com> |
Report: make dbus properties writable
ReadingParametersFutureVersion interface for Reports is enhanced from read-only to read write and supports modification of readingParameteres, which is done by
Report: make dbus properties writable
ReadingParametersFutureVersion interface for Reports is enhanced from read-only to read write and supports modification of readingParameteres, which is done by updating metrics at the first place and re-registering them for sensors updates. Similar ReportActions interface is enhanced to read write. Additionally reportActions policy was modified that reports always contain 'LogToMetricReportsCollection' action. The whole change enables Redfish support for PATCH method added on webserver side.
Tested: - New unit tests were created, ran all new and previous UTs, all passed - Tested under QEMU, interface was checked for RW via dbus cli commands, checked if Reading Parameters of the Report can be read or written, if metrics are properly updated and registration/unregistration for updates works properly, checked if actions of Report can be read or written, if actions are properly updated and related action behavior follows the change accordingly - Tested under QEMU, verified if 'LogToMetricReportsCollection' action is always added when Report is created or when actions of Report are updated by dbus interface - Tested via webserver if it communicates properly with dbus interfaces of Telemetry and read/write operations via Redfish can be successfully executed
Signed-off-by: Lukasz Kazmierczak <lukasz.kazmierczak@intel.com> Change-Id: I7f2fe8eae1631c436cf61a516d5fd0b8358a76bd
show more ...
|
#
60fee077 |
| 13-Jan-2022 |
Krzysztof Grobelny <krzysztof.grobelny@intel.com> |
added property SupportedOperationTypes
- removed OperationType::single - for backward compatibility incomming OperationType::single alted to produce same output functionality - added property Supp
added property SupportedOperationTypes
- removed OperationType::single - for backward compatibility incomming OperationType::single alted to produce same output functionality - added property SupportedOperationTypes to ReportManager interface
Tested: - In cases where OperationType::single is used same MetricValues are produced - New property is visible on dbus
Change-Id: I838581c954abc0d8401e0ed530ce7e9c8013860b Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com>
show more ...
|
#
e6d48874 |
| 08-Feb-2022 |
Krzysztof Grobelny <krzysztof.grobelny@intel.com> |
Removed dependency to TriggerManager
introduces Messanger class which allows to send messages directly to subscribed targets, which allows to break dependencies between classes.
Testes: - All unit
Removed dependency to TriggerManager
introduces Messanger class which allows to send messages directly to subscribed targets, which allows to break dependencies between classes.
Testes: - All unit tests are passing - Links are correctly updated - Report is correctly updated by Trigger Action
Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com> Change-Id: I32d3aaba22f9ec07e611f53fe553bd27e1c04c6d
show more ...
|
#
b4ef22e4 |
| 07-Feb-2022 |
Szymon Dompke <szymon.dompke@intel.com> |
Report: Add TriggerIds property
This change is adding TriggerIds property for Report interface. It is an array of strings, each representing id of trigger which may update given report Readings prop
Report: Add TriggerIds property
This change is adding TriggerIds property for Report interface. It is an array of strings, each representing id of trigger which may update given report Readings property, due to UpdateReport action. This properly is read-only, but it can be changed in the runtime, when: - New Trigger is made using AddTrigger dbus method, when ReportId argument contains id of given report. - Trigger is deleted from dbus, and its ReportNames property included id of given report. - ReportNames property of any trigger is updated to include (or not) id of given report.
When this property is modified by service, signal will be emitted on dbus for property change.
When there is existing trigger with id of non-existing report in its ReportNames property, its id will be added to TriggerIds property of such report, the moment it is created by user.
Testing done: - new UTs were made, all UTs are passing. - manual testing on dbus interface was successful.
Signed-off-by: Szymon Dompke <szymon.dompke@intel.com> Change-Id: I1c4c94ce751ddaee001e3cadde3ea60aa8e1c224
show more ...
|
#
94f71c51 |
| 10-Dec-2021 |
Szymon Dompke <szymon.dompke@intel.com> |
Trigger: make dbus properties writable
This change allows to modify 'Sensors', 'ReportNames' and 'Thresholds' dbus properties of Trigger interface. They are required by Redfish to implement PATCH fu
Trigger: make dbus properties writable
This change allows to modify 'Sensors', 'ReportNames' and 'Thresholds' dbus properties of Trigger interface. They are required by Redfish to implement PATCH functionality for Trigger schema.
Some backend changes were required to enable this functionality, and as such few improvements were made for existing code: - NumericThreshold and DiscreteThreshold now have common implementation where it was possible. - Internal sensor info structure for Trigger is now the same as the one used for Report. This resulted in breaking compatibility with previous Trigger persistency data. - Added getInfo / getParams methods for Sensor and Threshold interfaces. They are used by Trigger dbus getters and persistency mechanism now, instead of storing this data in Trigger object.
Testing done: - Unit tests were expanded and are passing - dbus setters for Sensors and Thresholds are working and modifications are reflected by calling appropriate getters.
Signed-off-by: Szymon Dompke <szymon.dompke@intel.com> Change-Id: I7a14c15a30d78ce872342b5f938aba43c77be9c0
show more ...
|
#
b8cc78dd |
| 29-Nov-2021 |
Krzysztof Grobelny <krzysztof.grobelny@intel.com> |
Api changes in AddReportFuture version
Added support for CollectionFunction, CollectionDuration, CollectionTimeScope, ReportUpdates, AppendLimit.
New API separates Id and Name, user can decide to p
Api changes in AddReportFuture version
Added support for CollectionFunction, CollectionDuration, CollectionTimeScope, ReportUpdates, AppendLimit.
New API separates Id and Name, user can decide to pass only Name to auto generate Id or pass Id which needs to be unique.
Tested: - No functional changes to old API, everything works as before - All use cases can be replaced with new API to achieve same results - New features which require new API work as expected
Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com> Change-Id: I647efab36d90a548754f89968223e162a087481e
show more ...
|
#
51497a0c |
| 09-Nov-2021 |
Krzysztof Grobelny <krzysztof.grobelny@intel.com> |
Using enum class instead of string in more places
ReportingType and ReportUpdates are now used as enum class in more places than before. Changed how this two fields are stored in persistent configur
Using enum class instead of string in more places
ReportingType and ReportUpdates are now used as enum class in more places than before. Changed how this two fields are stored in persistent configuration. Increased Report::Version to break backward compatibility. Updated unit tests to verify changed functionality.
Tested: - All existing tests are passing
Change-Id: I55db205aefbe2b5a69fb7a31ccf11885aaecaaf2 Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com>
show more ...
|
#
3eb56865 |
| 20-Sep-2021 |
Szymon Dompke <szymon.dompke@intel.com> |
Add support for AppendLimit and ReportUpdates
Added 2 new properties for Report interface: AppendLimit and ReportUpdates. They were also added as arguments to the future version of AddReport method
Add support for AppendLimit and ReportUpdates
Added 2 new properties for Report interface: AppendLimit and ReportUpdates. They were also added as arguments to the future version of AddReport method of ReportManager.
ReportUpdates property defines the report update behavior: - Overwrite: Each report update overrides previous "Readings" property. "AppendLimit" set by user is not respected - "Readings" property size is equal to count of all sensor across all metrics defined in report. - AppendWrapsWhenFull: New readings are appended until limit specified by "AppendLimit" is reached. Then oldest readings are overwritten by new ones. - AppendStopsWhenFull: New readings are appended until limit specified by "AppendLimit" is reached. Then updates are stopped. - NewReport: not supported yet and will be implemented in the future.
Please note that if ReportingType is set to OnRequest, those 2 new properties are ignored, and Readings property will contain one reading per defined sensor, across all metrics. They are still stored, which means that if ReportingType will be changed in the runtime, those properties will be respected.
Tested: - Both new properties can be accessed from dbus. - Both properties are reflected in Readings property. - Old AddReport method is working as before the change. - UTs are passing.
Signed-off-by: Szymon Dompke <szymon.dompke@intel.com> Change-Id: I8a18f7e68215f0f6e5c403b533d2c4ff479df69e
show more ...
|
#
7e098e93 |
| 16-Sep-2021 |
Lukasz Kazmierczak <lukasz.kazmierczak@intel.com> |
Added support for Enabled property
Enabled property is added so that user can select via dbus interface if Readings are updated and signal on Readings update is emitted, moreover Metric calculation
Added support for Enabled property
Enabled property is added so that user can select via dbus interface if Readings are updated and signal on Readings update is emitted, moreover Metric calculation on received sensor data is active only when Enabled is set to true
Tested: - New unit tests were created, ran all new and previous UTs, all passed - Tested under QEMU by adding reports for single and multiple sensors, changing Enabled property and emitting signal of value change for sensors added into the report, checking if Readings is accordingly updated or not updated - Verified persistency, if Enabled property is successfully stored and restored after Telemetry service restart and also checked if after the restart dependencies of Enabled (Readings, Metric calculation) are properly initiated
Signed-off-by: Lukasz Kazmierczak <lukasz.kazmierczak@intel.com> Change-Id: I29cf13693a48d15cb16d2ad6707f483f67f4879b
show more ...
|
#
dcc4e193 |
| 08-Mar-2021 |
Krzysztof Grobelny <krzysztof.grobelny@intel.com> |
created AddReportFutureVersion dbus method
New method will support CollectionTimeScope, CollectionDuration
In order to make not breaking interface changes bmcweb will switch to AddReportFutureVersi
created AddReportFutureVersion dbus method
New method will support CollectionTimeScope, CollectionDuration
In order to make not breaking interface changes bmcweb will switch to AddReportFutureVersion, then AddReport will be changed to match AddReportFutureVersion, then redfish will switch back to use AddReport, then AddReportFutureVersion will be removed.
Tested: - Verified that current version of bmcweb works fine with old API
Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com> Change-Id: I51a9b7fb2f4da5b8d2f688ccd5e93710352b1ac7
show more ...
|
#
9f9ff90a |
| 05-Mar-2021 |
Krzysztof Grobelny <krzysztof.grobelny@intel.com> |
Revert "created AddReportFutureVersion dbus method"
This reverts commit 753e4b3c843dd5d1068949c4106a6389f0e0ffbc.
Reason for revert: Breaks bmcweb, same approach is needed for changed properties
C
Revert "created AddReportFutureVersion dbus method"
This reverts commit 753e4b3c843dd5d1068949c4106a6389f0e0ffbc.
Reason for revert: Breaks bmcweb, same approach is needed for changed properties
Change-Id: Id868159df916fcf0bdd7fc5062f8c51187fcc7e2
show more ...
|
#
753e4b3c |
| 11-Feb-2021 |
Krzysztof Grobelny <krzysztof.grobelny@intel.com> |
created AddReportFutureVersion dbus method
New method will support CollectionTimeScope, CollectionDuration
In order to make not breaking interface changes bmcweb will switch to AddReportFutureVersi
created AddReportFutureVersion dbus method
New method will support CollectionTimeScope, CollectionDuration
In order to make not breaking interface changes bmcweb will switch to AddReportFutureVersion, then AddReport will be changed to match AddReportFutureVersion, then redfish will switch back to use AddReport, then AddReportFutureVersion will be removed.
Change-Id: I9cc906cc1fa7cdf27be7e433390c516f6bae3c50 Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com>
show more ...
|
#
e8fc5751 |
| 05-Feb-2021 |
Krzysztof Grobelny <krzysztof.grobelny@intel.com> |
Changed dbus add report interface
- metric parameters now take single sensor instead of list - added interface support for new operation types
Tested: - All telemetry tests are passing.
Signed-off
Changed dbus add report interface
- metric parameters now take single sensor instead of list - added interface support for new operation types
Tested: - All telemetry tests are passing.
Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com> Change-Id: Id3a41c48e81a287e7d205ae1c747daa36d4cdb29
show more ...
|
#
d2238194 |
| 02-Dec-2020 |
Krzysztof Grobelny <krzysztof.grobelny@intel.com> |
Review fixes for 'Created metric class'
- Changed metric to_json to dumpConfiguration returning LabeledTuple - LabeledTuple can be created and assigned directly to json - LabeledTuple can be readed
Review fixes for 'Created metric class'
- Changed metric to_json to dumpConfiguration returning LabeledTuple - LabeledTuple can be created and assigned directly to json - LabeledTuple can be readed from json using json.get<LabeledTuple> - Added PrintTo for LabeledMetricParams, LabeledSensorParams - Added helper method expectMake to ReportFactoryMock - sensorPaths are serialized to tuple<service, path> instead of single field with service and path separated via ':' - Changed configuration version from 1 to 2
Change-Id: I7c45fb584687172f88fd549a93329264793b0b8e Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com>
show more ...
|
#
e2362796 |
| 27-Oct-2020 |
Wludzik, Jozef <jozef.wludzik@intel.com> |
Implement Report persistency
Now Report properties are stored in non-volatile memory. It allows to restore Report after system restart. Persistency of a report is controlled by Persistency property
Implement Report persistency
Now Report properties are stored in non-volatile memory. It allows to restore Report after system restart. Persistency of a report is controlled by Persistency property in Report interface.
Tested: - Passed unit tests - Verified that report is stored in /var/lib/telemetry dir - Verified that report is restored from storage after telemetry service start
Signed-off-by: Wludzik, Jozef <jozef.wludzik@intel.com> Change-Id: Iccfe21603eecffc4e174a4403f699b03de320db9
show more ...
|
#
c8e3a64a |
| 23-Oct-2020 |
Krzysztof Grobelny <krzysztof.grobelny@intel.com> |
Added Periodic reportingType support to Report
When report interval expires report will collect readings from metrics and update timestamp.
Tested: - Added new units tests covering added code -
Added Periodic reportingType support to Report
When report interval expires report will collect readings from metrics and update timestamp.
Tested: - Added new units tests covering added code - All existing unit tests are passing
Change-Id: I7f23ca05d77efb0f18d2c0d0f138c524ffb4f6af Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com>
show more ...
|