b3e03d2d | 28-Jun-2024 |
Michal Orzel <michalx.orzel@intel.com> |
Address Valgrind issues in CI
Fixes "uninitialized values" errors reported by Valgrind. Problem occurred from lack of specializations of googletest's PrintTo functions for several custom types.
Tes
Address Valgrind issues in CI
Fixes "uninitialized values" errors reported by Valgrind. Problem occurred from lack of specializations of googletest's PrintTo functions for several custom types.
Tested: On local CI container. After applying this patch issues stopped appearing.
Change-Id: I98d9fd19724bee15add7b19422a9ddc2e4cbef09 Signed-off-by: Michal Orzel <michalx.orzel@intel.com>
show more ...
|
cff70c14 | 27-Oct-2022 |
Krzysztof Grobelny <krzysztof.grobelny@intel.com> |
Removed FutureVersion from API
Instead of using FutureVersion API currently used version is updated. This change needs to be bumped together with [1]. API that utilized map of variants to be more fl
Removed FutureVersion from API
Instead of using FutureVersion API currently used version is updated. This change needs to be bumped together with [1]. API that utilized map of variants to be more flexible and backwards compatible was reverted. It was decided that straight forward API that is commonly used should be used instead.
Removed MetricId property from Metric. In telemetry it was implemented as a name for Metric, but it was supposed to work as described in [2]. Currently MetricId is not supported by telemetry service and property was removed.
Tested: - After chaging bmcweb to use new API old and new features are working as expected
[1]: https://gerrit.openbmc.org/c/openbmc/bmcweb/+/44270 [2]: https://redfish.dmtf.org/schemas/v1/MetricReportDefinition.v1_4_2.json
Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com> Change-Id: I5930a466a370f268d68f575a4a3db5ee9655e574
show more ...
|
3a1c297a | 10-May-2023 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: copy latest and re-format
clang-format-16 has some backwards incompatible changes that require additional settings for best compatibility and re-running the formatter. Copy the latest
clang-format: copy latest and re-format
clang-format-16 has some backwards incompatible changes that require additional settings for best compatibility and re-running the formatter. Copy the latest .clang-format from the docs repository and reformat the repository.
Change-Id: I1ac255c58971ac5cc4697b8bb1069067aad02d18 Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
1cdd7e4f | 08-Jun-2022 |
Szymon Dompke <szymon.dompke@intel.com> |
Use proper dbus path when possible.
Following methods and properties were updated to use full dbus path, instead of internal telemetry id: - TriggerManager.AddTrigger() - 'reportIds' arg - Trigger.R
Use proper dbus path when possible.
Following methods and properties were updated to use full dbus path, instead of internal telemetry id: - TriggerManager.AddTrigger() - 'reportIds' arg - Trigger.ReportIds - renamed to 'Reports' - Report.TriggerIds - renamed to 'Triggers'
Testing done: - UTs were updated and are passing.
Signed-off-by: Szymon Dompke <szymon.dompke@intel.com> Change-Id: I78d812d38289fac575d25b48503cc8b9c6f736fe
show more ...
|
51f0fd50 | 28-Dec-2021 |
Krzysztof Grobelny <krzysztof.grobelny@intel.com> |
Fixed issue with wrong timestamp
Telemetry service used steady_clock for generating timestamps, but it produced incorrect time. This change makes telemetry service use steady_clock for intervals and
Fixed issue with wrong timestamp
Telemetry service used steady_clock for generating timestamps, but it produced incorrect time. This change makes telemetry service use steady_clock for intervals and system_clock for timestamps.
Changed readings timestamp to display current timestamp instead of a time when reading was received.
Tested: - correct timestamp is visible on dbus - other telemetry service features are still working
Change-Id: Ic49f45640532cfffaeff5e0bd5591e6d99e5def5 Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com>
show more ...
|
dcc4e193 | 08-Mar-2021 |
Krzysztof Grobelny <krzysztof.grobelny@intel.com> |
created AddReportFutureVersion dbus method
New method will support CollectionTimeScope, CollectionDuration
In order to make not breaking interface changes bmcweb will switch to AddReportFutureVersi
created AddReportFutureVersion dbus method
New method will support CollectionTimeScope, CollectionDuration
In order to make not breaking interface changes bmcweb will switch to AddReportFutureVersion, then AddReport will be changed to match AddReportFutureVersion, then redfish will switch back to use AddReport, then AddReportFutureVersion will be removed.
Tested: - Verified that current version of bmcweb works fine with old API
Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com> Change-Id: I51a9b7fb2f4da5b8d2f688ccd5e93710352b1ac7
show more ...
|
9f9ff90a | 05-Mar-2021 |
Krzysztof Grobelny <krzysztof.grobelny@intel.com> |
Revert "created AddReportFutureVersion dbus method"
This reverts commit 753e4b3c843dd5d1068949c4106a6389f0e0ffbc.
Reason for revert: Breaks bmcweb, same approach is needed for changed properties
C
Revert "created AddReportFutureVersion dbus method"
This reverts commit 753e4b3c843dd5d1068949c4106a6389f0e0ffbc.
Reason for revert: Breaks bmcweb, same approach is needed for changed properties
Change-Id: Id868159df916fcf0bdd7fc5062f8c51187fcc7e2
show more ...
|
753e4b3c | 11-Feb-2021 |
Krzysztof Grobelny <krzysztof.grobelny@intel.com> |
created AddReportFutureVersion dbus method
New method will support CollectionTimeScope, CollectionDuration
In order to make not breaking interface changes bmcweb will switch to AddReportFutureVersi
created AddReportFutureVersion dbus method
New method will support CollectionTimeScope, CollectionDuration
In order to make not breaking interface changes bmcweb will switch to AddReportFutureVersion, then AddReport will be changed to match AddReportFutureVersion, then redfish will switch back to use AddReport, then AddReportFutureVersion will be removed.
Change-Id: I9cc906cc1fa7cdf27be7e433390c516f6bae3c50 Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com>
show more ...
|
e8fc5751 | 05-Feb-2021 |
Krzysztof Grobelny <krzysztof.grobelny@intel.com> |
Changed dbus add report interface
- metric parameters now take single sensor instead of list - added interface support for new operation types
Tested: - All telemetry tests are passing.
Signed-off
Changed dbus add report interface
- metric parameters now take single sensor instead of list - added interface support for new operation types
Tested: - All telemetry tests are passing.
Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com> Change-Id: Id3a41c48e81a287e7d205ae1c747daa36d4cdb29
show more ...
|
d2238194 | 02-Dec-2020 |
Krzysztof Grobelny <krzysztof.grobelny@intel.com> |
Review fixes for 'Created metric class'
- Changed metric to_json to dumpConfiguration returning LabeledTuple - LabeledTuple can be created and assigned directly to json - LabeledTuple can be readed
Review fixes for 'Created metric class'
- Changed metric to_json to dumpConfiguration returning LabeledTuple - LabeledTuple can be created and assigned directly to json - LabeledTuple can be readed from json using json.get<LabeledTuple> - Added PrintTo for LabeledMetricParams, LabeledSensorParams - Added helper method expectMake to ReportFactoryMock - sensorPaths are serialized to tuple<service, path> instead of single field with service and path separated via ':' - Changed configuration version from 1 to 2
Change-Id: I7c45fb584687172f88fd549a93329264793b0b8e Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com>
show more ...
|
6ccfcbf5 | 04-Nov-2020 |
Krzysztof Grobelny <krzysztof.grobelny@intel.com> |
Created metric class
Metric collects updates from sensor. Report displays metric readings depending on reportingType.
Tested: - Added new units tests for Metric class - All other unit tests are
Created metric class
Metric collects updates from sensor. Report displays metric readings depending on reportingType.
Tested: - Added new units tests for Metric class - All other unit tests are passing
Change-Id: I19f4831fab163a4f9540cef7bb23e903ae90fddf Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com>
show more ...
|