#
b7b7e1b6 |
| 19-May-2022 |
Szymon Dompke <szymon.dompke@intel.com> |
Update Trigger Actions implementation
Dbus trigger action names were modified to reflect separation of Telemetry Service from Redfish: - LogToLogService is renamed to LogToJournal, - RedfishEvent wa
Update Trigger Actions implementation
Dbus trigger action names were modified to reflect separation of Telemetry Service from Redfish: - LogToLogService is renamed to LogToJournal, - RedfishEvent was renamed to LogToRedfishEventLog
Both of those logging actions, now also include trigger id and threshold name. Threshold naming logic: - For discrete triggers, it can be specified by user, if left empty it will be changed to "{Severity} condition". - Numeric triggers have no way of naming threshold, instead its type will be converted to string, example "UpperWarning" - Discrete OnChange threshold will always be named "OnChange"
Additionally, defect was found with timestamp attached to Trigger Logs: it was a steady_clock timestamp instead of system_clock. The function which was supposed to format it was also working incorrectly, and was improved to work with milliseconds. This change required major refactor of unit tests, especially for numeric threshold.
Testing done: - LogToJournal action is working properly, - LogToRedfishEventLog action is working properly, - UTs are passing.
Signed-off-by: Szymon Dompke <szymon.dompke@intel.com> Change-Id: Iae2490682f0e9e2a610b45fd8af5cc5e21e66f35
show more ...
|
#
51f0fd50 |
| 28-Dec-2021 |
Krzysztof Grobelny <krzysztof.grobelny@intel.com> |
Fixed issue with wrong timestamp
Telemetry service used steady_clock for generating timestamps, but it produced incorrect time. This change makes telemetry service use steady_clock for intervals and
Fixed issue with wrong timestamp
Telemetry service used steady_clock for generating timestamps, but it produced incorrect time. This change makes telemetry service use steady_clock for intervals and system_clock for timestamps.
Changed readings timestamp to display current timestamp instead of a time when reading was received.
Tested: - correct timestamp is visible on dbus - other telemetry service features are still working
Change-Id: Ic49f45640532cfffaeff5e0bd5591e6d99e5def5 Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com>
show more ...
|
#
1477fe6a |
| 02-Jan-2021 |
Wludzik, Jozef <jozef.wludzik@intel.com> |
Implement NumericThreshold for Trigger
Implemented NumericThreshold for Trigger that allows to set expected threshold value for collection of sensors and monitors if this value is crossed. Implement
Implement NumericThreshold for Trigger
Implemented NumericThreshold for Trigger that allows to set expected threshold value for collection of sensors and monitors if this value is crossed. Implemented detection of direction when threshold value is crossed. Added initial interface that is used to commit an action when threshold value is crossed. Moved Sensor Cache from Report Factory to Telemetry class, now Sensor Cache is shared between Report Factory and Trigger Factory. Moved fetching sensor from Dbus to seperate header to have single implementation for factories. Disabled tests that uses boost coroutine because of false positive that is catched by address sanitizer.
Tested: - Passed unit tests - Built in yocto envrionment with success - Telemetry service started successfully in OpenBMC
Change-Id: I1ff7ab96174a27576786f0b9a71554fe1eeff436 Signed-off-by: Wludzik, Jozef <jozef.wludzik@intel.com>
show more ...
|