Update sst-compare-redfish-os.py for TPMI based CPUs

The output of `intel-speed-select` is slightly different for TPMI-based
CPUs. Filter out some unnecessary info and check two possible JSON keys
f

Update sst-compare-redfish-os.py for TPMI based CPUs

The output of `intel-speed-select` is slightly different for TPMI-based
CPUs. Filter out some unnecessary info and check two possible JSON keys
for the SSE turbo buckets.

Change-Id: Ia6ceadf36cfafcdd5f3c3eb4a759ea8bacd5763c
Signed-off-by: Jonathan Doman <jonathan.doman@intel.com>

show more ...

Fix sst-info.sh script

Partial revert of 3e6be2eea132571ec4cae82cd16cdec6c9170560, which
applied shellcheck recommendations a bit too zealously.

* Go back to /bin/sh since we don't need bash constr

Fix sst-info.sh script

Partial revert of 3e6be2eea132571ec4cae82cd16cdec6c9170560, which
applied shellcheck recommendations a bit too zealously.

* Go back to /bin/sh since we don't need bash constructs
* Remove function keyword from function defs, which is not POSIX sh and
also not even recommended for bash
* Replace some intentional word splitting with a new function

Tested: Tested with DEBUG=1 on a system that supports SST and verified
that all three subcommands were constructing busctl calls correctly.

Change-Id: I83ec923cea4f64a04706c0e92200cd92e0ab5ac0
Signed-off-by: Jonathan Doman <jonathan.doman@intel.com>

show more ...

shellcheck: fix issues and format with beautysh

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I5129be6a6c4fc98eb0ef13901d6814683145a617

sst-compare-redfish-os.py: fix flake8 and reformat with black

flake8 was reporting numerous issues in this script, some of which
were due to line lengths longer than desired. Fix the flake8 issues

sst-compare-redfish-os.py: fix flake8 and reformat with black

flake8 was reporting numerous issues in this script, some of which
were due to line lengths longer than desired. Fix the flake8 issues
and reformat with black.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I5cc3bdbf2982858f3756ef81a6677a94ab619a55

show more ...

beautysh: re-format

beautysh is enabled in the openbmc-build-scripts on Bash/Zsh/POSIX-sh
files to have a consistent formatting. Re-run the formatter on the
whole repository.

Change-Id: I808cd4a37

beautysh: re-format

beautysh is enabled in the openbmc-build-scripts on Bash/Zsh/POSIX-sh
files to have a consistent formatting. Re-run the formatter on the
whole repository.

Change-Id: I808cd4a379c290d39eb4481b66a8ae26b1b993aa
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

tools:sst-compare-redfish-os: Handle missing properties

Turns out there are some properties not exposed by the
intel-speed-select tool, so we need to handle missing values without
failing the test.

tools:sst-compare-redfish-os: Handle missing properties

Turns out there are some properties not exposed by the
intel-speed-select tool, so we need to handle missing values without
failing the test.

Tested: Ran sst-compare-redfish-os.py:
...
Junction Temperature:
Redfish: 81
Linux: 81
SSE Max Turbo Speed: MISSING VALUE
Redfish: 3500
Linux: None
TDP:
Redfish: 250
Linux: 250
...
Everything matched! :)

Signed-off-by: Jonathan Doman <jonathan.doman@intel.com>
Change-Id: Ia34ee13879801eb0c351508ccc7d906bf5e122e0

show more ...

Add support for dynamic SST configuration change

- Implement the CurrentOperatingConfig getters to dynamically read
configuration via PECI. The approach is to read the value from
PECI for each D

Add support for dynamic SST configuration change

- Implement the CurrentOperatingConfig getters to dynamically read
configuration via PECI. The approach is to read the value from
PECI for each D-Bus read. When the host is off, return "default"
values, and when the host is on but the read fails, return the last
read (cached) values.
- Implement the CurrentOperatingConfig setters to modify configuration
via PECI.

Tested:
- Change SST-PP profile and SST-BF flag via D-Bus properties, and
confirmed that host-side Linux tool shows changes.
- Change while host off and confirm it's rejected.
- Change while host booting and confirm it's rejected.
- Read configuration while host off and confirm last known values are
returned.
- Read configuration while host booting and confirm actual values are
returned.
- Change on ICX after host booted and confirm it's rejected.

Signed-off-by: Jonathan Doman <jonathan.doman@intel.com>
Change-Id: Ie6eed8ab23bff289e01d6d125402a5509d3a9110

show more ...

cpuinfoapp: Add SST discovery feature

Retrieve Intel Speed Select Technology (SST) configuration values for
all CPUs via PECI (OS-PCode mailbox). Each CPU may have up to three
Performance Profiles (

cpuinfoapp: Add SST discovery feature

Retrieve Intel Speed Select Technology (SST) configuration values for
all CPUs via PECI (OS-PCode mailbox). Each CPU may have up to three
Performance Profiles (PP), each with accompanying Base Frequency (BF)
information.

Discovery is started immediately, but if no CPUs are found or any
unexpected PECI error is encountered, discovery is aborted and scheduled
for periodic retries until complete.

The profile data is published on D-Bus using two predefined interfaces:
- xyz.openbmc_project.Control.Processor.CurrentOperationConfig, which
is implemented on each "cpu" object in the inventory, and contains
mutable properties for OOB configuration (modifiying properties not
supported yet).
- xyz.openbmc_project.Inventory.Item.Cpu.OperationConfig, which is
implemented on separate "config" objects and contains the readonly
properties for each performance profile.

Tested:
- Profiled performance of PECI operations via code instrumentation
(takes ~2 min per CPU on ast2500 during BMC boot, ~2 sec during BMC idle).
- Validated Redfish output against Linux driver using included python
tool.
- Injected PECI failures in code to test error handling, and tested
with Linux OS idling on host to make sure WOP is working.

Change-Id: I0d8ae79655dfd2880cf3bae6abe600597740df7c
Signed-off-by: Jonathan Doman <jonathan.doman@intel.com>

show more ...