Populate MemoryTotalWidth property

The "MemoryTotalWidth" property did not display correct information
from the smbios file. Add function to transfer "totalWidth" type and
return data in sdbusplus f

Populate MemoryTotalWidth property

The "MemoryTotalWidth" property did not display correct information
from the smbios file. Add function to transfer "totalWidth" type and
return data in sdbusplus format.

Tested:
Before
```
root@qbmc:root@qbmc:~# busctl introspect xyz.openbmc_project.Smbios.MDR_V2 /xyz/openbmc_project/inventory/system/chassis/motherboard/dimm0 xyz.openbmc_project.Inventory.Item.Dimm
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
.AllowedSpeedsMT property aq 0 emits-change writable
.CASLatencies property q 0 emits-change writable
.ECC property s "xyz.openbmc_project.Inventory.Item.D... emits-change writable
.FormFactor property s "xyz.openbmc_project.Inventory.Item.D... emits-change writable
.MaxMemorySpeedInMhz property q 4800 emits-change writable
.MemoryAttributes property y 2 emits-change writable
.MemoryConfiguredSpeedInMhz property q 4800 emits-change writable
.MemoryDataWidth property q 64 emits-change writable
.MemoryDeviceLocator property s "DIMM0" emits-change writable
.MemoryMedia property s "xyz.openbmc_project.Inventory.Item.D... emits-change writable
.MemorySizeInKB property t 33554432 emits-change writable
.MemoryTotalWidth property q 0 emits-change writable
.MemoryType property s "xyz.openbmc_project.Inventory.Item.D... emits-change writable
.MemoryTypeDetail property s "SynchronousUnbuffered" emits-change writable
.RevisionCode property q 0 emits-change writable
```
After patching, MemoryTotalWidth property get correct value.
```
root@qbmc:~# busctl introspect xyz.openbmc_project.Smbios.MDR_V2 /xyz/openbmc_project/inventory/system/chassis/motherboard/dimm0 xyz.openbmc_project.Inventory.Item.Dimm
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
.AllowedSpeedsMT property aq 0 emits-change writable
.CASLatencies property q 0 emits-change writable
.ECC property s "xyz.openbmc_project.Inventory.Item.D... emits-change writable
.FormFactor property s "xyz.openbmc_project.Inventory.Item.D... emits-change writable
.MaxMemorySpeedInMhz property q 4800 emits-change writable
.MemoryAttributes property y 2 emits-change writable
.MemoryConfiguredSpeedInMhz property q 4800 emits-change writable
.MemoryDataWidth property q 64 emits-change writable
.MemoryDeviceLocator property s "DIMM0" emits-change writable
.MemoryMedia property s "xyz.openbmc_project.Inventory.Item.D... emits-change writable
.MemorySizeInKB property t 33554432 emits-change writable
.MemoryTotalWidth property q 72 emits-change writable
.MemoryType property s "xyz.openbmc_project.Inventory.Item.D... emits-change writable
.MemoryTypeDetail property s "SynchronousUnbuffered" emits-change writable
.RevisionCode property q 0 emits-change writable
```

Change-Id: I355ef057d7d28e4507d7c91eb45ab2453ed1923e
Signed-off-by: Joseph Fu <joseph.fu@quantatw.com>

show more ...

Populate Memory attributes

Add support to populate MemoryMedia, Slot and Socket attribute values
to dbus attributes.

Tested:
Memory attributes MemoryMedia,Slot and Socket are populated in dbus
thro

Populate Memory attributes

Add support to populate MemoryMedia, Slot and Socket attribute values
to dbus attributes.

Tested:
Memory attributes MemoryMedia,Slot and Socket are populated in dbus
through busctl command
Command:
busctl introspect xyz.openbmc_project.Smbios.MDR_V2
/xyz/openbmc_project/inventory/system/chassis/motherboard/dimm0
Response:
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
....

xyz.openbmc_project.Inventory.Decorator.LocationCode interface - - -
.LocationCode property s "BANK 0 CPU0_DIMM_A" emits-change writable
xyz.openbmc_project.Inventory.Item interface - - -
.Present property b true emits-change writable
.PrettyName property s "" emits-change writable
xyz.openbmc_project.Inventory.Item.Dimm interface - - -

.MemoryAttributes property u 8388610 emits-change writable
.MemoryConfiguredSpeedInMhz property q 19460 emits-change writable
.MemoryDataWidth property q 64 emits-change writable
.MemoryDeviceLocator property s "BANK 0 CPU0_DIMM_A" emits-change writable
.MemoryMedia property s "xyz.openbmc_project.Inventory.Item.D... emits-change writable
.MemorySizeInKB property u 1468006400 emits-change writable
.MemoryTotalWidth property q 0 emits-change writable
.MemoryType property s "xyz.openbmc_project.Inventory.Item.D... emits-change writable
.MemoryTypeDetail property s "SynchronousRegistered" emits-change writable
.RevisionCode property q 0 emits-change writable
xyz.openbmc_project.Inventory.Item.Dimm.MemoryLocation interface - - -
.Channel property y 0 emits-change writable
.MemoryController property y 0 emits-change writable
.Slot property y 65 emits-change writable
.Socket property y 1 emits-change writable
.....

Signed-off-by: poram srinivasa rao <poramx.srinivasa.rao@intel.com>
Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: Iabc2a58642167344711550b669ed4f207fb39d45

show more ...

Change the byte of the MemoryAttributes attribute to the size type

We prefer to use size_t type instead of byte type in PDI[1]

[1] https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/63

Change the byte of the MemoryAttributes attribute to the size type

We prefer to use size_t type instead of byte type in PDI[1]

[1] https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/63799

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I211a7cd553338995170407fa583d8926a6c98f53

show more ...

mdrv2: Attempt to update D-Bus objects in place

When systemInfoUpdate() is called multiple times, there's a potential
race condition of a user polling for the objects while the array of
D-Bus object

mdrv2: Attempt to update D-Bus objects in place

When systemInfoUpdate() is called multiple times, there's a potential
race condition of a user polling for the objects while the array of
D-Bus objects are erased and being repopulated. This results in
incomplete set of memory or CPU counts, which can lead to unforseen
consequences.

Tested: Verified that a corner case that was hitting this case
consistently (when SMBIOS was transferred using ipmi-blob repeatedly)
goes away with this implementation.

Signed-off-by: Brandon Kim <brandonkim@google.com>
Change-Id: I312aa91cd11b1dd06502d04272889922108d39a2

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I172b14c1a881c734851b7dc6e0e90ee2e11cce03
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Update to the new sdbusplus namespace format

The sdbusplus namespace format was updated in [1]. This updates the
local namespaces to the new format.

[1]: https://github.com/openbmc/sdbusplus/commit

Update to the new sdbusplus namespace format

The sdbusplus namespace format was updated in [1]. This updates the
local namespaces to the new format.

[1]: https://github.com/openbmc/sdbusplus/commit/5011340e14da7fc04f8b20721c4631f778200edd

Change-Id: Ic6b874fb86d2ff2192d8067871bd2170696f2b8c
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>

show more ...

Fix memory extendedSize type

Modify "extendedSize" type to support 64-bit environment.
The size_t type uses 8 bytes in a 64-bit environment, the
properties "MemorySizeInKB" and "MemoryConfiguredSpee

Fix memory extendedSize type

Modify "extendedSize" type to support 64-bit environment.
The size_t type uses 8 bytes in a 64-bit environment, the
properties "MemorySizeInKB" and "MemoryConfiguredSpeedInMhz"
will get wrong values from smbios file.

Tested:
```
root@qbmc:~# busctl introspect xyz.openbmc_project.Smbios.MDR_V2 \
> /xyz/openbmc_project/inventory/system/chassis/motherboard/dimm0 \
> xyz.openbmc_project.Inventory.Item.Dimm
.AllowedSpeedsMT property aq 0 emits-change writable
.CASLatencies property q 0 emits-change writable
.ECC property s "xyz.openbmc_project.Inventory.Item.D... emits-change writable
.FormFactor property s "xyz.openbmc_project.Inventory.Item.D... emits-change writable
.MaxMemorySpeedInMhz property q 4800 emits-change writable
.MemoryAttributes property y 2 emits-change writable
.MemoryConfiguredSpeedInMhz property q 1100 emits-change writable
.MemoryDataWidth property q 64 emits-change writable
.MemoryDeviceLocator property s "P0 CHANNEL A DIMM0" emits-change writable
.MemoryMedia property s "xyz.openbmc_project.Inventory.Item.D... emits-change writable
.MemorySizeInKB property t 3479875137107394560 emits-change writable
.MemoryTotalWidth property q 0 emits-change writable
...
```
After
```
root@qbmc:~# busctl introspect xyz.openbmc_project.Smbios.MDR_V2 \
> /xyz/openbmc_project/inventory/system/chassis/motherboard/dimm0 \
> xyz.openbmc_project.Inventory.Item.Dimm
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
.AllowedSpeedsMT property aq 0 emits-change writable
.CASLatencies property q 0 emits-change writable
.ECC property s "xyz.openbmc_project.Inventory.Item.D... emits-change writable
.FormFactor property s "xyz.openbmc_project.Inventory.Item.D... emits-change writable
.MaxMemorySpeedInMhz property q 4800 emits-change writable
.MemoryAttributes property y 2 emits-change writable
.MemoryConfiguredSpeedInMhz property q 4800 emits-change writable
.MemoryDataWidth property q 64 emits-change writable
.MemoryDeviceLocator property s "P0 CHANNEL A DIMM0" emits-change writable
.MemoryMedia property s "xyz.openbmc_project.Inventory.Item.D... emits-change writable
.MemorySizeInKB property t 33554432 emits-change writable
.MemoryTotalWidth property q 0 emits-change writable
...
```

Change-Id: I205de7df72269e472143ea3a3fc2f6f9e4af56ee
Signed-off-by: Joseph Fu <joseph.fu@quantatw.com>

show more ...

dimm: use size to determine if DIMM is present and functional

Currently, we are using "NO DIMM" in dimmManufacturer to determine if
there is a DIMM sensor or not. However, it's "Unknown" in an AMD m

dimm: use size to determine if DIMM is present and functional

Currently, we are using "NO DIMM" in dimmManufacturer to determine if
there is a DIMM sensor or not. However, it's "Unknown" in an AMD machine
we are testing.

Looking into SMBIOS spec (DSP0134_3.3.0), it looks like using size to
determine if DIMM is present and functional is a better option.

Tested:
Check an Intel CPU machine and the Present is true when DIMM is there
and false when it's not:
```
busctl introspect xyz.openbmc_project.Smbios.MDR_V2 \
/xyz/openbmc_project/inventory/system/chassis/motherboard/dimm0 \
xyz.openbmc_project.Inventory.Item
NAME TYPE SIGNATURE RESULT/VALUE
FLAGS
.Present property b true
emits-change writable
.PrettyName property s ""
emits-change writable

busctl introspect xyz.openbmc_project.Smbios.MDR_V2 \
/xyz/openbmc_project/inventory/system/chassis/motherboard/dimm1 \
xyz.openbmc_project.Inventory.Item
NAME TYPE SIGNATURE RESULT/VALUE
FLAGS
.Present property b false
emits-change writable
.PrettyName property s ""
emits-change writable
```
Check an AMD machine and it works fine with a bad DIMM and a good DIMM:
```
busctl introspect
xyz.openbmc_project.Smbios.MDR_V2
/xyz/openbmc_project/inventory/system/chassis/motherboard/dimm0
xyz.openbmc_project.Inventory.Item
NAME TYPE SIGNATURE RESULT/VALUE
FLAGS
.Present property b false
emits-change writable
.PrettyName property s ""
emits-change writable

busctl introspect
xyz.openbmc_project.Smbios.MDR_V2
/xyz/openbmc_project/inventory/system/chassis/motherboard/dimm1
xyz.openbmc_project.Inventory.Item
NAME TYPE SIGNATURE RESULT/VALUE
FLAGS
.Present property b true
emits-change writable
.PrettyName property s ""
emits-change writable
```

Change-Id: If6ea55f35b4af3225c4a07de481d930fa461b3e7
Signed-off-by: Tom Tung <shes050117@gmail.com>

show more ...

Add config to allow DIMM only in Location Code

This change creates an option that excludes the bank number from the
location code. This addresses issues from [1] that changed the location
format, br

Add config to allow DIMM only in Location Code

This change creates an option that excludes the bank number from the
location code. This addresses issues from [1] that changed the location
format, breaking previous assumptions related to location codes.

This command was used the validate the format of the location code.
'''
$ busctl introspect "xyz.openbmc_project.Smbios.MDR_V2" /xyz/openbmc_project/inventory/system/chassis/motherboard/dimm4
...
xyz.openbmc_project.Inventory.Decorator.LocationCode interface - - -
.LocationCode property s "DIMM2" emits-change
```

[1] https://github.com/openbmc/smbios-mdr/commit/744b35aad0051084c7b71fee8898d1e496345270

Signed-off-by: John Edward Broadbent <jebr@google.com>
Change-Id: I3b1e219aabba20c0031bfe78bad17887cf05715c

show more ...

Utilize 'Bank Locator' memory device table field

SMBIOS specification defines the following fields in the
'Memory Device (Type 17)' table:

'''
Device Locator
String number of the string that identi

Utilize 'Bank Locator' memory device table field

SMBIOS specification defines the following fields in the
'Memory Device (Type 17)' table:

'''
Device Locator
String number of the string that identifies the physically-labeled
socket or board position where the memory device is located.
EXAMPLE: "DIMM 0"

Bank Locator
String number of the string that identifies the physically labeled
bank where the memory device is located.
EXAMPLE: "Bank 0" or "A"
'''

Currently smbios-mdr uses only 'Device Locator' field for the
'Dimm::MemoryDeviceLocator' value.
Utilize both 'Bank Locator' and 'Device Locator' fields to construct
more complete locator value.

Tested:
Tested on the AMD EthanolX board. Example of the locator fields in
one of the Type 17 tables:
Bank Locator: "P0 CHANNEL A",
Device Locator: "DIMM 0".

Before the patch "MemoryDeviceLocator" property on the
"xyz.openbmc_project.Inventory.Item.Dimm" interface is equal to
the "DIMM 0".
After the patch it is equal to the "P0 CHANNEL A DIMM 0".

Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
Change-Id: I0e4913b8ac0639a9549c217ca9dfbfe34ea82c68

show more ...

Expose memory error correction type

Memory error correction types are provided by smbios table type-16.
This change use that table to populate 'ECC' field in
xyz.openbmc_project.Inventory.Item.Dimm

Expose memory error correction type

Memory error correction types are provided by smbios table type-16.
This change use that table to populate 'ECC' field in
xyz.openbmc_project.Inventory.Item.Dimm interface.

Tested:
Tested this on a real machine.

Signed-off-by: Kasun Athukorala <kasunath@google.com>
Change-Id: Iaeb27f81d9b97be1858d1c4564318f5dc69cfa4f

show more ...

Remove trailing spaces in PartNumber

Sometime PartNumber can contain trailing spaces. This is unnecessary
and can cause issues when trying to compare with this field. This
change will remove trailin

Remove trailing spaces in PartNumber

Sometime PartNumber can contain trailing spaces. This is unnecessary
and can cause issues when trying to compare with this field. This
change will remove trailing whitespaces if any.

Tested:
Verified on a machine that the part number doesn't
contain any trailing white spaces with this change.

Signed-off-by: Kasun Athukorala <kasunath@google.com>
Change-Id: I271c9f527f98fbb79493cfe3715b421b44996a91

show more ...

Fix dimm present and functional property to true for robot test

Symptom:
Auto test got failed from ipmi/test_ipmi_sdr.robot
Test DIMM SDR Info At Power Off | FAIL |
Test DIMM SDR Info At Power On |

Fix dimm present and functional property to true for robot test

Symptom:
Auto test got failed from ipmi/test_ipmi_sdr.robot
Test DIMM SDR Info At Power Off | FAIL |
Test DIMM SDR Info At Power On | FAIL |

Root cause:
Read "Present" property from "Verify SDR" keyword and got unexpected result.
Then cause test item "Test DIMM SDR Info At Power On" and
"Test DIMM SDR Info At Power Off" both got failed.

"Present" property ${presence_rest} got false value from
/xyz/openbmc_project/inventory/system/chassis/motherboard/dimmX path
that didn't match expectation of auto test item as below:

If ${presence_ipmi} output is "Presence Detected"
then ${presence_rest} and ${functional_rest} should be true.

However, ${presence_rest} is false and another "Functional" property
didn't be added correctly according current design.
Then cause both DIMM SDR Info test items got failed.

Example of IPMI SDR elist output (ipmitool sdr elist command)
dimm0 | 72h | ok | 32.25 | Presence Detected
dimm1 | 73h | ok | 32.26 | Presence Detected
dimm2 | 74h | ok | 32.27 | Presence Detected
(For example: our host inlcude one DDR4 at dimm0 is DDR4,
dimm1 and dimm2 are NO DIMM, but output is Presence Detected also)

Solution:
According ipmi sdr elist output "Presence Detected", we need to set
present property to true and add functional property with true by default.

Tested:
Run robot test ipmi/test_ipmi_sdr.robot
Test DIMM SDR Info At Power Off | PASS |
Test DIMM SDR Info At Power On | PASS |

Signed-off-by: Tim Lee <timlee660101@gmail.com>
Change-Id: Iaf2e130b682ec47d3b522bc07fa7859aeba559ae

show more ...

smbios-mdr: Associate with the motherboard

The change associates the objects such as processor, memory and PCIe
slots published by smbios-mdr with the motherboard inventory object.
Presently objects

smbios-mdr: Associate with the motherboard

The change associates the objects such as processor, memory and PCIe
slots published by smbios-mdr with the motherboard inventory object.
Presently objects paths created by smbios-mdr have the motherboard path
as the prefix -- "/xyz/openbmc_project/inventory/chassis/motherboard".
For machine with entity-manager dynamic stack, that hardcoded
motherboard path would probably not be the object path of the
motherboard.

We have implemented a DBus method in EM that can return the inventory
object path of the root board in the system. Such associations can be
assembled in Redfish resources can indicate the machine topology.

Tested:
DBus call on the Association interface of a CPU object.

busctl get-property xyz.openbmc_project.Smbios.MDR_V2 \
/xyz/openbmc_project/inventory/system/chassis/motherboard/cpu0 \
xyz.openbmc_project.Association.Definitions Associations
a(sss) 1 "chassis" "processors" \
"/xyz/openbmc_project/inventory/system/board/GSZ"

Signed-off-by: Jie Yang <jjy@google.com>
Change-Id: Ia95159a87c2ce5e69e90e622cf341a68e7db13d4

show more ...

Add CPU and memory LocationCode DBus interface

LocationCode DBus interface can describe the sockets with physical
labels printed on the board. Bmcweb looks up the LocationCode for CPU
and DIMM resou

Add CPU and memory LocationCode DBus interface

LocationCode DBus interface can describe the sockets with physical
labels printed on the board. Bmcweb looks up the LocationCode for CPU
and DIMM resources and then identify the resource location. Those
physical CPU and DIMM socket labels are hardcoded in SMBIOS table as
socket designation.

Tested:
CPU and memory DBus objects show the
xyz.openbmc_project.Inventory.Decorator.LocationCode interface and the
LocationCode property is the socket label.

Signed-off-by: Jie Yang <jjy@google.com>
Change-Id: I6131567aca1958505989773fc800a4c2d1dd7e1f

show more ...

Fix smbios-mdrv2 CI build

The phosphor-dbus-interface type for memorySizeInKB changed
from uint32_t to size_t.

https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-dbus-interfaces/+/41870

This up

Fix smbios-mdrv2 CI build

The phosphor-dbus-interface type for memorySizeInKB changed
from uint32_t to size_t.

https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-dbus-interfaces/+/41870

This updates smbios-mdrv2 with that change to fix the CI build.

The phosphor-dbus-interface name for Common::UUID changed
from uUID to uuid. This updates smbios-mdrv2 with that change
to fix the CI build.

Change-Id: I37994e7b36ea8182c01386d804ff2de1e682fdd8
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Get Present property for Dimms

From smbios file, for physically not present dimms details are filled
as "NO DIMM". Using which populating Present property under
xyz.openbmc_project.Inventory.Item in

Get Present property for Dimms

From smbios file, for physically not present dimms details are filled
as "NO DIMM". Using which populating Present property under
xyz.openbmc_project.Inventory.Item interface with
true/false that indicates presence of dimms and making manufacturer
value empty for no dimm presence.

Tested:
Checked property is filled via dbus call.

Signed-off-by: Joshi-Mansi <mansi.joshi@linux.intel.com>
Change-Id: I84b05aeef3f77353fee1b663d39f3451c8faa337

show more ...

Fix some build failure issue

Fix some issues which will make build failure.
Also format the code with latest clang-format.

Tested:
Power cycle the system and after BIOS finish post, correct DIMM an

Fix some build failure issue

Fix some issues which will make build failure.
Also format the code with latest clang-format.

Tested:
Power cycle the system and after BIOS finish post, correct DIMM and CPU
information and UUID can show in Redfish.

Signed-off-by: Cheng C Yang <cheng.c.yang@linux.intel.com>
Change-Id: I5833a89842bc0969829d10fed262cf43d31d8c3f

show more ...

Add DIMM dbus service for MDR V2

Add all DIMM information in smbios table and provide dbus
interface for redfish to get DIMM information.

Tested:
DC cycle the system and waiting for BIOS entring se

Add DIMM dbus service for MDR V2

Add all DIMM information in smbios table and provide dbus
interface for redfish to get DIMM information.

Tested:
DC cycle the system and waiting for BIOS entring setup page.
Correct DIMM information should show in Redfish.

Signed-off-by: Cheng C Yang <cheng.c.yang@linux.intel.com>
Change-Id: I8c2678c5d40f4d1fde81292b21aa94e80b0ab586

show more ...