python: reformat using black

Code cannot currently be submitted to this repo because it fails
in the unit-test phase. Attempt to reformat the code using `black`
to hopefully make pycodestyle happie

python: reformat using black

Code cannot currently be submitted to this repo because it fails
in the unit-test phase. Attempt to reformat the code using `black`
to hopefully make pycodestyle happier.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I17aa506471ceade224bcab5b2fa0dc8cd7a88c0a

show more ...

Add getObjectFrom* interfaces back in

Got a bit zealous with the removal of "legacy" interfaces
from system_manager.py in https://gerrit.openbmc-project.xyz/#/c/8874/
and removed som

Add getObjectFrom* interfaces back in

Got a bit zealous with the removal of "legacy" interfaces
from system_manager.py in https://gerrit.openbmc-project.xyz/#/c/8874/
and removed some still required by phosphor-host-ipmid code for
some of the legacy sensors.

Only adding the minimum required back in with this commit.

Tested: Flashed image on witherspoon and verified host errors
are no longer reported.

Resolves openbmc/openbmc#2975

Change-Id: I6ba601be6310c57122f5e2f1dc37c6eae5417771
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

Port to python 3

Port code to python 3 yet remain backward compatible to python 2.
This port is in preparation for yocto 2.4 upgrade.

Partially resolves openbmc/openbmc#2920

Port to python 3

Port code to python 3 yet remain backward compatible to python 2.
This port is in preparation for yocto 2.4 upgrade.

Partially resolves openbmc/openbmc#2920

Change-Id: If174ce9444bde4e21fb086764f4def017e423201
Signed-off-by: CamVan Nguyen <ctnguyen@us.ibm.com>

show more ...

Remove all legacy function from system manager

This commit removes all of the un-used interfaces in
order to get it down to its bare function and to
make eventual removal of this leg

Remove all legacy function from system manager

This commit removes all of the un-used interfaces in
order to get it down to its bare function and to
make eventual removal of this legacy application
easier

Tested: Built image and verified witherspoon system
still powers on as expected and no new errors or issues
show up in basic regression.

Change-Id: I55b7f3ebe68ce224bfccf14b0e9a4ceb4617f3d8
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

pep8 fixes

Also ignore the configs/ directory since it only contains
system configuration files named <system>.py.

Change-Id: I0416239c4030ce5bc39473e65e560016cd4ffc75
Signe

pep8 fixes

Also ignore the configs/ directory since it only contains
system configuration files named <system>.py.

Change-Id: I0416239c4030ce5bc39473e65e560016cd4ffc75
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

Spelling fixes

Change-Id: Ia4ded0c195204543c3df671ea471610237f5f44b
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

pysystemmgr: Fix pci_reset_outs

The pcie_reset_outs is incorrect and cause the PCIE reset functionality
broken.
Fix this by correctly parsing the GPIO config table.

Change-I

pysystemmgr: Fix pci_reset_outs

The pcie_reset_outs is incorrect and cause the PCIE reset functionality
broken.
Fix this by correctly parsing the GPIO config table.

Change-Id: I14bef6eba32c43fcc8e13ec956ad2e171d3e90b8
Signed-off-by: Lei YU <mine260309@gmail.com>

show more ...

GPIO abstraction for power and host control

In libopenbmc_intf/power_gpio.c there are GPIO abstractions for power
related GPIOs.
Host control related GPIOs need to do the same abstra

GPIO abstraction for power and host control

In libopenbmc_intf/power_gpio.c there are GPIO abstractions for power
related GPIOs.
Host control related GPIOs need to do the same abstraction.

The changes include:
1. Add host control related GPIOs in gpio_configs and update
system_manager.py
2. Update control_host_obj.c to use the abstracted GPIOs
3. Update GPIO_CONFIGS for all machines and add host control related
GPIOs

power_gpio will be renamed to gpio_configs in next commit;

Resolves openbmc/openbmc#814

Change-Id: I7832065d495d7d64c5df2f5b177005b97e68900a
Signed-off-by: Lei YU <mine260309@gmail.com>

show more ...

op-pwrctl: Hold PCI resets until BootProgress passes BASE_INITIALIZATION state

When powering on host, hold PCI resets until hostboot passes stage
"BASE_INITIALIZATION"(0x14).

Th

op-pwrctl: Hold PCI resets until BootProgress passes BASE_INITIALIZATION state

When powering on host, hold PCI resets until hostboot passes stage
"BASE_INITIALIZATION"(0x14).

This fix applies to Firestone and Garrison.

Partially resolves openbmc/openbmc#315

Change-Id: Ic71c81406ac188b34df89569e2264ea0b94406f3
Signed-off-by: Yi Li <adamliyi@msn.com>

show more ...

gpio: Raise exception on GPIO lookup failure

This allows dbus calls to gpioInit to fail instead of only returning a
default value. This behavior allows the C-side GPIO lookup to error ou

gpio: Raise exception on GPIO lookup failure

This allows dbus calls to gpioInit to fail instead of only returning a
default value. This behavior allows the C-side GPIO lookup to error out
as expected.

Signed-off-by: Xo Wang <xow@google.com>
Change-Id: I13ad20de5d209716f26e46c12ca6941eb3dd5997

show more ...

pwrctl: Add latch output to power control

On the Zaius machine, the BMC signals that power up the CPU are gated by
a latch to protect against GPIO blips during BMC reset/power loss.

pwrctl: Add latch output to power control

On the Zaius machine, the BMC signals that power up the CPU are gated by
a latch to protect against GPIO blips during BMC reset/power loss.

This adds an optional power GPIO configuration that controls the latch's
enable pin. Its behavior is to assert high when the op-pwrctl runs,
allowing power_up lines to propagate past their latches.

Signed-off-by: Xo Wang <xow@google.com>
Change-Id: Ibf0d1db771033cb9bba82575cca1bd21cfb3ad3d

show more ...

system_manager, libobmc-intf: Add power GPIO configuration interface

This adds a dbus call (in org.openbmc.managers.System) and C binding (in
libopenbmc-intf) to read a POWER_CONFIG from

system_manager, libobmc-intf: Add power GPIO configuration interface

This adds a dbus call (in org.openbmc.managers.System) and C binding (in
libopenbmc-intf) to read a POWER_CONFIG from the Python system
configuration that abstracts GPIO functionality (power good, reset, etc)
from their net names in GPIO_CONFIG.

This should eventually replace machine-specific patches to op-pwrctl
that define their own power and reset lines.

Change-Id: I56eaaf60ef852b68124e4a765942243ad17d06ac
Signed-off-by: Xo Wang <xow@google.com>

show more ...

Fix for Power Restore Policy

This fix is to make the Restore_last_state of Power Restore Policy
to working properly.

eg:- if the last state is Host_powered_on/off and system goe

Fix for Power Restore Policy

This fix is to make the Restore_last_state of Power Restore Policy
to working properly.

eg:- if the last state is Host_powered_on/off and system goes for pdu
reboot then system should reach to the Host_Powred_On/Off state.

Fixes openbmc/openbmc#196

Change-Id: If4bdb65a21452d7aa041312fcdbb1daa1b1b0424
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>

show more ...

configs: Remove gpio code from config files

Move to a new obmc.system module.

Change-Id: Ie02a4b2c14cfcf272d8823d44fb9d7c03b796c87
Signed-off-by: Brad Bishop <bradleyb@fuzziesqu

configs: Remove gpio code from config files

Move to a new obmc.system module.

Change-Id: Ie02a4b2c14cfcf272d8823d44fb9d7c03b796c87
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

inventory: Move INVENTORY_ROOT to inventory module

Change-Id: Ic68d4a48ff46002858934e0b9c9b1694a2a17a08
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

python: add vim modelines

Change-Id: Ic13d79892e3efe6f7bad357ad747e6fd25299d02
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

Use super to construct dbus.service.Object

Change-Id: I830decfc523d435c6b9ecdc9ffffec7956c3b85d
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

system_manager: cleanup

select python via /usr/bin/env

Change-Id: I426a8947e277892c3084ef08c246e98b625c3d10
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

systemmgr: Remove state management

With the switch to systemd this isn't needed anymore.

A small bit remains allowing the obmcutil cmdline to
continue reporing the familiar stat

systemmgr: Remove state management

With the switch to systemd this isn't needed anymore.

A small bit remains allowing the obmcutil cmdline to
continue reporing the familiar states for now.

Change-Id: I4c9a0201e0237fdcbd4f69f0de05c92f223827f0
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

pysystemmgr: Handling SIGCHLD signal

SystemManager starts multiple child processes when system state changes.
Set parent process to ignore the SIGCHLD signal, to prevent child
proces

pysystemmgr: Handling SIGCHLD signal

SystemManager starts multiple child processes when system state changes.
Set parent process to ignore the SIGCHLD signal, to prevent child
processes transforming into zombies when they terminate.

Resolves openbmc/openbmc#206

Change-Id: Ic8baa0cbb97f2df8fcc462a732a4194e4a6d3f8c
Signed-off-by: Yi Li <adamliyi@msn.com>

show more ...

Remove unused CACHE_PATH variable from configs

The library function doing the caching now makes the
parent directory if it doesn't exist so also removing
that bit of code from the sy

Remove unused CACHE_PATH variable from configs

The library function doing the caching now makes the
parent directory if it doesn't exist so also removing
that bit of code from the system manager.

Change-Id: I30a55737a51e698d977dbc3f30208db1d4e0e87e
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

system_manager: wait for objects with mapper wait

This is much faster than the current introspection based
mechanism.

Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

system_manager: wait for objects with mapper wait

This is much faster than the current introspection based
mechanism.

Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Change-Id: I1a737cab00311e9e0c0b63f4d8a487085cdf44e0

show more ...

system_manager: Remove bus from lookup response

Remove the busname field from the 'GetObject' method responses.
Applications should get the busname information from the mapper.

system_manager: Remove bus from lookup response

Remove the busname field from the 'GetObject' method responses.
Applications should get the busname information from the mapper.

Change-Id: Id548f3d5d6afda8334ad1163d66f69832591511a
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

system_manager: Remove dead code

Remove a reference to 'BMC_INIT' state which isn't used.
Remove heartbeat code that isn't used.

Change-Id: I2de0c881372085519a15235703881054c5a9

system_manager: Remove dead code

Remove a reference to 'BMC_INIT' state which isn't used.
Remove heartbeat code that isn't used.

Change-Id: I2de0c881372085519a15235703881054c5a9adfa
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

system_manager: Run pep8 on system_manager.py

Change-Id: I976228399027420f255f09622b02352e1799fe91
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>