#
cb267c8f |
| 05-Jan-2022 |
George Liu <liuxiwei@inspur.com> |
logging: switch to lg2
After switching to C++20, it is recommended to use `phosphor::lg2` to format log, and the correct `CODE_LINE` and `CODE_FUNC` values can be used in log tracking.
Tested: buil
logging: switch to lg2
After switching to C++20, it is recommended to use `phosphor::lg2` to format log, and the correct `CODE_LINE` and `CODE_FUNC` values can be used in log tracking.
Tested: built phosphor-srvcfg-manager successfully and Unit Test passes.
Signed-off-by: George Liu <liuxiwei@inspur.com> Change-Id: Ib676a0d8082b0e3e72b51bd5115bf5b05599e6ec
show more ...
|
#
a1fe1a28 |
| 18-Oct-2021 |
Bruce Mitchell <bruce.mitchell@linux.vnet.ibm.com> |
Use true instead of 1 for a while loop
Converts the while loop to while (true) from while (1). This is in the same spirt as using ES.47: Use nullptr rather than 0 or NULL https://isocpp.github.io/Cp
Use true instead of 1 for a while loop
Converts the while loop to while (true) from while (1). This is in the same spirt as using ES.47: Use nullptr rather than 0 or NULL https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Res-nullptr
Tested: Built p10bmc before and after change, successful build and runs on QEMU with no differences.
Signed-off-by: Bruce Mitchell <bruce.mitchell@linux.vnet.ibm.com> Change-Id: Ia01a17775f4731536bd6a1d0a09a927d3fc1807d
show more ...
|
#
a19b5093 |
| 24-May-2021 |
George Liu <liuxiwei@inspur.com> |
Allow disabling SSH
The intent behind this commit is to add the dropbear service, monitor the Enabled and Running properties, and then update the dropbear.socket to allow disabling/enabling SSH.
Te
Allow disabling SSH
The intent behind this commit is to add the dropbear service, monitor the Enabled and Running properties, and then update the dropbear.socket to allow disabling/enabling SSH.
Tested: 1. busctl introspect xyz.openbmc_project.Control.Service.Manager /xyz/openbmc_project/control/service/dropbear xyz.openbmc_project.Control.Service.Attributes interface .Enabled property b false emits-change writable .Masked property b false emits-change writable .Running property b true emits-change writable
Open a new SSH connection: sudo ssh username@<IP> Successfully connected
2. busctl set-property xyz.openbmc_project.Control.Service.Manager /xyz/openbmc_project/control/service/dropbear xyz.openbmc_project.Control.Service.Attributes Running b false
busctl introspect xyz.openbmc_project.Control.Service.Manager /xyz/openbmc_project/control/service/dropbear xyz.openbmc_project.Control.Service.Attributes interface .Enabled property b false emits-change writable .Masked property b false emits-change writable .Running property b false emits-change writable
Open a new SSH connection: sudo ssh username@<IP> ssh: connect to host <IP> port 22: Connection refused
Signed-off-by: George Liu <liuxiwei@inspur.com> Change-Id: I5d004f7f49c25fc90b93dabd124fe0d3d93ca822
show more ...
|
#
ba2c083e |
| 15-Jul-2020 |
Vernon Mauery <vernon.mauery@linux.intel.com> |
Change files to use standard unix file endings
CRLF line endings are non-standard for this project. Change them to use the standard unix LF ending.
Tested: `git show -w` shows no difference
Change
Change files to use standard unix file endings
CRLF line endings are non-standard for this project. Change them to use the standard unix LF ending.
Tested: `git show -w` shows no difference
Change-Id: I353adcd2054c48a040b4e3a09bc46913cb6422fa Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>
show more ...
|
#
ee853eb2 |
| 28-May-2020 |
AppaRao Puli <apparao.puli@linux.intel.com> |
update to latest clang-format-10
Update the .clang-format and run the latest clang-format-10 on existing source.
Tested: It builds fine locally.
Signed-off-by: AppaRao Puli <apparao.puli@linux.int
update to latest clang-format-10
Update the .clang-format and run the latest clang-format-10 on existing source.
Tested: It builds fine locally.
Signed-off-by: AppaRao Puli <apparao.puli@linux.intel.com> Change-Id: I903b94b8334af2b50ec2c9b929c1e028901df20e
show more ...
|
#
33816cf9 |
| 14-Jun-2019 |
Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com> |
srvcfg-mgr: Use poll method to trigger init
Latest up-stream sync causes issue, due to which unable to receive StartupFinished signal from systemd1. Hence triggering the poll method too, so service
srvcfg-mgr: Use poll method to trigger init
Latest up-stream sync causes issue, due to which unable to receive StartupFinished signal from systemd1. Hence triggering the poll method too, so service will be able to init, once all units are loaded by systemd1
Tested: 1. Verified objects are exposed during boot-up and working as expected
Change-Id: I0757faf50f8d8915d4641d1dbd6e13f85420a913 Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>
show more ...
|
#
90f2da3f |
| 22-May-2019 |
Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com> |
srvcfg: Updated for dynamic service/socket mgmt
Fixed srvcfg crash manager issue, by doing the service & socket unit file queries dynamically and exposing the objects to be controlled. This takes ca
srvcfg: Updated for dynamic service/socket mgmt
Fixed srvcfg crash manager issue, by doing the service & socket unit file queries dynamically and exposing the objects to be controlled. This takes care of instanced service & socket files like phosphor-ipmi-net@eth0 or phosphor-ipmi-net@eth1 dynamically.
Tested: 1. Verified as per the base service name, all the instanced service & socket names are dynamically queried and exposed 2. Made sure to list the disabled services thorugh this method 3. Made sure new services listed after fw-update are also exposed as objects 4. Verfied phosphor-ipmi-net@eth0 port change using ipmitool -p <newport> option 5. Verified permanent disable of the unit. 6. Verified run time enable / disable of the service. 7. Verified phosphor-ipmi-kcs service permanent & run time enable / disable
Change-Id: Ib933a2fbff73eae4348a5940d350ae7972db03fb Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>
show more ...
|
#
e55cfd6e |
| 15-Feb-2019 |
AppaRao Puli <apparao.puli@linux.intel.com> |
srvcfg-manager State change issue fix.
srvcfg-manager State change is not working as it need to act on both .service and .socket files. Also used MaskUnitFiles and UnmaskUnitFiles to make changes pe
srvcfg-manager State change issue fix.
srvcfg-manager State change is not working as it need to act on both .service and .socket files. Also used MaskUnitFiles and UnmaskUnitFiles to make changes persistent.
Tested By: Disabled/Enabled the state and checked the service is stopping/starting properly. Also rebooted system and checked persistent behaviour. Checked changing port/channel and validated functionality.
Change-Id: Ib0dce95db3926f5d700fb729aae7bdac1caf64e4 Signed-off-by: AppaRao Puli <apparao.puli@linux.intel.com>
show more ...
|
#
0084047d |
| 03-Oct-2018 |
AppaRao Puli <apparao.puli@linux.intel.com> |
Config service manager implementation.
Added new service for managing the service(RMCP+, ssh, web) properties like state, port, channel etc. This is common service supports both systemctl and iptabl
Config service manager implementation.
Added new service for managing the service(RMCP+, ssh, web) properties like state, port, channel etc. This is common service supports both systemctl and iptables.
Example usage: Blocking specific service port and restricting network traffic on specific channels etc.
Unit Test: - Changed port of RMCP+ service and validated. - Restricted network traffic on specific channel(eth0) and cross validated functionality.
Change-Id: I835a4723bc5d5a65efb6ec329f74f3932e841522 Signed-off-by: AppaRao Puli <apparao.puli@linux.intel.com>
show more ...
|