clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I6c62f244ae77c511ecbb62b72964154f465fb590
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I89c45445ea256569100d5fcb2a442a1b29de939e
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I84a952aae0e96b2960d8622659902df660d5ddb8
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

utility/sdbus: Add bus processing workaround

Provide a wrapper for others to use that works around a memory leak that
we have with processing dbus matches in an event loop.

Change-Id: I944e9c254784

utility/sdbus: Add bus processing workaround

Provide a wrapper for others to use that works around a memory leak that
we have with processing dbus matches in an event loop.

Change-Id: I944e9c2547844b507216e334bd013f26b8a547da
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

meson: Update minimum version to 0.57.0

Required for c++20 suppport.

Change-Id: I3d34c7ebecbb9b7a1f1f8fe43f7b36f8d1581979
Signed-off-by: William A. Kennington III <wak@google.com>

build: rename dependency variable

Per [1], the naming convention for dependencies is '<project_name>_dep',
for consistency when importing the project as a meson subproject.
Rename the variable here

build: rename dependency variable

Per [1], the naming convention for dependencies is '<project_name>_dep',
for consistency when importing the project as a meson subproject.
Rename the variable here to match this convention.

Based on [2] there appears to not be any current users of this as a
subproject which would need to be updated.

1. https://mesonbuild.com/Subprojects.html#naming-convention-for-dependency-variables
2. https://github.com/search?q=org%3Aopenbmc+get_variable&type=code

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I66082b3f667e9d00ede02184d0b008d0dd22d36b

show more ...

internal/utils: Remove performCallback

This logic doesn't need to be maintained separately from the sdevent
source.

Change-Id: I1290a13953c71db06d5a8fd6ed630a690958a4a4
Signed-off-by: William A. Ke

internal/utils: Remove performCallback

This logic doesn't need to be maintained separately from the sdevent
source.

Change-Id: I1290a13953c71db06d5a8fd6ed630a690958a4a4
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

performCallback: Don't return errors

Just because a callback throws an error doesn't mean that we want it to
stop source processing.

Change-Id: Ifcd5f61b3423033f720b1e683b56aa49570e6581
Signed-off-

performCallback: Don't return errors

Just because a callback throws an error doesn't mean that we want it to
stop source processing.

Change-Id: Ifcd5f61b3423033f720b1e683b56aa49570e6581
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

subprojects: Update to HEAD

Change-Id: Idbc173920abc588d35be56fa7cd3171cac6673cf
Signed-off-by: William A. Kennington III <wak@google.com>

utility/timer: Implement heap based userdata

Change-Id: I38b127e4fb147f207f32ff44a9f8d82ee7866ba9
Signed-off-by: William A. Kennington III <wak@google.com>

source/base: Support floating sources

This allows the source to stay attached to the event loop even if all of
the source handles are unreferenced.

Change-Id: I81e97674869ceba3e71479efa6ce38a67c0ba

source/base: Support floating sources

This allows the source to stay attached to the event loop even if all of
the source handles are unreferenced.

Change-Id: I81e97674869ceba3e71479efa6ce38a67c0ba5c7
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

source/*: Allow copies to be made

Sources are now just reference holders so we can copy them freely.

Change-Id: I263219de83341473c333a29cf651ae82428a208a
Signed-off-by: William A. Kennington III <w

source/*: Allow copies to be made

Sources are now just reference holders so we can copy them freely.

Change-Id: I263219de83341473c333a29cf651ae82428a208a
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

source/*: Implement heap based userdata

This makes no immediate change to the external interface, but it will
enable us to do things like making copies of the event sources and
support for floating

source/*: Implement heap based userdata

This makes no immediate change to the external interface, but it will
enable us to do things like making copies of the event sources and
support for floating event source types.

Change-Id: Ida73e773eb0869f6f6f21c1e03c61e9ce2b5625c
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

event: Add non-owning constructor

This allows internal store event objects without having to contain
circular references. A circular reference in an event source will cause
the event loop from ever

event: Add non-owning constructor

This allows internal store event objects without having to contain
circular references. A circular reference in an event source will cause
the event loop from ever cleaning up correctly.

Change-Id: I23fe0c95093953071216cf1deeb17e79defb7ffb
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

test: Allow optional usage of vendored googletest

Change-Id: I7011edb826b11762f1eb49e8bbc3a19c8006f8c5
Signed-off-by: William A. Kennington III <wak@google.com>

autotools: Remove

Meson is now used to build this package in all of the necessary places.

Change-Id: Ic5155621967fa94ec03eced2193e0d453b174eba
Signed-off-by: William A. Kennington III <wak@google.c

autotools: Remove

Meson is now used to build this package in all of the necessary places.

Change-Id: Ic5155621967fa94ec03eced2193e0d453b174eba
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

meson: Use declare_dependency for libraries

Now example binaries and tests don't have to be aware of the nuances for
configuring the build to use the library. This makes the project library
look lik

meson: Use declare_dependency for libraries

Now example binaries and tests don't have to be aware of the nuances for
configuring the build to use the library. This makes the project library
look like any other system dependency.

Change-Id: Ife3bcd3dcbd423f08c513f9a05fc8cabff41e2f6
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

internal/utils: performCallback should preserve argument references

Arguments including the function are now passed with reference types
forwarded.

Change-Id: I32cf4704737faa6c140d16352528ceb0d738f

internal/utils: performCallback should preserve argument references

Arguments including the function are now passed with reference types
forwarded.

Change-Id: I32cf4704737faa6c140d16352528ceb0d738f5b8
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

source/base: Remove unused ref constructor

We don't ever use this constructor and it was effectively package
private. Remove it as we don't ever need to add references to our
sd_event_source*.

Test

source/base: Remove unused ref constructor

We don't ever use this constructor and it was effectively package
private. Remove it as we don't ever need to add references to our
sd_event_source*.

Tested:
Built and run through unit test suite.

Change-Id: I1ca9fd4ecfdef1a3fd5aa2ca214be657c1a04b94
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

internal/sdref: Remove in favor of stdplus/handle

We no longer need to roll our own managed handle type now that stdplus
implements a generic one.

Tested:
Built and run through unit tests.

Cha

internal/sdref: Remove in favor of stdplus/handle

We no longer need to roll our own managed handle type now that stdplus
implements a generic one.

Tested:
Built and run through unit tests.

Change-Id: Id34cd8d3ffacf7901d49cac335fa93f744f0e310
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

autotools: Fix for autoconf-archive 2019.01.19

The code coverage macros from the archive changed in a backward
incompatible way. This adds a workaround to autodetect either version
and do the right

autotools: Fix for autoconf-archive 2019.01.19

The code coverage macros from the archive changed in a backward
incompatible way. This adds a workaround to autodetect either version
and do the right thing

Change-Id: Ic010ed59fb332e19e5c76f60e55f864f8f4a43f8
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

clang-tidy: Basic configuration

This also cleans up some outstanding issues detected by the
configuration.

Tested:
Ran through unit test scripts.

Change-Id: I3357a2280a681a87532d6d72315260db2a

clang-tidy: Basic configuration

This also cleans up some outstanding issues detected by the
configuration.

Tested:
Ran through unit test scripts.

Change-Id: I3357a2280a681a87532d6d72315260db2ab73e87
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

meson: Add alternative build system

For now both autotools and meson will be maintained side by side.
Eventually we should remove the autotools build system.

Change-Id: I04382b17d5267ee218e2658fc16

meson: Add alternative build system

For now both autotools and meson will be maintained side by side.
Eventually we should remove the autotools build system.

Change-Id: I04382b17d5267ee218e2658fc163da17853f637a
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

utility/timer: Implement callback setting

All of the other classes that take callbacks support having the callback
updated.

Tested:
Builds and passed through the unit test suite.

Change-Id: I0

utility/timer: Implement callback setting

All of the other classes that take callbacks support having the callback
updated.

Tested:
Builds and passed through the unit test suite.

Change-Id: I0efcd074523fa6ec0cc84c7a930346dd9340f7ec
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

utility/timer: Make movable

Now that we can update the callbacks of our sources, we can move the
timer object freely by updating the callback when moved.

Tested:
Unit tests pass, and we no long

utility/timer: Make movable

Now that we can update the callbacks of our sources, we can move the
timer object freely by updating the callback when moved.

Tested:
Unit tests pass, and we no longer see any valgrind issues when
moving the timer object.

Change-Id: I15baf97538459ca8b9c48b75dba77d09b7b5075b
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...