object_path: fix potential buffer overrun

The `filename` function attempted to look at the first character
of a substring, which could have been empty. This was noticed by
UBSAN in GCC 13.2.

Signe

object_path: fix potential buffer overrun

The `filename` function attempted to look at the first character
of a substring, which could have been empty. This was noticed by
UBSAN in GCC 13.2.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I7397861b6b19ef86d1c5c01dc1007a8804d08ab6

show more ...

Silence sign-conversion warning

In this case, we're loading an int into a char. Given that we're
building a hex string, this is intended, and can never overflow, but
this conversion causes a warnin

Silence sign-conversion warning

In this case, we're loading an int into a char. Given that we're
building a hex string, this is intended, and can never overflow, but
this conversion causes a warning about implicit conversions.

Make the conversion explicit by wrapping in a static_cast.

Change-Id: I4c103afcaad2943f339413e1ecdd934677805dad
Signed-off-by: Ed Tanous <edtanous@google.com>

show more ...

native_types: Use int8_t instead of char

Technically a char is signed, but the compiler warns about using -1 char
values. int8_t is the intended type here.

Change-Id: I888aef3bf

native_types: Use int8_t instead of char

Technically a char is signed, but the compiler warns about using -1 char
values. int8_t is the intended type here.

Change-Id: I888aef3bff9b585beed7d0ebc0e75f01f0e7558b
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

message/native_types: Constexpr fix in c++17 mode

If we don't initialize the array at declaration time, we can't consider
the function constexpr as the values could be non-deterministic.

message/native_types: Constexpr fix in c++17 mode

If we don't initialize the array at declaration time, we can't consider
the function constexpr as the values could be non-deterministic.

Change-Id: I3ba476cf58b86c44ad2e2216b74da09229e3d0c4
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

native_types: string_path_wrapper: Don't escape all strings

Not all strings require escaping when appending them to a path. This
allows us to now append `openbmc_project` to `/xyz` and h

native_types: string_path_wrapper: Don't escape all strings

Not all strings require escaping when appending them to a path. This
allows us to now append `openbmc_project` to `/xyz` and have
expected behavior.

Change-Id: I49a2ee100455cff4067dcf3df61f3e145231eeba
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

native_types: Reduce append allocation

This builds the string from left to right, instead of dealing with
string inserts, optimizing for allocations. Uses our own hex encoder
instead

native_types: Reduce append allocation

This builds the string from left to right, instead of dealing with
string inserts, optimizing for allocations. Uses our own hex encoder
instead of relying on systemd libraries. This maintains explicit
compatability with the systemd encoding scheme.

Change-Id: Ia6c2f4fb19984f549c6bac2d67d0b5d610022038
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

native_types: Migrate large functions to shared lib

This speeds up compilation of changes and should save space in users of
the functions.

Change-Id: Iee9029800c11dcd4e94f165766

native_types: Migrate large functions to shared lib

This speeds up compilation of changes and should save space in users of
the functions.

Change-Id: Iee9029800c11dcd4e94f165766836bae327ee9b5
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...