Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: Iab32afe9e86f7f4c18984ad2c7717d7cbfd422bb
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

docs: propose D-Bus paths and service-name format for interface yaml

This patch proposes format for adding D-Bus paths and service-name to
yaml interface files. The intent of this addition is to fac

docs: propose D-Bus paths and service-name format for interface yaml

This patch proposes format for adding D-Bus paths and service-name to
yaml interface files. The intent of this addition is to facilitate
const auto-generation for paths and service-names so they can be used
by D-Bus interface developers rather than using static strings at
multiple places which makes code browsing & maintainability a
challenge.

Change-Id: I09fbc4d9745b2101136a815a8c9d1790047121db
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

sdbus++: error: move error to front of namespace

To be consistent with the new 'server' and 'client' namespaces,
refactor the 'error' namespace in the same way. Move 'error' to
the front and use sn

sdbus++: error: move error to front of namespace

To be consistent with the new 'server' and 'client' namespaces,
refactor the 'error' namespace in the same way. Move 'error' to
the front and use snake_case for namespace and struct identifiers.
Leave the same backwards compatibility, which can be disabled with
the SDBUSPP_REMOVE_DEPRECATED_NAMESPACE guard.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I1a147a153798c84eaac3f6bf9581c6ca31ecaf4f

show more ...

prettierrc: update config

Copy org-wide config from openbmc-build-scripts and reformat
accordingly.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie142989f03f7d702b48f33bbf1c50b3b2

prettierrc: update config

Copy org-wide config from openbmc-build-scripts and reformat
accordingly.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie142989f03f7d702b48f33bbf1c50b3b2f1f47c4

show more ...

Clean up ASIO set-property callback code

This reverts commit ce62764d6c0a72ec88eb433e1afd05b751225971, which
introduced inconsistent semantics for the underlying ASIO set handler
functions. The "ext

Clean up ASIO set-property callback code

This reverts commit ce62764d6c0a72ec88eb433e1afd05b751225971, which
introduced inconsistent semantics for the underlying ASIO set handler
functions. The "external" `call` case expected the handler to return an
integer error code, while the "internal" `set` case expected the handler
to return a boolean status.

This also does a small refactor on the two similar `call` and `set`
functions to deduplicate, and adds ASIO.md to document the expected
semantics of the ASIO handlers.

The vast majority of user code in OpenBMC is still returning integers
from the callbacks (0/1/-1), but in most cases 0 was used to mean
failure, and 1 was used to mean success, so formalizing that the
callback should return a boolean value will not break things.

Tested: With accompanying dbus-sensors change
I05c41318954d5d1549752c5ef2c227f3f22a45d3, using steps in that commit
msg.

Signed-off-by: Jonathan Doman <jonathan.doman@intel.com>
Change-Id: Ic3a36027fa95a77469439b296a1497634cfe030f

show more ...

docs: move yaml documentation to a subdir

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I6ee7c15e1d7c65a11f27c5a8d3b64675ec03e69c

markdownlint: minor changes for new version

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9bf316f2e1008af13e5cce4edcdd2db6fcdc9ef2

doc: format with markdownlint

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I53c76c240a893ede5314839e70fe82b93325d59a

sdbus++: add errno property to errors

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9de8211cd503503dd11a404cf3ffe0fd1c8399c6

sdbus++: add minint/maxint support for integer default values

Allow default values of minint and maxint for integer types using the
`std::numeric_limits::{min,max}`.

Tested:

Generated cpp files wi

sdbus++: add minint/maxint support for integer default values

Allow default values of minint and maxint for integer types using the
`std::numeric_limits::{min,max}`.

Tested:

Generated cpp files with
```
./tools/sdbus++-gen-meson --command cpp --tool "./tools/sdbus++" \
--directory "." --output "." test
```

test.interface.yaml
```
properties:
- name: test0
type: uint64
default: minint
- name: test1
type: uint64
default: maxint
- name: test2
type: uint64

```

Snippet of server.hpp
```
uint64_t _test0 = 0;
uint64_t _test1 = std::numeric_limits<uint64_t>::max();
uint64_t _test2{};
```

Change-Id: I38ae3be783211ca0c4e6af9c1e20816579276c9e
Signed-off-by: Willy Tu <wltu@google.com>
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

sdbus++: support special double values

Enable properties to have default values of special IEEE floating
points: 'NaN', 'infinity' and 'epsilon'.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

sdbus++: support special double values

Enable properties to have default values of special IEEE floating
points: 'NaN', 'infinity' and 'epsilon'.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I7c2daa3c36cde69c2ee06afd75a8d2e77992c6e7

show more ...

sdbus++: add size_t / ssize_t types to YAML

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I4bbbf273e588bdc560c27fc6e208530c19c30f4b

sdbus++: support 'readonly' flag

The previous documentation of 'const' did not match the
specification at a D-Bus level nor the implementation in sdbus++.
Correct the documentation for 'const' and a

sdbus++: support 'readonly' flag

The previous documentation of 'const' did not match the
specification at a D-Bus level nor the implementation in sdbus++.
Correct the documentation for 'const' and add a new 'readonly' flag
which enables the previously documented behavior for 'const.

This was reported by a user outside of the openbmc project which had
already been using the 'readonly' flag in their YAML to identify this
condition. Previously, sdbus++ silently ignored flags it didn't
explicitly support but as of 20255a5fce55a0743dc3d307d1168f18ed553751
this turned into an error.

There are cases of interfaces in 'phosphor-dbus-interfaces' currently
using 'const' where they likely desire a 'readonly' instead. We are
not changing the behavior of 'const' with this commit, so there would
be no regressions induced by this code change.

Resolves openbmc/sdbusplus#48.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I690cb424f5fd00da190343a345ae57ccae393041

show more ...

sdbus++: add support for 'set'

Add 'set' as a supported type to `sdbus++` and set as `std::set`.
The use of ordered-set is to match 'dict' as `std::map` and because
'struct' is `std::tuple`, which h

sdbus++: add support for 'set'

Add 'set' as a supported type to `sdbus++` and set as `std::set`.
The use of ordered-set is to match 'dict' as `std::map` and because
'struct' is `std::tuple`, which has `operator<=>` but not `std::hash`.
This ensures better compatiblilty with possible property type choices
by users.

Also, add a few test cases to ensure `std::set` and `std::unordered_set`
are well-covered.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I59605db1b22d54f783d807eda1e1ec1f9eb6792f

show more ...

Add support for vtable flags for properties

This adds support for specifying the vtable flags
`SD_BUS_VTABLE_DEPRECATED`, `SD_BUS_VTABLE_HIDDEN`,
`SD_BUS_VTABLE_UNPRIVILEGED`, `SD_BUS_VTABLE_PROPERT

Add support for vtable flags for properties

This adds support for specifying the vtable flags
`SD_BUS_VTABLE_DEPRECATED`, `SD_BUS_VTABLE_HIDDEN`,
`SD_BUS_VTABLE_UNPRIVILEGED`, `SD_BUS_VTABLE_PROPERTY_CONST`,
`SD_BUS_VTABLE_PROPERTY_EMITS_CHANGE`,
`SD_BUS_VTABLE_PROPERTY_EMITS_INVALIDATION` and
`SD_BUS_VTABLE_PROPERTY_EXPLICIT` for properties. The list of flags in
the YAML files will be ORed together. If no flags have been specified,
we add SD_BUS_VTABLE_PROPERTY_EMITS_CHANGE by default (as before, just
too preserve the behavior; even though one would maybe like to specify
this explicitly).

Change-Id: Ib752cae6e74b2265c75e68707e2520f88f3181e8
Signed-off-by: Waqar Hameed <waqarh@axis.com>

show more ...

Add support for vtable flags for methods

This adds support for specifying the vtable flags
SD_BUS_VTABLE_DEPRECATED, SD_BUS_VTABLE_HIDDEN,
SD_BUS_VTABLE_UNPRIVILEGED and SD_BUS_VTABLE_METHOD_NO_REPL

Add support for vtable flags for methods

This adds support for specifying the vtable flags
SD_BUS_VTABLE_DEPRECATED, SD_BUS_VTABLE_HIDDEN,
SD_BUS_VTABLE_UNPRIVILEGED and SD_BUS_VTABLE_METHOD_NO_REPLY for
methods. The list of flags in the YAML file will be ORed together.

Change-Id: I7762ffb15a1483760f3b7e0ea02e80fd52ebd9b9
Signed-off-by: Waqar Hameed <waqarh@axis.com>

show more ...

Add support for Unix file descriptors

Change-Id: I2d1402c38b7b8b39cee42f959a0421b24a80e45d
Signed-off-by: Waqar Hameed <waqarh@axis.com>

property: Add support for const (read-only) values

There is already support for setting a property as const
(see vtable.hpp and corresponding test cases).
Implement this in the generated code by add

property: Add support for const (read-only) values

There is already support for setting a property as const
(see vtable.hpp and corresponding test cases).
Implement this in the generated code by adding support
for a new yaml flag.

Closes openbmc/openbmc#2028

Tested: Added the const flag to the Software Priority property,
and changing the value via REST and busctl would fail with
"org.freedesktop.DBus.Error.PropertyReadOnly", but the code
update app was able to set its value.

Change-Id: I8534753233080366503fd4f1a0c224c2946e8764
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

property: Add errors support

Add errors support for properties.

Closes openbmc/openbmc#1641

Tested: Verified that when an interface threw a defined property
error, the generated code caught it and

property: Add errors support

Add errors support for properties.

Closes openbmc/openbmc#1641

Tested: Verified that when an interface threw a defined property
error, the generated code caught it and returned an error to
the REST call.

Change-Id: I8cb8c77995026f12e373291822e4e0a623a84d81
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

docs: document interface and error YAMLs

Resolves openbmc/openbmc#477.

Change-Id: I07392ae4712206753399b58650e4658ef769e558
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>