Updated Storage Inventory Interface in hsbp-manager

Storage inventory interface in redfish code and hsbp manager
is mismatched. So updated the Storage Inventory interface from
"inventory.item.storag

Updated Storage Inventory Interface in hsbp-manager

Storage inventory interface in redfish code and hsbp manager
is mismatched. So updated the Storage Inventory interface from
"inventory.item.storage" to "Inventory.Item.Storage"

Change-Id: I4fe01b7a674fbac42ed4925aba12e0358d8d2289
Signed-off-by: PavanKumarIntel <pavanx.kumar.martha@intel.com>

show more ...

Add storage inventory support for hsbp-manager

Added storage inventory support for hsbp manager
Recently there is a upstream code changes done for
multiple storage support in bmcweb. So Added the st

Add storage inventory support for hsbp-manager

Added storage inventory support for hsbp manager
Recently there is a upstream code changes done for
multiple storage support in bmcweb. So Added the storage
inventory interface as
/xyz/openbmc_project/inventory/item/storage/hsbp/1
in hsbp-manager.

get: https://{bmc_ip}/redfish/v1/Systems/system/Storage

{
"@odata.id": "/redfish/v1/Systems/system/Storage",
"@odata.type": "#StorageCollection.StorageCollection",
"Members": [
{
"@odata.id": "/redfish/v1/Systems/system/Storage/1"
}
],
"Members@odata.count": 1,
"Name": "Storage Collection"
}

get: https://{bmc_ip}/redfish/v1/Systems/system/Storage/1

{
"@odata.id": "/redfish/v1/Systems/system/Storage/1",
"@odata.type": "#Storage.v1_13_0.Storage",
"Controllers": {
"@odata.id": "/redfish/v1/Systems/system/Storage/1/
Controllers"
},
"Drives": [
{
"@odata.id": "/redfish/v1/Systems/system/Storage/1
/Drives/Drive_1"
},
{
"@odata.id": "/redfish/v1/Systems/system/Storage/1
/Drives/Drive_2"
}
],
"Drives@odata.count": 2,
"Id": "1",
"Name": "Storage",
"Status": {
"Health": "OK",
"HealthRollup": "OK",
"State": "Enabled"
}
}


Redfish Validator: passed

Change-Id: I086ef93952767e8b676ab6fb1dba244ac416d032
Signed-off-by: Dileep Kumar Choppa <dileepx.kumar.choppa@intel.com>

show more ...

Update to the latest sdbusplus

The CI build is failing during linking with sdbusplus, so update to the
latest to fix it.

Change-Id: I876c157e6dd48d205543d6a828d1159835525303
Signed-off-by: Jason M.

Update to the latest sdbusplus

The CI build is failing during linking with sdbusplus, so update to the
latest to fix it.

Change-Id: I876c157e6dd48d205543d6a828d1159835525303
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>

show more ...

Revert "Temporarily disable -fno-rtti to fix the build"

This reverts commit a83c827da232740c33d3b51fdcc3d70a484d4f55.

The build is working again, so add -fno-rtti back in.

Change-Id: I3e8fff45860b

Revert "Temporarily disable -fno-rtti to fix the build"

This reverts commit a83c827da232740c33d3b51fdcc3d70a484d4f55.

The build is working again, so add -fno-rtti back in.

Change-Id: I3e8fff45860ba6c56eb5c808e7ab77bd0f520547
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>

show more ...

Use variable for service install location

After enabling 'usrmerge', the install location for systemd service
files changed. This uses a variable to get the installation location
instead of hardcodi

Use variable for service install location

After enabling 'usrmerge', the install location for systemd service
files changed. This uses a variable to get the installation location
instead of hardcoding it.

Tested:
Confirmed that with 'usrmerge' enabled, the service file is correctly
installed.

Change-Id: Ia7e3ef57cbbd89cd259472f48baab2ec1b661fd1
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>

show more ...

Remove Hunter

Hunter is causing pkgconfig to fail to find systemd. Since it looks like
we don't use GTest right now, anyway, let's just remove Hunter.

Change-Id: Ifb801998591c23bd6d808decf8c817e6e6

Remove Hunter

Hunter is causing pkgconfig to fail to find systemd. Since it looks like
we don't use GTest right now, anyway, let's just remove Hunter.

Change-Id: Ifb801998591c23bd6d808decf8c817e6e698bbdc
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>

show more ...

Avoid writing same data to IoExpander and ClockBuffer

During initialization hsbp-manager sets zero at bit position of clock buffer register and IO output register that has a NVMe drive in it.

Code

Avoid writing same data to IoExpander and ClockBuffer

During initialization hsbp-manager sets zero at bit position of clock buffer register and IO output register that has a NVMe drive in it.

Code changes are made to make sure that if the bit positions are
already set to zero, we can avoid the write to clock buffer register
and IO output register.

Tested:
- Made sure the working of hsbp manager is not affected.
- Made sure that write to clock buffer register and IO output register
does not happen if we restart hsbp manager service, as bits are
already set to zeros.

Change-Id: Iaa08be8eba93ecc51ef70cc4bd9fb371de6474a1
Signed-off-by: Arun Lal K M <arun.lal@intel.com>

show more ...

remove dbus interfaces on Backplane destruction

activationIface(dbus_interface) attribute of Backplane(struct) was not
getting removed from dbus on destruction of Backplane object. Later as
Backplan

remove dbus interfaces on Backplane destruction

activationIface(dbus_interface) attribute of Backplane(struct) was not
getting removed from dbus on destruction of Backplane object. Later as
Backplane object gets reconstructed for same Backplane add_interface API
throws exception since interface is still there.
Remove activation dbus_interface on destruction of Backplane object.

Led associated with a Backplane were not getting destructed on
destruction of Backplane object. This was because Led is created as
shared_ptr and Led object itself keeps one reference causing use_count
to never go to zero.
Use weak reference in Led object. This causes Led object destructor to
get called on destruction of Backplane.

Change-Id: I3499b3617810ca39c99ecd1a8de7f56c93a2a586
Signed-off-by: Vikash Chandola <vikash.chandola@intel.com>

show more ...

Add missing include

list was included through a dependency on sdbusplus which no longer
provides it, so it needs to be explicitly included here.

Change-Id: Ia39a1cd6b41c1837503ea9c0a8d272739589235f

Add missing include

list was included through a dependency on sdbusplus which no longer
provides it, so it needs to be explicitly included here.

Change-Id: Ia39a1cd6b41c1837503ea9c0a8d272739589235f
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>

show more ...

Revamp HSBP clock enabling code flow

This commit enhances the existing HSBP clock enabling logic
by eliminating most of the hardcoded register addresses, mapping
tables etc. The revamped code pulls

Revamp HSBP clock enabling code flow

This commit enhances the existing HSBP clock enabling logic
by eliminating most of the hardcoded register addresses, mapping
tables etc. The revamped code pulls all the configuration from the
Dbus object exposed by entity-manager, i.e. all the required hardware
information is moved into a configuration file, thereby reducing
hardcoding of values. This approch also makes it flexible to add
any number/type of clock buffers and also have flexibility in
mapping the drives (i.e. in case the hardware maps the HSBP drives
differently, only a configuratioon change is all that is needed
without having to touch the code).
Below is a template of configuration that needs to be appended
into the baseboard configuration file:
{
"RootI2cBus": 4,
"HsbpSupported": [
"HSBP_1",
"HSBP_2",
"HSBP_3"
],
"HSBP_1": [
"CPU0_NVME1",
"CPU0_NVME2",
"CPU0_NVME3",
"CPU0_NVME4",
"CPU0_NVME5",
"CPU0_NVME6",
"CPU0_NVME7",
"CPU0_NVME8"
],
"HSBP_2": [
"CPU1_NVME1",
"CPU1_NVME2",
"CPU1_NVME3",
"CPU1_NVME4",
"CPU1_NVME5",
"CPU1_NVME6",
"CPU1_NVME7",
"CPU1_NVME8"
],
"HSBP_3": [
"-",
"-",
"-",
"-",
"-",
"-",
"-",
"-"
],
"ClockBuffer": [
"abcd"
],
"IoExpander": [
"efgh"
],
"Name": "HSBP Config",
"Type": "HSBPConfiguration"
},
{
"Address": "0x12",
"Bus": 4,
"Mode": "SMBus",
"OutCtrlBaseAddr": "0x81",
"OutCtrlByteCount": 2,
"Byte0": [
"CPU0_NVME5",
"CPU0_NVME2",
"CPU0_NVME8",
"CPU0_NVME4",
"CPU0_NVME1",
"CPU0_NVME6",
"CPU0_NVME7",
"CPU0_NVME3"
],
"Byte1": [
"-",
"-",
"-",
"-",
"-",
"-",
"-",
"-"
],
"Name": "CPU0 Clock Buffer",
"Type": "abcd"
},
{
"Address": "0x34",
"Bus": 4,
"Mode": "IO",
"OutCtrlBaseAddr": "0x81",
"OutCtrlByteCount": 2,
"Byte0": [
"CPU1_NVME1",
"CPU1_NVME2",
"CPU1_NVME3",
"CPU1_NVME4",
"CPU1_NVME5",
"CPU1_NVME6",
"CPU1_NVME7",
"CPU1_NVME8"
],
"Byte1": [
"-",
"-",
"-",
"-",
"-",
"-",
"-",
"-"
],
"Name": "CPU1 Clock Buffer",
"Type": "abcd"
},
{
"Address": "0x56",
"Bus": 4,
"ConfIORegAddr": "0x06",
"OutCtrlBaseAddr": "0x02",
"OutCtrlByteCount": 2,
"IO0": [
"CPU1_NVME1",
"CPU1_NVME2",
"CPU1_NVME3",
"CPU1_NVME4",
"CPU1_NVME5",
"CPU1_NVME6",
"CPU1_NVME7",
"CPU1_NVME8"
],
"IO1": [
"-",
"-",
"-",
"-",
"-",
"-",
"-",
"-"
],
"Name": "IO Expander",
"Type": "efgh"
}

TESTED:
- On BMC boot, the connected HSBP drives were detected and
respective clock was enabled
- Hot Swapped couple of drives and confirmed the respective
clocks being enabled (The clocks were disabled for the Drives
which were removed)
- Verified by i2cdump of clock buffer(s) and checking respective
registers

Change-Id: Ice2b3b4f9d16df6d572ab34c8ea0cfddf657554c
Signed-off-by: P Dheeraj Srujan Kumar <p.dheeraj.srujan.kumar@intel.com>

show more ...

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

Change-Id: Idc1ee4342f1fc6c671a8f0b14eac663a1e2e6ef6
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

cmake: update to C++20

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9060117746a8b13246656ff06baa091e98e09796

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Idf165747d0fd6079ba217992f2c46a388ce2d906

show more ...

sdbusplus: update ref

The external-project ref for sdbusplus is now 2 years old. Update
it to something more recent.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I49d66447c31601d

sdbusplus: update ref

The external-project ref for sdbusplus is now 2 years old. Update
it to something more recent.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I49d66447c31601d30ed9c0106f2b9c6732dd5a4b

show more ...

hsbp-manager: fix build against latest sdbusplus

sdbusplus headers changed and now we need to explicitly include the
match header.

Tested: Build succeeds.

Signed-off-by: Jonathan Doman <jonathan.d

hsbp-manager: fix build against latest sdbusplus

sdbusplus headers changed and now we need to explicitly include the
match header.

Tested: Build succeeds.

Signed-off-by: Jonathan Doman <jonathan.doman@intel.com>
Change-Id: I9cd2b12f251434351e5f4f0b92bdf771c6958827

show more ...

Fix to populate all HSBP inventory

Issue: if backplanes map cleared inside of the async_method_call,
system is not populating all HSBP inventory items in RedFish.

Fix: So moved backplanes.clear() t

Fix to populate all HSBP inventory

Issue: if backplanes map cleared inside of the async_method_call,
system is not populating all HSBP inventory items in RedFish.

Fix: So moved backplanes.clear() to outside of the async_method_call.
Now RedFish populating all the HSBP inventory items.

Tested:
Verified from Redfish, shown both HSBP inventory items.

Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: Idd8ca45b19e7d124a9cfbbe9bbbfb698fc289a6f

show more ...

Enable/Disable PCIe clocks on NVMe drive hot-add/remove

When the BMC detects the hot-add/hot-removal of an NVMe drive on HSBP,
the BMC shall enable/disable the clock to the NVMe drive on the
DB2000

Enable/Disable PCIe clocks on NVMe drive hot-add/remove

When the BMC detects the hot-add/hot-removal of an NVMe drive on HSBP,
the BMC shall enable/disable the clock to the NVMe drive on the
DB2000 clock buffer to reduce EMI.
In addition fix the issue of addition/removal events not getting
logged in System Event Log.

Tested:
1. DB2000 clock enabling/disabling on hot addition/removal of PCIe
drives tested with debug cpld image which emulates hot
addition/removal of drives. Addition/removal verified via ITP.
DB2000 clock enabling/disabling verified independently via
i2c-tools from BMC also.
2. SEL log entries on each hot-add/removal verified via redfish
Signed-off-by: Rohit Chandel <rohit.k.chandel@intel.com>
Change-Id: I5c6f8d6cf0b8fb737006b6ca14f2cfcd6a3de27d

show more ...

Fixing Boost library package download link

Boost library package download link seems broken. Updating it with
working link.

Signed-off-by: Rohit Chandel <rohit.k.chandel@intel.com>
Change-Id: I8d5f

Fixing Boost library package download link

Boost library package download link seems broken. Updating it with
working link.

Signed-off-by: Rohit Chandel <rohit.k.chandel@intel.com>
Change-Id: I8d5f90b87dbeb87e664ecec25a3c06137ec2bdad

show more ...

Temporarily disable -fno-rtti to fix the build

Hitting a build issue with -fno-rtti that appears to be caused
by a Boost bug:
See https://github.com/chriskohlhoff/asio/issues/533

Disabling it for n

Temporarily disable -fno-rtti to fix the build

Hitting a build issue with -fno-rtti that appears to be caused
by a Boost bug:
See https://github.com/chriskohlhoff/asio/issues/533

Disabling it for now.

Change-Id: I57ac7b35c20d9846713adcef4ce514ef40036063
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Remove asset when drive removed

This removes the asset interface when a drive is
removed so the old serial number and fru fields
don't show up in Redfish.

Tested: Had present flip to not present af

Remove asset when drive removed

This removes the asset interface when a drive is
removed so the old serial number and fru fields
don't show up in Redfish.

Tested: Had present flip to not present after
predfined period, when not present, no fru fields
in redfish

Change-Id: Iea90509bdca26758472105c55001abac951128d3
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Log insertion/removal of all Hard Disk Drives

Insertion and removal events were only being logged for NVMe
drives. The D-Bus event system could only be enabled for NVMe
drives. The D-Bus method allo

Log insertion/removal of all Hard Disk Drives

Insertion and removal events were only being logged for NVMe
drives. The D-Bus event system could only be enabled for NVMe
drives. The D-Bus method allowed the NVMe serial number to be added to
the insertion/removal event. SAS/SATA insertion/removal was not
detected. The only time SAS/SATA drives were detected was during HSPB
power on.

The changes here log the insertion and removal of all drives.

Tested:
Created an in code temporary test that toggled the Drive 1 Present bit
during every UpdateDrives call. This was done because physically
inserting/removing the drive is impractical.
Confirmed after each toggle there was a journal event for "Iventory
Added" and "Inventory Removed", and that the extended data included
the drive number.

Change-Id: I48ce1e0dc15cf8a42a498bf8dbe93a88ebd30a58
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>

show more ...

sdbusplus: use meson build

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie35abaf5a9773c4f92c18b7b1fa22dfb280d08a9

cmake: upgrade boost

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib8cc28a4d27f177e06d2f77a5a0109f6e61adaf9

Make hsbp-manager in charge of logging drive events

The logic was getting too complicated to get EM to log
all the drive adds and removes for some drives and not
others. This moves all the logging t

Make hsbp-manager in charge of logging drive events

The logic was getting too complicated to get EM to log
all the drive adds and removes for some drives and not
others. This moves all the logging to hsbp-manager.

This also changes the backplane object to use a
shared_ptr to make sure destruction happens correctly.

Tested: Tested using code branch that flips the bit,
sending to validation for more testing

Change-Id: I305d01374579b95dcfa16c21db0c9c70a98e8181
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Fix extra logs for NVMe drives

NVMe drives have FRUs. Because of this entity-manager
handles the add/remove messages. Make sure hsbp-manager
doesn't log for these, and that we rescan when they
chang

Fix extra logs for NVMe drives

NVMe drives have FRUs. Because of this entity-manager
handles the add/remove messages. Make sure hsbp-manager
doesn't log for these, and that we rescan when they
change.

Tested: Extra logs went away, got add / remove messages
when status changed

Change-Id: Ie9b6d980be9cb557f44da1ffaed79ecc867c2d98
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...