Declare originalFlags inside lambda function

This commit fix the compilation error in lambda function as
"originalFlags" variable not declare in capture clause

Change-Id: Ic1099430276ecff1c552a7848

Declare originalFlags inside lambda function

This commit fix the compilation error in lambda function as
"originalFlags" variable not declare in capture clause

Change-Id: Ic1099430276ecff1c552a78480f943bb41532463
Signed-off-by: PavanKumarIntel <pavanx.kumar.martha@intel.com>

show more ...

Fix the bugs found in static analysis

Not restoring ostream format:
cerr format not restoring to default, can lead to printing
values in incorrect format.

Change-Id: Ie529b9a8261f651c76d2fc

Fix the bugs found in static analysis

Not restoring ostream format:
cerr format not restoring to default, can lead to printing
values in incorrect format.

Change-Id: Ie529b9a8261f651c76d2fc232d89d4f711cb05b5
Signed-off-by: PavanKumarIntel <pavanx.kumar.martha@intel.com>

show more ...

Use variable for service install location

After enabling 'usrmerge', the install location for systemd service
files changed. This uses a variable to get the installation location
instead of hardcodi

Use variable for service install location

After enabling 'usrmerge', the install location for systemd service
files changed. This uses a variable to get the installation location
instead of hardcoding it.

Tested:
Confirmed that with 'usrmerge' enabled, the service file is correctly
installed.

Change-Id: Ia7e3ef57cbbd89cd259472f48baab2ec1b661fd1
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>

show more ...

Remove Hunter

Hunter is causing pkgconfig to fail to find systemd. Since it looks like
we don't use GTest right now, anyway, let's just remove Hunter.

Change-Id: Ifb801998591c23bd6d808decf8c817e6e6

Remove Hunter

Hunter is causing pkgconfig to fail to find systemd. Since it looks like
we don't use GTest right now, anyway, let's just remove Hunter.

Change-Id: Ifb801998591c23bd6d808decf8c817e6e698bbdc
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>

show more ...

Change io_service to io_context

This was renamed a while back in boost to be compliant with the
std::executors proposal.

Change-Id: Id97c83116ee47c49076476a331588035c3894418
Signed-off-by: Ed Tanou

Change io_service to io_context

This was renamed a while back in boost to be compliant with the
std::executors proposal.

Change-Id: Id97c83116ee47c49076476a331588035c3894418
Signed-off-by: Ed Tanous <edtanous@google.com>

show more ...

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

Change-Id: Idc1ee4342f1fc6c671a8f0b14eac663a1e2e6ef6
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

cmake: update to C++20

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9060117746a8b13246656ff06baa091e98e09796

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Idf165747d0fd6079ba217992f2c46a388ce2d906

show more ...

sdbusplus: update ref

The external-project ref for sdbusplus is now 2 years old. Update
it to something more recent.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I49d66447c31601d

sdbusplus: update ref

The external-project ref for sdbusplus is now 2 years old. Update
it to something more recent.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I49d66447c31601d30ed9c0106f2b9c6732dd5a4b

show more ...

Fix: LED state not changes for UpperCriticalthresh

Issue: LED state is in Blinking Green after setting the
'Upper Critical threshold'.

RootCause: A Typo in the event name used in source code

Fix: LED state not changes for UpperCriticalthresh

Issue: LED state is in Blinking Green after setting the
'Upper Critical threshold'.

RootCause: A Typo in the event name used in source code.

Fix:
After setting the Threshold value expected LED status should be
"blinking Amber "

Tested:

Initial LED state:
ipmitool raw 0x30 0xb0
20 --> Solid Green

1. Patch the 'Upper Critical threshold' value to 'Inlet_BRD_Temp'
PATCH : https://<bmcip>/redfish/v1/Chassis/<Baseboard>/Thermal
patch body:
{
"Temperatures":[
{
"MemberId":"Inlet_BRD_Temp",
"ReadingCelsius":120.0
}
]
}

Response :
{
"@odata.id": "/redfish/v1/Chassis/<Baseboard>/Thermal",
"@odata.type": "#Thermal.v1_4_0.Thermal",
"Fans": [],
"Id": "Thermal",
"Name": "Thermal",
"Temperatures": []
}

LED state changed
ipmitool raw 0x30 0xb0
04 --> Blinking Amber

Signed-off-by: sunitakx <sunitax.kumari@linux.intel.com>
Change-Id: I9941c35a4b66555f0147315e2405361e0795f6ac

show more ...

callback-manager: match thersholdAsserted signal for updateLedStatus

Issue: For ADC sensors, LED state did not change after de-assert.

Fix: Added a match for thresholdAsserted signal to capture the

callback-manager: match thersholdAsserted signal for updateLedStatus

Issue: For ADC sensors, LED state did not change after de-assert.

Fix: Added a match for thresholdAsserted signal to capture the de-assert
event for powerDelayed threshold sensors and update the LED state
accordingly.

Tested:

ipmitool sdr elist | grep P3VBAT
P3VBAT | 47h | ok | 0.1 | 3.14 Volts

Initial state:
ipmitool raw 0x4 0x27 0x47
1b 7b 6b 00 a4 a6 00

Initial LED state:
ipmitool raw 0x30 0xb0
20 --> Solid Green

Assert events:

1. Change the Lower Non-Critical threshold
ipmitool raw 0x04 0x26 0x47 0x1b 0xa1 0x6b 0x00 0xa4 0xa6 0x00

ipmitool raw 0x4 0x27 0x47
1b a1 6b 00 a4 a6 00

ipmitool raw 0x30 0xb0
10 --> Blinking Green.

2. Change the Lower critical threshold
ipmitool raw 0x04 0x26 0x47 0x1b 0xa1 0xa1 0x00 0xa4 0xa6 0x00

ipmitool raw 0x4 0x27 0x47
1b a1 a1 00 a4 a6 00

ipmitool raw 0x30 0xb0
04 --> Blinking Amber

De-assert events:

1. Restore Lower critical threshold.
ipmitool raw 0x04 0x26 0x47 0x1b 0xa1 0x6b 0x00 0xa4 0xa6 0x00

ipmitool raw 0x4 0x27 0x47
1b a1 6b 00 a4 a6 00

ipmitool raw 0x30 0xb0
10 --> Blinking Green

2. Restore Lower Non-Critical Threshold.
ipmitool raw 0x04 0x26 0x47 0x1b 0x7b 0x6b 0x00 0xa4 0xa6 0x00

ipmitool raw 0x4 0x27 0x47
1b 7b 6b 00 a4 a6 00

ipmitool raw 0x30 0xb0
20 --> Solid Green

ipmitool sel list
1 | Pre-Init |0000006680| Voltage #0x47 | Lower Non-critical going
low | Asserted
2 | Pre-Init |0000006944| Voltage #0x47 | Lower Critical going low
| Asserted
3 | Pre-Init |0000007218| Voltage #0x47 | Lower Critical going low
| Deasserted
4 | Pre-Init |0000007345| Voltage #0x47 | Lower Non-critical going
low | Deasserted

Signed-off-by: Chalapathi Venkataramashetty <chalapathix.venkataramashetty@intel.com>
Change-Id: I505871913bbbcfc7ba174d9243c736561818ee0f

show more ...

Fix for Update LED State in case of forceRefresh

Issue: RetriggerLEDUpdate does not revert system ready and fault led
xyz.openbmc_project.Led.Physical State to initial state in case of
forceRefr

Fix for Update LED State in case of forceRefresh

Issue: RetriggerLEDUpdate does not revert system ready and fault led
xyz.openbmc_project.Led.Physical State to initial state in case of
forceRefresh.

Tested:
LED State:
1. busctl call xyz.openbmc_project.LED.Controller.status_green
/xyz/openbmc_project/led/physical/status_green
org.freedesktop.DBus.Properties Get ss
xyz.openbmc_project.Led.Physical State

v s "xyz.openbmc_project.Led.Physical.Action.Blink"

busctl call xyz.openbmc_project.LED.Controller.status_amber
/xyz/openbmc_project/led/physical/status_amber
org.freedesktop.DBus.Properties Get ss
xyz.openbmc_project.Led.Physical State

v s "xyz.openbmc_project.Led.Physical.Action.Off"

2. Execute command in manufacturing mode:
ipmitool raw 0x30 0x15 0x0f 0x00 0x00
OR
ipmitool raw 0x30 0x15 0x01 0x00 0x01

3. busctl call xyz.openbmc_project.CallbackManager
/xyz/openbmc_project/CallbackManager
xyz.openbmc_project.CallbackManager RetriggerLEDUpdate

4. busctl call xyz.openbmc_project.LED.Controller.status_green
/xyz/openbmc_project/led/physical/status_green
org.freedesktop.DBus.Properties Get ss
xyz.openbmc_project.Led.Physical State

v s "xyz.openbmc_project.Led.Physical.Action.Blink"

busctl call xyz.openbmc_project.LED.Controller.status_amber
/xyz/openbmc_project/led/physical/status_amber
org.freedesktop.DBus.Properties Get ss
xyz.openbmc_project.Led.Physical State

v s "xyz.openbmc_project.Led.Physical.Action.Off"

Signed-off-by: sunitakx <sunitax.kumari@linux.intel.com>
Change-Id: I2f66fbddcd8fd0a9fc0825d44f8cd41c640d7882

show more ...

Add missing header files to prepare for upstream sync

Upstream removed some blanketed include. Add missing headers to
fix build issues when sync with upstream.

Signed-off-by: Zhikui Ren <zhikui.re

Add missing header files to prepare for upstream sync

Upstream removed some blanketed include. Add missing headers to
fix build issues when sync with upstream.

Signed-off-by: Zhikui Ren <zhikui.ren@intel.com>
Change-Id: I853eb529d678e90d12c7f75dd3218e97b34c6976

show more ...

Fix Associations

It was spelled wrong. Also, there is no need to compare
against the local object if it is globally critical, so
make the check easier.

Tested: Made a drive error and the led blinke

Fix Associations

It was spelled wrong. Also, there is no need to compare
against the local object if it is globally critical, so
make the check easier.

Tested: Made a drive error and the led blinked

Change-Id: I52590f0888380a6d7460e9220d814174cb17a52b
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

callback-manager: Update to the latest .clang-format

Change-Id: I2ce11f153739f3d07640c4755dfc64ff44fd328c
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

sdbusplus: use meson build

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie35abaf5a9773c4f92c18b7b1fa22dfb280d08a9

cmake: upgrade boost

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib8cc28a4d27f177e06d2f77a5a0109f6e61adaf9

Update callback manager to new association

Mapper no longer supports the old one.

Tested: Mapper shows associations again, available in
redfish

Change-Id: I876c7b9be4d24e3bc73e4b5ff0e9290e422baaa9

Update callback manager to new association

Mapper no longer supports the old one.

Tested: Mapper shows associations again, available in
redfish

Change-Id: I876c7b9be4d24e3bc73e4b5ff0e9290e422baaa9
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Add Association Monitoring support

Based on redfish design, there is global and non global
critical / warning to monitor health. Take these and
use them to trigger the led.

Tested: Created IPMI ME

Add Association Monitoring support

Based on redfish design, there is global and non global
critical / warning to monitor health. Take these and
use them to trigger the led.

Tested: Created IPMI ME health event and saw led turn
to blinking yellow

Change-Id: I0ddcd142355b148b6ae07b6d0e9274c3e99a049e
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

callback-manager: Add association manager

This adds an association manager based on Redfish health
whitepaper to do a rollup of subcomponent health.

https://gerrit.openbmc-project.xyz/c/openbmc/doc

callback-manager: Add association manager

This adds an association manager based on Redfish health
whitepaper to do a rollup of subcomponent health.

https://gerrit.openbmc-project.xyz/c/openbmc/docs/+/21380

Tested:

Chassis health rollup works with upstream patch 21798

{
"@odata.context": "/redfish/v1/$metadata#Chassis.Chassis",
"@odata.id": "/redfish/v1/Chassis/WFP_Baseboard",
"@odata.type": "#Chassis.v1_4_0.Chassis",
"ChassisType": "RackMount",
"Id": "WFP_Baseboard",
"Links": {
"ComputerSystems": [
{
"@odata.id": "/redfish/v1/Systems/system"
}
],
"ManagedBy": [
{
"@odata.id": "/redfish/v1/Managers/bmc"
}
]
},
"Manufacturer": "Intel Corporation",
"Model": "S2600WFT",
"Name": "WFP_Baseboard",
"PartNumber": "123456789",
"Power": {
"@odata.id": "/redfish/v1/Chassis/WFP_Baseboard/Power"
},
"PowerState": "Off",
"SerialNumber": "123454321",
"Status": {
"Health": "Warning",
"HealthRollup": "Critical",
"State": "StandbyOffline"
},
"Thermal": {
"@odata.id": "/redfish/v1/Chassis/WFP_Baseboard/Thermal"
}
}

Change-Id: I1d944f31749f6eae952573078ad410547ae9faea
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Add support to retrigger LED Update

RetriggerLEDUpdate method added in callback-manager serivce. Used
to re-init the LED state in xyz.openbmc_project.LED.GroupManager.
This can be used by manufactur

Add support to retrigger LED Update

RetriggerLEDUpdate method added in callback-manager serivce. Used
to re-init the LED state in xyz.openbmc_project.LED.GroupManager.
This can be used by manufacturing revert function to re-init the
LED to the correct state, after any testing.

Tested:
1. Manually updated the LED state and called RetriggerLEDUpdate
method, which re-init the LED status, and set's to the correct one.

Change-Id: I4272ae0e02c81bea36db587f83e0a7ef2b91059e
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

Callback manager: set all leds each time

The led-manager priority doesn't work as well as we'd
hoped and we can occasionally see both blinking yellow
and green at the same time. To fix this handle p

Callback manager: set all leds each time

The led-manager priority doesn't work as well as we'd
hoped and we can occasionally see both blinking yellow
and green at the same time. To fix this handle priorities
in the callback manager.

Tested-by: Set warning and critical at the same time, only
saw critcial.

Change-Id: If0c5b7c2411ca1fd3dc74e407773e8f56e6c675f
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Add callback manager

Callback manager sets up matches and sets properties on
dbus.

Tested: used sensor override to make sensors assert
critical and warning interfaces and saw led change. also
caugh

Add callback manager

Callback manager sets up matches and sets properties on
dbus.

Tested: used sensor override to make sensors assert
critical and warning interfaces and saw led change. also
caught a few buggy threshold settings using led.

Change-Id: I06c164b749febbc3e81cb3db5f7a0a2b72b3678f
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...