Updated Storage Inventory Interface in hsbp-manager

Storage inventory interface in redfish code and hsbp manager
is mismatched. So updated the Storage Inventory interface from
"inventory.item.storag

Updated Storage Inventory Interface in hsbp-manager

Storage inventory interface in redfish code and hsbp manager
is mismatched. So updated the Storage Inventory interface from
"inventory.item.storage" to "Inventory.Item.Storage"

Change-Id: I4fe01b7a674fbac42ed4925aba12e0358d8d2289
Signed-off-by: PavanKumarIntel <pavanx.kumar.martha@intel.com>

show more ...

Add storage inventory support for hsbp-manager

Added storage inventory support for hsbp manager
Recently there is a upstream code changes done for
multiple storage support in bmcweb. So Added the st

Add storage inventory support for hsbp-manager

Added storage inventory support for hsbp manager
Recently there is a upstream code changes done for
multiple storage support in bmcweb. So Added the storage
inventory interface as
/xyz/openbmc_project/inventory/item/storage/hsbp/1
in hsbp-manager.

get: https://{bmc_ip}/redfish/v1/Systems/system/Storage

{
"@odata.id": "/redfish/v1/Systems/system/Storage",
"@odata.type": "#StorageCollection.StorageCollection",
"Members": [
{
"@odata.id": "/redfish/v1/Systems/system/Storage/1"
}
],
"Members@odata.count": 1,
"Name": "Storage Collection"
}

get: https://{bmc_ip}/redfish/v1/Systems/system/Storage/1

{
"@odata.id": "/redfish/v1/Systems/system/Storage/1",
"@odata.type": "#Storage.v1_13_0.Storage",
"Controllers": {
"@odata.id": "/redfish/v1/Systems/system/Storage/1/
Controllers"
},
"Drives": [
{
"@odata.id": "/redfish/v1/Systems/system/Storage/1
/Drives/Drive_1"
},
{
"@odata.id": "/redfish/v1/Systems/system/Storage/1
/Drives/Drive_2"
}
],
"Drives@odata.count": 2,
"Id": "1",
"Name": "Storage",
"Status": {
"Health": "OK",
"HealthRollup": "OK",
"State": "Enabled"
}
}


Redfish Validator: passed

Change-Id: I086ef93952767e8b676ab6fb1dba244ac416d032
Signed-off-by: Dileep Kumar Choppa <dileepx.kumar.choppa@intel.com>

show more ...

Declare originalFlags inside lambda function

This commit fix the compilation error in lambda function as
"originalFlags" variable not declare in capture clause

Change-Id: Ic1099430276ecff1c552a7848

Declare originalFlags inside lambda function

This commit fix the compilation error in lambda function as
"originalFlags" variable not declare in capture clause

Change-Id: Ic1099430276ecff1c552a78480f943bb41532463
Signed-off-by: PavanKumarIntel <pavanx.kumar.martha@intel.com>

show more ...

Fix the bugs found in static analysis

Not restoring ostream format:
cerr format not restoring to default, can lead to printing
values in incorrect format.

Change-Id: Ie529b9a8261f651c76d2fc

Fix the bugs found in static analysis

Not restoring ostream format:
cerr format not restoring to default, can lead to printing
values in incorrect format.

Change-Id: Ie529b9a8261f651c76d2fc232d89d4f711cb05b5
Signed-off-by: PavanKumarIntel <pavanx.kumar.martha@intel.com>

show more ...

Update to the latest sdbusplus

The CI build is failing during linking with sdbusplus, so update to the
latest to fix it.

Change-Id: I876c157e6dd48d205543d6a828d1159835525303
Signed-off-by: Jason M.

Update to the latest sdbusplus

The CI build is failing during linking with sdbusplus, so update to the
latest to fix it.

Change-Id: I876c157e6dd48d205543d6a828d1159835525303
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>

show more ...

Revert "Temporarily disable -fno-rtti to fix the build"

This reverts commit a83c827da232740c33d3b51fdcc3d70a484d4f55.

The build is working again, so add -fno-rtti back in.

Change-Id: I3e8fff45860b

Revert "Temporarily disable -fno-rtti to fix the build"

This reverts commit a83c827da232740c33d3b51fdcc3d70a484d4f55.

The build is working again, so add -fno-rtti back in.

Change-Id: I3e8fff45860ba6c56eb5c808e7ab77bd0f520547
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>

show more ...

Use variable for service install location

After enabling 'usrmerge', the install location for systemd service
files changed. This uses a variable to get the installation location
instead of hardcodi

Use variable for service install location

After enabling 'usrmerge', the install location for systemd service
files changed. This uses a variable to get the installation location
instead of hardcoding it.

Tested:
Confirmed that with 'usrmerge' enabled, the service file is correctly
installed.

Change-Id: Ia7e3ef57cbbd89cd259472f48baab2ec1b661fd1
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>

show more ...

Remove Hunter

Hunter is causing pkgconfig to fail to find systemd. Since it looks like
we don't use GTest right now, anyway, let's just remove Hunter.

Change-Id: Ifb801998591c23bd6d808decf8c817e6e6

Remove Hunter

Hunter is causing pkgconfig to fail to find systemd. Since it looks like
we don't use GTest right now, anyway, let's just remove Hunter.

Change-Id: Ifb801998591c23bd6d808decf8c817e6e698bbdc
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>

show more ...

Avoid writing same data to IoExpander and ClockBuffer

During initialization hsbp-manager sets zero at bit position of clock buffer register and IO output register that has a NVMe drive in it.

Code

Avoid writing same data to IoExpander and ClockBuffer

During initialization hsbp-manager sets zero at bit position of clock buffer register and IO output register that has a NVMe drive in it.

Code changes are made to make sure that if the bit positions are
already set to zero, we can avoid the write to clock buffer register
and IO output register.

Tested:
- Made sure the working of hsbp manager is not affected.
- Made sure that write to clock buffer register and IO output register
does not happen if we restart hsbp manager service, as bits are
already set to zeros.

Change-Id: Iaa08be8eba93ecc51ef70cc4bd9fb371de6474a1
Signed-off-by: Arun Lal K M <arun.lal@intel.com>

show more ...

remove dbus interfaces on Backplane destruction

activationIface(dbus_interface) attribute of Backplane(struct) was not
getting removed from dbus on destruction of Backplane object. Later as
Backplan

remove dbus interfaces on Backplane destruction

activationIface(dbus_interface) attribute of Backplane(struct) was not
getting removed from dbus on destruction of Backplane object. Later as
Backplane object gets reconstructed for same Backplane add_interface API
throws exception since interface is still there.
Remove activation dbus_interface on destruction of Backplane object.

Led associated with a Backplane were not getting destructed on
destruction of Backplane object. This was because Led is created as
shared_ptr and Led object itself keeps one reference causing use_count
to never go to zero.
Use weak reference in Led object. This causes Led object destructor to
get called on destruction of Backplane.

Change-Id: I3499b3617810ca39c99ecd1a8de7f56c93a2a586
Signed-off-by: Vikash Chandola <vikash.chandola@intel.com>

show more ...

Change io_service to io_context

This was renamed a while back in boost to be compliant with the
std::executors proposal.

Change-Id: Id97c83116ee47c49076476a331588035c3894418
Signed-off-by: Ed Tanou

Change io_service to io_context

This was renamed a while back in boost to be compliant with the
std::executors proposal.

Change-Id: Id97c83116ee47c49076476a331588035c3894418
Signed-off-by: Ed Tanous <edtanous@google.com>

show more ...

Add missing include

list was included through a dependency on sdbusplus which no longer
provides it, so it needs to be explicitly included here.

Change-Id: Ia39a1cd6b41c1837503ea9c0a8d272739589235f

Add missing include

list was included through a dependency on sdbusplus which no longer
provides it, so it needs to be explicitly included here.

Change-Id: Ia39a1cd6b41c1837503ea9c0a8d272739589235f
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>

show more ...

Revamp HSBP clock enabling code flow

This commit enhances the existing HSBP clock enabling logic
by eliminating most of the hardcoded register addresses, mapping
tables etc. The revamped code pulls

Revamp HSBP clock enabling code flow

This commit enhances the existing HSBP clock enabling logic
by eliminating most of the hardcoded register addresses, mapping
tables etc. The revamped code pulls all the configuration from the
Dbus object exposed by entity-manager, i.e. all the required hardware
information is moved into a configuration file, thereby reducing
hardcoding of values. This approch also makes it flexible to add
any number/type of clock buffers and also have flexibility in
mapping the drives (i.e. in case the hardware maps the HSBP drives
differently, only a configuratioon change is all that is needed
without having to touch the code).
Below is a template of configuration that needs to be appended
into the baseboard configuration file:
{
"RootI2cBus": 4,
"HsbpSupported": [
"HSBP_1",
"HSBP_2",
"HSBP_3"
],
"HSBP_1": [
"CPU0_NVME1",
"CPU0_NVME2",
"CPU0_NVME3",
"CPU0_NVME4",
"CPU0_NVME5",
"CPU0_NVME6",
"CPU0_NVME7",
"CPU0_NVME8"
],
"HSBP_2": [
"CPU1_NVME1",
"CPU1_NVME2",
"CPU1_NVME3",
"CPU1_NVME4",
"CPU1_NVME5",
"CPU1_NVME6",
"CPU1_NVME7",
"CPU1_NVME8"
],
"HSBP_3": [
"-",
"-",
"-",
"-",
"-",
"-",
"-",
"-"
],
"ClockBuffer": [
"abcd"
],
"IoExpander": [
"efgh"
],
"Name": "HSBP Config",
"Type": "HSBPConfiguration"
},
{
"Address": "0x12",
"Bus": 4,
"Mode": "SMBus",
"OutCtrlBaseAddr": "0x81",
"OutCtrlByteCount": 2,
"Byte0": [
"CPU0_NVME5",
"CPU0_NVME2",
"CPU0_NVME8",
"CPU0_NVME4",
"CPU0_NVME1",
"CPU0_NVME6",
"CPU0_NVME7",
"CPU0_NVME3"
],
"Byte1": [
"-",
"-",
"-",
"-",
"-",
"-",
"-",
"-"
],
"Name": "CPU0 Clock Buffer",
"Type": "abcd"
},
{
"Address": "0x34",
"Bus": 4,
"Mode": "IO",
"OutCtrlBaseAddr": "0x81",
"OutCtrlByteCount": 2,
"Byte0": [
"CPU1_NVME1",
"CPU1_NVME2",
"CPU1_NVME3",
"CPU1_NVME4",
"CPU1_NVME5",
"CPU1_NVME6",
"CPU1_NVME7",
"CPU1_NVME8"
],
"Byte1": [
"-",
"-",
"-",
"-",
"-",
"-",
"-",
"-"
],
"Name": "CPU1 Clock Buffer",
"Type": "abcd"
},
{
"Address": "0x56",
"Bus": 4,
"ConfIORegAddr": "0x06",
"OutCtrlBaseAddr": "0x02",
"OutCtrlByteCount": 2,
"IO0": [
"CPU1_NVME1",
"CPU1_NVME2",
"CPU1_NVME3",
"CPU1_NVME4",
"CPU1_NVME5",
"CPU1_NVME6",
"CPU1_NVME7",
"CPU1_NVME8"
],
"IO1": [
"-",
"-",
"-",
"-",
"-",
"-",
"-",
"-"
],
"Name": "IO Expander",
"Type": "efgh"
}

TESTED:
- On BMC boot, the connected HSBP drives were detected and
respective clock was enabled
- Hot Swapped couple of drives and confirmed the respective
clocks being enabled (The clocks were disabled for the Drives
which were removed)
- Verified by i2cdump of clock buffer(s) and checking respective
registers

Change-Id: Ice2b3b4f9d16df6d572ab34c8ea0cfddf657554c
Signed-off-by: P Dheeraj Srujan Kumar <p.dheeraj.srujan.kumar@intel.com>

show more ...

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

Change-Id: Idc1ee4342f1fc6c671a8f0b14eac663a1e2e6ef6
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

cmake: update to C++20

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9060117746a8b13246656ff06baa091e98e09796

MAINTAINERS: remove file

The MAINTAINERS file is deprecated in favor of OWNERS.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Icdc53425cc788db5de2fa9d54346314d208893af

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Idf165747d0fd6079ba217992f2c46a388ce2d906

show more ...

sdbusplus: update ref

The external-project ref for sdbusplus is now 2 years old. Update
it to something more recent.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I49d66447c31601d

sdbusplus: update ref

The external-project ref for sdbusplus is now 2 years old. Update
it to something more recent.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I49d66447c31601d30ed9c0106f2b9c6732dd5a4b

show more ...

OWNERS: add file to match MAINTAINERS

The project has moved to using OWNERS to maintain the list of
repository maintainers and reviewers. Create one here.

Signed-off-by: Patrick Williams <patrick@

OWNERS: add file to match MAINTAINERS

The project has moved to using OWNERS to maintain the list of
repository maintainers and reviewers. Create one here.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I721086d95157bc9e543a75363df34a96fc2ae0c6

show more ...

hsbp-manager: fix build against latest sdbusplus

sdbusplus headers changed and now we need to explicitly include the
match header.

Tested: Build succeeds.

Signed-off-by: Jonathan Doman <jonathan.d

hsbp-manager: fix build against latest sdbusplus

sdbusplus headers changed and now we need to explicitly include the
match header.

Tested: Build succeeds.

Signed-off-by: Jonathan Doman <jonathan.doman@intel.com>
Change-Id: I9cd2b12f251434351e5f4f0b92bdf771c6958827

show more ...

Fix: LED state not changes for UpperCriticalthresh

Issue: LED state is in Blinking Green after setting the
'Upper Critical threshold'.

RootCause: A Typo in the event name used in source code

Fix: LED state not changes for UpperCriticalthresh

Issue: LED state is in Blinking Green after setting the
'Upper Critical threshold'.

RootCause: A Typo in the event name used in source code.

Fix:
After setting the Threshold value expected LED status should be
"blinking Amber "

Tested:

Initial LED state:
ipmitool raw 0x30 0xb0
20 --> Solid Green

1. Patch the 'Upper Critical threshold' value to 'Inlet_BRD_Temp'
PATCH : https://<bmcip>/redfish/v1/Chassis/<Baseboard>/Thermal
patch body:
{
"Temperatures":[
{
"MemberId":"Inlet_BRD_Temp",
"ReadingCelsius":120.0
}
]
}

Response :
{
"@odata.id": "/redfish/v1/Chassis/<Baseboard>/Thermal",
"@odata.type": "#Thermal.v1_4_0.Thermal",
"Fans": [],
"Id": "Thermal",
"Name": "Thermal",
"Temperatures": []
}

LED state changed
ipmitool raw 0x30 0xb0
04 --> Blinking Amber

Signed-off-by: sunitakx <sunitax.kumari@linux.intel.com>
Change-Id: I9941c35a4b66555f0147315e2405361e0795f6ac

show more ...

Fix to populate all HSBP inventory

Issue: if backplanes map cleared inside of the async_method_call,
system is not populating all HSBP inventory items in RedFish.

Fix: So moved backplanes.clear() t

Fix to populate all HSBP inventory

Issue: if backplanes map cleared inside of the async_method_call,
system is not populating all HSBP inventory items in RedFish.

Fix: So moved backplanes.clear() to outside of the async_method_call.
Now RedFish populating all the HSBP inventory items.

Tested:
Verified from Redfish, shown both HSBP inventory items.

Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: Idd8ca45b19e7d124a9cfbbe9bbbfb698fc289a6f

show more ...

Remove James from MAINTAINERS

Will be off the project starting Oct 9th.

Change-Id: I03d0a26b33ab5ef8e0e2fb0af1afe8664f827f74
Signed-off-by: James Feist <james.feist@linux.intel.com>

Remove Jae from the minatainer list.

Remove myself from maintainers.

Change-Id: I48bdae86e73c9b3161de0048dfad8dd4dd7295ce
Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>

callback-manager: match thersholdAsserted signal for updateLedStatus

Issue: For ADC sensors, LED state did not change after de-assert.

Fix: Added a match for thresholdAsserted signal to capture the

callback-manager: match thersholdAsserted signal for updateLedStatus

Issue: For ADC sensors, LED state did not change after de-assert.

Fix: Added a match for thresholdAsserted signal to capture the de-assert
event for powerDelayed threshold sensors and update the LED state
accordingly.

Tested:

ipmitool sdr elist | grep P3VBAT
P3VBAT | 47h | ok | 0.1 | 3.14 Volts

Initial state:
ipmitool raw 0x4 0x27 0x47
1b 7b 6b 00 a4 a6 00

Initial LED state:
ipmitool raw 0x30 0xb0
20 --> Solid Green

Assert events:

1. Change the Lower Non-Critical threshold
ipmitool raw 0x04 0x26 0x47 0x1b 0xa1 0x6b 0x00 0xa4 0xa6 0x00

ipmitool raw 0x4 0x27 0x47
1b a1 6b 00 a4 a6 00

ipmitool raw 0x30 0xb0
10 --> Blinking Green.

2. Change the Lower critical threshold
ipmitool raw 0x04 0x26 0x47 0x1b 0xa1 0xa1 0x00 0xa4 0xa6 0x00

ipmitool raw 0x4 0x27 0x47
1b a1 a1 00 a4 a6 00

ipmitool raw 0x30 0xb0
04 --> Blinking Amber

De-assert events:

1. Restore Lower critical threshold.
ipmitool raw 0x04 0x26 0x47 0x1b 0xa1 0x6b 0x00 0xa4 0xa6 0x00

ipmitool raw 0x4 0x27 0x47
1b a1 6b 00 a4 a6 00

ipmitool raw 0x30 0xb0
10 --> Blinking Green

2. Restore Lower Non-Critical Threshold.
ipmitool raw 0x04 0x26 0x47 0x1b 0x7b 0x6b 0x00 0xa4 0xa6 0x00

ipmitool raw 0x4 0x27 0x47
1b 7b 6b 00 a4 a6 00

ipmitool raw 0x30 0xb0
20 --> Solid Green

ipmitool sel list
1 | Pre-Init |0000006680| Voltage #0x47 | Lower Non-critical going
low | Asserted
2 | Pre-Init |0000006944| Voltage #0x47 | Lower Critical going low
| Asserted
3 | Pre-Init |0000007218| Voltage #0x47 | Lower Critical going low
| Deasserted
4 | Pre-Init |0000007345| Voltage #0x47 | Lower Non-critical going
low | Deasserted

Signed-off-by: Chalapathi Venkataramashetty <chalapathix.venkataramashetty@intel.com>
Change-Id: I505871913bbbcfc7ba174d9243c736561818ee0f

show more ...